Re: [PATCH] drm/amdkfd: reserve the BO before validating it

2024-01-12 Thread Francis, David
[AMD Official Use Only - General] On 2024-01-11 11:19, Felix Kuehling wrote: > On 2024-01-11 02:22, Lang Yu wrote: >> Fixes: 410f08516e0f ("drm/amdkfd: Move dma unmapping after TLB flush") >> >> [ 41.708711] WARNING: CPU: 0 PID: 1463 at >> drivers/gpu/drm/ttm/ttm_bo.c:846 ttm_bo_validate+0x146/0

Re: [PATCH] drm/amdgpu: Handle null atom context in VBIOS info ioctl

2023-09-05 Thread Francis, David
Deucher Sent: Tuesday, September 5, 2023 10:53 AM To: Francis, David <mailto:david.fran...@amd.com> Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH] drm/amdgpu: Handle null atom context in VBIOS info ioctl On Tue, Sep 5, 2023 at 10:50 AM David Franc

Re: [PATCH] drm/amdkfd: Fix EXT_COHERENT memory allocation crash

2023-10-03 Thread Francis, David
[AMD Official Use Only - General] > If there is no VRAM domain, bo_node is NULL and this causes crash. Move > ​the EXT_COHERENT support change to VRAM domain path. > > Need another patch to support override PTE flag on APU. > > Fixes: 55d7e2001c7e ("drm/amdgpu: Add EXT_COHERENT memory allocation f

Re: [PATCH v2] drm/amdkfd: Fix EXT_COHERENT memory allocation crash

2023-10-04 Thread Francis, David
[AMD Official Use Only - General] On 2023-10-03 17:37, Felix Kuehling wrote: On 2023-10-03 16:50, Philip Yang wrote: If there is no VRAM domain, bo_node is NULL and this causes crash. Refactor the change, and use the module parameter as higher privilege. Need another patch to support override P

[PATCH] drm/amdkfd: Make EXT_COHERENT parameter affect APU svm memory

2023-10-10 Thread Francis, David
[AMD Official Use Only - General] By the intended semantics of the EXT_COHERENT parameter, it should cause the driver to use MTYPE_UC instead of MTYPE_NC on non-local gfx9.4.3 APU memory. Signed-off-by: David Francis --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH] drm/amd/dc: Trigger set power state task when display configuration changes

2018-09-17 Thread Francis, David
On Linux, the clocks are already set by the time that function call is reached. amdgpu_pm_compute clocks resets the clocks to their default value. From: Zhu, Rex Sent: September 17, 2018 4:12:33 AM To: Deucher, Alexander; Wentland, Harry; Francis, David Cc: amd

Re: [PATCH 17/26] drm/amd/display: implement PERF_TRACE on Linux

2018-10-15 Thread Francis, David
Fully agreed. Will redesign this. From: Christian König Sent: October 13, 2018 1:40:24 PM To: Michel Dänzer; Lakha, Bhawanpreet Cc: Francis, David; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 17/26] drm/amd/display: implement PERF_TRACE on Linux Am

Re: [PATCH] drm/amd/display: Expose DRM_FORMAT_RGB565 on overlay planes

2019-04-26 Thread Francis, David
Reviewed-by: David Francis From: amd-gfx on behalf of Deucher, Alexander Sent: April 23, 2019 10:47:26 AM To: Kazlauskas, Nicholas; amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo); Wentland, Harry Subject: Re: [PATCH] drm/amd/display: Expose DRM_FORMAT_RGB

Re: [PATCH v2] drm/amd/display: Add connector debugfs for "output_bpc"

2019-06-04 Thread Francis, David
Looks straightforward Reviewed-by: David Francis From: amd-gfx on behalf of Nicholas Kazlauskas Sent: June 3, 2019 1:44:37 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo); Wentland, Harry; Kazlauskas, Nicholas Subject: [PATCH v2] drm/amd/display:

Re: [PATCH 2/2] drm/amd/display: Set default ABM level to module parameter

2019-06-06 Thread Francis, David
Series is Reviewed-by: David Francis From: amd-gfx on behalf of Nicholas Kazlauskas Sent: June 6, 2019 9:02:13 AM To: amd-gfx@lists.freedesktop.org Cc: Francis, David; Wentland, Harry; Kazlauskas, Nicholas Subject: [PATCH 2/2] drm/amd/display: Set default ABM

Re: [PATCH] drm/amd/display: Enable fast plane updates when state->allow_modeset = true

2019-06-07 Thread Francis, David
Patch is Reviewed-by: David Francis From: amd-gfx on behalf of Nicholas Kazlauskas Sent: June 7, 2019 11:16:55 AM To: amd-gfx@lists.freedesktop.org Cc: Francis, David; Wentland, Harry; Kazlauskas, Nicholas Subject: [PATCH] drm/amd/display: Enable fast plane

Re: [PATCH] drm/amd: Add DMCU firmware loading on raven

2018-09-07 Thread Francis, David
: amd-gfx@lists.freedesktop.org Cc: Francis, David Subject: [PATCH] drm/amd: Add DMCU firmware loading on raven [Why] DMCU (Display MicroController Unit) is an on-GPU microcontroller in AMD graphics cards that is used in features for embedded displays such as Panel Self-Refresh DMCU is part of the

Re: [PATCH] drm/amd: Add DMCU firmware loading on raven

2018-09-07 Thread Francis, David
Ignore this thread - new, fixed patch is up From: Francis, David Sent: September 7, 2018 10:26:59 AM To: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd: Add DMCU firmware loading on raven This will cause amdgpu startup to fail if the firmware does

Re: [PATCH 06/14] drm/amd/display: Use dc helpers to compute timeslot distribution

2019-08-19 Thread Francis, David
ng already takes bpp into >> account */ >> + pbn = drm_dp_calc_pbn_mode(clock, 1); >> >> - slots = drm_dp_find_vcpi_slots(mst_mgr, pbn); >> + /* Convert kilobits per second / 64 (for 64 timeslots) to pbn >> (54/64 megaby

Re: [PATCH 14/14] drm/amd/display: Trigger modesets on MST DSC connectors

2019-08-19 Thread Francis, David
>> @@ -7178,6 +7249,15 @@ static int amdgpu_dm_atomic_check(struct drm_device >> *dev, >>goto fail; >>} >> >> +#ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT >> + for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state,

Re: [PATCH 4/4] drm/amd/display: Lock the CRTC when setting CRC source

2019-08-20 Thread Francis, David
Series is Reviewed-by: David Francis From: amd-gfx on behalf of Nicholas Kazlauskas Sent: August 20, 2019 1:59 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo); Francis, David; Lakha, Bhawanpreet; Kazlauskas, Nicholas Subject: [PATCH 4/4

Re: [PATCH v3 16/16] drm/amd/display: Trigger modesets on MST DSC connectors

2019-08-21 Thread Francis, David
is clear what functionality is common between drivers From: dri-devel on behalf of David Francis Sent: August 21, 2019 4:01 PM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo); Francis, David; Kazlauskas

Re: [PATCH v3 13/16] drm/amd/display: Validate DSC caps on MST endpoints

2019-08-22 Thread Francis, David
Whoops, left in a test print. Ignore this patch From: David Francis Sent: August 21, 2019 4:01 PM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org Cc: Francis, David; Liu, Wenjing; Cornij, Nikola Subject: [PATCH v3 13/16] drm/amd

Re: [PATCH v3 00/16] Display Stream Compression (DSC) for AMD Navi

2019-08-22 Thread Francis, David
I was building against amd-staging-drm-next (commit e4a67e6cf14c). v4 will contain just the drm-mst patches and will apply on latest drm-tip/drm-tip (commit 018886de4726) From: Lyude Paul Sent: August 21, 2019 5:20 PM To: Francis, David; dri-de

Re: [PATCH] Revert "drm/amd/display: Enable fast plane updates when state->allow_modeset = true"

2019-06-20 Thread Francis, David
Reviewed-by: David Francis From: amd-gfx on behalf of Nicholas Kazlauskas Sent: June 20, 2019 8:34:03 AM To: amd-gfx@lists.freedesktop.org Cc: Francis, David; Wentland, Harry; Kazlauskas, Nicholas Subject: [PATCH] Revert "drm/amd/display: Enable fast

Re: [PATCH 3/3] drm/amd/display: Don't replace the dc_state for fast updates

2019-08-01 Thread Francis, David
Series is: Reviewed-by: David Francis From: Alex Deucher Sent: August 1, 2019 2:58:56 PM To: Kazlauskas, Nicholas Cc: amd-gfx list ; Li, Sun peng (Leo) ; Francis, David Subject: Re: [PATCH 3/3] drm/amd/display: Don't replace the dc_state for fast up

Re: [PATCH 2/2] drm/amd/display: Block immediate flips for non-fast updates

2019-08-02 Thread Francis, David
Series is: Reviewed-by: David Francis From: amd-gfx on behalf of Nicholas Kazlauskas Sent: August 2, 2019 11:11:50 AM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo) ; Francis, David ; Lakha, Bhawanpreet ; Kazlauskas, Nicholas Subject: [PATCH 2/2

Re: [PATCH] amd/dc/dce100: On dce100, set clocks to 0 on suspend

2018-07-12 Thread Francis, David
Upon closer inspection, this does not match any FDO bug. The FDO bug I thought this was related to was fixed by Michel Danzer, and this fixes an entirely separate issue. From: Michel Dänzer Sent: July 12, 2018 10:18:34 AM To: Wentland, Harry; Francis, David