Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Darrick J. Wong
mis.org/ > > Cc: Masami Hiramatsu > Cc: Mathieu Desnoyers > Cc: Linus Torvalds > Cc: Julia Lawall > Signed-off-by: Steven Rostedt (Google) /me finds this pretty magical, but such is the way of macros. Thanks for being much smarter about them than me. :) Acked-by: Darrick J. Wong# xfs --D

Re: [PATCH v1 01/14] ext4/xfs: add page refcount helper

2021-08-25 Thread Darrick J. Wong
il. > > Signed-off-by: Ralph Campbell > Signed-off-by: Alex Sierra > Reviewed-by: Christoph Hellwig Looks fine to me, Acked-by: Darrick J. Wong --D > --- > v3: > [AS]: rename dax_layout_is_idle_page func to dax_page_unused > > v4: > [AS]: This ref count functio

Re: [PATCH v1 00/12] MEMORY_DEVICE_COHERENT for CPU-accessible coherent device memory

2021-10-12 Thread Darrick J. Wong
On Tue, Oct 12, 2021 at 04:24:25PM -0400, Felix Kuehling wrote: > > Am 2021-10-12 um 3:11 p.m. schrieb Matthew Wilcox: > > On Tue, Oct 12, 2021 at 11:39:57AM -0700, Andrew Morton wrote: > >> Because I must ask: if this feature is for one single computer which > >> presumably has a custom kernel, w

Re: [PATCH v3 1/8] ext4/xfs: add page refcount helper

2021-06-17 Thread Darrick J. Wong
ue; > - return ___wait_var_event(&page->_refcount, > - atomic_read(&page->_refcount) == 1, TASK_INTERRUPTIBLE, > - 0, 0, xfs_wait_dax_page(inode)); > + return dax_wait_page(inode, page, xfs_wait_dax_page); Mechanically, this looks lik

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Darrick J. Wong
struct xfs_buf *bp) > - { > +{ > struct xfs_agf *agf = XFS_BUF_TO_AGF(bp); > > if (xfs_sb_version_hascrc(&mp->m_sb)) { > @@ -2449,8 +2449,7 @@ xfs_agf_verify( >be32_to_cpu(agf->agf_refcount_level) > XFS_BTREE_MAXLEVELS)) >

Re: [PATCH v1 2/3] xfs/libxfs: replace kmalloc() and memcpy() with kmemdup()

2025-01-06 Thread Darrick J. Wong
On Sun, Dec 29, 2024 at 01:58:19PM +0100, Andrey Albershteyn wrote: > On 2024-12-18 16:35:21, Darrick J. Wong wrote: > > On Tue, Dec 17, 2024 at 11:58:12PM +0100, Mirsad Todorovac wrote: > > > The source static analysis tool gave the following advice: > > > > > &g

Re: [PATCH v1 2/3] xfs/libxfs: replace kmalloc() and memcpy() with kmemdup()

2024-12-18 Thread Darrick J. Wong
XFS] Return case-insensitive match for dentry cache") > Fixes: 2451337dd0439 ("xfs: global error sign conversion") > Cc: Carlos Maiolino > Cc: "Darrick J. Wong" > Cc: Chandan Babu R > Cc: Dave Chinner > Cc: linux-...@vger.kernel.org > Cc: linux-ker...@