Re: [PATCH 1/8] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages

2022-02-07 Thread Chaitanya Kulkarni
urn ERR_PTR(-EINVAL); > } > Indeed it does have it in the makefile:- root@dev mm (for-next) # grep memremap.o Makefile obj-$(CONFIG_ZONE_DEVICE) += memremap.o Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 2/8] mm: remove the __KERNEL__ guard from

2022-02-07 Thread Chaitanya Kulkarni
+3378,4 @@ madvise_set_anon_name(struct mm_struct *mm, unsigned > long start, > } > #endif > > -#endif /* __KERNEL__ */ > #endif /* _LINUX_MM_H */ > Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 3/8] mm: remove pointless includes from

2022-02-07 Thread Chaitanya Kulkarni
On 2/6/22 10:32 PM, Christoph Hellwig wrote: > hmm.h pulls in the world for no good reason at all. Remove the > includes and push a few ones into the users instead. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 4/8] mm: move free_devmap_managed_page to memremap.c

2022-02-07 Thread Chaitanya Kulkarni
calls in my tree. Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 5/8] mm: simplify freeing of devmap managed pages

2022-02-07 Thread Chaitanya Kulkarni
eturn void and return true from above ? or maybe someone can send a cleanup once this is merged. > } > Irrespective of above comment(s), looks good. Reviewed-by: Chaitanya Kulkarni