RE: [PATCH v3 04/12] drm/fbdev: Select fbdev I/O helpers from modules that require them

2024-10-09 Thread Cavitt, Jonathan
gt; core DRM module. > > Signed-off-by: Thomas Zimmermann LGTM. Reviewed-by: Jonathan Cavitt -Jonathan Cavitt > --- > drivers/gpu/drm/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > ind

RE: [PATCH v3 09/12] drm/nouveau: Suspend and resume clients with client helpers

2024-10-09 Thread Cavitt, Jonathan
is is okay. I'd wait for an expert on nouveau to respond first before jumping to push. Reviewed-by: Jonathan Cavitt -Jonathan Cavitt > --- > drivers/gpu/drm/nouveau/nouveau_display.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers

RE: [PATCH v3 06/12] drm/client: Move client event handlers to drm_client_event.c

2024-10-09 Thread Cavitt, Jonathan
> - rename new files to drm_client_event.{c,h} > > Signed-off-by: Thomas Zimmermann > Cc: Jani Nikula > Cc: Rodrigo Vivi > Cc: Joonas Lahtinen > Cc: Tvrtko Ursulin > Cc: Karol Herbst > Cc: Lyude Paul > Cc: Danilo Krummrich LGTM. Reviewed-by: Jonathan Cavitt -Jona

RE: [PATCH v3 02/12] drm/xe: Select DRM_CLIENT_SELECTION

2024-10-09 Thread Cavitt, Jonathan
; Signed-off-by: Thomas Zimmermann > Cc: Lucas De Marchi > Cc: "Thomas Hellström" > Cc: Rodrigo Vivi LGTM. Reviewed-by: Jonathan Cavitt -Jonathan Cavitt > --- > drivers/gpu/drm/xe/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/dr

RE: [PATCH v3 07/12] drm/client: Move suspend/resume into DRM client callbacks

2024-10-09 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 4:59 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; intel-...@lists.freedesktop.org; int

RE: [PATCH v3 05/12] drm/fbdev: Store fbdev module parameters in separate file

2024-10-09 Thread Cavitt, Jonathan
Thomas Zimmermann LGTM. Reviewed-by: Jonathan Cavitt -Jonathan Cavitt > --- > drivers/gpu/drm/drm_fb_helper.c | 31 -- > drivers/gpu/drm/drm_internal.h | 7 + > drivers/gpu/drm/drm_kms_helper_common.c | 35 + > 3 files

RE: [PATCH v3 01/12] drm/i915: Select DRM_CLIENT_SELECTION

2024-10-09 Thread Cavitt, Jonathan
from i915. > > Signed-off-by: Thomas Zimmermann > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin LGTM. Reviewed-by: Jonathan Cavitt -Jonathan Cavitt > --- > drivers/gpu/drm/i915/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > d

RE: [PATCH v3 10/12] drm/radeon: Suspend and resume clients with client helpers

2024-10-09 Thread Cavitt, Jonathan
iew this patch before deciding to push. Reviewed-by: Jonathan Cavitt -Jonathan Cavitt > --- > drivers/gpu/drm/radeon/radeon_device.c | 19 ++- > drivers/gpu/drm/radeon/radeon_fbdev.c | 6 -- > drivers/gpu/drm/radeon/radeon_mode.h | 3 --- > 3 files change

RE: [PATCH v3 11/12] drm/client: Make client support optional

2024-10-09 Thread Cavitt, Jonathan
ient_debugfs_init() if DRM_CLIENT=n (kernel > test robot) > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: "Christian König" > Cc: Xinhui Pan LGTM. Reviewed-by: Jonathan Cavitt -Jonathan Cavitt > --- > drivers/gpu/drm/Kconfig

RE: [PATCH v3 03/12] drm/fbdev-dma: Select FB_DEFERRED_IO

2024-10-09 Thread Cavitt, Jonathan
gned-off-by: Thomas Zimmermann > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202410050241.mox9qrjp-...@intel.com/ > Fixes: 808a40b69468 ("drm/fbdev-dma: Implement damage handling and deferred > I/O") > Cc: Thomas Zimmermann > Cc

RE: [PATCH v3 12/12] drm/client: Add client-lib module

2024-10-09 Thread Cavitt, Jonathan
kernel options in drm_fb_helper.o, so leave this > file in the KMS-helper module for now. > > v3: > - fix commit changelog > v2: > - keep client code in core > - protect lib with DRM_CLIENT_LIB > - remove duplicate line from Makefile (Jocelyn) > > Signed-off-by: Thomas

RE: [PATCH v3 08/12] drm/amdgpu: Suspend and resume internal clients with client helpers

2024-10-09 Thread Cavitt, Jonathan
t my place to say this is okay. I'd wait for an expert on the amdgpu to respond first before jumping to push. Reviewed-by: Jonathan Cavitt -Jonathan Cavitt > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 22 +++--- > 1 file changed, 11 insertions(+), 1