Re: [bug report] new kvmalloc() WARN() triggered by DRM ioctls tracking

2021-12-16 Thread Boris Brezillon
Hi Steve, On Thu, 16 Dec 2021 14:02:25 + Steven Price wrote: > + Boris > > On 16/12/2021 12:08, Dan Carpenter wrote: > > Hi DRM Devs, > > > > In commit 7661809d493b ("mm: don't allow oversized kvmalloc() calls") > > from July, Linus added a WARN_ONCE() for "crazy" allocations over 2GB. > >

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-14 Thread Boris Brezillon
Hi Christian, On Thu, 4 May 2023 13:51:47 +0200 "Christian König" wrote: > This adds the infrastructure for an execution context for GEM buffers > which is similar to the existing TTMs execbuf util and intended to replace > it in the long term. > > The basic functionality is that we abstracts

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-14 Thread Boris Brezillon
On Wed, 14 Jun 2023 14:30:53 +0200 Christian König wrote: > Am 14.06.23 um 14:23 schrieb Boris Brezillon: > > Hi Christian, > > > > On Thu, 4 May 2023 13:51:47 +0200 > > "Christian König" wrote: > > > >> This adds the infrastructure fo

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-17 Thread Boris Brezillon
+Matthew who's been using drm_exec in Xe if I'm correct. Hello Christian, On Wed, 14 Jun 2023 15:02:52 +0200 Boris Brezillon wrote: > On Wed, 14 Jun 2023 14:30:53 +0200 > Christian König wrote: > > > Am 14.06.23 um 14:23 schrieb Boris Brezillon: > > > Hi

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
Hello Thomas, On Mon, 19 Jun 2023 10:59:16 +0200 Thomas Hellström (Intel) wrote: > > > +/** > > + * DOC: Overview > > + * > > + * This component mainly abstracts the retry loop necessary for locking > > + * multiple GEM objects while preparing hardware operations

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 11:20:06 +0200 Christian König wrote: > Hi guys, > > Am 19.06.23 um 10:59 schrieb Thomas Hellström (Intel): > > [SNIP] > > I really need to find some time to work on that anyway. > >> I've been playing with drm_exec for a couple weeks now, and I wanted > >> to s

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 12:44:06 +0200 Christian König wrote: > Am 19.06.23 um 12:12 schrieb Boris Brezillon: > > [SNIP] > > Note that the drm_exec_until_all_locked() helper I introduced is taking > > an expression, so in theory, you don't have to defi

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 13:05:02 +0200 Boris Brezillon wrote: > On Mon, 19 Jun 2023 12:44:06 +0200 > Christian König wrote: > > > Am 19.06.23 um 12:12 schrieb Boris Brezillon: > > > [SNIP] > > > Note that the drm_exec_until_all_locked() helper I introduced is

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 12:44:06 +0200 Christian König wrote: > Am 19.06.23 um 12:12 schrieb Boris Brezillon: > > [SNIP] > > Note that the drm_exec_until_all_locked() helper I introduced is taking > > an expression, so in theory, you don't have to defi

Re: [PATCH 01/13] drm: execution context for GEM buffers v4

2023-06-19 Thread Boris Brezillon
On Mon, 19 Jun 2023 14:29:23 +0200 Boris Brezillon wrote: > On Mon, 19 Jun 2023 12:44:06 +0200 > Christian König wrote: > > > Am 19.06.23 um 12:12 schrieb Boris Brezillon: > > > [SNIP] > > > Note that the drm_exec_until_all_locked() helper I introduced is

Re: [PATCH 06/13] drm/amdgpu: use the new drm_exec object for CS v2

2023-06-20 Thread Boris Brezillon
On Tue, 20 Jun 2023 10:12:13 +0200 Christian König wrote: > > I think Boris's suggestion of having this through a common > > DRM_EXEC_FLAG_ALLOW_DUPLICATES flag fits well. > > No, again. The only driver which should accept duplicates is radeon, for > all other drivers especially new ones dup

Re: [PATCH 06/13] drm/amdgpu: use the new drm_exec object for CS v2

2023-06-20 Thread Boris Brezillon
On Tue, 20 Jun 2023 10:44:26 +0200 Christian König wrote: > Am 20.06.23 um 10:28 schrieb Boris Brezillon: > > On Tue, 20 Jun 2023 10:12:13 +0200 > > Christian König wrote: > > > >>> I think Boris's suggestion of having this through a common > >>

Re: [PATCH 06/13] drm/amdgpu: use the new drm_exec object for CS v2

2023-06-20 Thread Boris Brezillon
On Tue, 20 Jun 2023 11:14:51 +0200 Christian König wrote: > Am 20.06.23 um 11:09 schrieb Boris Brezillon: > > On Tue, 20 Jun 2023 10:44:26 +0200 > > Christian König wrote: > > > >> Am 20.06.23 um 10:28 schrieb Boris Brezillon: > >>> On Tue, 20 Jun

Re: [PATCH 5/5] drm: drop DRM_AUTH from PRIME_TO/FROM_HANDLE ioctls

2019-11-26 Thread Boris Brezillon
Hi Emil, On Fri, 1 Nov 2019 13:03:13 + Emil Velikov wrote: > From: Emil Velikov > > As mentioned by Christian, for drivers which support only primary nodes > this changes the returned error from -EACCES into -EOPNOTSUPP/-ENOSYS. Are you sure this is true for MODESET-only nodes (those tha

Re: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning

2019-11-29 Thread Boris Brezillon
On Tue, 29 Oct 2019 14:07:48 -0400 Andrey Grodzovsky wrote: > Fix a static code checker warning. > > v2: Drop PTR_ERR_OR_ZERO. > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/scheduler/sched_main.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/d

Re: [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Boris Brezillon
Liviu Dudau > Cc: Brian Starkey > Cc: Mali DP Maintainers > Cc: Boris Brezillon > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Ludovic Desroches > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: Jani Nikula > Cc: Joonas Lahtinen > C

[PATCH v3 0/3] drm/connector: Provide generic support for underscan

2018-11-22 Thread Boris Brezillon
ion once/if the generic stuff are accepted. Regards, Boris Boris Brezillon (3): drm/connector: Add generic underscan properties drm/vc4: Take underscan setup into account when updating planes drm/vc4: Attach underscan props to the HDMI connector drivers/gpu/drm/drm_atomic_uapi.c |

[PATCH v3 3/3] drm/vc4: Attach underscan props to the HDMI connector

2018-11-22 Thread Boris Brezillon
,right,top,bottom} properties defined in config.txt and parsed by the VC4 firmware. Signed-off-by: Boris Brezillon --- Changes in v3: - none Changes in v2: - none --- drivers/gpu/drm/vc4/vc4_hdmi.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/vc4

[PATCH v3 1/3] drm/connector: Add generic underscan properties

2018-11-22 Thread Boris Brezillon
the property parsing logic can be shared by all DRM drivers. A driver can now attach underscan properties to its connector through the drm_connector_attach_underscan_properties() helper, and can check/apply the underscan setup based on the drm_connector_state->underscan fields. Signed-off-by: B

[PATCH v3 2/3] drm/vc4: Take underscan setup into account when updating planes

2018-11-22 Thread Boris Brezillon
ready to attach underscan properties to the HDMI connector. Signed-off-by: Boris Brezillon --- Changes in v3: - Rebase on top of the "cursor rescaling" changes Changes in v2: - Take changes on hborder/vborder meaning into account --- drivers/gpu/drm/vc4/vc4_cr

Re: [PATCH v3 1/3] drm/connector: Add generic underscan properties

2018-12-03 Thread Boris Brezillon
On Mon, 3 Dec 2018 16:40:11 +0200 Ville Syrjälä wrote: > On Thu, Nov 22, 2018 at 12:23:29PM +0100, Boris Brezillon wrote: > > @@ -924,6 +978,29 @@ struct drm_connector { > > */ > > struct drm_property_blob *path_blob_ptr; > > > > + /** > > +

Re: [PATCH v2 5/5] drm: don't block fb changes for async plane updates

2019-03-11 Thread Boris Brezillon
newfb = fb1, prepare fb1, cleanup fb2 > > Where calls to prepare/cleanup are balanced. > > Cc: # v4.14+ > Fixes: 25dc194b34dd ("drm: Block fb changes for async plane updates") > Suggested-by: Boris Brezillon > Signed-off-by: Helen Koike Reviewed-by: Boris

Re: [PATCH v3 2/4] drm/atomic: rename async_{update,check} to amend_{update,check}

2019-04-12 Thread Boris Brezillon
Hi Helen, On Fri, 12 Apr 2019 09:58:25 -0300 Helen Koike wrote: > Asynchronous update is the ability change the hw state at any time, not > only during vblank. > > Amend mode is the ability to perform 1000 commits to be applied as soon > as possible without waiting for 1000 vblanks. > > async

Re: [PATCH v3 2/4] drm/atomic: rename async_{update,check} to amend_{update,check}

2019-04-12 Thread Boris Brezillon
On Fri, 12 Apr 2019 11:06:13 -0300 Helen Koike wrote: > Hi Boris, > > On 4/12/19 10:49 AM, Boris Brezillon wrote: > > Hi Helen, > > > > On Fri, 12 Apr 2019 09:58:25 -0300 > > Helen Koike wrote: > > > >> Asynchronous update is the abilit

Re: [PATCH v4 0/5] drm: Fix fb changes for async updates

2019-06-04 Thread Boris Brezillon
On Mon, 3 Jun 2019 13:56:05 -0300 Helen Koike wrote: > Hello, > > I'm re-sending this series with the acked by in the msm patch and > updating the docs in the last patch, the rest is the same. > > v3 link: https://patchwork.kernel.org/project/dri-devel/list/?series=91353 Series queued to drm-

Re: [PATCH 11/11] drm: remove unused and redundant callbacks

2017-06-22 Thread Boris Brezillon
On Thu, 22 Jun 2017 08:37:55 +0200 Daniel Vetter wrote: > On Thu, Jun 22, 2017 at 12:34:36AM +0800, kbuild test robot wrote: > > Hi Peter, > > > > [auto build test ERROR on drm/drm-next] > > [also build test ERROR on next-20170621] > > [cannot apply to v4.12-rc6] > > [if your patch is applied to

Re: [PATCH] drm/core: Remove drm_dev_unref() and it's uses

2018-04-26 Thread Boris Brezillon
| 4 ++-- > drivers/gpu/drm/armada/armada_drv.c| 6 +++--- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++-- For atmel-hlcdc: Acked-by: Boris Brezillon ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 1/3] drm/connector: Add generic underscan properties

2018-05-07 Thread Boris Brezillon
the property parsing logic can be shared by all DRM drivers. A driver can now attach underscan properties to its connector through the drm_connector_attach_underscan_properties() helper, and can check/apply the underscan setup based on the drm_connector_state->underscan fields. Signed-off-by:

[PATCH 2/3] drm/vc4: Take underscan setup into account when updating planes

2018-05-07 Thread Boris Brezillon
ready to attach underscan properties to the HDMI connector. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/vc4/vc4_plane.c | 49 - 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4

[PATCH 0/3] drm/connector: Provide generic support for underscan

2018-05-07 Thread Boris Brezillon
, Boris Boris Brezillon (3): drm/connector: Add generic underscan properties drm/vc4: Take underscan setup into account when updating planes drm/vc4: Attach underscan props to the HDMI connector drivers/gpu/drm/drm_atomic.c| 12 drivers/gpu/drm/drm_connector

[PATCH 3/3] drm/vc4: Attach underscan props to the HDMI connector

2018-05-07 Thread Boris Brezillon
,right,top,bottom} properties defined in config.txt and parsed by the VC4 firmware. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/vc4/vc4_hdmi.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index

Re: [PATCH 1/3] drm/connector: Add generic underscan properties

2018-05-07 Thread Boris Brezillon
On Mon, 7 May 2018 18:01:44 +0300 Ville Syrjälä wrote: > On Mon, May 07, 2018 at 04:44:32PM +0200, Boris Brezillon wrote: > > We have 3 drivers defining the "underscan", "underscan hborder" and > > "underscan vborder" properties (radeon, amd and nouve

Re: [PATCH 0/3] drm/connector: Provide generic support for underscan

2018-05-09 Thread Boris Brezillon
Hi, On Mon, 7 May 2018 16:44:31 +0200 Boris Brezillon wrote: > Hello, > > This is an attempt at providing generic support for underscan connector > props. We already have 3 drivers defining the same underscan, underscan > vborder and underscan hborder properties (amd, radeon a

Re: [PATCH 3/3] drm/vc4: Attach underscan props to the HDMI connector

2018-05-09 Thread Boris Brezillon
On Mon, 7 May 2018 17:24:08 +0200 Daniel Vetter wrote: > On Mon, May 07, 2018 at 04:44:34PM +0200, Boris Brezillon wrote: > > Now that the plane code takes the underscan setup into account, we can > > safely attach the underscan props to the HDMI connector. > > > > W

Re: [PATCH 1/3] drm/connector: Add generic underscan properties

2018-05-11 Thread Boris Brezillon
On Tue, 8 May 2018 10:18:10 +1000 Ben Skeggs wrote: > On 8 May 2018 at 04:26, Harry Wentland wrote: > > > > > > On 2018-05-07 12:19 PM, Boris Brezillon wrote: > >> On Mon, 7 May 2018 18:01:44 +0300 > >> Ville Syrjälä wrote: > >> >

Re: [PATCH 1/3] drm/connector: Add generic underscan properties

2018-05-11 Thread Boris Brezillon
On Mon, 7 May 2018 17:25:30 +0200 Daniel Vetter wrote: > On Mon, May 07, 2018 at 05:15:33PM +0200, Daniel Vetter wrote: > > On Mon, May 07, 2018 at 04:44:32PM +0200, Boris Brezillon wrote: > > > We have 3 drivers defining the "underscan", "underscan hbor

[PATCH v2 4/4] drm/nouveau: Switch to the generic underscan props

2018-05-11 Thread Boris Brezillon
Now that underscan props can be parsed by the core and assigned to conn_state->underscan.xxx, we can rely on this implementation and get rid of the nouveau-specific underscan props. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/nouveau/nouveau_connector.c |

[PATCH v2 2/4] drm/vc4: Take underscan setup into account when updating planes

2018-05-11 Thread Boris Brezillon
ready to attach underscan properties to the HDMI connector. Signed-off-by: Boris Brezillon --- Changes in v2: - Take changes on hborder/vborder meaning into account --- drivers/gpu/drm/vc4/vc4_plane.c | 49 - 1 file changed, 48 insertions(+), 1 deletion

[PATCH v2 3/4] drm/vc4: Attach underscan props to the HDMI connector

2018-05-11 Thread Boris Brezillon
,right,top,bottom} properties defined in config.txt and parsed by the VC4 firmware. Signed-off-by: Boris Brezillon --- Changes in v2: - none --- drivers/gpu/drm/vc4/vc4_hdmi.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu

[PATCH v2 0/4] drm/connector: Provide generic support for underscan

2018-05-11 Thread Boris Brezillon
in the core and add ->underscan fields to drm_connector_state. In this v2, I also converted the nouveau driver to the generic approach. The amdgpu and radeon ones can't be converted since they're still not converted to the atomic interface. Regards, Boris Boris Brezillon (4):

[PATCH v2 1/4] drm/connector: Add generic underscan properties

2018-05-11 Thread Boris Brezillon
the property parsing logic can be shared by all DRM drivers. A driver can now attach underscan properties to its connector through the drm_connector_attach_underscan_properties() helper, and can check/apply the underscan setup based on the drm_connector_state->underscan fields. Signed-off-by: B

Re: [PATCH v2 2/4] drm/vc4: Take underscan setup into account when updating planes

2018-05-11 Thread Boris Brezillon
On Fri, 11 May 2018 18:34:50 +0300 Ville Syrjälä wrote: > On Fri, May 11, 2018 at 04:59:17PM +0200, Boris Brezillon wrote: > > Applying an underscan setup is just a matter of scaling all planes > > appropriately and adjusting the CRTC X/Y offset to account for the > > ho

Re: [PATCH v2 2/4] drm/vc4: Take underscan setup into account when updating planes

2018-05-11 Thread Boris Brezillon
On Fri, 11 May 2018 19:54:02 +0300 Ville Syrjälä wrote: > On Fri, May 11, 2018 at 05:52:56PM +0200, Boris Brezillon wrote: > > On Fri, 11 May 2018 18:34:50 +0300 > > Ville Syrjälä wrote: > > > > > On Fri, May 11, 2018 at 04:59:17PM +0200, Boris Brezillo

Re: [PATCH v2 2/4] drm/vc4: Take underscan setup into account when updating planes

2018-05-11 Thread Boris Brezillon
On Fri, 11 May 2018 20:29:48 +0300 Ville Syrjälä wrote: > On Fri, May 11, 2018 at 07:12:21PM +0200, Boris Brezillon wrote: > > On Fri, 11 May 2018 19:54:02 +0300 > > Ville Syrjälä wrote: > > > > > On Fri, May 11, 2018 at 05:52:56PM +0200, Boris Brezillon wrote:

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Boris Brezillon
On Wed, 22 Jan 2025 15:08:20 +0100 Philipp Stanner wrote: > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -3272,6 +3272,7 @@ group_create_queue(struct panthor_group *group, > const struct drm_panthor_queue_create *args) > { >

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Boris Brezillon
On Wed, 22 Jan 2025 15:08:20 +0100 Philipp Stanner wrote: > int drm_sched_init(struct drm_gpu_scheduler *sched, > -const struct drm_sched_backend_ops *ops, > -struct workqueue_struct *submit_wq, > -u32 num_rqs, u32 credit_limit, unsigned int hang_l

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Boris Brezillon
On Thu, 23 Jan 2025 08:33:01 +0100 Philipp Stanner wrote: > On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: > > On Wed, 22 Jan 2025 15:08:20 +0100 > > Philipp Stanner wrote: > > > > >  int drm_sched_init(struct drm_gpu_scheduler *sched, > > >

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Boris Brezillon
On Wed, 22 Jan 2025 16:14:59 + Tvrtko Ursulin wrote: > On 22/01/2025 15:51, Boris Brezillon wrote: > > On Wed, 22 Jan 2025 15:08:20 +0100 > > Philipp Stanner wrote: > > > >> --- a/drivers/gpu/drm/panthor/panthor_sched.c > >> +++ b/drivers/gpu/drm/

Re: [PATCH v2] drm/sched: Use struct for drm_sched_init() params

2025-01-29 Thread Boris Brezillon
| 17 +++--- > drivers/gpu/drm/nouveau/nouveau_sched.c| 15 +++-- > drivers/gpu/drm/panfrost/panfrost_job.c| 20 --- > drivers/gpu/drm/panthor/panthor_mmu.c | 16 +++-- > drivers/gpu/drm/panthor/panthor_sched.c| 29 + Panfrost and

Re: [PATCH v2] drm/sched: Use struct for drm_sched_init() params

2025-01-29 Thread Boris Brezillon
On Tue, 28 Jan 2025 22:49:47 +0100 Christian Gmeiner wrote: > > int etnaviv_sched_init(struct etnaviv_gpu *gpu) > > { > > - int ret; > > + const struct drm_sched_init_args args = { > > Why not declare it as static const struct drm_sched_init_args args = { ? Because some bits in