Re: [PATCH v2 1/5] drm/amd: Introduce additional IPS debug flags

2024-08-23 Thread Aurabindo Pillai
_DISABLE_IPS2_DYNAMIC = 0x2000, + + /** +* @DC_FORCE_IPS_ENABLE: If set, force enable all IPS, all the time. +*/ + DC_FORCE_IPS_ENABLE = 0x4000, }; enum amd_dpm_forced_level; Reviewed-by: Aurabindo Pillai -- Thanks & Regards, Aurabindo Pillai

Re: [PATCH 0/2] Fix for lightup issue on Lenovo 4k60 HDMI

2024-08-27 Thread Aurabindo Pillai
commit drm/amd/display: Fix Synaptics Cascaded DSC Determination drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Aurabindo Pillai -- Thanks & Regards, Aurabindo Pillai

[PATCH 00/15] DC Patches for 12 Feb 2024

2024-02-07 Thread Aurabindo Pillai
Summary: * Revert some changes related to pixel encoding and clocks that cause corruption * IPS hang fix and FGCG enable by default for DCN35 * PSR-SU/Replay fixes * Plane clip size change treated as medium update * Fix for checking link alignment done during link tra

[PATCH 01/15] drm/amd/display: Add align done check

2024-02-07 Thread Aurabindo Pillai
From: Zhikai Zhai [WHY] We Double-check link status if training successful, but miss the lane align status. [HOW] Add the lane align status check Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Zhikai Zhai --- .../gpu/drm/amd/display/dc/link/protocols/link_dp_training.c

[PATCH 02/15] Revert "drm/amd/display: increased min_dcfclk_mhz and min_fclk_mhz"

2024-02-07 Thread Aurabindo Pillai
From: Sohaib Nadeem [why]: This reverts commit 5abbfa320b88da6034fd4121fa68c2b0e15e97ac. The commit caused corruption when running some applications in fullscreen Reviewed-by: Alvin Lee Acked-by: Aurabindo Pillai Signed-off-by: Sohaib Nadeem --- drivers/gpu/drm/amd/display/dc/dml/dcn32

[PATCH 05/15] drm/amd/display: treat plane clip size change as MED update type

2024-02-07 Thread Aurabindo Pillai
params in next program pipe. Reviewed-by: Aric Cyr Acked-by: Aurabindo Pillai Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/core/dc.c| 7 ++- drivers/gpu/drm/amd/display/dc/dc.h | 1 + drivers/gpu/drm/amd/display/dc/hwss/dcn20

[PATCH 03/15] drm/amd/display: Preserve original aspect ratio in create stream

2024-02-07 Thread Aurabindo Pillai
during create the stream. Reviewed-by: Aurabindo Pillai Acked-by: Aurabindo Pillai Signed-off-by: Tom Chung --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display

[PATCH 07/15] drm/amd/display: Update FIXED_VS Retimer HWSS Test Pattern Sequences

2024-02-07 Thread Aurabindo Pillai
mming when performing test pattern overrides. Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Michael Strauss --- drivers/gpu/drm/amd/display/dc/dc.h | 12 + .../display/dc/link/accessories/link_dp_cts.c | 27 +++--- .../hwss/link_hwss_dio_fixed_vs_pe_reti

[PATCH 04/15] Revert "drm/amd/display: Send DTBCLK disable message on first commit"

2024-02-07 Thread Aurabindo Pillai
From: Gabe Teeger This reverts commit 3fda240dc2f6a4a9a3965b80cfb83d0ddfbf489c. System hang observed, this commit is thought to be the regression point. Reviewed-by: Ovidiu Bunea Acked-by: Aurabindo Pillai Signed-off-by: Gabe Teeger --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35

[PATCH 12/15] drm/amd/display: should support dmub hw lock on Replay

2024-02-07 Thread Aurabindo Pillai
: Aurabindo Pillai Signed-off-by: Martin Tsai --- drivers/gpu/drm/amd/display/dc/dce/dmub_hw_lock_mgr.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_hw_lock_mgr.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_hw_lock_mgr.c index ba1fec3016d5

[PATCH 09/15] drm/amd/display: fixed integer types and null check locations

2024-02-07 Thread Aurabindo Pillai
From: Sohaib Nadeem [why]: issues fixed: - comparison with wider integer type in loop condition which can cause infinite loops - pointer dereference before null check Reviewed-by: Josip Pavic Acked-by: Aurabindo Pillai Signed-off-by: Sohaib Nadeem --- .../gpu/drm/amd/display/dc/bios

[PATCH 08/15] drm/amd/display: Fix array-index-out-of-bounds in dcn35_clkmgr

2024-02-07 Thread Aurabindo Pillai
From: Roman Li [Why] There is a potential memory access violation while iterating through array of dcn35 clks. [How] Limit iteration per array size. Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Roman Li --- .../amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c

[PATCH 06/15] drm/amd/display: enable fgcg by default

2024-02-07 Thread Aurabindo Pillai
From: Charlene Liu [why] sw has most of the fgcg enabled which is the same as HW default. but driver disabled some due to enable flag not initialized. comparing HW state, we still need to enable dpp and dio. Reviewed-by: Muhammad Ahmed Acked-by: Aurabindo Pillai Signed-off-by: Charlene Liu

[PATCH 14/15] Revert "drm/amd/display: Add left edge pixel for YCbCr422/420 + ODM pipe split"

2024-02-07 Thread Aurabindo Pillai
From: George Shen [Why/How] A regression was identified with the change to add left edge pixel for YCbCr422/420 + ODM combine cases. This reverts commit 8d09500a33f6a0e0df9cf17822fe51520d0df002 Reviewed-by: Martin Leung Acked-by: Aurabindo Pillai Signed-off-by: George Shen --- drivers/gpu

[PATCH 10/15] drm/amd/display: Add shared firmware state for DMUB IPS handshake

2024-02-07 Thread Aurabindo Pillai
-by: Charlene Liu Acked-by: Aurabindo Pillai Signed-off-by: Nicholas Kazlauskas --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 83 +++-- drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 6 +- .../gpu/drm/amd/display/dmub/inc

[PATCH 11/15] drm/amd/display: allow psr-su/replay for z8

2024-02-07 Thread Aurabindo Pillai
From: Charlene Liu [why] allow psr-su/replay for z8 Reviewed-by: Muhammad Ahmed Reviewed-by: Sung joon Kim Acked-by: Aurabindo Pillai Signed-off-by: Charlene Liu --- .../gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_smu.c | 12 ++-- drivers/gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c

[PATCH 15/15] drm/amd/display: 3.2.272

2024-02-07 Thread Aurabindo Pillai
. * HDMI compliance test fixes and other improvements Acked-by: Aurabindo Pillai Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index

[PATCH 13/15] drm/amd/display: Increase ips2_eval delay for DCN35

2024-02-07 Thread Aurabindo Pillai
From: Nicholas Kazlauskas [Why] New worst-case measurement observed at 1897us. [How] Increase to 2000us to cover the new worst case + margin. Reviewed-by: Ovidiu Bunea Acked-by: Aurabindo Pillai Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/resource/dcn35

[PATCH] drm/amd: Update atomfirmware.h for DCN401

2024-02-20 Thread Aurabindo Pillai
Add new firmware header definitions reqiured for DCN401 Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/include/atomfirmware.h | 33 ++ 1 file changed, 33 insertions(+) diff --git a/drivers/gpu/drm/amd/include/atomfirmware.h b/drivers/gpu/drm/amd/include

[PATCH] drm/amd/display: Enable idle optimizations on DCN401

2024-06-11 Thread Aurabindo Pillai
Idle optimizations were disabled due to some bugs which are now fixed in DMCUB and PM firwmare. Enable these the optimizations back. Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/resource/dcn401/dcn401_resource.c| 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers

[PATCH] drm/amdgpu: init TA fw for psp v14

2024-06-17 Thread Aurabindo Pillai
From: Likun Gao Add support to init TA firmware for psp v14. Signed-off-by: Likun Gao --- drivers/gpu/drm/amd/amdgpu/psp_v14_0.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v14_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v14_0.c index cc0248efa6b6..4d33c95

[PATCH 1/2] drm/amd: Add reg definitions for DCN401 DCC

2024-06-17 Thread Aurabindo Pillai
Add the necessary register definitions to enable DCC on DCN4x Signed-off-by: Aurabindo Pillai --- .../include/asic_reg/dcn/dcn_4_1_0_sh_mask.h | 110 ++ 1 file changed, 110 insertions(+) diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_4_1_0_sh_mask.h b/drivers/gpu

[PATCH 2/2] drm/amd/display: Enable DCC on DCN401

2024-06-17 Thread Aurabindo Pillai
Add registers and entry points to enable DCC on DCN4x Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 10 + .../drm/amd/display/dc/core/dc_hw_sequencer.c | 11 + drivers/gpu/drm/amd/display/dc/dc.h | 4 + .../drm/amd/display/dc/dml2

[PATCH] drm/amd: Add some missing register definitions

2024-06-25 Thread Aurabindo Pillai
Add some register offsets that are required for Display DCC on DCN401 Fixes: 000342e3a22 ("drm/amd: Add reg definitions for DCN401 DCC") Reported-by: Tom St Denis Signed-off-by: Aurabindo Pillai --- .../include/asic_reg/dcn/dcn_4_1_0_offset.h| 18 ++ 1 file c

[PATCH] drm/amd/display: Fix null pointer deref in dcn20_resource.c

2024-06-26 Thread Aurabindo Pillai
] ? dm_update_plane_state.constprop.0+0x4e3/0x6b0 [amdgpu] [ 181.850840] amdgpu_dm_atomic_check+0xdfe/0x1760 [amdgpu] Signed-off-by: Aurabindo Pillai --- .../drm/amd/display/dc/resource/dcn20/dcn20_resource.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers

Re: [PATCH] drm/amd/display: Add null check before access structs

2024-06-26 Thread Aurabindo Pillai
state, curr_pipe->plane_state); + if (!phantom_plane) + return; } memcpy(&phantom_plane->address, &curr_pipe->plane_state->address, sizeof(phantom_plane->address)); -- -- Thanks & Regards, Aurabindo Pillai

Re: [PATCH 06/13] drm/amdgpu/display: handle gfx12 in dm_check_cursor_fb

2024-06-26 Thread Aurabindo Pillai
Reviewed-by: Aurabindo Pillai On 6/26/24 2:31 PM, Marek Olšák wrote: Checking SWIZZLE_MODE has undefined behavior on gfx12. Signed-off-by: Marek Olšák --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [PATCH 10/13] drm/amdgpu/display: handle gfx12 in amdgpu_dm_plane_format_mod_supported

2024-06-26 Thread Aurabindo Pillai
Reviewed-by: Aurabindo Pillai On 6/26/24 2:31 PM, Marek Olšák wrote: All this code has undefined behavior on GFX12 and shouldn't be executed. Signed-off-by: Marek Olšák --- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 47 ++- 1 file changed, 25 insertions(+

Re: [PATCH 11/13] drm/amdgpu/display: set plane attributes for gfx12 correctly

2024-06-26 Thread Aurabindo Pillai
ne_fill_gfx9_plane_attributes_from_modifiers(adev, afb, format, rotation, plane_size, tiling_info, dcc, Reviewed-by: Aurabindo Pillai -- Thanks & Regards, Aurabindo Pillai

Re: [PATCH 12/13] drm/amdgpu/display: add all gfx12 modifiers

2024-06-26 Thread Aurabindo Pillai
Reviewed-by: Aurabindo Pillai On 6/26/24 2:31 PM, Marek Olšák wrote: Signed-off-by: Marek Olšák --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm

Re: [PATCH 13/13] drm/amdgpu: rewrite convert_tiling_flags_to_modifier_gfx12

2024-06-26 Thread Aurabindo Pillai
Reviewed-by: Aurabindo Pillai On 6/26/24 2:31 PM, Marek Olšák wrote: There were multiple bugs, like checking SWIZZLE_MODE before checking GFX12_SWIZZLE_MODE, which has undefined behavior. The function had no effect before (it always returned -EINVAL). Signed-off-by: Marek Olšák

Re: [PATCH 05/13] drm/amdgpu: remove AMD_FMT_MOD_GFX12_DCC_MAX_COMPRESSED_BLOCK_* definitions

2024-06-26 Thread Aurabindo Pillai
Reviewed-by: Aurabindo Pillai On 6/26/24 2:31 PM, Marek Olšák wrote: They were added accidentally. Signed-off-by: Marek Olšák --- include/uapi/drm/drm_fourcc.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index

[PATCH v2] drm/amd/display: Fix null pointer deref in dcn20_resource.c

2024-06-26 Thread Aurabindo Pillai
] ? dm_update_plane_state.constprop.0+0x4e3/0x6b0 [amdgpu] [ 181.850840] amdgpu_dm_atomic_check+0xdfe/0x1760 [amdgpu] Signed-off-by: Aurabindo Pillai --- .../drm/amd/display/dc/resource/dcn20/dcn20_resource.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH] drm/amd/display: Allow display DCC for DCN401

2024-07-08 Thread Aurabindo Pillai
To enable mesa to use display dcc, DM should expose them in the supported modifiers. Add the best (most efficient) modifiers first. Signed-off-by: Aurabindo Pillai --- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 31 +++ 1 file changed, 25 insertions(+), 6 deletions(-) diff

Re: [PATCH] drm/amd/display: Allow display DCC for DCN401

2024-07-10 Thread Aurabindo Pillai
On 7/10/24 10:49 AM, Marek Olšák wrote: This will enable display DCC for Wayland because Mesa already exposes modifiers with DCC. Has it been tested? Yes, its working for most resolutions. Investigating issue with certain modes. Marek -- Thanks & Regards, Aurabindo Pillai

Re: [PATCH] drm/amd/display: Allow display DCC for DCN401

2024-07-10 Thread Aurabindo Pillai
On 7/10/24 4:12 PM, Marek Olšák wrote: Can you also increase KMS_DRIVER_MINOR with a proper comment in amdgpu_drv.c, which will be used by Mesa to tell whether display DCC is supported on gfx12? Sure, will do. -- Thanks & Regards, Aurabindo Pillai

[PATCH] drm/amd: Bump KMS_DRIVER_MINOR version

2024-07-11 Thread Aurabindo Pillai
Increase the KMS minor version to indicate GFX12 DCC support since this contains a major change in how DCC is managed across IPs like GFX, DCN etc. This will be used mainly by userspace like Mesa to figure out DCC support on GFX12 hardware. Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm

[PATCH] drm/amd/display: fix doc entry for bb_from_dmub

2024-07-15 Thread Aurabindo Pillai
Fixes the warning: Function parameter or struct member 'bb_from_dmub' not described in 'amdgpu_display_manager' Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a

Re: [PATCH] drm/amd/display: Add doc entry for program_3dlut_size

2024-07-15 Thread Aurabindo Pillai
phen Rothwell this patch is: Reviewed-by: Aurabindo Pillai -- Thanks & Regards, Aurabindo Pillai

Re: [PATCH] drm/amd/display: Add function banner for idle_workqueue

2024-07-15 Thread Aurabindo Pillai
Reviewed-by: Aurabindo Pillai On 7/15/24 4:57 PM, roman...@amd.com wrote: From: Roman Li [Why] htmldocs warning: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h: warning: Function parameter or struct member 'idle_workqueue' not described in 'amdgpu_display_manager'

Re: [PATCH] drm: Fix documentation warning for read_mpcc_state in mpc.h

2024-07-15 Thread Aurabindo Pillai
9d7 drm/amd/display: fix documentation warnings for mpc.h -- Thanks & Regards, Aurabindo Pillai

[PATCH 00/22] DC Patches for 15 July, 2024

2024-07-17 Thread Aurabindo Pillai
Wheeler Alex Hung (2): drm/amd/display: Add MST debug message when link detection fails drm/amd/display: Check link_res->hpo_dp_link_enc before using it Aric Cyr (1): drm/amd/display: 3.2.293 Aurabindo Pillai (3): drm/amd/display: rename dcn3/dcn4 to more sound terms drm/amd/display: ren

[PATCH 01/22] drm/amd/display: Remove hardmax usage for dcn401

2024-07-17 Thread Aurabindo Pillai
From: Dillon Varone [WHY&HOW] Hardmax message will be retired for dcn4, so this removes it. Reviewed-by: Alvin Lee Signed-off-by: Aurabindo Pillai Signed-off-by: Dillon Varone --- .../dc/clk_mgr/dcn401/dcn401_clk_mgr.c| 44 ++- drivers/gpu/drm/amd/display/dc/

[PATCH 02/22] drm/amd/display: Check for NULL pointer

2024-07-17 Thread Aurabindo Pillai
From: Sung Joon Kim [why & how] Need to make sure plane_state is initialized before accessing its members. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Xi (Alex) Liu Signed-off-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim --- drivers/gpu/drm

[PATCH 03/22] drm/amd/display: Add private data type for RCG

2024-07-17 Thread Aurabindo Pillai
From: Hansen Dsouza [why & how] Add private data types for better RCG control Reviewed-by: Chris Park Reviewed-by: Yihan Zhu Signed-off-by: Aurabindo Pillai Signed-off-by: Hansen Dsouza --- .../amd/display/dc/dccg/dcn35/dcn35_dccg.c| 81 +++ 1 file changed

[PATCH 04/22] drm/amd/display: Refactoring HPO

2024-07-17 Thread Aurabindo Pillai
From: Revalla Hari Krishna [Why] To refactor HPO files [How] Moved hpo related files to specific hpo folder and update Makefiles. Reviewed-by: Martin Leung Signed-off-by: Aurabindo Pillai Signed-off-by: Revalla Hari Krishna --- drivers/gpu/drm/amd/display/dc/dcn30/Makefile | 2

[PATCH 05/22] drm/amd/display: Remove ASSERT if significance is zero in math_ceil2

2024-07-17 Thread Aurabindo Pillai
the ASSERT if the significance is equal to zero to avoid unnecessary noise. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Chaitanya Dhere Signed-off-by: Aurabindo Pillai Signed-off-by: Rodrigo Siqueira --- .../dml2/dml21/src/dml2_standalone_libraries

[PATCH 06/22] drm/amd/display: Add RCG helper functions

2024-07-17 Thread Aurabindo Pillai
From: Hansen Dsouza [why & how] Add standard RCG helpers based on DCCG spec Reviewed-by: Daniel Miess Reviewed-by: Muhammad Ahmed Signed-off-by: Aurabindo Pillai Signed-off-by: Hansen Dsouza --- .../amd/display/dc/dccg/dcn35/dcn35_dccg.c| 307 ++ 1 file changed,

[PATCH 08/22] drm/amd/display: ensure EASF and ISHARP coefficients are programmed together

2024-07-17 Thread Aurabindo Pillai
force EASF coefficients programming Reviewed-by: Alvin Lee Signed-off-by: Aurabindo Pillai Signed-off-by: Samson Tam --- .../display/dc/dpp/dcn401/dcn401_dpp_dscl.c | 28 +-- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dpp

[PATCH 07/22] drm/amd/display: Fix visual confirm bug for SubVP

2024-07-17 Thread Aurabindo Pillai
From: Ryan Seto [Why] Visual confirm was incorrect on dual monitor SubVP setup [How] Adjusted p_state assignment for dual monitor SubVP setup Signed-off-by: Ryan Seto Reviewed-by: Chaitanya Dhere Signed-off-by: Aurabindo Pillai --- .../dc/dml2/dml21/dml21_translation_helper.c | 13

[PATCH 09/22] drm/amd/display: Check if Mode is Supported Before Returning Result

2024-07-17 Thread Aurabindo Pillai
From: Austin Zheng [Why] Even if the mode is not supported dml2_check_mode_supported() would still return true. This causes an unsupported mode to be programmed. [How] Check if the mode is supported or not and return the proper result. Reviewed-by: Chaitanya Dhere Signed-off-by: Aurabindo

[PATCH 10/22] drm/amd/display: Add source select helper functions

2024-07-17 Thread Aurabindo Pillai
From: Hansen Dsouza [why & how] Add source select helpers based on DCCG spec Reviewed-by: Daniel Miess Signed-off-by: Aurabindo Pillai Signed-off-by: Hansen Dsouza --- .../amd/display/dc/dccg/dcn35/dcn35_dccg.c| 324 ++ 1 file changed, 324 insertions(+) diff --g

[PATCH 11/22] drm/amd/display: rename dcn3/dcn4 to more sound terms

2024-07-17 Thread Aurabindo Pillai
Use more accurate names to refer to the asic architecture. dcn3 in DML actually refers to DCN32 and DCN321, so rename it to dcn32x dcn4 refers to any DCN4x soc., and hence rename dcn4 to dcn4x Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai

[PATCH 12/22] drm/amd/display: rename dcn401_soc to dcn4_variant_a_soc

2024-07-17 Thread Aurabindo Pillai
To distinguish between different soc with same DCN IP, use variants starting with alphabets Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai --- .../drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c| 2 +- .../amd/display/dc/dml2/dml21

[PATCH 13/22] drm/amd/display: Add helper function to check for non-address fast updates

2024-07-17 Thread Aurabindo Pillai
From: Ilya Bakoulin [Why/How] Need to identify which fast updates will update more than just the address. Reviewed-by: Alvin Lee Signed-off-by: Aurabindo Pillai Signed-off-by: Ilya Bakoulin --- drivers/gpu/drm/amd/display/dc/core/dc.c | 25 +++- drivers/gpu/drm/amd

[PATCH 14/22] drm/amd/display: Fix Potential Null Dereference

2024-07-17 Thread Aurabindo Pillai
From: Gabe Teeger [what & why] System hang after s4 regression points to code change here. Removing possible NULL dereference. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Nicholas Kazlauskas Signed-off-by: Aurabindo Pillai Signed-off-by: Gabe Te

[PATCH 15/22] drm/amd/display: Check top sink only when multiple streams for DP2

2024-07-17 Thread Aurabindo Pillai
DTBCLK and causes hang. [how] For DP2.0 MST hubs, only treat 1st remote sink as an encoder only when there are multiple displays connected. Reviewed-by: Michael Strauss Signed-off-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim --- .../amd/display/dc/dml2/dml2_internal_types.h | 1 + .../display

[PATCH 16/22] drm/amd/display: Add MST debug message when link detection fails

2024-07-17 Thread Aurabindo Pillai
From: Alex Hung [WHY & HOW] dc_link_detect returns a boolean value which can be used to print debug messages when it fails. This fixes 1 CHECKED_RETURN issue reported by Coverity. Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai Signed-off-by: Alex Hung --- drivers/gpu/drm

[PATCH 17/22] drm/amd/display: Check link_res->hpo_dp_link_enc before using it

2024-07-17 Thread Aurabindo Pillai
From: Alex Hung [WHAT & HOW] Functions dp_enable_link_phy and dp_disable_link_phy can pass link_res without initializing hpo_dp_link_enc and it is necessary to check for null before dereferencing. This fixes 1 FORWARD_NULL issue reported by Coverity. Fixes: abdcd93214 ("drm/amd/display: Check l

[PATCH 18/22] drm/amd/display: Remove old comments

2024-07-17 Thread Aurabindo Pillai
From: Rodrigo Siqueira Remove some old comments from DCN32/321. Signed-off-by: Rodrigo Siqueira Reviewed-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 4 ++-- drivers/gpu/drm/amd/display/dc/dml/dcn321/dcn321_fpu.c | 4 ++-- 2 files changed, 4 insertions

[PATCH 19/22] drm/amd/display: Various DML2 fixes for FAMS2

2024-07-17 Thread Aurabindo Pillai
From: Dillon Varone The disable fams2 operation was reworked, but some of the old code remained. This commit removes the disable_fams2_drr from the dml2_stream_parameters. Reviewed-by: Rodrigo Siqueira Signed-off-by: Dillon Varone Signed-off-by: Aurabindo Pillai --- .../amd/display/dc/dml2

[PATCH 20/22] drm/amd/display: Remove duplicate HWSS interfaces

2024-07-17 Thread Aurabindo Pillai
HWSS. - update_plane_addr should only be public, as it's used outside HWSS. Reviewed-by: Rodrigo Siqueira Signed-off-by: Joshua Aberback Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c | 1 - .../gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq

[PATCH 21/22] drm/amd/display: remove unused folder

2024-07-17 Thread Aurabindo Pillai
dc/{dcn401,dcn303} are unused since the files in it got moved under their respective new components location. Hence they are no longer necessary Fixes: fb17441f8ce4 ("drm/amd/display: Refactor DCN3X into component folder") Signed-off-by: Aurabindo Pillai Reviewed-by: Leo Li --- drive

[PATCH 22/22] drm/amd/display: 3.2.293

2024-07-17 Thread Aurabindo Pillai
From: Aric Cyr Signed-off-by: Aurabindo Pillai Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 272ae1bdc57f..4077c1ddb9c1 100644

[PATCH 00/37] DC Patches April 22, 2024

2024-04-22 Thread Aurabindo Pillai
Summary: * Changes across DSC, MST, DMCUB, Panel Replay and misc fixes. * Fixes to cursor programming sequence * Add some missing register defs * Formatting/Sytle fixes == Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.214.0 Aric Cyr (1): drm/am

[PATCH 01/37] drm/amd/display: Add missing debug registers for DCN2/3/3.1

2024-04-22 Thread Aurabindo Pillai
From: Rodrigo Siqueira This commit add some missing debug registers for DPCS and RDPC debug. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- .../amd/display/dc/dcn20/dcn20_link_encoder.h | 5 +++- .../display/dc/dcn31/dcn31_dio_link_encoder.h | 2

[PATCH 02/37] drm/amd/display: Add missing dwb registers

2024-04-22 Thread Aurabindo Pillai
From: Rodrigo Siqueira DCN3.0 supports some specific DWB debug registers that are not exposed yet. This commit just adds the missing registers. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dwb.h | 14

[PATCH 03/37] drm/amd/display: Add TMDS DC balancer control

2024-04-22 Thread Aurabindo Pillai
From: Rodrigo Siqueira Add TMDS balancer control to the list of available encoder registers for DCN 30. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dio_link_encoder.h | 3 ++- 1 file changed, 2

[PATCH 04/37] drm/amd/display: Add some missing HDMI registers for DCN3x

2024-04-22 Thread Aurabindo Pillai
From: Rodrigo Siqueira This commit add some missing HDMI control registers to DCN3x. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dccg.h | 3 +++ drivers/gpu/drm/amd/display/dc/dcn31/dcn31_dccg.h

[PATCH 05/37] drm/amd/display: Increase SAT_UPDATE_PENDING timeout

2024-04-22 Thread Aurabindo Pillai
From: Dmytro Laktyushkin Headless dp 2.0 will take longer to update. Reviewed-by: Rodrigo Siqueira Signed-off-by: Dmytro Laktyushkin Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_link_encoder.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 07/37] drm/amd/display: Clean up code in DC

2024-04-22 Thread Aurabindo Pillai
From: Rodrigo Siqueira This commit removes some unnecessary code and makes the required adjustments to replace other parts of the code with a short option. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/dce

[PATCH 06/37] drm/amd/display: Handle Y carry-over in VCP X.Y calculation

2024-04-22 Thread Aurabindo Pillai
From: George Shen Theoretically rare corner case where ceil(Y) results in rounding up to an integer. If this happens, the 1 should be carried over to the X value. CC: sta...@vger.kernel.org Reviewed-by: Rodrigo Siqueira Signed-off-by: George Shen Tested-by: Daniel Wheeler --- .../drm/amd/dis

[PATCH 08/37] drm/amd/display: Adjust registers sequence in the DIO list

2024-04-22 Thread Aurabindo Pillai
From: Rodrigo Siqueira This commit reorganizes the order in which some control registers are presented to make it easier to identify the operations based on the hardware doc. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/dc

[PATCH 09/37] drm/amd/display: Code style adjustments

2024-04-22 Thread Aurabindo Pillai
From: Rodrigo Siqueira This commit address some small code style issues in DC. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/dc/dcn321/dcn321_dio_link_encoder.c| 3 +-- drivers/gpu/drm/amd/display/dc/dm_helpers.h

[PATCH 10/37] drm/amd/display: Add some HDCP registers DCN35 list

2024-04-22 Thread Aurabindo Pillai
From: Rodrigo Siqueira Add some missing HDCP registers to be used in DCN35. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- .../amd/display/dc/dcn35/dcn35_dio_link_encoder.h| 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff

[PATCH 12/37] drm/amd/display: Ensure that dmcub support flag is set for DCN20

2024-04-22 Thread Aurabindo Pillai
From: Rodrigo Siqueira In the DCN20 resource initialization, ensure that DMCUB support starts configured as true. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/resource/dcn20/dcn20_resource.c | 1 + 1 file changed, 1

[PATCH 11/37] drm/amd/display: Update comments in DC

2024-04-22 Thread Aurabindo Pillai
From: Rodrigo Siqueira This commit adds, updates, and removes some of the comments used in the DC code. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/dc/dml/dcn10/dcn10_fpu.h| 2 +- .../gpu/drm/amd/display/dc/dpp/dcn201

[PATCH 13/37] drm/amd/display: Add missing IRQ types

2024-04-22 Thread Aurabindo Pillai
From: Rodrigo Siqueira This commit add some DPCX IRQ types. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/irq_types.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc

[PATCH 14/37] drm/amd/display: Drop unnecessary semicolon

2024-04-22 Thread Aurabindo Pillai
From: Rodrigo Siqueira Drop unnecessary semicolon that can create a problem of double semicolon in some compilers. Reviewed-by: Martin Leung Acked-by: Aurabindo Pillai Signed-off-by: Rodrigo Siqueira Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_opp.h | 3

[PATCH 15/37] drm/amd/display: Fix Replay Desync Error Test

2024-04-22 Thread Aurabindo Pillai
From: Dennis Chan When PHY power off, the DP_SEC_CNTL cannot be configured and cause disable Adaptive sync SDP failed. Regarding the issue, the driver will disabled AS-SDP in replay state machine. Reviewed-by: ChunTao Tso Acked-by: Aurabindo Pillai Signed-off-by: Dennis Chan Tested-by

[PATCH 16/37] drm/amd/display: Add null check in resource_log_pipe_topology_update

2024-04-22 Thread Aurabindo Pillai
eck in dc_resource.c/resource_log_pipe_topology_update. CC: sta...@vger.kernel.org Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Natanel Roizenman Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers

[PATCH 17/37] drm/amd/display: Add dtbclk access to dcn315

2024-04-22 Thread Aurabindo Pillai
wed-by: Dmytro Laktyushkin Acked-by: Aurabindo Pillai Signed-off-by: Swapnil Patel Tested-by: Daniel Wheeler --- .../drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c b/drive

[PATCH 18/37] drm/amd/display: Reuse the modified power sequence

2024-04-22 Thread Aurabindo Pillai
From: Sung Joon Kim [why & how] Need to update the function pointers that perform the power up and down sequence to reuse the modified sequence as a requirement. Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim Tested-by: Daniel Wheeler --- dri

[PATCH 19/37] drm/amd/display: Handle HPD_IRQ for internal link

2024-04-22 Thread Aurabindo Pillai
: Aurabindo Pillai Signed-off-by: Sung-huai Wang Tested-by: Daniel Wheeler --- .../dc/link/protocols/link_dp_irq_handler.c | 25 --- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_irq_handler.c b/drivers/gpu

[PATCH 20/37] drm/amd/display: Add delay to improve LTTPR UHBR interop

2024-04-22 Thread Aurabindo Pillai
From: Michael Strauss [WHY] Avoid race condition which puts LTTPR into bad state during UHBR LT. [HOW] Delay 30ms between starting UHBR TPS1 PHY output and sending TPS1 via DPCD. Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Michael Strauss Tested-by: Daniel Wheeler

[PATCH 22/37] drm/amd/display: Skip SST ACT polling when sink_count is 0

2024-04-22 Thread Aurabindo Pillai
be skipped when clearing the payload allocation table. Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: George Shen Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH 21/37] drm/amd/display: Atom Integrated System Info v2_2 for DCN35

2024-04-22 Thread Aurabindo Pillai
w BIOS version 2.3. Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Gabe Teeger Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/d

[PATCH 23/37] drm/amd/display: Block FPO According to Luminance Delta

2024-04-22 Thread Aurabindo Pillai
flicker. - Generalized increase/reduce dependent functions to reduce code clutter and allow for easier use. - Added a debug option to enable the feature. Disabled by default. Co-authored-by: Ethan Bitnun Reviewed-by: Dillon Varone Acked-by: Aurabindo Pillai Signed-off-by: Ethan Bitnun

[PATCH 24/37] drm/amd/display: Force flush after write to IPS driver signals

2024-04-22 Thread Aurabindo Pillai
From: Nicholas Kazlauskas [Why] It's possible that the write hasn't fully completed by the time we send (and flush) a command to DMCUB to notify idle to request IPS2 exit. [How] Perform a readback of the volatile structure into dc_dmub_srv state. Reviewed-by: Charlene Liu Acked-by:

[PATCH 25/37] drm/amd/display: Fix incorrect DSC instance for MST

2024-04-22 Thread Aurabindo Pillai
tor->sink check to find pipe_ctx. CC: sta...@vger.kernel.org Reviewed-by: Aurabindo Pillai Signed-off-by: Hersen Wu Tested-by: Daniel Wheeler --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 48 ++- 1 file changed, 36 insertions(+), 12 deletions(-) diff --git a/drivers/g

[PATCH 26/37] drm/amd/display: Allocate zero bw after bw alloc enable

2024-04-22 Thread Aurabindo Pillai
, this causes bw allocation failure when allocation greater than estimated bw. [How] Do zero alloc to make the CM to release preallocation and update estimated BW correctly for all DPIAs per host router. Reviewed-by: PeiChen Huang Acked-by: Aurabindo Pillai Signed-off-by: Meenakshikumar

[PATCH 27/37] drm/amd/display: Add condition for dp_set_dsc_config call

2024-04-22 Thread Aurabindo Pillai
From: Ilya Bakoulin Not every ASIC implements dp_set_dsc_config. Add condition to prevent calls to unimplemented function. Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Ilya Bakoulin Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 16

[PATCH 28/37] Revert "drm/amd/display: Fix incorrect pointer assignment"

2024-04-22 Thread Aurabindo Pillai
-by: Chaitanya Dhere Acked-by: Aurabindo Pillai Signed-off-by: Joshua Aberback Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/core/dc_state.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_state.c b/drivers

[PATCH 29/37] drm/amd/display: Separate setting and programming of cursor

2024-04-22 Thread Aurabindo Pillai
ommits. Reviewed-by: Agustin Gutierrez Acked-by: Aurabindo Pillai Signed-off-by: Harry Wentland Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 6 +- .../gpu/drm/amd/display/dc/core/dc_stream.c | 87

[PATCH 30/37] drm/amd/display: Set cursor attributes before position

2024-04-22 Thread Aurabindo Pillai
s first to ensure hubp has the right attributes to be programmed. Reviewed-by: Agustin Gutierrez Acked-by: Aurabindo Pillai Signed-off-by: Harry Wentland Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 2 +- drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_h

[PATCH 31/37] drm/amd/display: Fix recout calculation for stereo side-by-side

2024-04-22 Thread Aurabindo Pillai
From: Sung Joon Kim [why & how] The recout x offset was incorrect which led to wrong viewport calculation. For stereo side-by-side case, the slice index should be 0 for both split pipes. Reviewed-by: Dmytro Laktyushkin Acked-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim Tested-by: Da

[PATCH 32/37] drm/amd/display: Disable error correction if it's not supported

2024-04-22 Thread Aurabindo Pillai
From: Cruise [Why] Error correction was enabled in a monitor which doesn't support. [How] Disable error correction if it's not supported Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Cruise Tested-by: Daniel Wheeler --- .../display/dc/link/protocols/lin

[PATCH 34/37] drm/amd/display: Update dcn351 debug flags and function pointers

2024-04-22 Thread Aurabindo Pillai
From: Sung Joon Kim [why & how] There are potential issues with Z8 and IPS that need to be addressed and need to add in missing function pointers. Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim Tested-by: Daniel Wheeler --- drivers/gpu/drm

[PATCH 33/37] drm/amd/display: Keep VBios pixel rate div setting util next mode set

2024-04-22 Thread Aurabindo Pillai
mode set. Reviewed-by: Jun Lei Acked-by: Aurabindo Pillai Signed-off-by: yi-lchen Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 4 ++ .../drm/amd/display/dc/dcn314/dcn314_dccg.c | 12 ++--- .../gpu/drm/amd/display/dc/dcn32/dcn32_dccg.c | 13 +++--- .../

[PATCH 35/37] drm/amd/display: Replace uint8_t with u8 for dp_hdmi_dongle_signature_str

2024-04-22 Thread Aurabindo Pillai
From: Rodrigo Siqueira The string dp_hdmi_dongle_signature_str already uses u8 but the string dp_hdmi_dongle_signature_str does not. Just replace uint8_t with u8 for dp_hdmi_dongle_signature_str. Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Rodrigo Siqueira Tested-by

  1   2   3   4   5   6   7   >