Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-03-30 Thread Shengyu Qu
Hi, Do we really need to disable cursor plane color pipeline support? I don't think we need to disable that if it is supported, since there might be some user-defined colored cursor icon. Best regards, Shengyu For some unknown reason, seems my mail is not shown in the mail list archive, so

Re: [PATCH] ACPI: video: Handle fetching EDID as ACPI_TYPE_PACKAGE

2025-03-30 Thread Gergo Koteles
Hi Mario, Thanks for the suggestions! On Fri, 2025-03-28 at 08:42 -0500, Mario Limonciello wrote: > On 3/28/2025 06:12, Rafael J. Wysocki wrote: > > CC: Hans > > > > On Fri, Mar 28, 2025 at 3:51 AM Gergo Koteles wrote: > > > > > > Some Lenovo laptops incorrectly return EDID as > > > buffer in

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-03-30 Thread Shengyu Qu
Hi, Do we really need to disable cursor plane color pipeline support? I don't think we need to disable that if it is supported, since there might be some user-defined colored cursor icon. Best regards, Shengyu 在 2025/3/27 7:47, Alex Hung 写道: cursor plane does not need to have color pipeline

[PATCH v2] ACPI: video: Handle fetching EDID as ACPI_TYPE_PACKAGE

2025-03-30 Thread Gergo Koteles
The _DDC method should return a buffer, or an integer in case of an error. But some Lenovo laptops incorrectly return EDID as buffer in ACPI package. Calling _DDC generates this ACPI Warning: ACPI Warning: \_SB.PCI0.GP17.VGA.LCD._DDC: Return type mismatch - \ found Package, expected Integer/Buffer

Re: [PATCH] drm/amd/display: replace use of msleep(<20) with usleep_range for better accuracy

2025-03-30 Thread Shuah Khan
On 3/26/25 01:00, James Flowers wrote: msleep < 20ms will often sleep for ~20ms (according to Documentation/timers/timers-howto.rst). Can you elaborate and explain why this change is necessary? Signed-off-by: James Flowers --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2

RE: [PATCH 1/3] drm/amdgpu/pm: add workload profile pause helper

2025-03-30 Thread Feng, Kenneth
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Kenneth Feng -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Saturday, March 29, 2025 2:24 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 1/3] drm/amdgpu/pm: ad

Re: [PATCH 03/14] drm/amd: Convert dev_err_once() messages to drm_err_once()

2025-03-30 Thread Mario Limonciello
On 3/28/25 14:04, Alex Deucher wrote: On Thu, Mar 27, 2025 at 4:48 PM Mario Limonciello wrote: From: Mario Limonciello The errors for power consumption in amdgpu_acpi_is_s0ix_active() are under device scope. As they're drm errors, adjust to drm scope. Is there an advantage to drm vs dev