Re: [PATCH v3 1/4] drm/amdgpu: add or move defines for DCE6 in sid.h

On Thu, Mar 6, 2025 at 10:19 AM Alex Deucher wrote: > > On Wed, Mar 5, 2025 at 9:08 PM Alexandre Demers > wrote: > > > > For coherence with DCE8 et DCE10, add or move some values under sid.h. > > > > Signed-off-by: Alexandre Demers > > This change doesn't build. Please adjust the order of the p

[RFC PATCH 3/7] drm/amd/display: use drm_edid_product_id for parsing EDID product info

Since [1], we can use drm_edid_product_id to get debug info from drm_edid instead of directly parsing EDID. Link: https://lore.kernel.org/dri-devel/cover.1712655867.git.jani.nik...@intel.com/ [1] Signed-off-by: Melissa Wen --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 15

Re: [PATCH v2] drm/amdgpu: handle amdgpu_cgs_create_device() errors in amd_powerplay_create()

Applied. Thanks On Thu, Mar 6, 2025 at 2:52 AM Wentao Liang wrote: > > Add error handling to propagate amdgpu_cgs_create_device() failures > to the caller. When amdgpu_cgs_create_device() fails, release hwmgr > and return -ENOMEM to prevent null pointer dereference. > > [v1]->[v2]: Change error

Re: [PATCH] drm: amdkfd: Replace (un)register_chrdev() by (unregister/alloc)_chrdev_region()

On Wed, Mar 05, 2025 at 07:18:33PM -0500, Felix Kuehling wrote: > > On 2025-03-05 16:08, Salah Triki wrote: > > Replace (un)register_chrdev() by (unregister/alloc)_chrdev_region() as > > they are deprecated since kernel 2.6. > > Where is that information coming from? I see __register_chrdev docum

RE: [PATCH v2] drm/amdgpu: Use unique CPER record id across devices

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Tao Zhou > -Original Message- > From: Liu, Xiang(Dean) > Sent: Thursday, March 6, 2025 4:23 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Liu, Xiang(Dean) > Subject: [PATCH v2] drm/amdg

[RFC PATCH 7/7] drm/amd/display: get SADB from drm_eld when parsing EDID caps

drm_edid_connector_update() updates display info, filling ELD with speaker allocation data in the last step of update_dislay_info(). Our goal is stopping using raw edid, so we can extract SADB from drm_eld instead of access raw edid to get audio caps. Signed-off-by: Melissa Wen --- .../amd/displ

[RFC PATCH 4/7] drm/amd/display: parse display name from drm_eld

We don't need to parse dc_edid to get the display name since it's already set in drm_eld which in turn had it values updated when updating connector with the opaque drm_edid. Signed-off-by: Melissa Wen --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 10 ++ 1 file changed, 6

[RFC PATCH 5/7] drm/amd/display: get panel id with drm_edid helper

Instead of using driver-specific code, use DRM helpers. Signed-off-by: Melissa Wen --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/d

Re: [PATCH 04/11] drm/amdgpu/mes: centralize gfx_hqd mask management

On 3/6/2025 2:17 AM, Alex Deucher wrote: Move it to amdgpu_mes to align with the compute and sdma hqd masks. No functional change. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 24 drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 16 +++

[RFC PATCH 2/7] drm/amd/display: start using drm_edid helpers to parse EDID caps

Groundwork that allocates a temporary drm_edid from raw edid to take advantage of DRM common-code helpers instead of driver-specific code. Signed-off-by: Melissa Wen --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

[RFC PATCH 0/7] drm/amd/display: more DRM edid common-code to the display driver

Hi, I've been working on a new version of [1] that ports the AMD display driver to use the common `drm_edid` code instead of open and raw edid handling. The part of the previous series that didn't make the cut was to replace the open coded edid parser with `drm_edid_product_id` and `eld` data. Ho

[RFC PATCH 6/7] drm/amd/display: get SAD from drm_eld when parsing EDID caps

drm_edid_connector_update() updates display info, filling ELD with audio info from Short-Audio Descriptors in the last step of update_dislay_info(). Our goal is stopping using raw edid, so we can extract SAD from drm_eld instead of access raw edid to get audio caps. Signed-off-by: Melissa Wen ---

SI DMA: clarification on naming convention

Hi, While working on cleaning up sid.h, si_enums.h and some other SI related files, I've been scratching my head about why SI DMA files and variables were named "DMA" compared to CIK and over where "SDMA" is used. While I understand that a new system DMA was introduced with CIK, isn't SI DMA also

[RFC PATCH 1/7] drm/amd/display: make sure drm_edid stored in aconnector doesn't leak

Make sure the drm_edid container stored in aconnector is freed when detroying the aconnector. Fixes: 48edb2a4 ("drm/amd/display: switch amdgpu_dm_connector to use struct drm_edid") Signed-off-by: Melissa Wen --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ 1 file changed, 2 inserti