Re: [PATCH v3 02/10] drm/amdgpu: Add helper funcs for jpeg devcoredump

2025-01-31 Thread Lazar, Lijo
On 1/31/2025 1:22 PM, Sundararaju, Sathishkumar wrote: > Hi Lijo, > > Gentle ping, reg_dump_fini() is now moved to sw_fini() in this version > as suggested. > Ah, didn't know this was waiting on me. I was not particular about it, thought Leo's R-B was good enough. Series is - Acked-b

[PATCH v7 0/7] Improve gpu_scheduler trace events + uAPI

2025-01-31 Thread Pierre-Eric Pelloux-Prayer
Hi, The initial goal of this series was to improve the drm and amdgpu trace events to be able to expose more of the inner workings of the scheduler and drivers to developers via tools. Then, the series evolved to become focused only on gpu_scheduler. The changes around vblank events will be part

[PATCH v7 2/7] drm/sched: store the drm client_id in drm_sched_fence

2025-01-31 Thread Pierre-Eric Pelloux-Prayer
This will be used in a later commit to trace the drm client_id in some of the gpu_scheduler trace events. This requires changing all the users of drm_sched_job_init to add an extra parameter. The newly added drm_client_id field in the drm_sched_fence is a bit of a duplicate of the owner one. One

[PATCH 07/44] drm/amdgpu/vcn5.0.1: split code along instances

2025-01-31 Thread Alex Deucher
Split the code on a per instance basis. This will allow us to use the per instance functions in the future to handle more things per instance. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 352 1 file changed, 174 insertions(+), 178 deletions

[PATCH 04/44] drm/amdgpu/vcn4.0.3: split code along instances

2025-01-31 Thread Alex Deucher
Split the code on a per instance basis. This will allow us to use the per instance functions in the future to handle more things per instance. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 417 1 file changed, 206 insertions(+), 211 deletions

[PATCH 03/44] drm/amdgpu/vcn4.0: split code along instances

2025-01-31 Thread Alex Deucher
Split the code on a per instance basis. This will allow us to use the per instance functions in the future to handle more things per instance. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 436 +- 1 file changed, 215 insertions(+), 221 deletions

[PATCH V3 00/44] VCN instance rework

2025-01-31 Thread Alex Deucher
These series reworks how instances are handled for VCN to better split the state between instances. This allows for per instance powergating and opens the path to further splitting VCN IP blocks per instance in the future if that is desirable. Per instance powergating is needed for per engine rese

[PATCH 35/44] drm/amdgpu/vcn2.0: use generic set_power_gating_state helper

2025-01-31 Thread Alex Deucher
No need for an IP specific version. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c index ecbf0dd0b6603..5409a877

[PATCH 28/44] drm/amdgpu/vcn4.0.3: add set_pg_state callback

2025-01-31 Thread Alex Deucher
Rework the code as a vcn instance callback. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 36 ++--- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c i

[PATCH 05/44] drm/amdgpu/vcn4.0.5: split code along instances

2025-01-31 Thread Alex Deucher
Split the code on a per instance basis. This will allow us to use the per instance functions in the future to handle more things per instance. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 438 1 file changed, 216 insertions(+), 222 deletions

[PATCH 34/44] drm/amdgpu/vcn1.0: use generic set_power_gating_state helper

2025-01-31 Thread Alex Deucher
No need for an IP specific version. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c index fdb954c7377eb..f3d41ddd

[PATCH 22/44] drm/amdgpu/vcn: add new per instance callback for powergating

2025-01-31 Thread Alex Deucher
This is per instance so add a new function pointer for it. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h index 8d34e3814ab19..508fa02

[PATCH 17/44] drm/amdgpu/vcn4.0.3: convert internal functions to use vcn_inst

2025-01-31 Thread Alex Deucher
Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c |

[PATCH 12/44] drm/amdgpu/vcn3.0: convert internal functions to use vcn_inst

2025-01-31 Thread Alex Deucher
Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 79

[PATCH 31/44] drm/amdgpu/vcn5.0.1: add set_pg_state callback

2025-01-31 Thread Alex Deucher
Rework the code as a vcn instance callback. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c i

[PATCH 11/44] drm/amdgpu/vcn: switch vcn helpers to be instance based

2025-01-31 Thread Alex Deucher
Pass the instance to the helpers. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 437 drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 12 +- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 16 +- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 16 +- drivers/

[PATCH 32/44] drm/amdgpu/vcn: use per instance callbacks for idle work handler

2025-01-31 Thread Alex Deucher
Use the vcn instance power gating callbacks rather than the IP powergating callback. This limits power gating to only the instance in use rather than all of the instances. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 27 - 1 file changed, 13

[PATCH 18/44] drm/amdgpu/vcn4.0.5: convert internal functions to use vcn_inst

2025-01-31 Thread Alex Deucher
Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c |

[PATCH 06/44] drm/amdgpu/vcn5.0.0: split code along instances

2025-01-31 Thread Alex Deucher
Split the code on a per instance basis. This will allow us to use the per instance functions in the future to handle more things per instance. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 386 1 file changed, 190 insertions(+), 196 deletions

[PATCH 15/44] drm/amdgpu/vcn2.5: convert internal functions to use vcn_inst

2025-01-31 Thread Alex Deucher
Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 79

[PATCH 10/44] drm/amdgpu/vcn: move more instanced data to vcn_instance

2025-01-31 Thread Alex Deucher
Move more per instance data into the per instance structure. v2: index instances directly on vcn1.0 and 2.0 to make it clear that they only support a single instance (Lijo) Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c

[PATCH 02/44] drm/amdgpu/vcn3.0: split code along instances

2025-01-31 Thread Alex Deucher
Split the code on a per instance basis. This will allow us to use the per instance functions in the future to handle more things per instance. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 436 +- 1 file changed, 213 insertions(+), 223 deletions

[PATCH 09/44] drm/amdgpu/vcn: make powergating status per instance

2025-01-31 Thread Alex Deucher
Store it per instance so we can track it per instance. v2: index instances directly on vcn1.0 and 2.0 to make it clear that they only support a single instance (Lijo) Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2 +- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c |

[PATCH 25/44] drm/amdgpu/vcn2.5: add set_pg_state callback

2025-01-31 Thread Alex Deucher
Rework the code as a vcn instance callback. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 37 +++ 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c index

[PATCH 01/44] drm/amdgpu/vcn2.5: split code along instances

2025-01-31 Thread Alex Deucher
Split the code on a per instance basis. This will allow us to use the per instance functions in the future to handle more things per instance. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 841 +- 1 file changed, 411 insertions(+), 430 deletions

[PATCH 19/44] drm/amdgpu/vcn5.0.0: convert internal functions to use vcn_inst

2025-01-31 Thread Alex Deucher
Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c |

[PATCH 27/44] drm/amdgpu/vcn4.0: add set_pg_state callback

2025-01-31 Thread Alex Deucher
Rework the code as a vcn instance callback. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 38 +++ 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c index

[PATCH 08/44] drm/amdgpu/vcn: switch work handler to be per instance

2025-01-31 Thread Alex Deucher
Have a separate work handler for each VCN instance. This paves the way for per instance VCN power gating at runtime. v2: index instances directly on vcn1.0 and 2.0 to make it clear that they only support a single instance (Lijo) Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH 37/44] drm/amdgpu/vcn3.0: use generic set_power_gating_state helper

2025-01-31 Thread Alex Deucher
No need for an IP specific version. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c index 353aab5565702..2f

[PATCH 43/44] drm/amdgpu/vcn: optimize firmware storage

2025-01-31 Thread Alex Deucher
If each instance uses the same fw image, only store one copy in the driver. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 30 + drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 4 +++- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 3 +++ 3 files changed

[PATCH 42/44] drm/amdgpu/vcn5.0.1: use generic set_power_gating_state helper

2025-01-31 Thread Alex Deucher
No need for an IP specific version. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 27 + 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c index 5ef26

[PATCH 30/44] drm/amdgpu/vcn5.0.0: add set_pg_state callback

2025-01-31 Thread Alex Deucher
Rework the code as a vcn instance callback. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c i

[PATCH 13/44] drm/amdgpu/vcn1.0: convert internal functions to use vcn_inst

2025-01-31 Thread Alex Deucher
Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 85

[PATCH 29/44] drm/amdgpu/vcn4.0.5: add set_pg_state callback

2025-01-31 Thread Alex Deucher
Rework the code as a vcn instance callback. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c i

[PATCH 20/44] drm/amdgpu/vcn5.0.1: convert internal functions to use vcn_inst

2025-01-31 Thread Alex Deucher
Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c |

[PATCH 33/44] drm/amdgpu/vcn: add a generic helper for set_power_gating_state

2025-01-31 Thread Alex Deucher
It's common for all VCN variants. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 23 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 3 +++ 2 files changed, 26 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd

[PATCH 14/44] drm/amdgpu/vcn2.0: convert internal functions to use vcn_inst

2025-01-31 Thread Alex Deucher
Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. v2: index instances directly on vcn1.0 and 2.0 to make it clear that they on

[PATCH 21/44] drm/amdgpu/vcn: adjust pause_dpg_mode function signature

2025-01-31 Thread Alex Deucher
Change it to take a vcn instance rather than adev to align with the vcn instance changes. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4

[PATCH 41/44] drm/amdgpu/vcn5.0.0: use generic set_power_gating_state helper

2025-01-31 Thread Alex Deucher
No need for an IP specific version. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 27 + 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c index 95881

[PATCH 40/44] drm/amdgpu/vcn4.0.5: use generic set_power_gating_state helper

2025-01-31 Thread Alex Deucher
No need for an IP specific version. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 27 + 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c index 0ac41

[PATCH 39/44] drm/amdgpu/vcn4.0.3: use generic set_power_gating_state helper

2025-01-31 Thread Alex Deucher
No need for an IP specific version. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 27 + 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c index 219e9

[PATCH 38/44] drm/amdgpu/vcn4.0: use generic set_power_gating_state helper

2025-01-31 Thread Alex Deucher
No need for an IP specific version. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 27 +-- 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c index 790b53360

[PATCH 16/44] drm/amdgpu/vcn4.0: convert internal functions to use vcn_inst

2025-01-31 Thread Alex Deucher
Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 11

[PATCH 44/44] drm/amdgpu/vcn: use dev_info() for firmware information

2025-01-31 Thread Alex Deucher
To properly handle multiple GPUs. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c index edbcb11c382a2..8d8b39e6d197a

[PATCH 36/44] drm/amdgpu/vcn2.5: use generic set_power_gating_state helper

2025-01-31 Thread Alex Deucher
No need for an IP specific version. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c index f5889d1bd0d4c.

[PATCH 26/44] drm/amdgpu/vcn3.0: add set_pg_state callback

2025-01-31 Thread Alex Deucher
Rework the code as a vcn instance callback. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 39 ++- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c index

[PATCH 23/44] drm/amdgpu/vcn1.0: add set_pg_state callback

2025-01-31 Thread Alex Deucher
Rework the code as a vcn instance callback. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 32 ++- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c index

[PATCH 24/44] drm/amdgpu/vcn2.0: add set_pg_state callback

2025-01-31 Thread Alex Deucher
Rework the code as a vcn instance callback. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 35 ++- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c index

Re: [PATCH 2/7] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-01-31 Thread Christian König
Am 31.01.25 um 17:55 schrieb Sundararaju, Sathishkumar: On 1/31/2025 10:19 PM, Christian König wrote: Am 31.01.25 um 17:40 schrieb Sundararaju, Sathishkumar: Hi Christian, On 1/31/2025 9:56 PM, Christian König wrote: Am 31.01.25 um 17:23 schrieb Sathishkumar S: Add ring reset function callb

Re: [PATCH 2/7] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-01-31 Thread Alex Deucher
On Fri, Jan 31, 2025 at 11:32 AM Sathishkumar S wrote: > > Add ring reset function callback for JPEG4_0_3 to > recover from job timeouts without a full gpu reset. > > Signed-off-by: Sathishkumar S > --- > drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 60 ++-- > 1 file changed, 5

Re: [PATCH v7 0/7] Improve gpu_scheduler trace events + uAPI

2025-01-31 Thread Christian König
I can't see patch #1 in my inbox for some reason, but I already know what it does from your repository. Feel free to add Reviewed-by: Christian König to the entire series. Regards, Christian. Am 31.01.25 um 12:02 schrieb Pierre-Eric Pelloux-Prayer: Hi, The initial goal of this series was

[PATCH 1/7] drm/amdgpu: Per-instance init func for JPEG4_0_3

2025-01-31 Thread Sathishkumar S
Add helper functions to handle per-instance and per-core initialization and deinitialization in JPEG4_0_3. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 190 --- 1 file changed, 98 insertions(+), 92 deletions(-) diff --git a/drivers/gpu/drm/amd

Re: [PATCH 2/7] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-01-31 Thread Sundararaju, Sathishkumar
Hi Alex, On 1/31/2025 10:42 PM, Alex Deucher wrote: On Fri, Jan 31, 2025 at 11:32 AM Sathishkumar S wrote: Add ring reset function callback for JPEG4_0_3 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 60

[PATCH] Support dmabuf IPC with amdgpu CRIU

2025-01-31 Thread David Francis
This patch (in combination with the accompanying CRIU patch) allows the amdgpu CRIU plugin to support dmabuf IPC. It includes - A new amdgpu ioctl (amdgpu_criu_op_ioctl), which has similar options to kfd_ioctl_criu, and accompanying structs. - New "is_retry" field in amdkfd CRIU ioctls, to

[no subject]

2025-01-31 Thread David Francis
We are working on extending support for CRIU checkpoint/restore in the amdgpu driver to support new use cases and ROCm applications increasingly using render node ioctls for memory management. In the longer term this may also allow checkpoint/restore of graphics application. With this patch series

[PATCH 2/4] drm/amdgpu/gfx: add amdgpu_gfx_off_ctrl_immediate()

2025-01-31 Thread Alex Deucher
Same as amdgpu_gfx_off_ctrl(), but without the delay for gfxoff disallow. Suggested-by: Błażej Szczygieł Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 53 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 1 + 2 files changed, 41 insertions(+), 13

[PATCH 4/4] drm/amdgpu: bump version for RV/PCO compute fix

2025-01-31 Thread Alex Deucher
Bump the driver version for RV/PCO compute stability fix so mesa can use this check to enable compute queues on RV/PCO. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH 3/4] drm/amdgpu/gfx9: use amdgpu_gfx_off_ctrl_immediate() for PG

2025-01-31 Thread Alex Deucher
Use amdgpu_gfx_off_ctrl_immediate() when powergating. There's no need for the delay in gfx off allow. The powergating is dynamically disabled/enabled as for RV/PCO on compute queues and allowing gfx off again as soon the job is submitted improves power savings. Suggested-by: Błażej Szczygieł Lin

[PATCH 1/4] drm/amdgpu/gfx9: manually control gfxoff for CS on RV

2025-01-31 Thread Alex Deucher
When mesa started using compute queues more often we started seeing additional hangs with compute queues. Disabling gfxoff seems to mitigate that. Manually control gfxoff and gfx pg with command submissions to avoid any issues related to gfxoff. KFD already does the same thing for these chips. v

Re: [PATCH 2/7] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-01-31 Thread Sundararaju, Sathishkumar
Hi Christian, On 1/31/2025 9:56 PM, Christian König wrote: Am 31.01.25 um 17:23 schrieb Sathishkumar S: Add ring reset function callback for JPEG4_0_3 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S ---   drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 60

Re: [PATCH 2/2] drm/amdkfd: use GTT for VRAM on APUs only if GTT is larger

2025-01-31 Thread Philip Yang
On 2025-01-30 15:51, Alex Deucher wrote: If the user has configured a large carveout on a small APU, only use GTT for VRAM allocations if GTT is larger than VRAM. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 -- 1 file ch

Re: [PATCH 2/7] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-01-31 Thread Christian König
Am 31.01.25 um 17:40 schrieb Sundararaju, Sathishkumar: Hi Christian, On 1/31/2025 9:56 PM, Christian König wrote: Am 31.01.25 um 17:23 schrieb Sathishkumar S: Add ring reset function callback for JPEG4_0_3 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S

[PATCH] drm/amdkfd: Change error handling at prange update in svm_range_set_attr

2025-01-31 Thread Xiaogang . Chen
From: Xiaogang Chen When register a vm range at svm the added vm range may be split into multiple subranges and/or existing pranges got spitted. The new pranges need validated and mapped. This patch changes error handling for pranges that fail updating: 1: free prange resources and remove it fro

Re: [PATCH 2/7] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-01-31 Thread Sundararaju, Sathishkumar
On 1/31/2025 10:19 PM, Christian König wrote: Am 31.01.25 um 17:40 schrieb Sundararaju, Sathishkumar: Hi Christian, On 1/31/2025 9:56 PM, Christian König wrote: Am 31.01.25 um 17:23 schrieb Sathishkumar S: Add ring reset function callback for JPEG4_0_3 to recover from job timeouts withou

Re: [PATCH] drm/amd/pm: Limit to 8 jpeg rings per instance

2025-01-31 Thread Alex Deucher
On Fri, Jan 31, 2025 at 8:02 AM Lijo Lazar wrote: > > JPEG 5.0.1 supports upto 10 rings, however PMFW support for SMU v13.0.6 > variants is now limited to 8 per instance. Limit to 8 temporarily to > avoid out of bounds access. > > Signed-off-by: Lijo Lazar Acked-by: Alex Deucher > --- > drive

[PATCH 2/7] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-01-31 Thread Sathishkumar S
Add ring reset function callback for JPEG4_0_3 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 60 ++-- 1 file changed, 57 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgp

[PATCH 3/7] drm/amdgpu: Add ring reset callback for JPEG4_0_0

2025-01-31 Thread Sathishkumar S
Add ring reset function callback for JPEG4_0_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jp

[PATCH 5/7] drm/amdgpu: Per-instance init func for JPEG2_5_0

2025-01-31 Thread Sathishkumar S
Add helper functions to handle per-instance initialization and deinitialization in JPEG2_5_0. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 102 + 1 file changed, 55 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_

[PATCH 4/7] drm/amdgpu: Add ring reset callback for JPEG3_0_0

2025-01-31 Thread Sathishkumar S
Add ring reset function callback for JPEG3_0_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c b/dri

[PATCH 6/7] drm/amdgpu: Add ring reset callback for JPEG2_5_0

2025-01-31 Thread Sathishkumar S
Add ring reset function callback for JPEG2_5_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c b/dr

[PATCH 0/7] Add jpeg ring reset callback

2025-01-31 Thread Sathishkumar S
This patch-series adds jpeg ring reset callback function to recover from job timeouts without a full gpu reset. How is it tested:- A bad job on jpeg causes timeout and recovers alongside an unaffected mpv vaapi-decode(vcn) in playback loop. Sathishkumar S (7): drm/amdgpu: Per-instance init fu

Re: [PATCH 2/7] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-01-31 Thread Christian König
Am 31.01.25 um 17:23 schrieb Sathishkumar S: Add ring reset function callback for JPEG4_0_3 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 60 ++-- 1 file changed, 57 insertions(+), 3 del

[PATCH 7/7] drm/amdgpu: Add ring reset callback for JPEG2_0_0

2025-01-31 Thread Sathishkumar S
Add ring reset function callback for JPEG2_0_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c b/dri

Re: [PATCH 2/7] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-01-31 Thread Sundararaju, Sathishkumar
On 1/31/2025 10:35 PM, Christian König wrote: Am 31.01.25 um 17:55 schrieb Sundararaju, Sathishkumar: On 1/31/2025 10:19 PM, Christian König wrote: Am 31.01.25 um 17:40 schrieb Sundararaju, Sathishkumar: Hi Christian, On 1/31/2025 9:56 PM, Christian König wrote: Am 31.01.25 um 17:23 sch

[PATCH] drm/amd : Update MES API header file for v11 & v12

2025-01-31 Thread Shaoyun Liu
New features require the new fields defines Signed-off-by: Shaoyun Liu --- drivers/gpu/drm/amd/include/mes_v11_api_def.h | 46 ++- drivers/gpu/drm/amd/include/mes_v12_api_def.h | 34 +- 2 files changed, 78 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/am

RE: [PATCH] drm/amd : Update MES API header file for v11 & v12

2025-01-31 Thread Liu, Shaoyun
[AMD Official Use Only - AMD Internal Distribution Only] Sorry, please ignore this one . sent wrong patch. Regards Shaoyun.liu -Original Message- From: Liu, Shaoyun Sent: Friday, January 31, 2025 10:35 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: [PATCH] drm/amd : Upd

[PATCH] drm/amd/include : Update MES v12 API header according to new MES features

2025-01-31 Thread Shaoyun Liu
1. MES fence_value will be updated in fence_addr if API success, otherwise upper 32 bit will be used to indicate error code. In any case, MES will trigger an EOP interrupt with 0xb1 as context id in the interrupt cookie 2. Add RRMT option support which will be used for remote die register acc

[PATCH] drm/amd/pm: Fix get_if_active usage

2025-01-31 Thread Lijo Lazar
If a device supports runtime pm, then pm_runtime_get_if_active returns 0 if a device is not active and 1 if already active. However, if a device doesn't support runtime pm, the API returns -EINVAL. A device not supporting runtime pm implies it's not affected by runtime pm and it's active. Hence no

[PATCH] drm/amd/pm: Limit to 8 jpeg rings per instance

2025-01-31 Thread Lijo Lazar
JPEG 5.0.1 supports upto 10 rings, however PMFW support for SMU v13.0.6 variants is now limited to 8 per instance. Limit to 8 temporarily to avoid out of bounds access. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 8 +--- 1 file changed, 5 insertions(+

Re: [PATCH 2/2] drm/amdkfd: use GTT for VRAM on APUs only if GTT is larger

2025-01-31 Thread Alex Deucher
On Fri, Jan 31, 2025 at 12:13 PM Philip Yang wrote: > > > On 2025-01-30 15:51, Alex Deucher wrote: > > If the user has configured a large carveout on a small APU, > only use GTT for VRAM allocations if GTT is larger than > VRAM. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/

[PATCH V2 2/2] drm/amdkfd: use GTT for VRAM on APUs only if GTT is larger

2025-01-31 Thread Alex Deucher
If the user has configured a large carveout on a small APU, only use GTT for VRAM allocations if GTT is larger than VRAM. v2: fix reversed check (Philip) Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --g

[PATCH 1/2] drm/amdkfd: add a new flag to manage where VRAM allocations go

2025-01-31 Thread Alex Deucher
On big and small APUs we send KFD VRAM allocations to GTT since the carve out is either non-existent or relatively small. However, if someone sets the carve out size to be relatively large, we may end up using GTT rather than VRAM. No change of logic with this patch, but it allows the driver to d

[PATCH] drm/amd/display: Respect user's CONFIG_FRAME_WARN more for dml files

2025-01-31 Thread Nathan Chancellor
FRAME_WARN), $(frame_warn_limit)),y) +frame_warn_flag := -Wframe-larger-than=$(frame_warn_limit) +endif endif subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/dml2 --- base-commit: 7f2b5237e313e39008a85b33ca94ab503a8fdff9 change-id: 20250131-amdgpu-respect-config_frame_warn-739a9b24496e Be

Re: [PATCH 2/7] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-01-31 Thread Sundararaju, Sathishkumar
Hi Alex, I missed to see your other comment below, answered it inline. On 1/31/2025 11:11 PM, Sundararaju, Sathishkumar wrote: Hi Alex, On 1/31/2025 10:42 PM, Alex Deucher wrote: On Fri, Jan 31, 2025 at 11:32 AM Sathishkumar S wrote: Add ring reset function callback for JPEG4_0_3 to recover