Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Philipp Stanner
On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: > Am 22.01.25 um 15:08 schrieb Philipp Stanner: > > drm_sched_init() has a great many parameters and upcoming new > > functionality for the scheduler might add even more. Generally, the > > great number of parameters reduces readability and

Introducing AMDGPU Composition Stack (ACS)

2025-01-22 Thread Sharma, Shashank
[AMD Official Use Only - AMD Internal Distribution Only] Introducing AMDGPU Composition Stack (ACS). ACS is simply AMD's fork of Weston compositor, with some additional advanced features. We have created ACS considering the following primary goals in mind: * To act as a staging area for Wayl

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Matthew Brost
On Wed, Jan 22, 2025 at 03:48:54PM +0100, Philipp Stanner wrote: > On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: > > Am 22.01.25 um 15:08 schrieb Philipp Stanner: > > > drm_sched_init() has a great many parameters and upcoming new > > > functionality for the scheduler might add even mor

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Christian König
Am 22.01.25 um 15:48 schrieb Philipp Stanner: On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: Am 22.01.25 um 15:08 schrieb Philipp Stanner: drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of

Re: [PATCH] drm/amd/pm: Update smu_v13_0_0 SRIOV VF flag in msg mapping table

2025-01-22 Thread Lazar, Lijo
On 1/22/2025 3:58 PM, Zha, YiFan(Even) wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > > Hi Lijo, > > This will not affect 1VF mode. I just matched SMU supported/unsupported > VF msg .  Thanks for checking. Reviewed-by: Lijo Lazar Thanks, Lijo > Messages for 1 VF mod

Re: [PATCH v2 4/6] drm/amd/pm: Add metrics support for smuv13.0.12

2025-01-22 Thread Lazar, Lijo
On 1/22/2025 3:25 PM, Asad Kamal wrote: > Add metrics table support for smuv13.0.12 to > fetch data from metrics version v2 > > v2: Update get metric field and get metric size macro (Lijo) > > Signed-off-by: Asad Kamal Series is - Reviewed-by: Lijo Lazar Thanks, Lijo > --- > .../drm/amd

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Tvrtko Ursulin
On 22/01/2025 15:51, Boris Brezillon wrote: On Wed, 22 Jan 2025 15:08:20 +0100 Philipp Stanner wrote: --- a/drivers/gpu/drm/panthor/panthor_sched.c +++ b/drivers/gpu/drm/panthor/panthor_sched.c @@ -3272,6 +3272,7 @@ group_create_queue(struct panthor_group *group, const str

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-22 Thread Simona Vetter
On Tue, Jan 21, 2025 at 02:21:57PM -0500, Marek Olšák wrote: > On Mon, Jan 20, 2025 at 1:41 PM Simona Vetter > wrote: > > > On Mon, Jan 20, 2025 at 08:58:20AM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > > > > Am 18.01.25 um 03:37 schrieb Marek Olšák: > > > [...] > > > > > > > > 3) Implem

[pull] amdgpu drm-next-6.14

2025-01-22 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.14. The following changes since commit 97e5c9e4139087a67c2469488360a6d6afdd4b69: drm/amd/display: fix CEC DC_DEBUG_MASK documentation (2025-01-16 16:23:22 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-d

Re: [PATCH] drm/amd/pm: Update smu_v13_0_0 SRIOV VF flag in msg mapping table

2025-01-22 Thread Zha, YiFan(Even)
[AMD Official Use Only - AMD Internal Distribution Only] Hi Lijo, This will not affect 1VF mode. I just matched SMU supported/unsupported VF msg . Messages for 1 VF mode are still enabled, such as handle smu features, handle soft frequences, etc. Thanks. Best regard, Yifan Zha

[PATCH] drm/amdgpu: Update usage for bad page threshold

2025-01-22 Thread Hawking Zhang
The driver's behavior varies based on the configuration of amdgpu_bad_page_threshold setting Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 54 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h

Re: [PATCH] drm/amdgpu: update and cleanup PM4 headers

2025-01-22 Thread Alex Deucher
Ping? On Mon, Jan 20, 2025 at 2:47 PM Alex Deucher wrote: > > Consolidate PM4 definitions. Most of these were previously > only defined in UMDs. Add them here as well and sync with > latest packets. Also no need to include soc15d.h on gfx10+. > > Suggested-by: Saurabh Verma > Signed-off-by: A

Re: Introducing AMDGPU Composition Stack (ACS)

2025-01-22 Thread robert.d...@yahoo.fr
Hello, Do you plan to migrate some of the GPU-Open repos to this Gitlab org ? Or is it for a very distant future as the priority for the next years is on Wayland AMD-specific optimisations/interfaces/protocols ? (or give in to the second principle of thermodynamics :D ) Le mercredi 22 janvi

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Christian König
Am 22.01.25 um 16:23 schrieb Philipp Stanner: On Wed, 2025-01-22 at 16:06 +0100, Christian König wrote: Am 22.01.25 um 15:48 schrieb Philipp Stanner: On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: Am 22.01.25 um 15:08 schrieb Philipp Stanner: drm_sched_init() has a great many param

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Boris Brezillon
On Wed, 22 Jan 2025 15:08:20 +0100 Philipp Stanner wrote: > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -3272,6 +3272,7 @@ group_create_queue(struct panthor_group *group, > const struct drm_panthor_queue_create *args) > { >

Re: Introducing AMDGPU Composition Stack (ACS)

2025-01-22 Thread Sharma, Shashank
[AMD Official Use Only - AMD Internal Distribution Only] Hey, We can certainly talk about it and explore a bit more on the request. Regards Shashank From: robert.d...@yahoo.fr Sent: Wednesday, January 22, 2025 4:42 PM To: dri-de...@lists.freedesktop.org; amd-gfx l

RE: [PATCH v2] drm/amdgpu: Update usage for bad page threshold

2025-01-22 Thread Zhou1, Tao
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Tao Zhou > -Original Message- > From: Zhang, Hawking > Sent: Wednesday, January 22, 2025 7:38 PM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao > Cc: Zhang, Hawking > Subject: [PATCH v2] drm/amdgpu: Update usage fo

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Matthew Brost
On Wed, Jan 22, 2025 at 04:06:10PM +0100, Christian König wrote: > Am 22.01.25 um 15:48 schrieb Philipp Stanner: > > On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: > > > Am 22.01.25 um 15:08 schrieb Philipp Stanner: > > > > drm_sched_init() has a great many parameters and upcoming new >

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Philipp Stanner
On Wed, 2025-01-22 at 16:06 +0100, Christian König wrote: > Am 22.01.25 um 15:48 schrieb Philipp Stanner: > > On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: > > > Am 22.01.25 um 15:08 schrieb Philipp Stanner: > > > > drm_sched_init() has a great many parameters and upcoming new > > > > f

[PATCH v2] drm/amdgpu: Update usage for bad page threshold

2025-01-22 Thread Hawking Zhang
The driver's behavior varies based on the configuration of amdgpu_bad_page_threshold setting Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 54 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Danilo Krummrich
On Wed, Jan 22, 2025 at 03:08:20PM +0100, Philipp Stanner wrote: > drm_sched_init() has a great many parameters and upcoming new > functionality for the scheduler might add even more. Generally, the > great number of parameters reduces readability and has already caused > one missnaming in: > > co

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Christian König
Am 22.01.25 um 15:08 schrieb Philipp Stanner: drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of parameters reduces readability and has already caused one missnaming in: commit 6f1cacf4eba7 ("drm/nouve

[PATCH] drm/amdkfd: only flush the validate MES contex

2025-01-22 Thread Prike Liang
The following page fault was observed duringthe KFD process release. In this particular error case, the HIP test (./MemcpyPerformance -h) does not require the queue. As a result, the process_context_addr was not assigned when the KFD process was released, ultimately leading to this page fault durin

[PATCH v2 4/6] drm/amd/pm: Add metrics support for smuv13.0.12

2025-01-22 Thread Asad Kamal
Add metrics table support for smuv13.0.12 to fetch data from metrics version v2 v2: Update get metric field and get metric size macro (Lijo) Signed-off-by: Asad Kamal --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 186 ++ .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.h | 8

[PATCH v2 5/6] drm/amd/pm: Skip showing MCLK_OD level

2025-01-22 Thread Asad Kamal
Skip showing MCLK_OD level if setting UCLK MAX is not supported Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/d

[PATCH v2 3/6] drm/amd/pm: Add SMUv13.0.12 PPT interface

2025-01-22 Thread Asad Kamal
Add SMUv13.0.12 PPT interface to fetch dpm features Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../pm/swsmu/inc/pmfw_if/smu_v13_0_12_pmfw.h | 138 ++ drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 2 + drivers/gpu/drm/amd/pm/swsmu/smu13/Makefile | 2 +- .../dr

[PATCH v2 2/6] drm/amd/pm: Add metrics table header for smu_v13_0_12

2025-01-22 Thread Asad Kamal
Add metrics table header for smu_v13_0_12 as metrics version V2 Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h | 109 ++ 1 file changed, 109 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw

[PATCH v2 1/6] drm/amd/pm: Update metrics tbl struct for smu_v_13.0.6

2025-01-22 Thread Asad Kamal
Update metrics table struct name for smu_v_13.0.6 and keep it as version Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h | 6 +- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 56 +-- 2 files changed, 32 insertions(+), 30 del

[PATCH v2 6/6] drm/amd/pm: Update pm attr for gc_9_5_0

2025-01-22 Thread Asad Kamal
Update power management & clk attributes for gc_v_9_5_0 Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm

RE: [PATCH] drm/amdgpu: Update usage for bad page threshold

2025-01-22 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Please ignore this one. will send out a new one soon Regards, Hawking -Original Message- From: Zhang, Hawking Sent: Wednesday, January 22, 2025 18:30 To: amd-gfx@lists.freedesktop.org; Zhou1, Tao Cc: Zhang, Hawking Subject: [PAT

[PATCH] drm/amdgpu: Update usage for bad page threshold

2025-01-22 Thread Hawking Zhang
The driver's behavior varies based on the configuration of amdgpu_bad_page_threshold setting Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 54 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h

RE: [PATCH] drm/amdgpu: Update usage for bad page threshold

2025-01-22 Thread Zhou1, Tao
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Zhang, Hawking > Sent: Wednesday, January 22, 2025 6:30 PM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao > Cc: Zhang, Hawking > Subject: [PATCH] drm/amdgpu: Update usage for bad page threshold > > Th

[PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Philipp Stanner
drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of parameters reduces readability and has already caused one missnaming in: commit 6f1cacf4eba7 ("drm/nouveau: Improve variable name in nouveau_sched_init

Re: [V7 13/45] drm/colorop: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE

2025-01-22 Thread Harry Wentland
On 2025-01-13 13:23, Simon Ser wrote: >> v4: >> - Don't block setting of COLOR_RANGE and COLOR_ENCODING >>when client cap is set > > Can you remind me why these should not be blocked? > I initially blocked setting these when the client cap was set but that caused some IGT tests to blow u

Re: [V7 13/45] drm/colorop: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE

2025-01-22 Thread Simon Ser
On Wednesday, January 22nd, 2025 at 20:48, Harry Wentland wrote: > On 2025-01-13 13:23, Simon Ser wrote: > > > > v4: > > > - Don't block setting of COLOR_RANGE and COLOR_ENCODING > > > when client cap is set > > > > Can you remind me why these should not be blocked? > > I initially blocked se

[PATCH] drm/amdgpu: Skip err_count sysfs creation on VF unsupported RAS blocks

2025-01-22 Thread Victor Skvortsov
VFs are not able to query error counts for all RAS blocks. Rather than returning error for queries on these blocks, skip sysfs the creation all together. Signed-off-by: Victor Skvortsov --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 16 +

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Maíra Canal
Hi Philipp, On 22/01/25 11:08, Philipp Stanner wrote: drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of parameters reduces readability and has already caused one missnaming in: commit 6f1cacf4eba7 ("

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Boris Brezillon
On Wed, 22 Jan 2025 15:08:20 +0100 Philipp Stanner wrote: > int drm_sched_init(struct drm_gpu_scheduler *sched, > -const struct drm_sched_backend_ops *ops, > -struct workqueue_struct *submit_wq, > -u32 num_rqs, u32 credit_limit, unsigned int hang_l

Re: [V7 23/45] drm/amd/display: Ignore deprecated props when plane_color_pipeline set

2025-01-22 Thread Harry Wentland
On 2025-01-15 02:56, Simon Ser wrote: > Is this "ignore" something we could do at the core DRM level, instead > of doing it in all drivers? e.g. by silently ignoring user-space requests > to set the property? > I think it'd be better to reject setting the property. The problem is that a client

Re: [RFC v2 00/15] Enhance device state machine to better support suspend/resume

2025-01-22 Thread Mika Laitio
Is the latest version of this patch series (with possible fixes based on to comments) however maintained/available on some git tree for testing? On Sun, Jan 19, 2025 at 10:28 PM Zhang, Hawking wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > Thanks for the patches. > > We cu

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Boris Brezillon
On Wed, 22 Jan 2025 16:14:59 + Tvrtko Ursulin wrote: > On 22/01/2025 15:51, Boris Brezillon wrote: > > On Wed, 22 Jan 2025 15:08:20 +0100 > > Philipp Stanner wrote: > > > >> --- a/drivers/gpu/drm/panthor/panthor_sched.c > >> +++ b/drivers/gpu/drm/panthor/panthor_sched.c > >> @@ -3272,6 +3

RE: [PATCH] drm/amdgpu: Skip err_count sysfs creation on VF unsupported RAS blocks

2025-01-22 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] + DRM_DEV_DEBUG(adev->dev, "Unsupported SRIOV RAS telemetry block +0x%x\n", block); You may still want to keep dev_err, other that that, the patch is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- F

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Matthew Brost
On Wed, Jan 22, 2025 at 06:04:58PM +0100, Boris Brezillon wrote: > On Wed, 22 Jan 2025 16:14:59 + > Tvrtko Ursulin wrote: > > > On 22/01/2025 15:51, Boris Brezillon wrote: > > > On Wed, 22 Jan 2025 15:08:20 +0100 > > > Philipp Stanner wrote: > > > > > >> --- a/drivers/gpu/drm/panthor/pant

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Philipp Stanner
On Wed, 2025-01-22 at 20:37 -0800, Matthew Brost wrote: > On Wed, Jan 22, 2025 at 06:04:58PM +0100, Boris Brezillon wrote: > > On Wed, 22 Jan 2025 16:14:59 + > > Tvrtko Ursulin wrote: > > > > > On 22/01/2025 15:51, Boris Brezillon wrote: > > > > On Wed, 22 Jan 2025 15:08:20 +0100 > > > > Phil