Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-17 Thread Marek Olšák
If DRM_FORMAT_MOD_LINEAR stays, then most of this discussion is irrelevant. If you don't like the new linear modifiers, don't use them. If that's you, bye. For the rest, there are multiple solutions: 1) New vendor-agnostic linear modifiers. The reason why we would want them is that they define ro

Re: [PATCH] drm/amd/display: fix SUBVP DC_DEBUG_MASK documentation

2025-01-17 Thread Harry Wentland
On 2025-01-17 14:18, Alex Deucher wrote: > This needs to be kerneldoc formatted. > > Fixes: 5349658fa4a1 ("drm/amd: Add debug option to disable subvp") > Reported-by: Stephen Rothwell > Signed-off-by: Alex Deucher > Cc: Aurabindo Pillai Reviewed-by: Harry Wentland Harry > --- > drivers/gpu

Re: [RFC v2 07/15] drm/admgpu: rename amdgpu_ras_pre_fini() to amdgpu_ras_early_fini()

2025-01-17 Thread Lazar, Lijo
On 1/13/2025 7:12 AM, Jiang Liu wrote: > Rename amdgpu_ras_pre_fini() to amdgpu_ras_early_fini(), to keep same > style with other code. > > Signed-off-by: Jiang Liu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++--- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c| 2 +- > drivers/

Re: [RFC v2 08/15] drm/amdgpu: make IP block state machine works in stack like way

2025-01-17 Thread Lazar, Lijo
On 1/13/2025 7:12 AM, Jiang Liu wrote: > There are some mismatches between IP block state machine and its > associated status flags, especially about the meaning of > `status.late_initialized`. So let's make the state machine and > associated status flas work in stack-like way as below: > Callba

Re: [RFC v2 11/15] drm/amdgpu: convert ip block bool flags into an enum

2025-01-17 Thread Lazar, Lijo
On 1/13/2025 7:12 AM, Jiang Liu wrote: > Convert ip block bool flags into an enumeration, to explicitly mark > current state of the ip block. Also introduce helper functions to > manipulate the ip block state. Now the state machine works as below: > CallbacksState after succe

[PATCH] drm/amdgpu/mes12: enable mes pipe wptr polling

2025-01-17 Thread Jack Xiao
Enable mes pipe wptr polling for gfxoff might result in mes pipe wptr missing. Signed-off-by: Jack Xiao --- drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c b/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c index 185f4b5

Re: [V7 29/45] drm/colorop: Add PQ 125 EOTF and its inverse

2025-01-17 Thread Pekka Paalanen
On Thu, 19 Dec 2024 21:33:35 -0700 Alex Hung wrote: > From: Harry Wentland > > The PQ function defines a mapping of code values to nits (cd/m^2). > The max code value maps to 10,000 nits. > > Windows DWM's canonical composition color space (CCCS) defaults > to composing SDR contents to 80 nit

Re: drm/amdgpu: AMDGPU unusable since 6.12.1 and it looks like no one cares.

2025-01-17 Thread Pavel Nikulin
I think it persists as of 6.12.9 and today's firmware version from git. Hardware Asus um5606 It only happens when the AC adaptor is disconnected, and the screen refresh frequency is set to 120hz. It does not happen on any other refresh frequency, or when the charger is connected. It might be hap

Re: [PATCH] drm/amdgpu: fix ring timeout issue in gfx10 sr-iov environment

2025-01-17 Thread Alex Deucher
On Tue, Jan 14, 2025 at 5:32 AM Lin.Cao wrote: > > 'commit 6e66dc05b54f ("drm/amdgpu: set the VM pointer to NULL in > amdgpu_job_prepare")' set job->vm as NULL if there is no fence. It will > cause emit switch buffer be skippen if job->vm set as NULL. > > Check job rather than vm could solve this

Re: drm/amdgpu: AMDGPU unusable since 6.12.1 and it looks like no one cares.

2025-01-17 Thread Alex Deucher
On Fri, Jan 17, 2025 at 7:27 AM Pavel Nikulin wrote: > > I think it persists as of 6.12.9 and today's firmware version from git. > > Hardware Asus um5606 > > It only happens when the AC adaptor is disconnected, and the screen > refresh frequency is set to 120hz. It does not happen on any other > r

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-17 Thread Simona Vetter
On Wed, Jan 15, 2025 at 12:20:07PM +, Daniel Stone wrote: > On Wed, 15 Jan 2025 at 04:05, Marek Olšák wrote: > > On Tue, Jan 14, 2025 at 12:58 PM Daniel Stone wrote: > >> AMD hardware is the only hardware I know of which doesn't support > >> overaligning. Say (not hypothetically) we have a GP

Re: [PATCH] drm/amd/pm: Use correct macros for smu caps

2025-01-17 Thread Alex Deucher
On Fri, Jan 17, 2025 at 10:14 AM Lijo Lazar wrote: > > Fix the initialization and usage of capability values and mask. > SMU_CAPS_MASK indicates mask value, and SMU_CAPS represent the > capability value. > Might be cleaner to have CAP_GET and CAP_SET macros. Alex > Signed-off-by: Lijo Lazar >

[PATCH] drm/amd/pm: Use correct macros for smu caps

2025-01-17 Thread Lijo Lazar
Fix the initialization and usage of capability values and mask. SMU_CAPS_MASK indicates mask value, and SMU_CAPS represent the capability value. Signed-off-by: Lijo Lazar Fixes: 9bb53d2ce109 ("drm/amd/pm: Add capability flags for SMU v13.0.6") --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c |

RE: [PATCH] drm/amdgpu: validate process_context_addr for the MES shader debugger

2025-01-17 Thread Liang, Prike
[Public] > From: Kim, Jonathan > Sent: Friday, January 17, 2025 12:21 AM > To: Liang, Prike ; amd-gfx@lists.freedesktop.org; Xiao, > Jack > Cc: Deucher, Alexander ; Kuehling, Felix > ; Koenig, Christian ; > Zhang, Jesse(Jie) > Subject: RE: [PATCH] drm/amdgpu: validate process_context_addr for t

Re: [RFC v2 10/15] drm/admgpu: make device state machine work in stack like way

2025-01-17 Thread Lazar, Lijo
On 1/13/2025 7:12 AM, Jiang Liu wrote: > Make the device state machine work in stack like way to better support > suspend/resume by following changes: > > 1. amdgpu_driver_load_kms() > amdgpu_device_init() > amdgpu_device_ip_early_init() > ip_blocks[i].

Re: [V7 31/45] drm/colorop: add BT2020/BT709 OETF and Inverse OETF

2025-01-17 Thread Pekka Paalanen
On Thu, 16 Jan 2025 10:56:22 +0200 Pekka Paalanen wrote: > On Thu, 19 Dec 2024 21:33:37 -0700 > Alex Hung wrote: > > > From: Harry Wentland > > > > The BT.709 and BT.2020 OETFs are the same, the only difference > > being that the BT.2020 variant is defined with more precision > > for 10 and 1

Re: [V7 43/45] drm/amd/display: Add AMD color pipeline doc

2025-01-17 Thread Pekka Paalanen
On Thu, 19 Dec 2024 21:33:49 -0700 Alex Hung wrote: > From: Harry Wentland > > Add kernel doc for AMD color pipeline. > > Signed-off-by: Alex Hung > Signed-off-by: Harry Wentland > --- > .../amd/display/amdgpu_dm/amdgpu_dm_color.c | 122 +++--- > 1 file changed, 102 insertions

RE: [PATCH] drm/amdgpu/mes12: enable mes pipe wptr polling

2025-01-17 Thread Xiao, Jack
[AMD Official Use Only - AMD Internal Distribution Only] Dropped, it caused a regression. Regards, Jack -Original Message- From: Xiao, Jack Sent: Friday, January 17, 2025 4:59 PM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Feng, Kenneth Cc: Xiao, Jack Subject: [PATCH] drm/amd

[pull] amdgpu, amdkfd drm-next-6.14

2025-01-17 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.14. The following changes since commit 24c61d553302ee49e9c21dd251275ba8c36dcfe4: Merge tag 'drm-msm-next-2025-01-07' of gitlab.freedesktop.org:drm/msm into drm-next (2025-01-13 11:14:07 +1000) are available in the Git repository at: https://gitlab.freedesktop.

[PATCH] drm/amd/display: fix SUBVP DC_DEBUG_MASK documentation

2025-01-17 Thread Alex Deucher
This needs to be kerneldoc formatted. Fixes: 5349658fa4a1 ("drm/amd: Add debug option to disable subvp") Reported-by: Stephen Rothwell Signed-off-by: Alex Deucher Cc: Aurabindo Pillai --- drivers/gpu/drm/amd/include/amd_shared.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git