Re: [PATCH 1/2] drm/amd/pm: Fill ip version for SMU v13.0.12

On 1/11/2025 1:47 AM, Alex Deucher wrote: > From: Asad Kamal > > Fill ip version in pm_metrics for SMU v13.0.12 > > Signed-off-by: Asad Kamal > Reviewed-by: Hawking Zhang > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 2 ++ > 1 file changed, 2

Re: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset

On 1/11/2025 2:53 AM, Kim, Jonathan wrote: > [Public] > >> -Original Message- >> From: Lazar, Lijo >> Sent: Friday, January 10, 2025 11:29 AM >> To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org >> Cc: Kasiviswanathan, Harish >> Subject: Re: [PATCH] drm/amdgpu: fix gpu recovery disabl

Re: [PATCH 1/5] drm/amdgpu/gfx: add ring helpers for setting workload profile

On 1/10/2025 8:33 PM, Alex Deucher wrote: > On Thu, Jan 9, 2025 at 10:30 PM Lazar, Lijo wrote: >> >> >> >> On 1/9/2025 10:36 PM, Alex Deucher wrote: >>> On Thu, Jan 9, 2025 at 12:59 AM Lazar, Lijo wrote: On 1/9/2025 4:26 AM, Alex Deucher wrote: > Add helpers to switch t

Re: [PATCH v2 0/5] drm/amd/display: Stop control flow if the divisior is zero

On 2025-01-06 03:57, Tiezhu Yang wrote: > As far as I can tell, with the current existing macro definitions, there > is no better way to do the minimal and proper changes to stop the control > flow if the divisior is zero. > > In order to keep the current ability for the aim of debugging and avoid

[PATCH v2] drm/amd/pm: Fill ip version for SMU v13.0.12

Fill ip version in pm_metrics for SMU v13.0.12 v2: Remove ip version check(Lijo) Signed-off-by: Asad Kamal Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/

Re: amdgpu 4k@120Hz / HDMI 2.1

On Thu, Jan 9, 2025 at 4:08 PM Armin Wolf wrote: > Sadly the HDMI forum only provides the HDMI specification under a special > license which > prohibits implementing it in open source drivers. > > Since membership inside the HDMI forum costs 15000$ annually, i suspect that > the HDMI forum > is

Re: amdgpu 4k@120Hz / HDMI 2.1

On Thu, Jan 9, 2025 at 3:57 PM Michel Dänzer wrote: > That's much lower level than OpenGL. OpenGL implementations can and do > internally use page flipping under the right circumstances, it cannot be > enforced via OpenGL / GLX / EGL APIs though, it's an implementation detail. It is indeed low

Re: [v4 5/5] drm/amdgpu: fix invalid memory access in amdgpu_fence_driver_sw_fini()

Am 10.01.25 um 08:37 schrieb Gerry Liu: 2025年1月10日 14:51，Christian König 写道： Am 10.01.25 um 03:08 schrieb Jiang Liu: Function detects initialization status by checking sched->ops, so set sched->ops to non-NULL just before return in function amdgpu_fence_driver_sw_fini() and amdgpu_device_init_

Re: [PATCH 1/2] drm/amdkfd: Sync trap handler binary with source

On 09/01/2025 17:56, Jay Cornwall wrote: Source and binary have become mismatched during branch activity. Signed-off-by: Jay Cornwall Cc: Lancelot Six Thanks for doing that. That new binary match what I obtain by re-assembling the sources. Reviewed-by: Lancelot Six Best, Lancelot.

Re: [PATCH 1/5] drm/amdgpu/gfx: add ring helpers for setting workload profile

On Thu, Jan 9, 2025 at 10:30 PM Lazar, Lijo wrote: > > > > On 1/9/2025 10:36 PM, Alex Deucher wrote: > > On Thu, Jan 9, 2025 at 12:59 AM Lazar, Lijo wrote: > >> > >> > >> > >> On 1/9/2025 4:26 AM, Alex Deucher wrote: > >>> Add helpers to switch the workload profile dynamically when > >>> commands

Re: [PATCH v4] drm/amdkfd: Fix partial migrate issue

On 2025-01-10 02:49, Emily Deng wrote: For partial migrate from ram to vram, the migrate->cpages is not equal to migrate->npages, should use migrate->npages to check all needed migrate pages which could be copied or not. And only need to set those pages could be m

Re: [PATCH v5] drm/amdkfd: Fix partial migrate issue

On 2025-01-10 09:25, Emily Deng wrote: For partial migrate from ram to vram, the migrate->cpages is not equal to migrate->npages, should use migrate->npages to check all needed migrate pages which could be copied or not. And only need to set those pages could be m

Re: [PATCH v2] drm/amdgpu: Fix the looply call svm_range_restore_pages issue

On 2025-01-09 12:14, Felix Kuehling wrote: On 2025-01-08 20:11, Philip Yang wrote: On 2025-01-07 22:08, Deng, Emily wrote: [AMD Official Use Only - AMD Internal Distribution

[PATCH v5] drm/amdkfd: Fix partial migrate issue

For partial migrate from ram to vram, the migrate->cpages is not equal to migrate->npages, should use migrate->npages to check all needed migrate pages which could be copied or not. And only need to set those pages could be migrated to migrate->dst[i], or the migrate_vma_pages will migrate the wro

[PATCH 1/3] drm/amdgpu: Add VCN v4.0.3 RRMT register offset

Add RRMT control register offset for VCN v4.0.3 Signed-off-by: Lijo Lazar Reviewed-by: Sathishkumar S --- drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_4_0_3_offset.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_4_0_3_offset.h

[PATCH 3/3] drm/amdgpu: Check RRMT status for JPEG v4.0.3

RRMT could get dynamically enabled/disabled by PSP firmware. Read the status from register for reading RRMT status. For VFs, this is not accessible, hence assume that it's always disabled for now. Signed-off-by: Lijo Lazar Reviewed-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h

[PATCH] drm/amdgpu: increase amdgpu max rings limit

increase max rings to 132 to support all JPEG5_0_1 cores, else ring_init fails due to ring count exceeding maximum limit. Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/g

[PATCH 2/3] drm/amdgpu: Check RRMT status for VCN v4.0.3

RRMT could get dynamically enabled/disabled by PSP firmware. Read the status from register for reading RRMT status. For VFs, this is not accessible, hence assume that it's always disabled for now. Signed-off-by: Lijo Lazar Reviewed-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h

Re: [PATCH] drm/amdgpu: disable gfxoff with the compute workload on gfx12

On Thu, Jan 9, 2025 at 9:39 PM Kenneth Feng wrote: > > Disable gfxoff with the compute workload on gfx12. This is a > workaround for the opencl test failure. > > Signed-off-by: Kenneth Feng Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 5 +++-- > 1 file changed,

Re: [PATCH v4] drm/amdkfd: Fix partial migrate issue

On 1/10/2025 8:37 AM, Philip Yang wrote: On 2025-01-10 02:49, Emily Deng wrote: For partial migrate from ram to vram, the migrate->cpages is not equal to migrate->npages, should use migrate->npages to check all needed migrate pages which could be copied or not. And only need to set those pa

[pull] amdgpu, amdkfd drm-next-6.14

Hi Dave, Simona, Updates for 6.14. The following changes since commit 695c2c745e5dff201b75da8a1d237ce403600d04: drm/amdgpu: Handle NULL bo->tbo.resource (again) in amdgpu_vm_bo_update (2024-12-18 12:39:08 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/

Re: [PATCH v4] drm/amdkfd: Fix partial migrate issue

On 2025-01-10 11:23, Chen, Xiaogang wrote: On 1/10/2025 8:37 AM, Philip Yang wrote: On 2025-01-10 02:49, Emily Deng wrote: For partial migrate from ram to vram, the migrate->cpages is n

Re: [RFC PATCH 03/13] drm/amdgpu: add a flag to track ras debugfs creation status

On Fri, Jan 10, 2025 at 12:10 PM Mario Limonciello wrote: > > On 1/9/2025 21:19, Gerry Liu wrote: > > > > > >> 2025年1月9日 01:19，Mario Limonciello >> > 写道： > >> > >> On 1/8/2025 07:59, Jiang Liu wrote: > >>> Add a flag to track ras debugfs creation status, to avoid

Re: [PATCH v4] drm/amdkfd: Fix partial migrate issue

On 1/10/2025 11:33 AM, Philip Yang wrote: On 2025-01-10 11:23, Chen, Xiaogang wrote: On 1/10/2025 8:37 AM, Philip Yang wrote: On 2025-01-10 02:49, Emily Deng wrote: For partial migrate from ram to vram, the migrate->cpages is not equal to migrate->npages, should use migrate->npages to c

RE: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset

[Public] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, January 9, 2025 10:39 PM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish > Subject: Re: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset > > > > On 1/9/2025 8:27 PM, Kim

Re: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset

On 1/10/2025 9:43 PM, Kim, Jonathan wrote: > [Public] > >> -Original Message- >> From: Lazar, Lijo >> Sent: Thursday, January 9, 2025 10:39 PM >> To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org >> Cc: Kasiviswanathan, Harish >> Subject: Re: [PATCH] drm/amdgpu: fix gpu recovery disab

Re: [RFC PATCH 03/13] drm/amdgpu: add a flag to track ras debugfs creation status

On 1/9/2025 21:19, Gerry Liu wrote: 2025年1月9日 01:19，Mario Limonciello > 写道： On 1/8/2025 07:59, Jiang Liu wrote: Add a flag to track ras debugfs creation status, to avoid possible incorrect reference count management for ras block object  in function amdgpu_r

Re: [PATCH 2/2] drm/amdkfd: Clear MODE.VSKIP in gfx9 trap handler

On 1/10/2025 12:14, Six, Lancelot wrote: If user shader issues S_SETVSKIP then this state will persist when executing the trap handler, causing vector instructions to be skipped. Restore VSKIP state before resuming the user shader. Hi, I agree with the patch, I just find the text above confu

Re: [PATCH 2/2] drm/amdkfd: Clear MODE.VSKIP in gfx9 trap handler

On 10/01/2025 19:37, Jay Cornwall wrote: On 1/10/2025 12:14, Six, Lancelot wrote: If user shader issues S_SETVSKIP then this state will persist when executing the trap handler, causing vector instructions to be skipped. Restore VSKIP state before resuming the user shader. Hi, I agree wit

[PATCH] drm/amdgpu: enlarge the VBIOS binary size limit

From: Shiwu Zhang Some chips have a larger VBIOS file so raise the size limit to support the flashing tool. Signed-off-by: Shiwu Zhang Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH 1/2] drm/amdgpu: read harvest info from harvest table for gfx950

From: Le Ma Harvest table is applied for gfx950. Signed-off-by: Le Ma Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c

[PATCH 2/2] drm/amdgpu: Set noretry default for GC 9.5.0

From: Amber Lin Set GC 9.5.0 noretry default as 1 for better performance. It can be changed by the administrator using amdgpu.noretry=0 or by the user using HSA_XNACK=1 environment variable. Signed-off-by: Amber Lin Reviewed-by: Harish Kasiviswanathan Signed-off-by: Alex Deucher --- drivers/

[PATCH 2/2] drm/amd/pm: Populate pmfw version for SMU v13.0.12

From: Asad Kamal Populate pmfw version for SMU v13.0.12 to device struct v2: Remove ip version check to get smu version Signed-off-by: Asad Kamal Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 5 + 1 file changed, 1 insertion(

[PATCH 1/2] drm/amd/pm: Fill ip version for SMU v13.0.12

From: Asad Kamal Fill ip version in pm_metrics for SMU v13.0.12 Signed-off-by: Asad Kamal Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/s

[PATCH] drm/amdgpu: Use active umc info from discovery

From: Lijo Lazar There could be configs where some UMC instances are harvested. This information is obtained through discovery data and populated in umc.active_mask. Avoid reassigning this as AID mask, instead use the mask directly while iterating through umc instances. This is to avoid accesses

Re: [PATCH 00/10] Add additional i2c buses

Series is Reviewed-by: Harry Wentland Harry On 2025-01-06 15:33, Alex Deucher wrote: > At the momemt we only expose the i2c buses used by the driver > for displays or EEPROMs. However, some OEMs/AIBs use extra i2c > buses for things like RGB controls. Expose the extra i2c buses in > case the OE

Re: [v4 1/5] drm/amdgpu: clear adev->in_suspend flag when fails to suspend

On 1/9/2025 20:08, Jiang Liu wrote: Clear adev->in_suspend flag when fails to suspend, otherwise it will cause too much warnings like: [ 1802.212027] [ cut here ] [ 1802.212028] WARNING: CPU: 97 PID: 11282 at drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:452 amdgpu_bo_free_k

Re: [v4 4/5] drm/amdgpu: enhance error handling in function amdgpu_pci_probe()

On 1/9/2025 20:08, Jiang Liu wrote: Enhance error handling in function amdgpu_pci_probe() to avoid possible resource leakage. Signed-off-by: Jiang Liu Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions

Re: [v4 3/5] drm/amdgpu: fix use after free bug related to amdgpu_driver_release_kms()

On 1/9/2025 20:08, Jiang Liu wrote: If some GPU device failed to probe, `rmmod amdgpu` will trigger a use after free bug related to amdgpu_driver_release_kms() as: [16002.085540] BUG: kernel NULL pointer dereference, address: [16002.093792] #PF: supervisor read access in kernel m

Re: [v4 2/5] drm/amdxcp: introduce new API amdgpu_xcp_drm_dev_free()

On 1/9/2025 20:08, Jiang Liu wrote: Introduce new interface amdgpu_xcp_drm_dev_free() to free a specific drm_device crreated by amdgpu_xcp_drm_dev_alloc(), which will be used s/crreated/created/ to do error recovery. Signed-off-by: Jiang Liu --- drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.c |

Re: [v4 0/6] Fix several bugs in error handling during device probe

Just a minor nit on this cover letter; you have it listed as [v4 0/6] but there are only 5 patches in the series in this version so the cover letter title should be updated too. On 1/9/2025 20:08, Jiang Liu wrote: This patchset tries to fix several memory leakages/invalid memory accesses on er

Re: amdgpu 4k@120Hz / HDMI 2.1

Am 09.01.25 um 10:19 schrieb Mischa Baars: On Mon, Jan 6, 2025 at 4:30 AM Mario Limonciello wrote: When new specifications are made available it's not like the old one suddenly becomes "open", so I don't see any reason that a new specification would change anything. I paid about €3000 for my

kmemleak: Found object by alias at 0xffff888107b65918

Hi folks, this is rc6 + tip/master, machine is Carrizo laptop. full dmesg attached. Thx. ... [ 13.271015] [drm] DM_PPLIB:level : 8 [ 13.271658] [drm] Display Core v3.2.310 initialized on DCE 11.0 [ 13.351651] kmemleak: Found object by alias at 0x888107b65918 [ 13.35236

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

On 12/19/24 10:03, Simona Vetter wrote: On Thu, Dec 19, 2024 at 09:02:27AM +, Daniel Stone wrote: On Wed, 18 Dec 2024 at 10:32, Brian Starkey wrote: On Wed, Dec 18, 2024 at 11:24:58AM +, Simona Vetter wrote: For that reason I think linear modifiers with explicit pitch/size alignment c

RE: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset

[Public] > -Original Message- > From: Lazar, Lijo > Sent: Friday, January 10, 2025 11:29 AM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish > Subject: Re: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset > > > > On 1/10/2025 9:43 PM, Kim