Re: [PATCH v2] drm/amdgpu: Fix Illegal opcode in command stream Error

2024-12-26 Thread Sharma, Shashank
[AMD Official Use Only - AMD Internal Distribution Only] Please feel free to use: Reviewed-by: Shashank Sharma Regards Shashank From: Yadav, Arvind Sent: Monday, December 23, 2024 4:34 PM To: Koenig, Christian ; Sharma, Shashank ; Deucher, Alexander Cc: amd-gf

[PATCH v3 2/2] drm/amd/pm: Fill max mem bw & total app clk counter

2024-12-26 Thread Asad Kamal
Fill max memory bandwidth and total app clock counter to metrics v1_7 v2: Remove unnecessary check v3: Add app clock counter support for apu Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 23 +++ 1 file changed, 23 inserti

[PATCH v3 1/2] drm/amd/pm: Update SMUv13.0.6 PMFW headers

2024-12-26 Thread Asad Kamal
Update pmfw headers for smuv13.0.6 to pmfw version 85.121 Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h| 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13

[PATCH] drm/amd: Fix random crashes due to bad kfree

2024-12-26 Thread Chris Bainbridge
Commit c6a837088bed ("drm/amd/display: Fetch the EDID from _DDC if available for eDP") added function dm_helpers_probe_acpi_edid, which fetches the EDID from the BIOS by calling acpi_video_get_edid. acpi_video_get_edid returns a pointer to the EDID, but this pointer does not originate from kmalloc

Re: [PATCH v6 9/9] drm/amd/display: Mark dc_fixpt_from_fraction() noinline

2024-12-26 Thread Tiezhu Yang
On 12/24/2024 05:46 AM, Nathan Chancellor wrote: On Sun, Dec 22, 2024 at 12:27:47PM +0800, Tiezhu Yang wrote: ... With the above changes, there is no "falls through" objtool warning compiled with both clang 19 and the latest mainline clang 20. I am somewhat surprised that changes anything b

Re: [PATCH] drm/amd: Fix random crashes due to bad kfree

2024-12-26 Thread Chris Bainbridge
On Thu, Dec 26, 2024 at 12:19:02AM +0100, Tobias Jakobi wrote: > Hi Chris! > > On 12/26/24 00:09, Chris Bainbridge wrote: > > > Commit c6a837088bed ("drm/amd/display: Fetch the EDID from _DDC if > > available for eDP") added function dm_helpers_probe_acpi_edid, which > > fetches the EDID from the

Re: [PATCH] drm/amd: Fix random crashes due to bad kfree

2024-12-26 Thread Tobias Jakobi
Hi Chris! On 12/26/24 00:09, Chris Bainbridge wrote: Commit c6a837088bed ("drm/amd/display: Fetch the EDID from _DDC if available for eDP") added function dm_helpers_probe_acpi_edid, which fetches the EDID from the BIOS by calling acpi_video_get_edid. acpi_video_get_edid returns a pointer to th

Re: [PATCH] drm/amd: Fix random crashes due to bad kfree

2024-12-26 Thread Tobias Jakobi
On 12/26/24 02:27, Chris Bainbridge wrote: On Thu, Dec 26, 2024 at 12:19:02AM +0100, Tobias Jakobi wrote: Hi Chris! On 12/26/24 00:09, Chris Bainbridge wrote: Commit c6a837088bed ("drm/amd/display: Fetch the EDID from _DDC if available for eDP") added function dm_helpers_probe_acpi_edid, whi

Re: [PATCH] drm/amd: Fix random crashes due to bad kfree

2024-12-26 Thread Tobias Jakobi
On 12/26/24 02:27, Chris Bainbridge wrote: On Thu, Dec 26, 2024 at 12:19:02AM +0100, Tobias Jakobi wrote: Hi Chris! On 12/26/24 00:09, Chris Bainbridge wrote: Commit c6a837088bed ("drm/amd/display: Fetch the EDID from _DDC if available for eDP") added function dm_helpers_probe_acpi_edid, whi