Before forcing level, CG/PG is disabled or enabled depending on the new
level. However if the force level operation fails, CG/PG state remains
modified. Revert the state change on failure. Also, move invalid
operation checks to the beginning before any logic that could change SOC
state.
Signed-off
From: Alex Hung
[ Upstream commit 8b0ddf19cca2a352b2a7e01d99d3ba949a99c84c ]
BIOS images may fail to load and null checks are added before they are
used.
This fixes 6 NULL_RETURNS issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
Signe
* li...@treblig.org (li...@treblig.org) wrote:
> From: "Dr. David Alan Gilbert"
>
> Hi,
> This removes a bunch more functions (and a field) from
> drm/amd/display that are unused.
>
> Signed-off-by: Dr. David Alan Gilbert
Hi Alex, Harry,
Gentle ping on this set - I think you've already pul
[AMD Official Use Only - AMD Internal Distribution Only]
Series is
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Candice Li
Sent: Friday, December 6, 2024 17:05
To: amd-gfx@lists.freedesktop.org
Cc: Li, Candice
Subject: [PATCH 4/4] drm/amdgp
Add nbif v6_3_1 fatal error handling support.
Signed-off-by: Candice Li
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 12
drivers/gpu/drm/amd/amdgpu/nbif_v6_3_1.c | 81
drivers/gpu/drm/amd/amdgpu/nbif_v6_3_1.h | 1 +
drivers/gpu/drm/amd/amdgpu/soc24.c | 19 +
Add umc v8_14_0 ip headers.
Signed-off-by: Candice Li
---
.../include/asic_reg/umc/umc_8_14_0_offset.h | 29 +++
.../include/asic_reg/umc/umc_8_14_0_sh_mask.h | 37 +++
2 files changed, 66 insertions(+)
create mode 100644 drivers/gpu/drm/amd/include/asic_reg/umc/umc
Add psp v14_0_3 ras support.
Signed-off-by: Candice Li
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 9961ff6c29f668..623ae9b3880037 100644
--- a/drivers/gpu/
Add umc v8_14 ras functions.
Signed-off-by: Candice Li
---
drivers/gpu/drm/amd/amdgpu/Makefile| 2 +-
drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 18 ++-
drivers/gpu/drm/amd/amdgpu/umc_v8_14.c | 160 +
drivers/gpu/drm/amd/amdgpu/umc_v8_14.h | 51
4 files cha
Reading access to connector->eld can happen at the same time the
drm_edid_to_eld() updates the data. Take the newly added eld_mutex in
order to protect connector->eld from concurrent access.
Reviewed-by: Maxime Ripard
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 4 ++--
Reading access to connector->eld can happen at the same time the
drm_edid_to_eld() updates the data. Take the newly added eld_mutex in
order to protect connector->eld from concurrent access.
Reviewed-by: Maxime Ripard
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 2
The connector->eld is accessed by the .get_eld() callback. This access
can collide with the drm_edid_to_eld() updating the data at the same
time. Add drm_connector.eld_mutex to protect the data from concurrenct
access. Individual drivers are not updated (to reduce possible issues
while applying the
Reading access to connector->eld can happen at the same time the
drm_edid_to_eld() updates the data. Take the newly added eld_mutex in
order to protect connector->eld from concurrent access.
Reviewed-by: Maxime Ripard
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/bridge/ite-it66121.c | 2
Reading access to connector->eld can happen at the same time the
drm_edid_to_eld() updates the data. Take the newly added eld_mutex in
order to protect connector->eld from concurrent access.
Reviewed-by: Maxime Ripard
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/bridge/analogix/anx7625.c
Reading access to connector->eld can happen at the same time the
drm_edid_to_eld() updates the data. Take the newly added eld_mutex in
order to protect connector->eld from concurrent access.
Reviewed-by: Maxime Ripard
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/amd/display/amdgpu_dm/amd
The connector->eld is accessed by the .get_eld() callback. This access
can collide with the drm_edid_to_eld() updating the data at the same
time. Add drm_connector.eld_mutex to protect the data from concurrenct
access.
The individual drivers were just compile tested. I propose to merge the
drm_con
Reading access to connector->eld can happen at the same time the
drm_edid_to_eld() updates the data. Take the newly added eld_mutex in
order to protect connector->eld from concurrent access.
Reviewed-by: Maxime Ripard
Acked-by: Abhinav Kumar
Reviewed-by: Abhinav Kumar
Signed-off-by: Dmitry Bary
Reading access to connector->eld can happen at the same time the
drm_edid_to_eld() updates the data. Take the newly added eld_mutex in
order to protect connector->eld from concurrent access.
Reviewed-by: Maxime Ripard
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/radeon/radeon_audio.c | 2
Reading access to connector->eld can happen at the same time the
drm_edid_to_eld() updates the data. Take the newly added eld_mutex in
order to protect connector->eld from concurrent access.
Reviewed-by: Maxime Ripard
Acked-by: Raphael Gallais-Pou
Signed-off-by: Dmitry Baryshkov
---
drivers/gp
Reading access to connector->eld can happen at the same time the
drm_edid_to_eld() updates the data. Take the newly added eld_mutex in
order to protect connector->eld from concurrent access.
Reviewed-by: Maxime Ripard
Reviewed-by: Jani Nikula
Acked-by: Jani Nikula
Signed-off-by: Dmitry Baryshko
On Fri, Dec 6, 2024 at 8:26 AM Lijo Lazar wrote:
>
> Before forcing level, CG/PG is disabled or enabled depending on the new
> level. However if the force level operation fails, CG/PG state remains
> modified. Revert the state change on failure. Also, move invalid
> operation checks to the beginni
Clean up code to quiet the compiler on us failing to check the return
code.
Signed-off-by: Andrew Martin
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 14 +++---
.../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 3
On Fri, Dec 06, 2024 at 02:04:52PM -0500, Alex Deucher wrote:
> Hi Dave, Simona,
>
> Fixes for 6.13.
>
> Resending as this didn't seem to make it out to the mailing list when I first
> sent it.
>
> The following changes since commit 40384c840ea1944d7c5a392e8975ed088ecf0b37:
>
> Linux 6.13-rc1
Hi Dave, Simona,
Fixes for 6.13.
Resending as this didn't seem to make it out to the mailing list when I first
sent it.
The following changes since commit 40384c840ea1944d7c5a392e8975ed088ecf0b37:
Linux 6.13-rc1 (2024-12-01 14:28:56 -0800)
are available in the Git repository at:
https://g
Emitting the cleaner shader must come after the check if a VM switch is
necessary or not.
Otherwise we will emit the cleaner shader every time and not just when it is
necessary because we switched between applications.
This can otherwise crash on gang submit and probably decreases performance
qui
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks Lijo.
-Original Message-
From: Lazar, Lijo
Sent: Friday, December 6, 2024 12:11 AM
To: Nirujogi, Pratap ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Koenig, Christian
; Limonciello, Mario ;
Chan, Benjamin (Koon
On Fri, Dec 6, 2024 at 9:37 AM Alex Deucher wrote:
>
> On Fri, Dec 6, 2024 at 9:35 AM Christian König
> wrote:
> >
> > Emitting the cleaner shader must come after the check if a VM switch is
> > necessary or not.
> >
> > Otherwise we will emit the cleaner shader every time and not just when it is
On Fri, Dec 6, 2024 at 9:35 AM Christian König
wrote:
>
> Emitting the cleaner shader must come after the check if a VM switch is
> necessary or not.
>
> Otherwise we will emit the cleaner shader every time and not just when it is
> necessary because we switched between applications.
>
> This can
This a pointer that is being passed into other functions, so it is best to
initialize it to NULL prior.
Signed-off-by: Andrew Martin
---
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
b/driv
28 matches
Mail list logo
