Re: [PATCH] amdgpu/uvd: get ring reference from rq scheduler

Am 05.12.24 um 00:31 schrieb David (Ming Qiang) Wu: base.sched may not be set for each instance and should not be used for cases such as non-IB tests. Signed-off-by: David (Ming Qiang) Wu Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 2 +- 1 file changed, 1 in

[PATCH v2] drm/amd/amdgpu: Add Descriptions to Process Isolation and Cleaner Shader Sysfs Functions

This update adds explanations to key functions related to process isolation and cleaner shader execution sysfs interfaces. - `amdgpu_gfx_set_run_cleaner_shader`: Describes how to manually run a cleaner shader, which clears the Local Data Store (LDS) and General Purpose Registers (GPRs) to ensu

[PATCH] drm/amd: Show an info message about optional firmware missing

With the warning from the core about missing firmware gone, users still may be notified of missing optional firmware by a more friendly message to clarify it's optional. Suggested-by: Lijo Lazar Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 5 - 1 file cha

Re: [PATCH] drm/amd: Show an info message about optional firmware missing

On Thu, Dec 5, 2024 at 12:05 PM Mario Limonciello wrote: > > With the warning from the core about missing firmware gone, users still > may be notified of missing optional firmware by a more friendly message > to clarify it's optional. > > Suggested-by: Lijo Lazar > Signed-off-by: Mario Limonciell

[PATCH 07/10] drm/amdgpu: Add JPEG5_0_1 support

From: Sathishkumar S add support for JPEG5_0_1 v2: squash in updates, rebase on IP instance changes Signed-off-by: Sathishkumar S Reviewed-by: Sonny Jiang --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 708 +++ drivers/gp

[PATCH 10/10] drm/amdgpu: Enable VCN_5_0_1 IP block

From: Sonny Jiang Add VCN_5_0_1 IP block to kernel boot Signed-off-by: Sonny Jiang Acked-by: Leo Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discover

[PATCH 04/10] drm/amdgpu: update macro for maximum jpeg rings

From: Sathishkumar S Update the macro to accomdate more rings. Signed-off-by: Sathishkumar S Acked-by: Leo Liu Reviewed-by: Sonny Jiang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 3 ++- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 2 +- 2 files changed, 3 inser

[PATCH 08/10] drm/amdgpu: enable JPEG5_0_1 ip block

From: Sathishkumar S enable JPEG5_0_1 ip block Signed-off-by: Sathishkumar S Reviewed-by: Sonny Jiang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers

[PATCH 06/10] drm/amdgpu: Add VCN_5_0_1 codec query

From: Sonny Jiang Support VCN_5_0_1 codec query v2: squash in updates Signed-off-by: Sonny Jiang Acked-by: Leo Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc1

[PATCH 09/10] drm/amdgpu: Add VCN_5_0_1 support

From: Sonny Jiang Add vcn support for VCN_5_0_1 v2: rebase, squash in fixes (Alex) Signed-off-by: Sonny Jiang Acked-by: Leo Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile |3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c |7 +- drivers/gpu/drm/amd/amdgpu/am

[PATCH 01/10] drm/amdgpu: add irq source ids for VCN5_0/JPEG5_0

From: Sathishkumar S Add interrupt source id macros for VCN5 and JPEG5 V2: Update copyright year (Sonny) Signed-off-by: Sathishkumar S Acked-by: Leo Liu Reviewed-by: Sonny Jiang Signed-off-by: Alex Deucher --- .../amd/include/ivsrcid/vcn/irqsrcs_vcn_5_0.h | 47 +++ 1 file c

Re: [PATCH v2] drm/amd/amdgpu: Add Descriptions to Process Isolation and Cleaner Shader Sysfs Functions

On Thu, Dec 5, 2024 at 10:30 AM Srinivasan Shanmugam wrote: > > This update adds explanations to key functions related to process > isolation and cleaner shader execution sysfs interfaces. > > - `amdgpu_gfx_set_run_cleaner_shader`: Describes how to manually run a > cleaner shader, which clears t

RE: [PATCH v2] drm/amdkfd: Dereference null return value

[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Kuehling, Felix > Sent: Wednesday, December 4, 2024 7:01 PM > To: Russell, Kent ; Martin, Andrew > ; amd-gfx@lists.freedesktop.org > Cc: Tudor, Alexandru > Subject: Re: [PATCH v2] drm/amdkfd: Dereferenc

[PATCH 03/10] drm/amdgpu: update irq sec header for vcn 5.0.0

No functional change. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c index f08dbe37499da..097b9ad1721fe 10064

Re: [PATCH 1/2] drm/amdkfd: hard-code cahceline for gc11

Please fix typo in title line: cahceline -> cacheline And I suggest also changing: gc11 -> GFX11 (for consistency with typical name used in comments) With comment fixes, I approve the commit: Reviewed-by: David Belanger On 11/28/2024 11:17 AM, Harish Kasiviswanathan wrote: This informatio

Re: [PATCH 2/2] drm/amdkfd: hard-code MALL Cacheline size for gfx11, gfx12

Reviewed-by: David Belanger On 11/28/2024 11:17 AM, Harish Kasiviswanathan wrote: Signed-off-by: Harish Kasiviswanathan --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/a

[PATCH 05/10] drm/amdgpu: Add VCN_5_0_1 firmware

From: Sonny Jiang Add vcn_5_0_1 firmware support Signed-off-by: Sonny Jiang Acked-by: Leo Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/

[PATCH] drm/amdgpu: Use MEC FW with SJT on gfx_v9_4_3

On SRIOV, guest driver and host driver might deploy different versions of MEC firmware binaries that lead to potential compability issues cause system hang. To solve this, host and guest deploy MEC fw copies with two level jump table. Signed-off-by: Yuan Feng --- drivers/gpu/drm/amd/amdgpu/gfx

Re: [PATCH v2 1/1] drm/virtio: Implement device_attach

Hi Christian, Thanks for your reply. I get your point. Actually I have a design to send a command from guest with pci notations of amdgpu and virtio-gpu to host side to calculate physical p2pdma_distance. I will send out those patches soon. Best regards, Julia On 2024/12/4 17:32, Christian Kö

[PATCH] drm/amdgpu: Fix for MEC SJT FW Load Fail on VF

From: yfeng1 Users might switch to ROCM build does not include MEC SJT FW and driver needs to consider this case. Signed-of-yfeng1 --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/dr

RE: [PATCH] drm/amdgpu: Use MEC FW with SJT on gfx_v9_4_3

[AMD Official Use Only - AMD Internal Distribution Only] Hey @Lazar, Lijo, Yes, Just pinged Victor, Zhao. Sure, I will make a change accordingly. Thanks, Yuan -Original Message- From: Lazar, Lijo Sent: Friday, December 6, 2024 12:18 AM To: Feng, Yuan ; amd-gfx@lists.freedesktop.org Sub

RE: [PATCH] drm/amdgpu: Use MEC FW with SJT on gfx_v9_4_3

[AMD Official Use Only - AMD Internal Distribution Only] Hi @Lazar, Lijo, Please refer the attached. The idea is to try to load regular MEC firmware if SJT one is not available. Thanks, Yuan -Original Message- From: Lazar, Lijo Sent: Friday, December 6, 2024 12:18 AM To: Feng, Yuan ;

[PATCH V4] drm/amdkfd: pause autosuspend when creating pdd

When using MES creating a pdd will require talking to the GPU to setup the relevant context. The code here forgot to wake up the GPU in case it was in suspend, this causes KVM to EFAULT for passthrough GPU for example. This issue can be masked if the GPU was woken up by other things (e.g. opening t

[PATCH v2 3/3] drm: remove driver date from struct drm_driver and all drivers

We stopped using the driver initialized date in commit 7fb8af6798e8 ("drm: deprecate driver date") and (eventually) started returning "0" for drm_version ioctl instead. Finish the job, and remove the unused date member from struct drm_driver, its initialization from drivers, along with the common

[PATCH 1/1] drm/amdgpu: Fix ISP HW init issue

ISP hw_init is not called with the recent changes releated to hw init levels. AMDGPU_INIT_LEVEL_DEFAULT is ignoring the ISP IP block as AMDGPU_IP_BLK_MASK_ALL is derived using incorrect max number of IP blocks. Update AMDGPU_IP_BLK_MASK_ALL to use AMD_IP_BLOCK_TYPE_NUM instead of AMDGPU_MAX_IP_NUM

[PATCH 0/1] Fix ISP hw init issue

Update AMDGPU_IP_BLK_MASK_ALL to use AMD_IP_BLOCK_TYPE_NUM instead of AMDGPU_MAX_IP_NUM to fix the issue. Pratap Nirujogi (1): drm/amdgpu: Fix ISP HW init issue drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.43.0

[PATCH 02/10] drm/amdgpu: update irq sec header for jpeg 5.0.0

No functional change. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c index 87b3f91440e2e..d5cf0f2799d44 100644

Re: [PATCH 1/1] drm/amdgpu: Fix ISP HW init issue

On 12/6/2024 1:46 AM, Pratap Nirujogi wrote: > ISP hw_init is not called with the recent changes releated > to hw init levels. AMDGPU_INIT_LEVEL_DEFAULT is ignoring > the ISP IP block as AMDGPU_IP_BLK_MASK_ALL is derived using > incorrect max number of IP blocks. > > Update AMDGPU_IP_BLK_MASK_A

Re: [PATCH] drm/amdgpu: Use MEC FW with SJT on gfx_v9_4_3

On 12/6/2024 4:15 AM, Yuan Feng wrote: > On SRIOV, guest driver and host driver might deploy different versions of MEC > firmware binaries that > lead to potential compability issues cause system hang. To solve this, host > and guest deploy MEC fw copies > with two level jump table. > > Signe