Return eeprom table checksum error result, otherwise
it might be overwritten by next call.
Signed-off-by: Jinzhou Su
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
b/drivers
[AMD Official Use Only - AMD Internal Distribution Only]
Please replace DRM_ERROR with dev_err. Other than that, the patch looks good to
me.
Regards,
Hawking
-Original Message-
From: Su, Joe
Sent: Monday, December 2, 2024 11:30 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ;
Return eeprom table checksum error result, otherwise
it might be overwritten by next call.
V2: replace DRM_ERROR with dev_err
Signed-off-by: Jinzhou Su
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/am
[AMD Official Use Only - AMD Internal Distribution Only]
Ah, hold on please. I assume even the BADG is written to headers. There are
still valid eeprom record available in the eeprom, right?
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Zhang,
Hawking
Sent: Monday, De
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Su, Joe
Sent: Monday, December 2, 2024 13:30
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Yang, Stanley
; Su, Joe
Subject: [PATCH] drm/amdgpu: return
There will to release the FW twice when the FW validated error.
Even if the release_firmware() will further validate the FW whether
is empty, but that will be redundant and inefficient.
Signed-off-by: Prike Liang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 5 +
1 file changed, 1 insertio
[AMD Official Use Only - AMD Internal Distribution Only]
> From: Christian König
> Sent: Tuesday, November 12, 2024 9:43 PM
> To: Liang, Prike ; Koenig, Christian
> ; Kuehling, Felix ; amd-
> g...@lists.freedesktop.org
> Cc: Deucher, Alexander ; Kasiviswanathan, Harish
>
> Subject: Re: [PATCH] d
On 12/2/2024 12:16 PM, Prike Liang wrote:
> There will to release the FW twice when the FW validated error.
> Even if the release_firmware() will further validate the FW whether
> is empty, but that will be redundant and inefficient.
Better to add a remark that amdgpu_ucode_request should be pa
Don't send the message if driver only warns for RAS bad page excess.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
b/drivers/gpu/drm/amd/amdgpu
