Re: [PATCH] amdgpu: Don't print L2 status if there's nothing to print

On 10/19/2024 1:51 AM, Kent Russell wrote: > If a 2nd fault comes in before the 1st is handled, the 1st fault will > clear out the FAULT STATUS registers before the 2nd fault is handled. > Thus we get a lot of zeroes. If status=0, just skip the L2 fault status > information, to avoid confusion o

Re: [PATCH] drm/amdgpu: Use SPX as default in partition config

On 10/19/2024 12:46 AM, Felix Kuehling wrote: > > On 2024-10-14 05:19, Lijo Lazar wrote: >> In certain cases - ex: when a reset is required on initialization - XCP >> manager won't have a valid partition mode. In such cases, use SPX as the >> default selected mode for which partition configurat

Re: [PATCH] amdgpu: Don't print L2 status if there's nothing to print

On Mon, Oct 21, 2024 at 10:13 AM Lazar, Lijo wrote: > > > > On 10/19/2024 1:51 AM, Kent Russell wrote: > > If a 2nd fault comes in before the 1st is handled, the 1st fault will > > clear out the FAULT STATUS registers before the 2nd fault is handled. > > Thus we get a lot of zeroes. If status=0, j

[PATCH v7 00/10] validate/clean the functions of ip funcs

v7: Drop the patches which addred return statement for failure in suspend in reset/suspend_ip_phase2 as they might cause some failures need through testing. v6: Fixed the missing return statement on suspend and update the code with V5 comments. v5: Fixed review comments. Dropped hw_fi

[PATCH v7 05/10] drm/amdgpu: clean the dummy resume functions

Remove the dummy resume functions for all ip blocks. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c index 9b98b40ac4db..1383fd1644d

Re: [PATCH] drm/amd/amdgpu: change the flush gpu tlb mode to sync mode.

Am 21.10.24 um 07:56 schrieb Chong Li: change the gpu tlb flush mode to sync mode to solve the issue in the rocm stress test. And again complete NAK to this. I've already proven together with Andjelkovic that the problem is that the rocm stress test is broken. The test tries to access memor

[PATCH v7 10/10] drm/amdgpu: clean unused functions of uvd/vcn/vce

Some of the functions pointers of amdgpu_ip_funcs are not used and are left commented out. Hence this cleans those up which arent used. Cc: Leo Liu Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 274 -- drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 273

[PATCH v7 08/10] drm/amdgpu: clean the dummy soft_reset functions

Remove the dummy soft_reset functions for all ip blocks. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 6 -- drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 6 -- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 6 -- drivers/gpu/drm/amd/amdg

[PATCH v7 09/10] drm/amdgpu: Clean the functions pointer set as NULL

We dont need to set the functions to NULL which arent needed as global structure members are by default set to zero or NULL for pointers. Cc: Leo Liu Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c |

[PATCH v7 07/10] drm/amdgpu: clean the dummy wait_for_idle functions

Remove the dummy wait_for_idle functions for all ip blocks. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 6 -- drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 6 -- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 6 -- drivers/gpu/drm/amd/a

[PATCH v7 04/10] drm/amdgpu: validate wait_for_idle before function call

Before making a function call to wait_for_idle, validate the function pointer like we do in sw_init. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH v7 01/10] drm/amdgpu: validate hw_fini before function call

Before making a function call to hw_fini, validate the function pointer like we do in sw_init. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 38 +- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu

Re: [PATCH] drm/amdkfd: fix the hang caused by the write reorder to fence_addr

Am 18.10.24 um 23:59 schrieb Philip Yang: On 2024-10-18 14:28, Felix Kuehling wrote: On 2024-10-17 04:34, Victor Zhao wrote: make sure KFD_FENCE_INIT write to fence_addr before pm_send_query_status called, to avoid qcm fence timeout caused by incorrect ordering. Signed-off-by: Victor Zhao -

[PATCH v7 02/10] drm/amdgpu: validate suspend before function call

Before making a function call to suspend, validate the function pointer like we do in sw_init. Use the helper function amdgpu_ip_block_suspend where same checks and calls are repeated. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/aldebaran.c | 11 ++- drivers/gpu/drm/amd/

[PATCH v7 06/10] drm/amdgpu: clean the dummy suspend functions

Remove the dummy suspend functions for all ip blocks. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 6 -- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 3 ++- drivers/gpu/drm/amd/amdgpu/cik.c | 6 -- drivers/gpu/drm/amd/amdgpu/si.c | 6 -- 4

[PATCH v7 03/10] drm/amdgpu: validate resume before function call

Before making a function call to resume, validate the function pointer like we do in sw_init. Use the helper function amdgpu_ip_block_resume where same checks and calls are repeated. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/aldebaran.c | 13 ++--- drivers/gpu/drm/amd/amdg

RE: [PATCH] drm/amd/amdgpu: change the flush gpu tlb mode to sync mode.

[AMD Official Use Only - AMD Internal Distribution Only] Hi, Christian, Raina, Yera. If this issue in rocm, I need assign my ticket SWDEV-459983 to rocm team. Is there anything to share with the rocm pm? Such as the Email or chat history

[PATCH 5.10 24/52] drm/radeon: Fix encoder->possible_clones

5.10-stable review patch. If anyone has any objections, please let me know. -- From: Ville Syrjälä commit 28127dba64d8ae1a0b737b973d6d029908599611 upstream. Include the encoder itself in its possible_clones bitmask. In the past nothing validated that drivers were populating po

[PATCH 6.1 51/91] drm/radeon: Fix encoder->possible_clones

6.1-stable review patch. If anyone has any objections, please let me know. -- From: Ville Syrjälä commit 28127dba64d8ae1a0b737b973d6d029908599611 upstream. Include the encoder itself in its possible_clones bitmask. In the past nothing validated that drivers were populating pos

Patch "drm/radeon: Fix encoder->possible_clones" has been added to the 6.6-stable tree

This is a note to let you know that I've just added the patch titled drm/radeon: Fix encoder->possible_clones to the 6.6-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-radeon-fix

Patch "drm/radeon: Fix encoder->possible_clones" has been added to the 5.15-stable tree

This is a note to let you know that I've just added the patch titled drm/radeon: Fix encoder->possible_clones to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-radeon-fi

[PATCH 6.11 059/135] drm/radeon: Fix encoder->possible_clones

6.11-stable review patch. If anyone has any objections, please let me know. -- From: Ville Syrjälä commit 28127dba64d8ae1a0b737b973d6d029908599611 upstream. Include the encoder itself in its possible_clones bitmask. In the past nothing validated that drivers were populating po

Patch "drm/radeon: Fix encoder->possible_clones" has been added to the 6.1-stable tree

This is a note to let you know that I've just added the patch titled drm/radeon: Fix encoder->possible_clones to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-radeon-fix

[PATCH 6.6 066/124] drm/radeon: Fix encoder->possible_clones

6.6-stable review patch. If anyone has any objections, please let me know. -- From: Ville Syrjälä commit 28127dba64d8ae1a0b737b973d6d029908599611 upstream. Include the encoder itself in its possible_clones bitmask. In the past nothing validated that drivers were populating pos

Patch "drm/radeon: Fix encoder->possible_clones" has been added to the 5.10-stable tree

This is a note to let you know that I've just added the patch titled drm/radeon: Fix encoder->possible_clones to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-radeon-fi

[PATCH 5.15 49/82] drm/radeon: Fix encoder->possible_clones

5.15-stable review patch. If anyone has any objections, please let me know. -- From: Ville Syrjälä commit 28127dba64d8ae1a0b737b973d6d029908599611 upstream. Include the encoder itself in its possible_clones bitmask. In the past nothing validated that drivers were populating po

Re: [PATCH] drm/amd/amdgpu: change the flush gpu tlb mode to sync mode.

Hi Chong, Andjelkovic just shared a bunch of traces from rocm on teams with me which I analyzed. When you know what you look for it's actually pretty obvious what's going on. Just look at the timestamp of the fault and compare that with the timestamp of the operation mapping something at the

Re: [PATCH] drm/amdgpu: Add gpu_addr support to seq64 allocation

Hi Christian, I couldn't find other users except userq fence driver which are not yet pushed into amd-staging-drm-next. Should we wait and push along with userq fence patches or we can push this one separately. Thanks, Arun. On 10/18/2024 7:09 PM, Christian König wrote: Am 18.10.24 um 15:26

Re: [PATCH] drm/amdgpu: Add gpu_addr support to seq64 allocation

Hi Arun, yeah better to make this here part of the userq fence patch set. Regards, Christian. Am 21.10.24 um 11:54 schrieb Paneer Selvam, Arunpravin: Hi Christian, I couldn't find other users except userq fence driver which are not yet pushed into amd-staging-drm-next. Should we wait and pus

Re: (subset) [PATCH 00/28] drm: Remove DRM aperture helpers

On Mon, 30 Sep 2024 15:02:58 +0200, Thomas Zimmermann wrote: > DRM's aperture helpers are merely wrappers around the respective > helpers in drivers/video/. The DRM interface existed first, but was > later generalized for use with fbdev and a few other graphics-related > places in the kernel. It

[PATCH] Revert "drm/amdkfd: SMI report dropped event count"

This reverts commit a3ab2d45b9887ee609cd3bea39f668236935774c. The userspace side for this code is not ready yet so revert for now. Signed-off-by: Alex Deucher Cc: Philip Yang --- drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 27 +++-- include/uapi/linux/kfd_ioctl.h

Re: [PATCH] drm/amdkfd: sever xgmi io link if host driver has disable sharing

Reviewed-by: Harish Kasiviswanathan On 2024-10-16 15:08, Kim, Jonathan wrote: > [Public] > > Messed up James' email in Tested-by tag. CC'ing James. > >> -Original Message- >> From: Kim, Jonathan >> Sent: Wednesday, October 16, 2024 11:59 AM >> To: amd-gfx@lists.freedesktop.org >> Cc:

Re: [PATCH] Revert "drm/amdkfd: SMI report dropped event count"

On 2024-10-21 13:46, Alex Deucher wrote: This reverts commit a3ab2d45b9887ee609cd3bea39f668236935774c. The userspace side for this code is not ready yet so revert for now. Signed-off-by: Alex Deucher Cc: Philip Yang Reviewed-by: Philip Yang

RE: [PATCH v6 00/12] validate/clean the functions of ip funcs

[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Khatri, Sunil > Sent: Friday, October 18, 2024 10:07 AM > To: Koenig, Christian ; Deucher, Alexander > ; Liu, Leo ; Lazar, Lijo > > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH v6 00/12] vali

Re: [PATCH v6 00/12] validate/clean the functions of ip funcs

On 10/21/2024 10:11 PM, Deucher, Alexander wrote: [AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Khatri, Sunil Sent: Friday, October 18, 2024 10:07 AM To: Koenig, Christian ; Deucher, Alexander ; Liu, Leo ; Lazar, Lijo Cc: amd-gfx@lists.freedesktop

[PATCH] drm/amdgpu: Fix video caps for H264 and HEVC encode maximum size

H264 supports 4096x4096 starting from Polaris. HEVC also supports 4096x4096, with VCN 3 and newer 8192x4352 is supported. Signed-off-by: David Rosca Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/nv.c| 12 ++-- drivers/gpu/drm/amd/amdgpu/soc15.c | 4 ++-- drivers/gpu/drm/amd/a

[PATCH] drm/amd : Update MES API header file for v11 & v12

New features require the new fields defines Signed-off-by: Shaoyun Liu --- drivers/gpu/drm/amd/include/mes_v11_api_def.h | 32 - drivers/gpu/drm/amd/include/mes_v12_api_def.h | 34 ++- 2 files changed, 64 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH] drm/amd : Update MES API header file for v11 & v12

New features require the new fields defines Signed-off-by: Shaoyun Liu --- drivers/gpu/drm/amd/include/mes_v11_api_def.h | 46 ++- drivers/gpu/drm/amd/include/mes_v12_api_def.h | 34 +- 2 files changed, 78 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/am

RE: [PATCH] drm/amdgpu: handle default profile on GC 9.4.1

[AMD Official Use Only - AMD Internal Distribution Only] Hi Alex, I have found another problem with the current code based on the default workload setting to 3D fullscreen. For example, the default workload is set to 3D fullscreen first, but in boot, it's not applied yet. Then a vcn ring test co

Re: [PATCH] amdkfd: Explicitly specify data type amdkfd_process_info in related functions

Gentle Ping On 10/15/2024 11:51 AM, Zhu Lingshan wrote: > This commit specifies data type struct amdkfd_process_info > rather than general void* in ralted functions. > > kfd_process->kgd_process_info is initialized > in init_kfd_vm() by such code: > > static int init_kfd_vm(struct amdgpu_vm *vm, v

RE: [PATCH 1/2] drm/amdgpu: add amdgpu_gfx_sched_mask and amdgpu_compute_sched_mask debugfs

[AMD Official Use Only - AMD Internal Distribution Only] Ping on this series? -Original Message- From: jesse.zh...@amd.com Sent: Friday, October 18, 2024 10:31 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Zhang, Jesse(Jie) Subject: [PATCH 1/2] drm/

Re: [PATCH] amdkfd: Explicitly specify data type amdkfd_process_info in related functions

On 2024-10-14 23:51, Zhu Lingshan wrote: > This commit specifies data type struct amdkfd_process_info > rather than general void* in ralted functions. Several interfaces in amdgpu_amdkfd.h use void * as opaque pointers, e.g. process_info, mem_obj, drm_priv. The reasons are partly historical be

Re: [PATCH] drm/amdgpu: handle default profile on GC 9.4.1

[AMD Official Use Only - AMD Internal Distribution Only] Ping? From: Deucher, Alexander Sent: Friday, October 18, 2024 3:20 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: handle default profile on GC 9.4.1 It does not s

Re: [PATCH] drm/amdgpu: Use SPX as default in partition config

On 2024-10-21 10:07, Lazar, Lijo wrote: > > > On 10/19/2024 12:46 AM, Felix Kuehling wrote: >> >> On 2024-10-14 05:19, Lijo Lazar wrote: >>> In certain cases - ex: when a reset is required on initialization - XCP >>> manager won't have a valid partition mode. In such cases, use SPX as the >>>

Re: [PATCH] drm/amd/display: Disable PSR-SU on Parade 08-01 TCON too

On 2024-02-05 16:12, Mario Limonciello wrote: Stuart Hayhurst has found that both at bootup and fullscreen VA-API video is leading to black screens for around 1 second and kernel WARNING [1] traces when calling dmub_psr_enable() with Parade 08-01 TCON. These symptoms all go away with PSR-SU d

Re: [PATCH] drm/amdgpu: Use SPX as default in partition config

On 10/22/2024 12:55 AM, Felix Kuehling wrote: > > > On 2024-10-21 10:07, Lazar, Lijo wrote: >> >> >> On 10/19/2024 12:46 AM, Felix Kuehling wrote: >>> >>> On 2024-10-14 05:19, Lijo Lazar wrote: In certain cases - ex: when a reset is required on initialization - XCP manager won't have

Re: [PATCH 00/32] Separating vcn power management by instance

Patches #1-#5, #7, #8, #32 are Acked-by: Christian König Patches #9 - #19, #27 are Reviewed-by: Christian König Patch #6 the drm/amdgpu prefix is missing from the subject line, apart from that the patch is Reviewed-by: Christian König For patches #20-#26 I'm not sure if those won't bre

[PATCH] drm/amdgpu: Reduce redundant gpu resets on nbio v7.4

On nbio v7.4, ras controller interrupt and athub interrupt are generated after injecting UE to PCIE, but gpu reset only needs to be triggered once. Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/

Re: [PATCH v5 1/4] drm/amdgpu: remove unused function parameter

Am 18.10.24 um 15:33 schrieb Yunxiang Li: amdgpu_vm_bo_invalidate doesn't use the adev parameter and not all callers have a reference to adev handy, so remove it for cleanliness. Signed-off-by: Yunxiang Li Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 +