On 2024-10-09 17:02, Chen, Xiaogang wrote:
On 10/9/2024 3:38 PM, Felix Kuehling wrote:
On 2024-10-09 14:08, Xiaogang.Chen wrote:
From: Xiaogang Chen
kfd process kref count(process->ref) is initialized to 1 by
kref_init. After
it is created not need to increaes its kref. Instad add kfd pro
[Public]
Reviewed-by: Roman Li
> -Original Message-
> From: SHANMUGAM, SRINIVASAN
> Sent: Wednesday, October 9, 2024 10:25 AM
> To: Siqueira, Rodrigo ; Pillai, Aurabindo
>
> Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN
> ; Chung, ChiaHsuan (Tom)
> ; Li, Roman ; Hung, Alex
>
On 10/9/2024 4:45 PM, Felix Kuehling wrote:
On 2024-10-09 17:02, Chen, Xiaogang wrote:
On 10/9/2024 3:38 PM, Felix Kuehling wrote:
On 2024-10-09 14:08, Xiaogang.Chen wrote:
From: Xiaogang Chen
kfd process kref count(process->ref) is initialized to 1 by
kref_init. After
it is created not
From: Alex Hung
[WHAT & HOW]
"split_pipe" are assigned to test_pipe and then immediately are updated
to other values. The same also applies to "status" as well.
Similarly, "id", "dwb" and "unused_dpps" are assigned but the functions
immediately return, and thus they have no effects.
As a result
From: Robin Chen
[WHY]
To get sink emission rate information for future
supported refresh rate calculation.
Reviewed-by: ChunTao Tso
Signed-off-by: Robin Chen
Signed-off-by: Roman Li
---
drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 3 ++-
.../dc/link/protocols/link_dp_capability.c|
From: Alex Hung
[WHAT]
The function core_link_read_dpcd returns status which is not used at
all, making them useless assignments.
[HOW]
Print error messages if core_link_read_dpcd does not return DC_OK.
This fixes 2 UNUSED_VALUE issues reported by Coverity.
Reviewed-by: Rodrigo Siqueira
Signe
From: Aric Cyr
- Add sharpening policy to plane state
- Clear pipe pointers on pipe reset
- Resolve correct MALL size for dcn401
- Read Sink emission rate capability
- IPX fixes
- Coverity fixes
Reviewed-by: Roman Li
Signed-off-by: Aric Cyr
Signed-off-by: Roman Li
---
drivers/gpu/drm/amd/dis
From: Ilya Bakoulin
[Why]
There is a known HW bug that causes the internal 3DLUT fetch signal to
be lost at VREADY, regardless of whether the OTG lock is being held or
not. A workaround is necessary to make sure that this internal signal
stays up after OTG unlock.
[How]
Set the 3DLUT_ENABLE bit
From: Samson Tam
[Why]
Pass in sharpening policy through plane state from control side
[How]
Add sharpener support through dc_caps.
Add sharpen policy to plane state and move to spl_input.
Pass sharpen policy from plane state to SPL.
Reviewed-by: Aric Cyr
Signed-off-by: Samson Tam
Signed-off-
From: Leo Chen
[Why]
A race condition occurs between cursor movement and vertical interrupt control
thread from OS, with both threads trying to exit IPS2.
Vertical interrupt control thread clears the prev driver allow signal while not
fully
finishing the IPS2 exit process.
[How]
We want to dete
From: Joshua Aberback
[Why]
We want to clean up unnecessary asserts, one of which is an assert in
resource_is_pipe_type that fires if a pipe has no stream and still has
pointers to other pipes ("dangling state"). This gets hit because pipes
are not properly cleaned up in reset_back_end_for_pipe.
From: Dillon Varone
[WHY]
Code for dcn401 to calculate available MALL size for display was shared
with dcn32 and did not provide the correct result for all ASICs.
[HOW]
Add dcn401 specific function to properly calculate the available MALL
for display.
Reviewed-by: Chris Park
Signed-off-by: Dil
From: "Leo (Hanghong) Ma"
[Why && How]
Previous change for Coverity has caused regression on visual confirm
so fix it by reverting the part that affects visual confirm.
Reviewed-by: Chris Park
Signed-off-by: Leo (Hanghong) Ma
Signed-off-by: Roman Li
---
drivers/gpu/drm/amd/display/dc/dc_dmub
From: Alex Hung
[WHAT & HOW]
Print error messages when programming shaper lut or 3dlut fails.
This fixes 5 UNUSED_VALUE issues reported by Coverity.
Reviewed-by: Rodrigo Siqueira
Signed-off-by: Alex Hung
Signed-off-by: Roman Li
---
.../gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c | 7 ++
From: Roman Li
[Why]
Currently idle worker thread that checks for HPD while system is in IPS2
only supports headless and static screen use-cases.
In other display-off scenarios hotplug may not work.
[How]
For display-off only allow idle optimization when no display is connected.
Reviewed-by: Su
From: Samson Tam
[Why & How]
Disable dynamic ODM when sharpness is enabled
Reviewed-by: Alvin Lee
Signed-off-by: Samson Tam
Signed-off-by: Roman Li
---
.../gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git
a/drivers/gpu/drm/amd/di
From: Alex Hung
[WHAT & HOW]
drm_dp_dpcd_write() returns negative error on failure and thus returned
values need to be checked.
This fixes 3 UNUSED_VALUE issues reported by Coverity.
Reviewed-by: Rodrigo Siqueira
Signed-off-by: Alex Hung
Signed-off-by: Roman Li
---
.../amd/display/amdgpu_dm
From: Roman Li
This DC v.3.2.305 patchset brings improvements in multiple areas. In summary,
we have:
- Add sharpening policy to plane state
- Clear pipe pointers on pipe reset
- Resolve correct MALL size for dcn401
- Read Sink emission rate capability
- IPX fixes
- Coverity fixes
Cc: Daniel
From: Roman Li
[Why]
Idle worker thread waits HPD_DETECTION_TIME for HPD processing complete.
Some displays require longer time for that.
[How]
Increase HPD_DETECTION_TIME to 100ms.
Reviewed-by: Sun peng Li
Signed-off-by: Roman Li
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c |
From: Alex Hung
[WHAT & HOW]
dpcd_get_tunneling_device_data calls core_link_read_dpcd which can
fail. The status from core_link_read_dpcd should be checked and error
messages is printed in case of failures.
This fixes 1 UNUSED_VALUE issue reported by Coverity.
Reviewed-by: Rodrigo Siqueira
Sig
On 10/9/2024 3:38 PM, Felix Kuehling wrote:
On 2024-10-09 14:08, Xiaogang.Chen wrote:
From: Xiaogang Chen
kfd process kref count(process->ref) is initialized to 1 by
kref_init. After
it is created not need to increaes its kref. Instad add kfd process
kref at kfd
process mmu notifier alloca
From: Xiaogang Chen
kfd process kref count(process->ref) is initialized to 1 by kref_init. After
it is created not need to increaes its kref. Instad add kfd process kref at kfd
process mmu notifier allocation since we decrease the ref at free_notifier of
mmu_notifier_ops, so pair them.
Signed-of
On 2024-10-04 16:28, Philip Yang wrote:
Per process device data pdd->vram_usage is used by rocm-smi to report
VRAM usage, this is currently missing the svm_bo usage accounting, so
"rocm-smi --showpids" per process report is incorrect.
Add pdd->vram_usage accounting for svm_bo and change type t
On 2024-10-04 11:54, Xiaogang.Chen wrote:
From: Xiaogang Chen
When kfd process has been terminated not restore userptr buffer after mmu
notifier invalidates a range.
Is this fixing a real problem or a hypothetical problem? If there is a
real problem, can you include more information here?
On 2024-10-09 14:08, Xiaogang.Chen wrote:
From: Xiaogang Chen
kfd process kref count(process->ref) is initialized to 1 by kref_init. After
it is created not need to increaes its kref. Instad add kfd process kref at kfd
process mmu notifier allocation since we decrease the ref at free_notifier o
From: LipArcanjo
All dce command_table_helper's shares a copy-pasted collection
of copy-pasted functions, which are: phy_id_to_atom,
clock_source_id_to_atom_phy_clk_src_id, and engine_bp_to_atom.
This patch removes the multiple copy-pasted by creating a
common command table and make the command_
[AMD Official Use Only - AMD Internal Distribution Only]
> -Original Message-
> From: SHANMUGAM, SRINIVASAN
> Sent: Tuesday, October 8, 2024 11:43 PM
> To: Koenig, Christian ; Deucher, Alexander
>
> Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN
> ; Joshi, Mukul ;
> Kasiviswana
On 10/9/2024 4:36 PM, Felix Kuehling wrote:
On 2024-10-04 11:54, Xiaogang.Chen wrote:
From: Xiaogang Chen
When kfd process has been terminated not restore userptr buffer after
mmu
notifier invalidates a range.
Is this fixing a real problem or a hypothetical problem? If there is a
real
Before making a function call to sw_init, validate
the function pointer.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amd
Remove the dummy sw_init functions and set the
corresponding functions to NULL.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 5 -
drivers/gpu/drm/amd/amdgpu/cik.c| 7 +--
drivers/gpu/drm/amd/amdgpu/si.c | 7 +--
3 files changed, 2 insertio
[AMD Official Use Only - AMD Internal Distribution Only]
> -Original Message-
> From: Lazar, Lijo
> Sent: Wednesday, October 9, 2024 5:13 PM
> To: Zhu, Jiadong ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: Re: [PATCH v3 3/3] drm/amdgpu/sdma4.4.2: implement ring rese
On 10/9/2024 7:06 PM, Boyuan Zhang wrote:
>
> On 2024-10-08 23:43, Lazar, Lijo wrote:
>>
>> On 10/9/2024 3:34 AM, Boyuan Zhang wrote:
>>> On 2024-10-08 03:03, Lazar, Lijo wrote:
On 10/7/2024 8:54 PM, Alex Deucher wrote:
> On Mon, Oct 7, 2024 at 10:32 AM Lazar, Lijo
> wrote:
>>
Le 08/10/2024 à 10:13, Christian König a écrit :
Am 03.10.24 um 14:43 schrieb Pierre-Eric Pelloux-Prayer:
This will allow to use flexible array to store the process name and
other information.
This also means that process name will be determined once and for all,
instead of at each submit.
S
From: Jiadong Zhu
update smu header for sdma soft reset.
Signed-off-by: Jiadong Zhu
---
drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_ppsmc.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_ppsmc.h
b/drivers/gpu
From: Jiadong Zhu
Implement sdma queue reset callback via SMU interface.
v2: Leverage inst_stop/start functions in reset sequence.
Use GET_INST for physical SDMA instance.
Disable apu for sdma reset.
v3: Rephrase error prints.
Signed-off-by: Jiadong Zhu
---
drivers/gpu/drm/amd/amdgpu/
Le 08/10/2024 à 10:24, Christian König a écrit :
Am 03.10.24 um 14:43 schrieb Pierre-Eric Pelloux-Prayer:
If a drm_file name is set append it to the process name.
This information is useful with the virtio/native-context driver: this
allows the guest applications identifier to visible in amdg
On Tue, Oct 8, 2024 at 8:24 PM Rafael J. Wysocki wrote:
>
> On Tue, Oct 8, 2024 at 12:35 AM Ulf Hansson wrote:
> >
> > On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart
> > wrote:
> > >
> > > Hi Ulf,
> > >
> > > On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote:
> > > > On Mon, 7 Oct 2024
-Original Message-
From: Intel-xe On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
intel-...@lists.freedesktop.org; int
-Original Message-
From: Intel-xe On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
intel-...@lists.freedesktop.org; int
-Original Message-
From: Intel-xe On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
intel-...@lists.freedesktop.org; int
Before this patch, if multiple BO_HANDLES chunks were submitted,
the error -EINVAL would be correctly set but could be overwritten
by the return value from amdgpu_cs_p1_bo_handles(). This patch
ensures that if there are multiple BO_HANDLES, we stop.
Cc: sta...@vger.kernel.org
Fixes: fec5f8e8c6bc (
On Sat, 2024-10-05 at 04:14 +, Matthew Brost wrote:
> On Fri, Oct 04, 2024 at 04:28:29PM +0200, Thomas Hellström wrote:
> > On Wed, 2024-10-02 at 14:54 +0200, Thomas Hellström wrote:
> > > On Wed, 2024-10-02 at 14:45 +0200, Christian König wrote:
> > > > Am 02.10.24 um 14:24 schrieb Thomas Hell
-Original Message-
From: Intel-xe On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
intel-...@lists.freedesktop.org; int
-Original Message-
From: Intel-xe On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
intel-...@lists.freedesktop.org; int
On Fri, Sep 27, 2024, at 7:06 PM, Mario Limonciello wrote:
> From: Mario Limonciello
>
> Some manufacturers have intentionally put an EDID that differs from
> the EDID on the internal panel on laptops.
>
> Attempt to fetch this EDID if it exists and prefer it over the EDID
> that is provided by th
Improves the coding style by updating bit-shift
operations in the amdgpu_jpeg.c driver file.
It ensures consistency and avoids potential issues
by explicitly using 1U and 1ULL for unsigned
and unsigned long long shifts in all relevant instances.
Signed-off-by: Advait Dhamorikar
---
v1->v2: addre
-Original Message-
From: Intel-xe On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
intel-...@lists.freedesktop.org; int
-Original Message-
From: Intel-xe On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
intel-...@lists.freedesktop.org; int
On 08/10/2024 19:10, Christian König wrote:
Am 08.10.24 um 17:05 schrieb Tvrtko Ursulin:
From: Tvrtko Ursulin
I've noticed the hardware ring padding optimisations have landed so I
decided
to respin the CPU side optimisations.
First two patches are simply adding ring fill helpers which dea
-Original Message-
From: Intel-xe On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
intel-...@lists.freedesktop.org; int
-Original Message-
From: Intel-xe On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 5:00 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
intel-...@lists.freedesktop.org; int
From: "Dr. David Alan Gilbert"
cm3_helper_translate_curve_to_degamma_hw_format() since it was added in
2020's commit
03f54d7d3448 ("drm/amd/display: Add DCN3 DPP")
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
.../amd/display/dc/dcn30/dcn30_cm_common.c| 151 --
.../
On Tue, 8 Oct 2024 at 20:25, Rafael J. Wysocki wrote:
>
> On Tue, Oct 8, 2024 at 12:35 AM Ulf Hansson wrote:
> >
> > On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart
> > wrote:
> > >
> > > Hi Ulf,
> > >
> > > On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote:
> > > > On Mon, 7 Oct 2024 at
On 10/3/24 13:00, Harry Wentland wrote:
> Debugging LUT math is much easier when we can unit test
...
> diff --git a/drivers/gpu/drm/vkms/tests/vkms_color_test.c
> b/drivers/gpu/drm/vkms/tests/vkms_color_test.c
> new file mode 100644
> index ..efe139978860
> --- /dev/null
> +++ b/drive
On 08/10/2024 7:24 pm, Rafael J. Wysocki wrote:
On Tue, Oct 8, 2024 at 12:35 AM Ulf Hansson wrote:
On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart
wrote:
Hi Ulf,
On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote:
On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote:
On Fri, Oct 04
Hello,
On Mon, Oct 07, 2024 at 09:49:24PM +0300, Laurent Pinchart wrote:
> On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote:
> > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus
> > wrote:
> > >
> > > Hello everyone,
> > >
> > > This set will switch the users of pm_runtime_put_autosuspend()
Hi,
I have sent the v2 Patch reflecting these changes along with
the Cc tag as suggested by Christian.
Thanks
-Original Message-
From: Intel-gfx On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
intel-...@lists.freedesktop.org; in
-Original Message-
From: Intel-gfx On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 5:00 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
intel-...@lists.freedesktop.org; in
-Original Message-
From: Intel-xe On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
intel-...@lists.freedesktop.org; int
On Wed, Oct 9, 2024 at 2:48 PM Richard Fitzgerald
wrote:
>
> On 08/10/2024 7:24 pm, Rafael J. Wysocki wrote:
> > On Tue, Oct 8, 2024 at 12:35 AM Ulf Hansson wrote:
> >>
> >> On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart
> >> wrote:
> >>>
> >>> Hi Ulf,
> >>>
> >>> On Tue, Oct 08, 2024 at 12:08:24
On 2024-10-08 23:43, Lazar, Lijo wrote:
On 10/9/2024 3:34 AM, Boyuan Zhang wrote:
On 2024-10-08 03:03, Lazar, Lijo wrote:
On 10/7/2024 8:54 PM, Alex Deucher wrote:
On Mon, Oct 7, 2024 at 10:32 AM Lazar, Lijo wrote:
On 10/7/2024 7:47 PM, Alex Deucher wrote:
On Mon, Oct 7, 2024 at 9:58 AM
On 08/10/2024 19:11, Christian König wrote:
Stop masking the wptr and decrementing the count_dw while writing into
the ring buffer. We can do that all at once while pushing the changes to
the HW.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 11 +--
Hi,
Le 05/10/2024 à 01:59, Mohammed Anees a écrit :
Before this patch, if multiple BO_HANDLES chunks were submitted,
the error -EINVAL would be correctly set but could be overwritten
by the return value from amdgpu_cs_p1_bo_handles(). This patch
ensures that once an error condition is detected,
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Jack Xiao
Regards,
Jack
-Original Message-
From: Chen, Michael
Sent: Wednesday, October 9, 2024 4:42 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Xiao, Jack
; Chen, Michael
Subject: [PATCH] drm/amd
Before making a function call to sw_init, validate
the function pointer.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/a
Remove the dummy sw_init functions and set the
corresponding functions to NULL.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 5 -
drivers/gpu/drm/amd/amdgpu/cik.c| 7 +--
drivers/gpu/drm/amd/amdgpu/si.c | 7 +--
3 files changed, 2 insertio
On 08/10/2024 19:11, Christian König wrote:
Volatile only prevents the compiler from re-ordering reads and writes.
Since we always only modify the ring buffer from one CPU thread and have
an explicit barrier before signaling the HW this should have no effect at
all and just prevents compiler op
On 10/9/2024 5:44 PM, Asad Kamal wrote:
> Fill pcie other end recovery counter to metrics 1.6
>
> v2: Add separate function to check recovery counter support
>
> Signed-off-by: Asad Kamal
> ---
> .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 16
> 1 file changed, 16 ins
Thanks for the updated patch, looks good to me.
Le 09/10/2024 à 14:31, Christian König a écrit :
Am 09.10.24 um 14:28 schrieb Mohammed Anees:
Before this patch, if multiple BO_HANDLES chunks were submitted,
the error -EINVAL would be correctly set but could be overwritten
by the return value fr
From: Jiadong Zhu
Implement sdma soft reset by sending MSG_ResetSDMA on smu 13.0.6.
v2: Add firmware version for the reset message.
v3: Add ip version check. Print inst_mask on failure.
Signed-off-by: Jiadong Zhu
---
drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 15
drivers/gpu
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Lazar, Lijo
Sent: Tuesday, October 8, 2024 22:01
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Deucher, Alexander
; Bhardwaj, Rajneesh ;
Errabolu, Ram
On 10/9/2024 4:19 PM, Christian König wrote:
Am 09.10.24 um 10:48 schrieb Sunil Khatri:
Before making a function call to sw_init, validate
the function pointer.
Maybe add " like we do for hw_init." or some similar example of
optional callback.
Sure will update the commit message also
S
On 10/9/2024 4:21 PM, Christian König wrote:
Am 09.10.24 um 10:48 schrieb Sunil Khatri:
Remove the dummy sw_init functions and set the
corresponding functions to NULL.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 5 -
drivers/gpu/drm/amd/amdgpu/cik.c
Am 09.10.24 um 09:41 schrieb Tvrtko Ursulin:
On 08/10/2024 19:11, Christian König wrote:
Volatile only prevents the compiler from re-ordering reads and writes.
Since we always only modify the ring buffer from one CPU thread and have
an explicit barrier before signaling the HW this should have n
Am 09.10.24 um 10:22 schrieb Pierre-Eric Pelloux-Prayer:
Hi,
Le 05/10/2024 à 01:59, Mohammed Anees a écrit :
Before this patch, if multiple BO_HANDLES chunks were submitted,
the error -EINVAL would be correctly set but could be overwritten
by the return value from amdgpu_cs_p1_bo_handles(). Thi
Am 09.10.24 um 10:48 schrieb Sunil Khatri:
Remove the dummy sw_init functions and set the
corresponding functions to NULL.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 5 -
drivers/gpu/drm/amd/amdgpu/cik.c| 7 +--
drivers/gpu/drm/amd/amdgpu/si.c
Am 09.10.24 um 10:48 schrieb Sunil Khatri:
Before making a function call to sw_init, validate
the function pointer.
Maybe add " like we do for hw_init." or some similar example of optional
callback.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 +++-
Am 09.10.24 um 14:28 schrieb Mohammed Anees:
Before this patch, if multiple BO_HANDLES chunks were submitted,
the error -EINVAL would be correctly set but could be overwritten
by the return value from amdgpu_cs_p1_bo_handles(). This patch
ensures that if there are multiple BO_HANDLES, we stop.
C
Am 08.10.24 um 23:15 schrieb boyuan.zh...@amd.com:
From: Boyuan Zhang
For smu ip with multiple vcn instances (smu 11/13/14), remove all the
for loop in dpm_set_vcn_enable() functions. And use the instance
argument to power up/down vcn for the given instance only, instead
of powering up/down
On 10/9/2024 1:35 AM, Alex Deucher wrote:
It should be enabled on both bare metal and VFs.
Fixes: e189be9b2e38 ("drm/amdgpu: Add enforce_isolation sysfs attribute")
Signed-off-by: Alex Deucher
Cc: Srinivasan Shanmugam
Cc: Amber Lin
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 11 ---
On 10/9/2024 12:52 PM, jiadong@amd.com wrote:
> From: Jiadong Zhu
>
> Implement sdma queue reset callback via SMU interface.
>
> v2: Leverage inst_stop/start functions in reset sequence.
> Use GET_INST for physical SDMA instance.
> Disable apu for sdma reset.
> v3: Rephrase error
Fill pcie other end recovery counter to metrics 1.6
v2: Add separate function to check recovery counter support
Signed-off-by: Asad Kamal
---
.../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13
Update pmfw headers for smuv13.0.6 to version 0xE
Signed-off-by: Asad Kamal
---
drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h
b/drivers/gpu/drm/amd/p
Friendly ping on reviewing this series from the AMD side. Thanks!
On Thu, Aug 8, 2024 at 3:09 AM Bas Nieuwenhuizen
wrote:
> For the rationale see the earlier RFC by Faith:
> https://lists.freedesktop.org/archives/amd-gfx/2024-August/112273.html
>
> This mainly makes two changes:
>
> 1. Uses a su
Remove the dummy sw_init functions for all
IP blocks.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 6 --
drivers/gpu/drm/amd/amdgpu/cik.c| 6 --
drivers/gpu/drm/amd/amdgpu/si.c | 6 --
3 files changed, 18 deletions(-)
diff --git a/drivers
Remove the dummy sw_fini functions for all
ip blocks.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 6 --
drivers/gpu/drm/amd/amdgpu/cik.c| 6 --
drivers/gpu/drm/amd/amdgpu/nv.c | 6 --
drivers/gpu/drm/amd/amdgpu/si.c | 7 ---
d
Before making a function call to sw_fini, validate
the function pointer like we do in sw_init.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
Remove the dummy resume functions for all
ip blocks.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
index 9b98b40ac4db..1383fd1644d
Before making a function call to resume, validate
the function pointer like we do in sw_init.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/aldebaran.c | 23 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 47 -
drivers/gpu/drm/amd/amdgpu/sienna_cic
Before making a function call to wait_for_idle,
validate the function pointer like we do in sw_init.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
Before making a function call to sw_init, validate
the function pointer like we do in late_init.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b
Before making a function call to hw_fini, validate
the function pointer like we do in sw_init.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 26 +-
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu
Remove the dummy soft_reset functions for all
ip blocks.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 6 --
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 5 -
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 6 --
drivers/gpu/drm/amd/amdgp
Already working on that, but userqueues have pushed that back quite a bit.
Sorry,
Christian.
Am 09.10.24 um 16:17 schrieb Bas Nieuwenhuizen:
Friendly ping on reviewing this series from the AMD side. Thanks!
On Thu, Aug 8, 2024 at 3:09 AM Bas Nieuwenhuizen
wrote:
For the rationale see t
Before making a function call to suspend, validate
the function pointer like we do in sw_init.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/aldebaran.c | 15 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 26 -
drivers/gpu/drm/amd/amdgpu/amdgpu_
Remove the dummy hw_fini functions for all
ip blocks.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 6 --
drivers/gpu/drm/amd/amdgpu/cik.c | 6 --
drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 11 +--
drivers/gpu/drm/amd/amdgpu/si.c |
Remove the dummy wait_for_idle functions for all
ip blocks.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 6 --
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 5 -
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 6 --
drivers/gpu/drm/amd/am
Remove the dummy suspend functions for all
ip blocks.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 6 --
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/cik.c | 6 --
drivers/gpu/drm/amd/amdgpu/si.c | 6 --
4
This patch adds a boundary check for the hpd_source index during the
link encoder creation process for dcn3x IP's. The check ensures that the
index is within the valid range of the link_enc_hpd_regs array to
prevent out-of-bounds access.
Cc: Tom Chung
Cc: Rodrigo Siqueira
Cc: Roman Li
Cc: Alex
1 - 100 of 102 matches
Mail list logo
