On Tue Oct 1, 2024 at 2:32 PM PDT, John Rowley wrote:
> The attached patch seems to improve rendering performance a lot; animations
> and desktop performance are generally smoother again.
>
> But it doesn't seem 100%, e.g. if I let the laptop idle for 10 secs before
> interacting with the touchpa
On Mon, 30 Sep 2024, Thomas Zimmermann wrote:
> DRM's aperture functions have long been implemented as helpers
> under drivers/video/ for use with fbdev. Avoid the DRM wrappers by
> calling the video functions directly.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
Am 02.10.24 um 06:36 schrieb boyuan.zh...@amd.com:
From: Boyuan Zhang
The new function smu_dpm_set_vcn_enable_instance() will be used to enable
or disable vcn engine dynamic power for the given vcn instance only.
The original function smu_dpm_set_vcn_enable() will still be used to enable
or di
Am 02.10.24 um 06:36 schrieb boyuan.zh...@amd.com:
From: Boyuan Zhang
vcn gating state should now be based on instance. For example, instance 0
can be gated while instance 1 is ungated, or vice versa.
Therefore, change the cur_state to be an array, so that it can track the
gating status for ea
Am 02.10.24 um 06:36 schrieb boyuan.zh...@amd.com:
From: Boyuan Zhang
Pass ip_block instead of adev in set_powergating_state callback function.
Modify set_powergating_state ip functions for all correspoding ip blocks.
Signed-off-by: Boyuan Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
On Wed, Oct 2, 2024 at 12:38 AM wrote:
>
> From: Boyuan Zhang
>
> The new function dpm_set_vcn_enable_instance() will be used to enable
> or disable vcn engine dynamic power for the given vcn instance.
>
> The original function dpm_set_vcn_enable() will still be used to enable
> or disable vcn en
On Wed, Oct 2, 2024 at 12:39 AM wrote:
>
> From: Boyuan Zhang
>
> Add instance number to ip block to track which instance the ip block
> belongs to.
>
> Also, add a new function to allow ip block to save the instance number
> along with other ip block driver information.
>
> Signed-off-by: Boyuan
Patches 1, 3, 5 are:
Reviewed-by: Alex Deucher
On Wed, Oct 2, 2024 at 1:02 PM Srinivasan Shanmugam
wrote:
>
> This patch adds support for the PACKET3_RUN_CLEANER_SHADER packet in the
> gfx_v12_0 module. This packet is used to emit the cleaner shader, which
> is used to clear GPU memory before it
[Public]
> -Original Message-
> From: Vignesh Raman
> Sent: Tuesday, October 1, 2024 9:51 AM
> To: Deucher, Alexander ; Koenig, Christian
> ; Pan, Xinhui ; amd-
> g...@lists.freedesktop.org
> Cc: dani...@collabora.com; helen.ko...@collabora.com; airl...@gmail.com;
> dan...@ffwll.ch; robdc
On 2024-10-01 18:38, Xiaogang.Chen wrote:
From: Xiaogang Chen
This patch allows kfd driver function correctly when AMD gpu devices got
plug/unplug at run time.
When an AMD gpu device got unplug kfd driver gracefully terminates existing kfd
processes after stops all queues, sends SIGTERM to u
On 2024-09-30 02:35, Lang Yu wrote:
Only creating a new reference for each process instead of each VM.
Fixes: 9a1c1339abf9 ("drm/amdkfd: Run restore_workers on freezable WQs")
Suggested-by: Felix Kuehling
Signed-off-by: Lang Yu
Reviewed-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdgp
Disabling PSR as per Leo's reply seems to have done the trick!
Stock 6.12-rc1 (without revert): BROKEN
/sys/kernel/debug/dri/:c1:00.0/eDP-1/psr_state:
6
/sys/kernel/debug/dri/:c1:00.0/eDP-1/psr_capability:
Sink support: yes [0x03]
Driver support: yes
With amdgpu.dcde
The attached patch seems to improve rendering performance a lot; animations and
desktop performance are generally smoother again.
But it doesn't seem 100%, e.g. if I let the laptop idle for 10 secs before
interacting with the touchpad, the desktop cursor seems to stick in-place for
100-200ms or
Hello,
I have a new laptop with a 7840U and am running into the same problem on kernel
6.10.11 and 6.11.0. My symptoms are slightly different, in that video played
through Firefox works for some period before eventually having a GPU crash.
This can be anywhere from seconds to 10+ minutes, thoug
I was using power-profiles-daemon version 0.23 in balanced mode.
I also tested TLP, and vanilla kernel without any power daemons running.
Without any daemons I use the following:
energy_performance_preference: balance_power
scaling_driver: amd-pstate-epp
scaling_governor: powersave
Fix the html doc warning due to mix up of the
forward declaration of struct amdgpu_ip_block.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/include/amd_shared.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/include/amd_shared.h
b/drivers/gpu/dr
Am 02.10.24 um 11:26 schrieb Sunil Khatri:
Fix the html doc warning due to mix up of the
forward declaration of struct amdgpu_ip_block.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/include/amd_shared.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
ge-id: 20241002-tonyk-async_flip-828cfe9cf3ca
Best regards,
--
André Almeida
Currently, DRM atomic uAPI allows only primary planes to be flipped
asynchronously. However, each driver might be able to perform async
flips in other different plane types. To enable drivers to set their own
restrictions on which type of plane they can or cannot flip, use the
existing atomic_async
amdgpu can handle async flips on overlay planes, so allow it for atomic
async checks.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pla
On Wed, 02 Oct 2024, Thomas Hellström wrote:
> The ttm_device_init funcition uses multiple bool arguments. That means
> readability in the caller becomes poor, and all callers need to change if
> yet another bool is added.
>
> Instead use a struct with multiple single-bit flags. This addresses bot
Am 02.10.24 um 14:24 schrieb Thomas Hellström:
The ttm_device_init funcition uses multiple bool arguments. That means
readability in the caller becomes poor, and all callers need to change if
yet another bool is added.
Instead use a struct with multiple single-bit flags. This addresses both
prob
Applied. Thanks!
Alex
On Wed, Oct 2, 2024 at 9:28 AM Igor Artemiev wrote:
>
> amdgpu_irq_ad_id() may fail and the irq handlers will not be registered.
> This patch adds error code check.
>
> Found by Linux Verification Center (linuxtesting.org) with static
> analysis tool SVACE.
>
> Signed-off-
Applied. Thanks!
On Wed, Oct 2, 2024 at 3:51 AM Colin Ian King wrote:
>
> There is a spelling mistake in a dev_err message. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/driver
From: Ville Syrjälä
An attempt to hide the drm_plane/crtc legacy state better.
This also highlights the fact that a lot of supposedly
atomic drivers are poking around in the legacy crtc state,
which is rather questionable. For planes we did force the
legacy state to NULL already to force drivers
From: Ville Syrjälä
Hide the plane->fb/etc. footguns better by stashing them inside
a "legacy" sub struct.
Eventually maybe we could turn 'legacy' into a pointer
that only exists on legacy drivers to completely prevent
any abuse by atomic drivers...
Side note: _dpu_plane_set_danger_state() look
From: Ville Syrjälä
Atomic drivers shouldn't be using the legacy state stored
directly under drm_crtc. Move that junk into a 'legacy' sub
structure to highlight the offenders, of which there are
quite a few unfortunately.
I'm hoping we could get all these fixed and then declare
the legacy state
The Kconfig token DRM_CLIENT_SELECTION will make DRM clients
available to drivers. Select it from i915.
Signed-off-by: Thomas Zimmermann
Cc: Jani Nikula i
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git
A number of DRM-client functions serve as entry points from device
operations to client code. Moving them info a separate file will later
allow for a more fine-grained kernel configuration. For most of the
users it is sufficient to include instead of
the full driver-side interface in
v2:
- renam
The Kconfig token DRM_CLIENT_SELECTION will make DRM clients
available to drivers. Select it from xe.
Signed-off-by: Thomas Zimmermann
Cc: Lucas De Marchi
Cc: "Thomas Hellström"
Cc: Rodrigo Vivi
---
drivers/gpu/drm/xe/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm
With the next DRM client coming soon (drm_log) and most of DRM's
fbdev emulation consolidated in a few places, it's time to provide
a single place for the clients.
The new module drm_client_lib.ko stores most of the in-kernel client
code. It is designed such that drivers can opt into client suppor
If you're referring to the Freedesktop DRM issue then sinatosk a separate
poster. I'm not involved in that thread. 🙂
From: Christopher Snowhill
To: John Rowley ; Mario Limonciello
; Leo Li ; Hamza Mahfooz
CC: Harry Wentland ; Rodrigo Siqueira
; amd-gf
Some graphics APIs differentiate between out-of-graphics-memory and
out-of-host-memory (system memory). Add a device init flag to
have -ENOSPC propagated from the resource managers instead of being
converted to -ENOMEM, to aid driver stacks in determining what
error code to return or whether correc
amdgpu_irq_ad_id() may fail and the irq handlers will not be registered.
This patch adds error code check.
Found by Linux Verification Center (linuxtesting.org) with static
analysis tool SVACE.
Signed-off-by: Igor Artemiev
---
v2: Remove the cast to struct amdgpu_device as Christian König
sugg
There is a spelling mistake in a dev_err message. Fix it.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
index b17e
Some graphics APIs differentiate between out-of-graphics-memory and
out-of-host-memory (system memory). Add a device init flag to
have -ENOSPC propagated from the resource managers instead of being
converted to -ENOMEM, to aid driver stacks in determining what
error code to return or whether correc
The ttm_device_init funcition uses multiple bool arguments. That means
readability in the caller becomes poor, and all callers need to change if
yet another bool is added.
Instead use a struct with multiple single-bit flags. This addresses both
problems. Prefer it over using defines or enums with
On Wed, 2024-10-02 at 14:45 +0200, Christian König wrote:
> Am 02.10.24 um 14:24 schrieb Thomas Hellström:
> > The ttm_device_init funcition uses multiple bool arguments. That
> > means
> > readability in the caller becomes poor, and all callers need to
> > change if
> > yet another bool is added.
On Mon, Sep 30, 2024 at 03:03:00PM +0200, Thomas Zimmermann wrote:
> DRM's aperture functions have long been implemented as helpers
> under drivers/video/ for use with fbdev. Avoid the DRM wrappers by
> calling the video functions directly.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Liviu Dudau
On Wed, Oct 2, 2024 at 12:41 AM Srinivasan Shanmugam
wrote:
>
> The patch modifies the gfx_v10_0_kiq_set_resources function to write
> the cleaner shader's memory controller address to the ring buffer. It
> also adds a new function, gfx_v10_0_ring_emit_cleaner_shader, which
> emits the PACKET3_RUN
On Wed, Oct 2, 2024 at 12:41 AM Srinivasan Shanmugam
wrote:
>
> The patch modifies the gfx_v11_0_kiq_set_resources function to write
> the cleaner shader's memory controller address to the ring buffer. It
> also adds a new function, gfx_v11_0_ring_emit_cleaner_shader, which
> emits the PACKET3_RUN
On Wed, Oct 2, 2024 at 12:58 AM Srinivasan Shanmugam
wrote:
>
> This commit applies isolation enforcement to the GFX and Compute rings
> in the gfx_v10_0 module.
>
> The commit sets `amdgpu_gfx_enforce_isolation_ring_begin_use` and
> `amdgpu_gfx_enforce_isolation_ring_end_use` as the functions to
On Wed, Oct 2, 2024 at 12:41 AM Srinivasan Shanmugam
wrote:
>
> This commit applies isolation enforcement to the GFX and Compute rings
> in the gfx_v11_0 module.
>
> The commit sets `amdgpu_gfx_enforce_isolation_ring_begin_use` and
> `amdgpu_gfx_enforce_isolation_ring_end_use` as the functions to
On Wed, Oct 2, 2024 at 12:53 AM Srinivasan Shanmugam
wrote:
>
> This commit applies isolation enforcement to the GFX and Compute rings
> in the gfx_v12_0 module.
>
> The commit sets `amdgpu_gfx_enforce_isolation_ring_begin_use` and
> `amdgpu_gfx_enforce_isolation_ring_end_use` as the functions to
On Wed, Oct 2, 2024 at 12:58 AM Srinivasan Shanmugam
wrote:
>
> This patch adds support for the PACKET3_RUN_CLEANER_SHADER packet in the
> gfx_v12_0 module. This packet is used to emit the cleaner shader, which
> is used to clear GPU memory before it's reused, helping to prevent data
> leakage bet
The patch modifies the gfx_v10_0_kiq_set_resources function to write
the cleaner shader's memory controller address to the ring buffer. It
also adds a new function, gfx_v10_0_ring_emit_cleaner_shader, which
emits the PACKET3_RUN_CLEANER_SHADER packet to the ring buffer.
This patch adds support for
This patch adds support for the PACKET3_RUN_CLEANER_SHADER packet in the
gfx_v12_0 module. This packet is used to emit the cleaner shader, which
is used to clear GPU memory before it's reused, helping to prevent data
leakage between different processes.
Finally, the patch updates the ring function
The patch modifies the gfx_v11_0_kiq_set_resources function to write
the cleaner shader's memory controller address to the ring buffer. It
also adds a new function, gfx_v11_0_ring_emit_cleaner_shader, which
emits the PACKET3_RUN_CLEANER_SHADER packet to the ring buffer.
This patch adds support for
[AMD Official Use Only - AMD Internal Distribution Only]
> -Original Message-
> From: James Alseth
> Sent: Wednesday, October 2, 2024 12:14 AM
> To: Koenig, Christian
> Cc: Pan, Xinhui ; Deucher, Alexander
> ; Amd Gfx ;
> Regressions ; Sigmaepsilon92
>
> Subject: Re: 7840U amdgpu MMVM_L
Replace calls to drm_fb_helper_set_suspend() with calls to the client
functions drm_client_dev_suspend() and drm_client_dev_resume(). Any
registered in-kernel client will now receive suspend and resume events.
Signed-off-by: Thomas Zimmermann
Cc: Alex Deucher
Cc: "Christian König"
Cc: Xinhui Pa
Fbdev emulation for SHMEM and TTM requires helpers from the fbdev
subsystem. Select them from the modules that use them instead of the
core DRM module.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/d
Replace calls to drm_fb_helper_set_suspend_unlocked() with calls
to the client functions drm_client_dev_suspend() and
drm_client_dev_resume(). Any registered in-kernel client will now
receive suspend and resume events.
Signed-off-by: Thomas Zimmermann
Cc: Karol Herbst
Cc: Lyude Paul
Cc: Danilo
Replace calls to drm_fb_helper_set_suspend_unlocked() with calls
to the client functions drm_client_dev_suspend() and
drm_client_dev_resume(). Any registered in-kernel client will now
receive suspend and resume events.
Signed-off-by: Thomas Zimmermann
Cc: Alex Deucher
Cc: "Christian König"
Cc:
Suspend and resume is still tied to fbdev emulation. Modeset helpers
and several drivers call drm_fb_helper_set_suspend_unlocked() to inform
the fbdev client about suspend/resume events.
To make it work with arbitrary clients, add per-client callback
functions for suspend and resume. Implement the
Add drm_client_lib.ko to contain DRM's built-in client. Move the
existing client for fbdev emulation into the new module. Protect the
new module behind CONFIG_DRM_CLIENT_LIB.
The Kconfig rules separate the DRM drivers from the DRM clients. A
driver can opt into the default clients, but the user co
Only build client code if DRM_CLIENT has been selected. Automatially
do so if one of the default clients has been enabled. If client support
has been disabled, the helpers for client-related events are empty and
the regular client functions are not present.
Amdgpu has an internal DRM client, so it
The fbdev code does not really belong into drm_kms_helper.ko. But
there are module parameters that control the behavior of the fbdev
emulation. It is not possible to remove them from the module without
breaking someone's installation.
Therefore move the fbdev module parameters to drm_kms_helper_co
Am 02.10.24 um 14:24 schrieb Thomas Hellström:
Some graphics APIs differentiate between out-of-graphics-memory and
out-of-host-memory (system memory). Add a device init flag to
have -ENOSPC propagated from the resource managers instead of being
converted to -ENOMEM, to aid driver stacks in determ
Hi Dave, Simona,
Fixes for 6.12.
The following changes since commit d7d2688bf4ea58734d73e18edcbf4684b1496d30:
drm/amd/pm: update workload mask after the setting (2024-09-26 17:05:10 -0400)
are available in the Git repository at:
https://gitlab.freedesktop.org/agd5f/linux.git
tags/amd-drm-
htmldoc geenration depend upon the input arguments etc
to generate the document. After update of handle to
ip_block then update needs in comments too to fix the
warnings.
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202410021904.yygjlpk9-...@intel.com
Signed-off-b
Am 02.10.24 um 16:00 schrieb Sunil Khatri:
htmldoc geenration depend upon the input arguments etc
to generate the document. After update of handle to
ip_block then update needs in comments too to fix the
warnings.
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202
On Wed, Oct 2, 2024 at 8:24 AM Thomas Hellström
wrote:
>
> The ttm_device_init funcition uses multiple bool arguments. That means
> readability in the caller becomes poor, and all callers need to change if
> yet another bool is added.
>
> Instead use a struct with multiple single-bit flags. This a
62 matches
Mail list logo
