Re: [PATCH] drm/amdgpu: simplify vram alloc logic since 2GB limitation removed

2024-09-27 Thread Christian König
Arun please take a look at that. Looks valid to me in general. Thanks, Christian. Am 23.09.24 um 10:19 schrieb Yifan Zhang: Make vram alloc loop simpler after 2GB limitation removed. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 15 +-- 1 file c

Re: [PATCH v4 0/6] DRM_SET_CLIENT_NAME ioctl

2024-09-27 Thread Christian König
Am 27.09.24 um 10:48 schrieb Pierre-Eric Pelloux-Prayer: v4 changelog: * DRM_SET_NAME -> DRM_SET_CLIENT_NAME (Dmitry) * reject names that would mess up with formatting (Sima), and use a stricter filter (isgraph allowed extended ASCII which weren't looking great) * documentation edits, minor

Re: [PATCH v2 0/7] Add support for dynamic NPS switch

2024-09-27 Thread Xu, Feifei
Series is Reviewed-by: Feifei Xu On 9/27/2024 12:52 PM, Lijo Lazar wrote: This series adds supports for dynamic NPS switch on GC v9.4.3/9.4.4 SOC variants. In order to do dynamic NPS switch a sysfs interface is provided to request a new NPS mode. If the device is part of a hive, all hive devic

Re: [PATCH v5 47/80] drm/xlnx: Run DRM default client setup

2024-09-27 Thread Tomi Valkeinen
On 24/09/2024 10:12, Thomas Zimmermann wrote: Call drm_client_setup_with_fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION v2: - use drm_client_setup_with_

Re: [PATCH v5 79/80] drm/omapdrm: Remove struct drm_fb_helper from struct omap_fbdev.

2024-09-27 Thread Tomi Valkeinen
Hi, On 24/09/2024 10:13, Thomas Zimmermann wrote: Store instances of drm_fb_helper and struct omap_fbdev separately. This will allow omapdrm to use the common fbdev client, which allocates its own instance of struct drm_fb_helper. There is at most one instance of each per DRM device, so both ca

Re: [PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-27 Thread Tvrtko Ursulin
On 26/09/2024 09:15, Philipp Stanner wrote: On Mon, 2024-09-23 at 15:35 +0100, Tvrtko Ursulin wrote: Ping Christian and Philipp - reasonably happy with v2? I think it's the only unreviewed patch from the series. Howdy, sry for the delay, I had been traveling. I have a few nits below regar

Re: [PATCH v5 80/80] drm/omapdrm: Run DRM default client setup

2024-09-27 Thread Tomi Valkeinen
On 24/09/2024 10:13, Thomas Zimmermann wrote: Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the

Re: [PATCH] drm/amdgpu: fix PTE copy corruption for sdma 7

2024-09-27 Thread Alex Deucher
On Thu, Sep 26, 2024 at 4:43 AM Min, Frank wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > From: Frank Min > > Without setting dcc bit, there is ramdon PTE copy corruption on sdma 7. > > so add this bit and update the packet format accordingly. > > Signed-off-by: Frank Min

Re: [PATCH v4 0/6] DRM_SET_CLIENT_NAME ioctl

2024-09-27 Thread Jani Nikula
On Fri, 27 Sep 2024, Christian König wrote: > Am 27.09.24 um 10:48 schrieb Pierre-Eric Pelloux-Prayer: >> v4 changelog: >> * DRM_SET_NAME -> DRM_SET_CLIENT_NAME (Dmitry) >> * reject names that would mess up with formatting (Sima), >>and use a stricter filter (isgraph allowed extended ASCII >>

[PATCH v1 1/5] drm/amdgpu: update the handle ptr in early_init

2024-09-27 Thread Sunil Khatri
update the handle ptr to amdgpu_ip_block ptr for all functions pointers on early_init. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 6 -- drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 5 +++

[PATCH v1 0/5] Update the *handle with ip_block ptr

2024-09-27 Thread Sunil Khatri
Update for function ptrs early_init, late_init, sw_init, sw_fini, early_fini Sunil Khatri (5): drm/amdgpu: update the handle ptr in early_init drm/amdgpu: update the handle ptr in late_init drm/amdgpu: update the handle ptr in sw_init drm/amdgpu: update the handle ptr in sw_fini drm/am

Re: [PATCH v3] docs/gpu: ci: update flake tests requirements

2024-09-27 Thread Rodrigo Vivi
On Fri, Sep 27, 2024 at 10:54:14AM +0530, Vignesh Raman wrote: > Update the documentation to specify linking to a relevant GitLab > issue or email report for each new flake entry. Added specific > GitLab issue urls for i915, msm and amdgpu driver. > > Acked-by: Abhinav Kumar # msm > Acked-by: Dmi

Re: [PATCH v2] drm/amdgpu/gfx9: Convert `//` to `/* ... */` in cleaner shader code

2024-09-27 Thread Christian König
Am 25.09.24 um 21:45 schrieb Felix Kuehling: On 2024-09-04 07:03, Christian König wrote: It could be that the automated testing tools will run amok on that. I need to ask Felix for details but I think the code for the CWSR trap handlers were converted to C style comments as well because of t

[PATCH 06/13] drm/amd/display: Introduce New ABC Framework for Brightness Control

2024-09-27 Thread Fangzhi Zuo
From: Muyuan Yang Adjust the existing brightness control functions to use the new ABC Framework and prioritize Aux-based brightness control. Reviewed-by: Anthony Koo Signed-off-by: Muyuan Yang Signed-off-by: Fangzhi Zuo --- .../link/protocols/link_edp_panel_control.c | 40 +

[PATCH 03/13] drm/amd/display: Add logs to record register read/write

2024-09-27 Thread Fangzhi Zuo
From: Paul Hsieh [Why] There are some issues which customer only can provide full dump for analyze, without register history, it's hard to debug HW status. [How] 1. Put register read/write into WPP log so we can trace the logs from full memory dump. 2. MALL doesn't add into WPP, add it. Reviewe

[PATCH 07/13] drm/amd/display: Remove always-false branches

2024-09-27 Thread Fangzhi Zuo
From: Alex Hung [WHAT & HOW] MacroTileSizeBytes is set to either 256 or 65535 and it is never 4096. Its branch is not taken, and should be removed. Similarly, mode_422 is always 0 and thus ppe will always be 1. The ternary operator should be removed. This fixes 2 DEADCODE issues reported by Cove

[PATCH 04/13] drm/amd/display: add more support for UHBR10 eDP

2024-09-27 Thread Fangzhi Zuo
From: "Liu Xi (Alex)" [Why and how] The current UHBR10 eDP panel has new security feature update. Add support for the new FW Reviewed-by: Wenjing Liu Signed-off-by: Liu Xi (Alex) Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/dc.h| 1 - .../drm/am

[PATCH 05/13] drm/amd/display: Change Brightness Control Priority

2024-09-27 Thread Fangzhi Zuo
From: Muyuan Yang Prioritize Aux-based over PWM-based brightness control for more types of panels and introduce a new structure to store and manage the type of brightness control used. Reviewed-by: Anthony Koo Signed-off-by: Muyuan Yang Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/disp

Re: [PATCH v7 00/10] drm/amd/display: Use drm_edid for more code

2024-09-27 Thread Alex Hung
Hi Mario and Melissa, There are three regressions identified during the test, and improvement is required before the patches can be merged. Please see details below. 1. null pointer when hot-plugging a dsc hub (+ three 4k60 monitors). This may point to "drm/amd/display: use drm_edid_product_i

[PATCH 10/13] drm/amd/display: Add IPS residency capture helpers to dc_dmub_srv

2024-09-27 Thread Fangzhi Zuo
From: Ovidiu Bunea This enables starting and stopping IPS residency measurements and querying the IPS residency information consisting of residency percent, entry counter, total time active & inactive, and histograms for the specified IPS mode. Reviewed-by: Nicholas Kazlauskas Reviewed-by: Aric

[PATCH 00/13] DC Patches Sept 23, 2024

2024-09-27 Thread Fangzhi Zuo
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Improve brightness control * Add support for UHBR10 eDP * OPTC required only for DTBCLK_P for dcn401 * Fix TBT monitor resume issue * Code cleanup Cc: Daniel Wheeler Alex Hung (3): drm/amd/display: Remove alwa

[PATCH 09/13] drm/amd/display: Removed unused assignments and variables

2024-09-27 Thread Fangzhi Zuo
From: Alex Hung [WHAT] A number of values are assigned to variables but the stored values are not used afterwards. [HOW] The assignments are removed. If the variables are not used, they are removed as well. This fixes 9 UNUSED_VALUE issues reported by Coverity. Reviewed-by: Rodrigo Siqueira S

Re: [PATCH 0/5] drm: Introduce DRM client library

2024-09-27 Thread Felix Kuehling
On 2024-09-27 10:37, Thomas Zimmermann wrote: With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it's time to provide a single place for the clients. The new module drm_client_lib.ko stores most of the common client code. It's designe

Re: [PATCH v7 00/10] drm/amd/display: Use drm_edid for more code

2024-09-27 Thread Alex Hung
On 9/27/24 14:45, Melissa Wen wrote: Hi Alex, Thanks for the intensive testing. I'll need some time to reproduce and debug these regressions. So, we can divide this series into four steps: 1-2 are the basis for drm_edid migration 3-4 are code cleanups 5-9 are drm_edid_product_id migration 1

Re: [PATCH v5 42/80] drm/tilcdc: Run DRM default client setup

2024-09-27 Thread Tomi Valkeinen
On 24/09/2024 10:12, Thomas Zimmermann wrote: Call drm_client_setup_with_color_mode() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION v3: - add DRM_FBDEV_DMA_DRIV

[PATCH -next] drm/amdkfd: Remove the redundant parameter comments in function get_wave_count

2024-09-27 Thread Jiapeng Chong
This commit updates described non-existent parameters 'wave_cnt' and 'vmid', and failed to describe the existing 'queue_cnt' parameter. drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c:954: warning: Excess function parameter 'vmid' description in 'get_wave_count'. drivers/gpu/drm/amd/amdgpu/amdg

[PATCH v1 3/5] drm/amdgpu: update the handle ptr in sw_init

2024-09-27 Thread Sunil Khatri
update the *handle to amdgpu_ip_block ptr for all functions pointers of sw_init. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 2 +- drivers

Re: [PATCH v1 1/5] drm/amdgpu: update the handle ptr in early_init

2024-09-27 Thread Khatri, Sunil
On 9/27/2024 5:51 PM, Christian König wrote: Am 27.09.24 um 11:57 schrieb Sunil Khatri: update the handle ptr to amdgpu_ip_block ptr for all functions pointers on early_init. Signed-off-by: Sunil Khatri ---   drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c   | 2 +-   drivers/gpu/drm/amd/amdg

Re: AMD Radeon out of memory causes system instability.

2024-09-27 Thread Christian König
Am 05.08.24 um 08:02 schrieb James Lawrence: Apologies if I'm hitting the wrong mailing list. long time user, first time reporter and all that. Sorry for the delayed reply  Without a maintainer in CC such requests are usually overlooked on the mailing list. recently my system has been suff

[PATCH 02/13] drm/amd/display: Fix system hang while resume with TBT monitor

2024-09-27 Thread Fangzhi Zuo
From: Tom Chung [Why] Connected with a Thunderbolt monitor and do the suspend and the system may hang while resume. The TBT monitor HPD will be triggered during the resume procedure and call the drm_client_modeset_probe() while struct drm_connector connector->dev->master is NULL. It will mess u

[PATCH 01/13] drm/amd/display: Adjust PHY FSM transition to TX_EN-to-PLL_ON for TMDS

2024-09-27 Thread Fangzhi Zuo
From: Ryan Seto [Why] If two monitors with TMDS signals were timing synced and one was disconnected, the stream would go out of sync too early due to the PLL turning off and the system could hang [How] On link disable output, change PHY FSM transition from TX_EN-to-PHY_OFF to TX_EN-to-PLL_ON for

[PATCH 11/13] drm/amd/display: Configure DTBCLK_P with OPTC only for dcn401

2024-09-27 Thread Fangzhi Zuo
From: Dillon Varone [WHY] DTBCLK_P is used to generate virtual pixel clock, and to drive the HPO stream encoder clock. Programming the required clock when enabling/disabling both components can cause issues. For example, if HPO is being disabled and clock source is changed to REFCLK, virtual pixe

[PATCH 08/13] drm/amd/display: Eliminate recursive header inclusion

2024-09-27 Thread Fangzhi Zuo
From: Alex Hung [WHAT & HOW] This removes recursive inclusion like dc.h -> dc_state.h -> dc.h and dc.h -> dc_plane.h -> dc.h This fixes 4 PW.INCLUDE_RECURSION issues reported by Coverity. Reviewed-by: Rodrigo Siqueira Signed-off-by: Alex Hung Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/a

Re: [PATCH v7 00/10] drm/amd/display: Use drm_edid for more code

2024-09-27 Thread Melissa Wen
Hi Alex, Thanks for the intensive testing. I'll need some time to reproduce and debug these regressions. So, we can divide this series into four steps: 1-2 are the basis for drm_edid migration 3-4 are code cleanups 5-9 are drm_edid_product_id migration 10 is for ACPI EDID feature. Bearing this

RE: [PATCH 1/2] drm/amd/display: increase max surfaces in line with planes and streams

2024-09-27 Thread Mohamed, Zaeem
[AMD Official Use Only - AMD Internal Distribution Only] Hi Melissa, MAX_SURFACE_NUM and MAX_PLANES both represent the upper bound of planes that are supported by HW. It is best to replace MAX_SURFACE_NUM with MAX_PLANES to remove redundancy. MAX_SURFACES is used to represent the upper bound of

Re: [PATCH 1/2] drm/amd/display: increase max surfaces in line with planes and streams

2024-09-27 Thread Melissa Wen
Hi Zaeem, Thanks for explaining their relationship. So IIUC, current DM implementation for dc_surface_updates array is wrong, since it's taking MAX_SURFACES (=3) for allocation but MAX_PLANES (=6) as the upper bound of size of the dc_surface_updates array, as you can see in this allocation an

Re: [PATCH] drm/amdkfd: Fix an eviction fence leak

2024-09-27 Thread Felix Kuehling
On 2024-09-27 06:36, Lang Yu wrote: dma_fence_get/put() should be called balanced in init_kfd_vm() and amdgpu_amdkfd_gpuvm_destroy_cb(). I don't think that's correct. The reference taken in init_kfd_vm is returned to the caller of amdgpu_amdkfd_gpuvm_acquire_process_vm, which gets stored in

[pull] amdgpu, amdkfd drm-fixes-6.12

2024-09-27 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.12. The following changes since commit 84f76408abe989809de19d02e476b044fd985adc: drm/amdgpu/mes12: reduce timeout (2024-09-18 16:15:13 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.12-2024-09

Re: [PATCH v3] docs/gpu: ci: update flake tests requirements

2024-09-27 Thread Maxime Ripard
On Fri, 27 Sep 2024 10:54:14 +0530, Vignesh Raman wrote: > Update the documentation to specify linking to a relevant GitLab > issue or email report for each new flake entry. Added specific > GitLab issue urls for i915, msm and amdgpu driver. > > Acked-by: Abhinav Kumar # msm > > [ ... ] Acked-b

RE: [PATCH v1 0/9] drm/amd/pm runtime pm changes

2024-09-27 Thread Feng, Kenneth
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Kenneth Feng -Original Message- From: Pelloux-Prayer, Pierre-Eric Sent: Wednesday, September 25, 2024 3:54 PM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Feng, Kenneth ; Limonciello, Mario Cc

[PATCH] drm/amdkfd: Fix an eviction fence leak

2024-09-27 Thread Lang Yu
dma_fence_get/put() should be called balanced in init_kfd_vm() and amdgpu_amdkfd_gpuvm_destroy_cb(). Fixes: 9a1c1339abf9 ("drm/amdkfd: Run restore_workers on freezable WQs") Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 01/13] drm/amd/display: Adjust PHY FSM transition to TX_EN-to-PLL_ON for TMDS

2024-09-27 Thread Fangzhi Zuo
From: Ryan Seto [Why] If two monitors with TMDS signals were timing synced and one was disconnected, the stream would go out of sync too early due to the PLL turning off and the system could hang [How] On link disable output, change PHY FSM transition from TX_EN-to-PHY_OFF to TX_EN-to-PLL_ON for

[PATCH v4 0/6] DRM_SET_CLIENT_NAME ioctl

2024-09-27 Thread Pierre-Eric Pelloux-Prayer
v4 changelog: * DRM_SET_NAME -> DRM_SET_CLIENT_NAME (Dmitry) * reject names that would mess up with formatting (Sima), and use a stricter filter (isgraph allowed extended ASCII which weren't looking great) * documentation edits, minor fixups (Dmitry, Trvtko) * clarified commit message of commit

[PATCH v4 6/6] drm/amdgpu: use drm_file::name in task_info::process_desc

2024-09-27 Thread Pierre-Eric Pelloux-Prayer
If a drm_file name is set append it to the process name. This information is useful with the virtio/native-context driver: this allows the guest applications identifier to visible in amdgpu's output. The output in amdgpu_vm_info/amdgpu_gem_info looks like this: pid:12255Process:glxgears/te

[PATCH v4 5/6] drm/amdgpu: make process_name a flexible array

2024-09-27 Thread Pierre-Eric Pelloux-Prayer
And rename it process_desc, since it will soon contain more than just the process_name. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c

[PATCH v4 3/6] drm/amdgpu: delay the use of amdgpu_vm_set_task_info

2024-09-27 Thread Pierre-Eric Pelloux-Prayer
At the point the VM is locked (through the root PDs dma_resv object), so it's safer to call amdgpu_vm_set_task_info. The original place was not protected against concurrent access, but the risk was limited to mangled process/task name. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/d

[PATCH v4 4/6] drm/amdgpu: alloc and init vm::task_info from first submit

2024-09-27 Thread Pierre-Eric Pelloux-Prayer
This will allow to use flexible array to store the process name and other information. This also means that process name will be determined once and for all, instead of at each submit. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 29

[PATCH v4 2/6] drm: use drm_file client_name in fdinfo

2024-09-27 Thread Pierre-Eric Pelloux-Prayer
Add an optional drm-client-name field to drm fdinfo's output. Reviewed-by: Christian König Reviewed-by: Tvrtko Ursulin Signed-off-by: Pierre-Eric Pelloux-Prayer --- Documentation/gpu/drm-usage-stats.rst | 5 + drivers/gpu/drm/drm_file.c| 5 + 2 files changed, 10 insertions(

[PATCH v4 1/6] drm: add DRM_SET_CLIENT_NAME ioctl

2024-09-27 Thread Pierre-Eric Pelloux-Prayer
Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debugging. This is similar to the existing DMA_BUF_SET_NAME ioctl. Access to client_name is protected by a mutex, and the 'clients' debugfs file has been updated to print it. User

[PATCH v1 5/5] drm/amdgpu: update the handle ptr in early_fini

2024-09-27 Thread Sunil Khatri
Update the *handle to amdgpu_ip_block ptr for all functions pointers of early_fini. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- drivers/gpu/drm/amd/include/amd_shared.h | 2 +- 3 fi

[PATCH v1 4/5] drm/amdgpu: update the handle ptr in sw_fini

2024-09-27 Thread Sunil Khatri
update the *handle to amdgpu_ip_block ptr for all functions pointers of sw_fini. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 2 +- drivers

[PATCH v1 2/5] drm/amdgpu: update the handle ptr in late_init

2024-09-27 Thread Sunil Khatri
Update the ptr handle to amdgpu_ip_block ptr in all the functions of late_init function ptr. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/aldebaran.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c |

RE: [PATCH v1 5/9] drm/amd/pm: use pm_runtime_get_if_active for debugfs getters

2024-09-27 Thread Feng, Kenneth
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Pelloux-Prayer, Pierre-Eric Sent: Wednesday, September 25, 2024 3:54 PM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Feng, Kenneth ; Limonciello, Mario Cc: Pelloux-Prayer, Pierre-Eric Subject:

Re: [PATCH v1 1/5] drm/amdgpu: update the handle ptr in early_init

2024-09-27 Thread Christian König
Am 27.09.24 um 11:57 schrieb Sunil Khatri: update the handle ptr to amdgpu_ip_block ptr for all functions pointers on early_init. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 6 -- drivers/g

[PATCH 3/5] drm: Move client-device functions in to drm_client_dev.c

2024-09-27 Thread Thomas Zimmermann
A number of DRM-client functions serve as entry points from device operations to client code. Move them info a separate file, so that the other client functions can be moved into a different module. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/drm-client.rst | 3 + drivers/gpu/drm/Ma

[PATCH 5/5] drm: Add client-lib module

2024-09-27 Thread Thomas Zimmermann
Add drm_client_lib.ko to contain most of the client code. Move the existing client for fbdev emulation into the new module. Protect the new module behind CONFIG_DRM_CLIENT. The Kconfig rules separate the DRM drivers from the DRM clients. A driver can opt into the default clients, but the user conf

[PATCH v2 3/5] drm/amdgpu: update the handle ptr in sw_init

2024-09-27 Thread Sunil Khatri
update the *handle to amdgpu_ip_block ptr for all functions pointers of sw_init. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 2 +- drivers

[PATCH v2 5/5] drm/amdgpu: update the handle ptr in early_fini

2024-09-27 Thread Sunil Khatri
Update the *handle to amdgpu_ip_block ptr for all functions pointers of early_fini. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- drivers/gpu/drm/amd/include/amd_shared.h | 2 +- 3 fi

[PATCH v2 4/5] drm/amdgpu: update the handle ptr in sw_fini

2024-09-27 Thread Sunil Khatri
update the *handle to amdgpu_ip_block ptr for all functions pointers of sw_fini. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 2 +- drivers

[PATCH 2/5] drm/xe: Select DRM_CLIENT_SELECTION

2024-09-27 Thread Thomas Zimmermann
The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from xe. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/xe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig index ebd0879e04d4..ba

[PATCH 1/5] drm/i915: Select DRM_CLIENT_SELECTION

2024-09-27 Thread Thomas Zimmermann
The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from i915. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index db400aad

Re: [PATCH v5 79/80] drm/omapdrm: Remove struct drm_fb_helper from struct omap_fbdev.

2024-09-27 Thread Thomas Zimmermann
Hi Am 26.09.24 um 15:07 schrieb Tomi Valkeinen: Hi, On 24/09/2024 10:13, Thomas Zimmermann wrote: Store instances of drm_fb_helper and struct omap_fbdev separately. This will allow omapdrm to use the common fbdev client, which allocates its own instance of struct drm_fb_helper. There is at mo

[PATCH v2 1/5] drm/amdgpu: update the handle ptr in early_init

2024-09-27 Thread Sunil Khatri
update the handle ptr to amdgpu_ip_block ptr for all functions pointers on early_init. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 24 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 5

Re: [PATCH v1 1/5] drm/amdgpu: update the handle ptr in early_init

2024-09-27 Thread Khatri, Sunil
On 9/27/2024 7:26 PM, Khatri, Sunil wrote: On 9/27/2024 5:51 PM, Christian König wrote: Am 27.09.24 um 11:57 schrieb Sunil Khatri: update the handle ptr to amdgpu_ip_block ptr for all functions pointers on early_init. Signed-off-by: Sunil Khatri ---   drivers/gpu/drm/amd/amdgpu/amdgpu_acp.

[PATCH 4/5] drm: Select fbdev helpers for modules that require them

2024-09-27 Thread Thomas Zimmermann
Fbdev emulation for SHMEM and TTM requires helpers from the fbdev subsystem. Select them from the modules that use them instead of the core DRM module. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/d

[PATCH 02/13] drm/amd/display: Fix system hang while resume with TBT monitor

2024-09-27 Thread Fangzhi Zuo
From: Tom Chung [Why] Connected with a Thunderbolt monitor and do the suspend and the system may hang while resume. The TBT monitor HPD will be triggered during the resume procedure and call the drm_client_modeset_probe() while struct drm_connector connector->dev->master is NULL. It will mess u

[PATCH 03/13] drm/amd/display: Add logs to record register read/write

2024-09-27 Thread Fangzhi Zuo
From: Paul Hsieh [Why] There are some issues which customer only can provide full dump for analyze, without register history, it's hard to debug HW status. [How] 1. Put register read/write into WPP log so we can trace the logs from full memory dump. 2. MALL doesn't add into WPP, add it. Reviewe

[PATCH 12/13] drm/amd/display: [FW Promotion] Release 0.0.236.0

2024-09-27 Thread Fangzhi Zuo
From: Taimur Hassan Signed-off-by: Taimur Hassan Signed-off-by: Fangzhi Zuo --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 62 +-- 1 file changed, 57 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/

[PATCH 13/13] drm/amd/display: 3.2.303

2024-09-27 Thread Fangzhi Zuo
From: Aric Cyr DC 3.2.303 contains some improvements as summarized below: * Improve brightness control * Add support for UHBR10 eDP * OPTC required only for DTBCLK_P for dcn401 * Fix TBT monitor resume issue * Code cleanup Signed-off-by: Aric Cyr Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm

[PATCH 0/5] drm: Introduce DRM client library

2024-09-27 Thread Thomas Zimmermann
With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it's time to provide a single place for the clients. The new module drm_client_lib.ko stores most of the common client code. It's designed such that drivers can opt into client support, b

[PATCH 00/13] DC Patches Sept 23, 2024

2024-09-27 Thread Fangzhi Zuo
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Improve brightness control * Add support for UHBR10 eDP * OPTC required only for DTBCLK_P for dcn401 * Fix TBT monitor resume issue * Code cleanup Cc: Daniel Wheeler Alex Hung (3): drm/amd/display: Remove alwa

[PATCH v2 2/5] drm/amdgpu: update the handle ptr in late_init

2024-09-27 Thread Sunil Khatri
Update the ptr handle to amdgpu_ip_block ptr in all the functions of late_init function ptr. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/aldebaran.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c |

[PATCH v8 0/5] drm/amd/display: Use drm_edid for more code

2024-09-27 Thread Mario Limonciello
From: Mario Limonciello This is the successor of Melissa's v5 series that was posted [1] as well as my series that was posted [2]. Melissa's patches are mostly unmodified from v5, but the series has been rebase on the new 6.10 based amd-staging-drm-next. As were both touching similar code for f

[PATCH v8 1/5] drm/amd/display: switch amdgpu_dm_connector to use struct drm_edid

2024-09-27 Thread Mario Limonciello
From: Melissa Wen Replace raw edid handling (struct edid) with the opaque EDID type (struct drm_edid) on amdgpu_dm_connector for consistency. It may also prevent mismatch of approaches in different parts of the driver code. Signed-off-by: Melissa Wen Co-developed-by: Mario Limonciello Signed-o

[PATCH v8 2/5] drm/amd/display: switch to setting physical address directly

2024-09-27 Thread Mario Limonciello
From: Melissa Wen Connectors have source physical address available in display info. Use drm_dp_cec_attach() to use it instead of parsing the EDID again. Signed-off-by: Melissa Wen Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++--- 1 file change

[PATCH v8 4/5] drm/amd/display: remove redundant freesync parser for DP

2024-09-27 Thread Mario Limonciello
From: Melissa Wen When updating connector under drm_edid infrastructure, many calculations and validations are already done and become redundant inside AMD driver. Remove those driver-specific code in favor of the DRM common code. Signed-off-by: Melissa Wen Co-developed-by: Mario Limonciello S

[PATCH v8 3/5] drm/amd/display: always call connector_update when parsing freesync_caps

2024-09-27 Thread Mario Limonciello
From: Melissa Wen Update connector caps with drm_edid data before parsing info for freesync. Signed-off-by: Melissa Wen Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v8 5/5] drm/amd/display: Fetch the EDID from _DDC if available for eDP

2024-09-27 Thread Mario Limonciello
From: Mario Limonciello Some manufacturers have intentionally put an EDID that differs from the EDID on the internal panel on laptops. Attempt to fetch this EDID if it exists and prefer it over the EDID that is provided by the panel. If a user prefers to use the EDID from the panel, offer a DC d