[PATCH v5 38/80] drm/sti: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The sti driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out entire

Re: [PATCH v3 4/6] drm/amdgpu: alloc and init vm::task_info from first submit

2024-09-24 Thread Pierre-Eric Pelloux-Prayer
Le 23/09/2024 à 12:58, Tvrtko Ursulin a écrit : On 20/09/2024 10:06, Pierre-Eric Pelloux-Prayer wrote: This will allow to use flexible array to store the process name and other information. This also means that process name will be determined once and for all, instead of at each submit. B

[PATCH v5 37/80] drm/rockchip: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION Signed-off-by: Thomas Zimmermann Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Andy Yan Acked

[PATCH v5 17/80] drm/ili9341: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas --- drivers/gpu/drm/

[PATCH v5 21/80] drm/imx/lcdc: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION Signed-off-by: Thomas Zimmermann Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel T

[PATCH v5 74/80] drm/exynos-drm: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v5 63/80] drm/fbdev-shmem: Remove obsolete setup function

2024-09-24 Thread Thomas Zimmermann
The old setup function drm_fbdev_shmem_setup() is unused. Remove it and its internal callbacks. New drivers should call drm_client_setup() instead. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fbdev_shmem.c | 120 +-

[PATCH v5 76/80] drm/msm: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v5 49/80] drm/fbdev-shmem: Support struct drm_driver.fbdev_probe

2024-09-24 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and reimplement the old fb_probe callback on top of it. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. This change allows the common fbdev client to run on top of SHME

[PATCH v5 73/80] drm/armada: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v5 15/80] drm/ili9163: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/Kconfig | 1 + drivers/gpu/d

Re: [PATCH] drm/amdgpu: add amdgpu_device reference in ip block

2024-09-24 Thread Christian König
Am 24.09.24 um 14:57 schrieb Sunil Khatri: To handle amdgpu_device reference for different GPUs we add it's reference in each ip block which can be used to differentiate between difference gpu devices. Signed-off-by: Sunil Khatri Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgp

[PATCH v2 2/4] drm/amdgpu: Add callback get xcp resource info

2024-09-24 Thread Asad Kamal
From: Lijo Lazar Add a callback interface to get the resource information of a partition mode. Presently the information has number of resources and number of entities sharing the resource. Add the implementation for aquavanjaram SOCs. Signed-off-by: Lijo Lazar Signed-off-by: Asad Kamal ---

[PATCH v2 3/4] drm/amdgpu: Add sysfs nodes to get xcp details

2024-09-24 Thread Asad Kamal
From: Lijo Lazar Add partition config nodes in sysfs to get resource instance details for a particular partition mode. A resource could be anything like an xcc, vcn decoder, system dma units etc. Details of various resource instances are available under /sys/bus/pci/devices/.../compute_partition

[PATCH v2 4/4] drm/amdgpu: Add supported partition mode node

2024-09-24 Thread Asad Kamal
Add sysfs node to show supoorted partition modes across all NPS modes Signed-off-by: Asad Kamal --- drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c | 48 +++-- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c b/drivers/gpu/drm/am

[PATCH v2 1/4] drm/amd: Add helper to get partition config modes

2024-09-24 Thread Asad Kamal
From: Lijo Lazar Add helper to get supported/available partition config modes Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c| 40 drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.h| 2 + drivers/gpu/drm/amd/amdgpu/aqua_vanjaram.c | 54 +

Re: [PATCH 2/8] drm/sched: Always wake up correct scheduler in drm_sched_entity_push_job

2024-09-24 Thread Christian König
Am 24.09.24 um 16:12 schrieb Tvrtko Ursulin: On 24/09/2024 14:55, Christian König wrote: I've pushed the first to drm-misc-next, but that one here fails to apply cleanly. This appears due 440d52b370b0 ("drm/sched: Fix dynamic job-flow control race") in drm-misc-fixes. In theory 1-3 from my

Re: [PATCH] drm/amdgpu: Fix typo "acccess" and improve the comment style here

2024-09-24 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Sep 20, 2024 at 2:29 AM Christian König wrote: > > Am 20.09.24 um 04:27 schrieb WangYuli: > > There are some spelling mistakes of 'acccess' in comments which > > should be instead of 'access'. > > > > And the comment style should be like this: > > /* > >* Tex

Re: [PATCH] drm/amd/display: fix typos in several function pointer checks

2024-09-24 Thread Alex Deucher
Applied. Thanks! On Sat, Sep 21, 2024 at 3:48 AM Vitaliy Shevtsov wrote: > > Fix several copypaste mistakes in *_disable_link_output() functions where > an improper function pointer is checked before dereference. > > Found by Linux Verification Center (linuxtesting.org) with Svace. > > Signed-of

RE: [PATCH v2 4/4] drm/amdgpu: Add supported partition mode node

2024-09-24 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Kamal, Asad Sent: Tuesday, September 24, 2024 22:16 To: amd-gfx@lists.freedesktop.org; Lazar, Lijo Cc: Ma, Le ; Zhang, Hawking ; Zhang, Morris ; Kam

Re: [PATCH 3/4] drm/amdgpu/sdma5.2: split out per instance resume function

2024-09-24 Thread Alex Deucher
On Fri, Sep 20, 2024 at 2:31 AM wrote: > > From: Jiadong Zhu > > Extract the resume sequence from sdma_v5_2_gfx_resume for > starting/restarting an individual instance. > > Signed-off-by: Jiadong Zhu Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 247 ++--

Re: [PATCH 1/4] drm/amdgpu/sdma5: split out per instance resume function

2024-09-24 Thread Alex Deucher
On Fri, Sep 20, 2024 at 2:43 AM wrote: > > From: Jiadong Zhu > > Extract the resume sequence from sdma_v5_0_gfx_resume for > starting/restarting an individual instance. > > Signed-off-by: Jiadong Zhu Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 253 ++--

Re: [PATCH 2/2] drm/amdgpu: Show current compute partition on VF

2024-09-24 Thread Chander, Vignesh
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: vignesh.chan...@amd.com Verified-by: vignesh.chan...@amd.com From: Lijo Lazar Sent: Tuesday, September 24, 2024 2:02:50 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexa

Re: [PATCH 2/4] drm/amdgpu/sdma5: implement ring reset callback for sdma5

2024-09-24 Thread Alex Deucher
On Fri, Sep 20, 2024 at 2:43 AM wrote: > > From: Jiadong Zhu > > Implement sdma queue reset callback via MMIO. > > Signed-off-by: Jiadong Zhu > --- > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 81 ++ > 1 file changed, 81 insertions(+) > > diff --git a/drivers/gpu/drm/amd/a

Re: [PATCH 0/5] AMDGPU deadcode

2024-09-24 Thread Alex Deucher
On Sun, Sep 22, 2024 at 9:43 PM wrote: > > From: "Dr. David Alan Gilbert" > > Hi, > This is a bunch of deadcode removal in amdgpu; > some of the functions are ones which were previously > used but haven't been for a while, others are functions > that were added a few years ago and haven't ever

Re: radeon ARUBA NULL pointer dereference

2024-09-24 Thread Alex Deucher
On Tue, Sep 24, 2024 at 8:43 AM Thomas Zimmermann wrote: > > > > Am 24.09.24 um 14:20 schrieb Thomas Zimmermann: > > (cc: DMA and x86 folks) > > > > Hi > > > > Am 24.09.24 um 04:08 schrieb Arthur Marsh: > >> Using current Linus git head kernel, I was able to save the dmesg > >> output: > >> > >> [

RE: [PATCH] drm/amdgpu: simplify vram alloc logic since 2GB limitation removed

2024-09-24 Thread Zhang, Yifan
[AMD Official Use Only - AMD Internal Distribution Only] 2GB limitation in VRAM allocation is removed in below patch. My patch is a follow up refine for this. The remaing_size calculation was to address the 2GB limitation in contiguous VRAM allocation, and no longer needed after the limitation

Re: [PATCH 4/4] drm/amdgpu/sdma5.2: implement ring reset callback for sdma5.2

2024-09-24 Thread Alex Deucher
On Fri, Sep 20, 2024 at 2:31 AM wrote: > > From: Jiadong Zhu > > Implement sdma queue reset callback via MMIO. > > Signed-off-by: Jiadong Zhu > --- > drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 86 +- > 1 file changed, 85 insertions(+), 1 deletion(-) > > diff --git a/driver

Re: [PATCH 2/8] drm/sched: Always wake up correct scheduler in drm_sched_entity_push_job

2024-09-24 Thread Christian König
I've pushed the first to drm-misc-next, but that one here fails to apply cleanly. Christian. Am 24.09.24 um 12:19 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Since drm_sched_entity_modify_sched() can modify the entities run queue, lets make sure to only dereference the pointer once so both

Re: [PATCH] drm/amdgpu: simplify vram alloc logic since 2GB limitation removed

2024-09-24 Thread Alex Deucher
On Mon, Sep 23, 2024 at 4:28 AM Yifan Zhang wrote: > > Make vram alloc loop simpler after 2GB limitation removed. Can you provide more context? What 2GB limitation are you referring to? Alex > > Signed-off-by: Yifan Zhang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 15 +---

Re: [PATCH 1/7] drm/amdgpu: Add option to refresh NPS data

2024-09-24 Thread Bhardwaj, Rajneesh
Reviewed-by: Rajneesh Bhardwaj On 9/24/2024 1:56 AM, Lijo Lazar wrote: In certain use cases, NPS data needs to be refreshed again from discovery table. Add API parameter to refresh NPS data from discovery table. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 6

Re: [PATCH 4/7] drm/amdgpu: Add sysfs interfaces for NPS mode

2024-09-24 Thread Bhardwaj, Rajneesh
Reviewed-by: Rajneesh Bhardwaj On 9/24/2024 1:56 AM, Lijo Lazar wrote: Add a sysfs interface to see available NPS modes to switch to - cat /sys/bus/pci/devices/../available_memory_paritition Make the current_memory_partition sysfs node read/write for requesting a new NPS mode. The req

Re: [PATCH 6/7] drm/amdgpu: Check gmc requirement for reset on init

2024-09-24 Thread Bhardwaj, Rajneesh
Reviewed-by: Rajneesh Bhardwaj On 9/24/2024 1:56 AM, Lijo Lazar wrote: Add a callback to check if there is any condition detected by GMC block for reset on init. One case is if a pending NPS change request is detected. If reset is done because of NPS switch, refresh NPS info from discovery tabl

RE: [PATCH v2] drm/amdgpu: Flush tlb by VM_INVALIDATION packet in sdma_v5_2

2024-09-24 Thread Chen, Horace
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-By: Horace Chen Thanks & Regards, Horace. -Original Message- From: amd-gfx On Behalf Of YuanShang Sent: Monday, September 9, 2024 5:40 PM To: amd-gfx@lists.freedesktop.org Cc: YuanShang Mao (River) ; YuanShang Mao (River

[PATCH v5 26/80] drm/mediatek: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The mediatek driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out e

[PATCH v5 40/80] drm/sun4i: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The sun4i driver specifies as preferred color mode of 32. As this is the default if no format has been given, leave it out ent

[PATCH v5 25/80] drm/mcde: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The mcde driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out entir

[PATCH v5 48/80] drm/fbdev-dma: Remove obsolete setup function

2024-09-24 Thread Thomas Zimmermann
The old setup function drm_fbdev_dma_setup() is unused. Remove it and its internal callbacks. New drivers should call drm_client_setup() instead. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fbdev_dma.c | 120 +--- in

[PATCH v5 77/80] drm/radeon: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v5 58/80] drm/simpledrm: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION Signed-off-by: Thomas Zimmermann Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Revi

[PATCH v5 65/80] drm/amdgpu: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The amdgpu driver specifies a preferred color mode depending on the available video memory, with a default of 32. Adapt this f

[PATCH v5 71/80] drm/vmwgfx: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION Signed-off-by: Thomas Zimmermann Cc: Zack Rusin Cc: Broadcom internal kernel review list

[PATCH v5 64/80] drm/fbdev-ttm: Support struct drm_driver.fbdev_probe

2024-09-24 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and reimplement the old fb_probe callback on top of it. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. This change allows the common fbdev client to run on top of TTM-

[PATCH v5 66/80] drm/hisilicon/hibmc: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The hibmc driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out enti

[PATCH v5 50/80] drm/ast: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The ast driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out entire

[PATCH v5 62/80] drm/vkms: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION Signed-off-by: Thomas Zimmermann Cc: Rodrigo Siqueira Cc: Melissa Wen Cc: "Maíra Canal"

[PATCH v5 52/80] drm/cirrus: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The cirrus driver requests the same client pixel format as the value stored in struct drm_mode_config.preferred_depth. The fbd

[PATCH v5 57/80] drm/ofdrm: Use DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION Signed-off-by: Thomas Zimmermann Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Revi

[PATCH v5 59/80] drm/solomon: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The solomon driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out en

[PATCH v5 69/80] drm/qxl: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The qxl driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out entire

[PATCH v5 30/80] drm/mxsfb: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The mxsfb driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out enti

[PATCH v5 43/80] drm/st7586: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION Signed-off-by: Thomas Zimmermann Cc: David Lechner Acked-by: David Lechner --- drivers/

Re: [PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-24 Thread Christian König
Am 16.09.24 um 19:30 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit larger refactoring we can do the same optimisation on the rq->lock. (Currently both drm_

Re: [PATCH] drm/amd/powerplay: skip enable mgpu fan boost in SRIOV

2024-09-24 Thread Yin, ZhenGuo (Chris)
On 9/24/2024 8:24 PM, Lazar, Lijo wrote: On 9/24/2024 9:10 AM, ZhenGuo Yin wrote: SMU_MSG_SetMGpuFanBoostLimitRpm is unsupported for VF, skip enabling mgpu fan boost in SRIOV. Signed-off-by: ZhenGuo Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+)

<    1   2