Re: [PATCH 6/8] drm/sched: Re-order struct drm_sched_rq members for clarity

2024-09-16 Thread Philipp Stanner
On Fri, 2024-09-13 at 17:05 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Current kerneldoc for struct drm_sched_rq incompletely documents what > fields are protected by the lock. > > This is not good because it is misleading. > > Lets fix it by listing all the elements which are prot

Re: [PATCH 4/8] drm/sched: Optimise drm_sched_entity_push_job

2024-09-16 Thread Christian König
Am 13.09.24 um 18:05 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin In FIFO mode We can avoid dropping the lock only to immediately re-acquire by adding a new drm_sched_rq_update_fifo_locked() helper. v2: * Remove drm_sched_rq_update_fifo() altogether. (Christian) Signed-off-by: Tvrtko Ursuli

Re: [PATCH 8/8] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-16 Thread Christian König
Am 13.09.24 um 18:05 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit larger refactoring we can do the same optimisation on the rq->lock. (Currently both drm_

Re: [PATCH v11 08/28] drm/amdgpu: map wptr BO into GART

2024-09-16 Thread Christian König
Am 09.09.24 um 22:05 schrieb Shashank Sharma: To support oversubscription, MES FW expects WPTR BOs to be mapped into GART, before they are submitted to usermode queues. This patch adds a function for the same. V4: fix the wptr value before mapping lookup (Bas, Christian). V5: Addressed review c

[PATCH 0/1] drm/amd: more VRR race fixes during IRQ handling

2024-09-16 Thread tjakobi
From: Tobias Jakobi Hello, this is a follow-up for these (already merged) patches: https://lore.kernel.org/all/cover.1725269643.git.tjak...@math.uni-bielefeld.de/ A user on the GitLab issue tracker pointed out that the problem also manifests itself on DCE110 hardware. This is a straight port o

[PATCH 6.6] drm/amd/display: Fix subvp+drr logic errors

2024-09-16 Thread Murad Masimov
From: Alvin Lee commit 8a0f02b7beed7b2b768dbdf3b79960de68f460c5 upstream. [Why] There is some logic error where the wrong variable was used to check for OTG_MASTER and DPP_PIPE. [How] Add booleans to confirm that the expected pipes were found before validating schedulability. Tested-by: Daniel

[PATCH 1/1] drm/amd/display: handle nulled pipe context in DCE110's set_drr()

2024-09-16 Thread tjakobi
From: Tobias Jakobi As set_drr() is called from IRQ context, it can happen that the pipe context has been nulled by dc_state_destruct(). Apply the same protection here that is already present for dcn35_set_drr() and dcn10_set_drr(). I.e. fetch the tg pointer first (to avoid a race with dc_state_

[PATCH 6.1] drm/amd/display: Fix subvp+drr logic errors

2024-09-16 Thread Murad Masimov
From: Alvin Lee commit 8a0f02b7beed7b2b768dbdf3b79960de68f460c5 upstream. [Why] There is some logic error where the wrong variable was used to check for OTG_MASTER and DPP_PIPE. [How] Add booleans to confirm that the expected pipes were found before validating schedulability. Tested-by: Daniel

Re: [PATCH 6/8] drm/sched: Re-order struct drm_sched_rq members for clarity

2024-09-16 Thread Tvrtko Ursulin
On 16/09/2024 09:16, Philipp Stanner wrote: On Fri, 2024-09-13 at 17:05 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Current kerneldoc for struct drm_sched_rq incompletely documents what fields are protected by the lock. This is not good because it is misleading. Lets fix it by listin

Re: [PATCH 8/8] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-16 Thread Tvrtko Ursulin
On 16/09/2024 13:11, Christian König wrote: Am 13.09.24 um 18:05 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit larger refactoring we can do the same opt

[PATCH v4] drm/amdgpu: track bo memory stats at runtime

2024-09-16 Thread Yunxiang Li
Before, every time fdinfo is queried we try to lock all the BOs in the VM and calculate memory usage from scratch. This works okay if the fdinfo is rarely read and the VMs don't have a ton of BOs. If either of these conditions is not true, we get a massive performance hit. In this new revision, we

Re: [PATCH v11 21/28] drm/amdgpu: add gfx eviction fence helpers

2024-09-16 Thread Christian König
Am 09.09.24 um 22:06 schrieb Shashank Sharma: This patch adds basic eviction fence framework for the gfx buffers. The idea is to: - One eviction fence is created per gfx process, at kms_open. - This fence is attached to all the gem buffers created by this process. - This fence is detached to a

[PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-16 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit larger refactoring we can do the same optimisation on the rq->lock. (Currently both drm_sched_rq_add_entity() and drm_sched_rq_update_f

Re: [PATCH v6 2/4] drm/amd/display: Add support for minimum backlight quirk

2024-09-16 Thread Harry Wentland
On 2024-08-26 12:57, Mario Limonciello wrote: > On 8/24/2024 13:33, Thomas Weißschuh wrote: >> Not all platforms provide the full range of PWM backlight capabilities >> supported by the hardware through ATIF. >> Use the generic drm panel minimum backlight quirk infrastructure to >> override the

[PATCH] drm/amdgpu/bios: split vbios fetching between APU and dGPU

2024-09-16 Thread Alex Deucher
We need some different logic for dGPUs and the APU path can be simplified because there are some methods which are never used on APUs. This also fixes a regression on some older APUs causing the the driver to fetch the unpatched ROM image rather than the patched image. Fixes: 9c081c11c621 ("drm/a

Re: [PATCH] drm/amd/display: Allow backlight to go below `AMDGPU_DM_DEFAULT_MIN_BACKLIGHT`

2024-09-16 Thread Harry Wentland
On 2024-09-15 15:28, Mario Limonciello wrote: > From: Mario Limonciello > > The issue with panel power savings compatibility below > `AMDGPU_DM_DEFAULT_MIN_BACKLIGHT` happens at > `AMDGPU_DM_DEFAULT_MIN_BACKLIGHT` as well. > > That issue will be fixed separately, so don't prevent the backlight >

RE: [PATCH] drm/amdgpu/bios: split vbios fetching between APU and dGPU

2024-09-16 Thread Zhang, George
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: George Zhang Thanks, Georrge -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Monday, September 16, 2024 4:02 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/b

Re: [PATCH 1/1] drm/amd/display: handle nulled pipe context in DCE110's set_drr()

2024-09-16 Thread Alex Deucher
Acked-by: Alex Deucher And applied. Thanks! On Mon, Sep 16, 2024 at 9:03 AM wrote: > > From: Tobias Jakobi > > As set_drr() is called from IRQ context, it can happen that the > pipe context has been nulled by dc_state_destruct(). > > Apply the same protection here that is already present for

Re: [PATCH] drm/amd/display: Remove unused function bios_get_vga_enabled_displays

2024-09-16 Thread Alex Deucher
Acked-by: Alex Deucher And applied. Thanks! On Sun, Sep 15, 2024 at 10:19 AM wrote: > > From: "Dr. David Alan Gilbert" > > bios_get_vga_enabled_displays has been unused since > commit 5a8132b9f606 ("drm/amd/display: remove dead dc vbios code") > > Remove it. > > Signed-off-by: Dr. David Ala