[PATCH RESEND] drm/amd/display: Add null check before access structs in dcn32_enable_phantom_plane

2024-09-09 Thread Ma Ke
In dcn32_enable_phantom_plane, we should better check null pointer before accessing various structs. Cc: sta...@vger.kernel.org Fixes: 235c67634230 ("drm/amd/display: add DCN32/321 specific files for Display Core") Signed-off-by: Ma Ke --- drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_res

Re: [PATCH v5.15-v5.10] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

2024-09-09 Thread Greg KH
On Fri, Sep 06, 2024 at 11:02:32AM -0400, Alex Deucher wrote: > On Fri, Sep 6, 2024 at 4:50 AM Mukul Sikka wrote: > > > > On Fri, Sep 6, 2024 at 12:05 AM Alex Deucher wrote: > > > > > > On Tue, Sep 3, 2024 at 5:53 AM sikkamukul > > > wrote: > > > > > > > > From: Bob Zhou > > > > > > > > [ Upst

Re: [PATCH 0/2] drm/amd: fix VRR race condition during IRQ handling

2024-09-09 Thread Christopher Snowhill
On Sun Sep 8, 2024 at 4:23 AM PDT, Tobias Jakobi wrote: > On 9/8/24 09:35, Christopher Snowhill wrote: > > > On Mon Sep 2, 2024 at 2:40 AM PDT, tjakobi wrote: > >> From: Tobias Jakobi > >> > >> Hello, > >> > >> this fixes a nasty race condition in the set_drr() callbacks for DCN10 > >> and DCN35 t

Re: [RFC 0/4] DRM scheduler fixes, or not, or incorrect kind

2024-09-09 Thread Philipp Stanner
Hi, On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In a recent conversation with Christian there was a thought that > drm_sched_entity_modify_sched() should start using the entity- > >rq_lock to be > safe against job submission and simultaneous priority chang

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-09-09 Thread Michel Dänzer
On 2024-09-06 21:46, Leo Li wrote: > > Second, can you try adding "amdgpu.dcdebugmask=0x40" to your kernel cmdline at > boot, and see if you can still repro the hang? > > This setting disables hw planes. If it resolves the hang, then it's quite > interesting, because it suggests that gnome may be

[PATCH] drm/amdgpu: Flush tlb by VM_INVALIDATION packet in sdma_v5_2

2024-09-09 Thread YuanShang
To flush tlb by one single packet, Use VM_INVALIDATION packet in function sdma_v5_2_ring_emit_vm_flush. Signed-off-by: YuanShang --- .../gpu/drm/amd/amdgpu/navi10_sdma_pkt_open.h | 64 +++ drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c| 24 ++- 2 files changed, 87 insertions(

[PATCH v2] drm/amdgpu: Flush tlb by VM_INVALIDATION packet in sdma_v5_2

2024-09-09 Thread YuanShang
In order for SDMA not to be switched between VM_INVALIDATION request and ack, use an single VM_INVALIDATION packet in function sdma_v5_2_ring_emit_vm_flush. Signed-off-by: YuanShang --- .../gpu/drm/amd/amdgpu/navi10_sdma_pkt_open.h | 64 +++ drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c

Re: [RFC 1/4] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-09 Thread Philipp Stanner
On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Without the locking amdgpu currently can race > amdgpu_ctx_set_entity_priority() and drm_sched_job_arm(),  I would explicitly say "amdgpu's amdgpu_ctx_set_entity_priority() races through drm_sched_entity_modify_s

Re: [RFC 2/4] drm/sched: Always wake up correct scheduler in drm_sched_entity_push_job

2024-09-09 Thread Philipp Stanner
On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Since drm_sched_entity_modify_sched() can modify the entities run > queue > lets make sure to only derefernce the pointer once so both adding and > waking up are guaranteed to be consistent. > > Signed-off-by: Tv

[PATCH 1/2] drm/amdgpu/mes11: update mes_reset_queue function to support sdma queue

2024-09-09 Thread jiadong.zhu
From: Jiadong Zhu Reset sdma queue through mmio based on me_id and queue_id. Signed-off-by: Jiadong Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 2 +- drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 53 - 2 files changed, 53 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 2/2] drm/amdgpu/sdma6: implement ring reset callback for sdma6

2024-09-09 Thread jiadong.zhu
From: Jiadong Zhu Implement sdma queue reset callback using mes_reset_queue_mmio. Extract sdma resume sequence from sdma_v6_0_gfx_resume for queue restarting. Signed-off-by: Jiadong Zhu --- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 266 +++-- 1 file changed, 157 insertions(+

[PATCH] drm/amdgpu: disable RAS bad page feature for specific APU

2024-09-09 Thread Tao Zhou
The feature is unsupported on specific APU. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index dbfc41ddc3c7..d46f216a33b1 100644 ---

Re: [RFC 1/4] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-09 Thread Christian König
Am 09.09.24 um 11:44 schrieb Philipp Stanner: On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Without the locking amdgpu currently can race amdgpu_ctx_set_entity_priority() and drm_sched_job_arm(), I would explicitly say "amdgpu's amdgpu_ctx_set_entity_priority()

Re: [RFC 2/4] drm/sched: Always wake up correct scheduler in drm_sched_entity_push_job

2024-09-09 Thread Christian König
Am 06.09.24 um 20:06 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Since drm_sched_entity_modify_sched() can modify the entities run queue lets make sure to only derefernce the pointer once so both adding and waking up are guaranteed to be consistent. Signed-off-by: Tvrtko Ursulin Fixes: b37ac

Re: [RFC 3/4] drm/sched: Always increment correct scheduler score

2024-09-09 Thread Christian König
Am 06.09.24 um 20:06 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Entities run queue can change during drm_sched_entity_push_job() so make sure to update the score consistently. Signed-off-by: Tvrtko Ursulin Fixes: d41a39dda140 ("drm/scheduler: improve job distribution with multiple queues")

[PATCH v4 00/80] drm: Provide client setup helper and convert drivers

2024-09-09 Thread Thomas Zimmermann
Provide drm_client_setup() to initialize in-kernel DRM clients. Then convert all drivers to the new interface. Remove old interfaces for the fbdev client. So far, the only supported DRM client in the kernel is for fbdev emulation with its fbcon support. Long term, we want to move away from fbcon.

[PATCH v4 02/80] drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info

2024-09-09 Thread Thomas Zimmermann
Call vga_switcheroo_client_fb_set() with the PCI device from the instance of struct fb_info. All fbdev clients now run these calls. For non-PCI devices or drivers without vga-switcheroo, this does nothing. For i915 and radeon, it allows these drivers to use a common fbdev client. The device is the

[PATCH v4 01/80] drm/fbdev-helper: Move color-mode lookup into 4CC format helper

2024-09-09 Thread Thomas Zimmermann
The color mode as specified on the kernel command line gives the user's preferred color depth and number of bits per pixel. Move the color-mode-to-format conversion from fbdev helpers into a 4CC helper, so that it can be shared among DRM clients. v2: - fix grammar in commit message (Laurent) Sign

[PATCH v4 03/80] drm/fbdev: Add memory-agnostic fbdev client

2024-09-09 Thread Thomas Zimmermann
Add an fbdev client that can work with any memory manager. The client implementation is the same as existing code in fbdev-dma or fbdev-shmem. Provide struct drm_driver.fbdev_probe for the new client to allocate the surface GEM buffer. The new callback replaces fb_probe of struct drm_fb_helper_fun

[PATCH v4 05/80] drm/fbdev-dma: Support struct drm_driver.fbdev_probe

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and reimplement the old fb_probe callback on top of it. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. This change allows the common fbdev client to run on top of DMA-

[PATCH v4 06/80] drm/arcgpu: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup_with_fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v2: - use drm_client_setup_with_fourcc() Signed-off-by: Thomas Zimmermann Cc: Alexey Brodkin Acked-by: Javier M

[PATCH v4 08/80] drm/arm/hdlcd: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The hdlcd driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out enti

[PATCH v4 10/80] drm/aspeed: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The aspeed driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out ent

[PATCH v4 11/80] drm/atmel-hdlcd: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup_with_fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v3: - add DRM_FBDEV_DMA_DRIVER_OPS macro (Sam) v2: - use drm_client_setup_with_fourcc() Signed-off-by: Thomas Zim

[PATCH v4 09/80] drm/arm/malidp: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The malidp driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out ent

[PATCH v4 12/80] drm/fsl-dcu: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup_with_color_mode() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Stefan Agner Cc: Alison Wang Acked-by: Javier Martinez Canillas ---

[PATCH v4 07/80] drm/arm/komeda: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The komeda driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out ent

[PATCH v4 13/80] drm/hisilicon/kirin: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The kirin driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out enti

[PATCH v4 14/80] drm/hx8357d: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/hx8357d.c | 4 +++- 1 file cha

[PATCH v4 16/80] drm/ili9225: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: David Lechner Acked-by: David Lechner --- drivers/gpu/drm/tiny/ili9225.c | 4 +++- 1

[PATCH v4 04/80] drm: Add client-agnostic setup helper

2024-09-09 Thread Thomas Zimmermann
DRM may support multiple in-kernel clients that run as soon as a DRM driver has been registered. To select the client(s) in a single place, introduce drm_client_setup(). Drivers that call the new helper automatically instantiate the kernel's configured default clients. Only fbdev emulation is curr

[PATCH v4 18/80] drm/ili9486: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Kamlesh Gurudasani Acked-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/ili948

[PATCH v4 15/80] drm/ili9163: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/ili9163.c | 4 +++- 1 file cha

[PATCH v4 17/80] drm/ili9341: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/ili9341.c | 4 +++- 1 file cha

[PATCH v4 23/80] drm/kmb: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Anitha Chrisanthus Cc: Edmund Dea Acked-by: Javier Martinez Canillas --- drivers/gpu

[PATCH v4 19/80] drm/imx/dcss: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The dcss driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out entir

[PATCH v4 21/80] drm/imx/lcdc: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Acked-by: J

[PATCH v4 26/80] drm/mediatek: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The mediatek driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out e

[PATCH v4 35/80] drm/renesas/shmobile: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup_with_fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v2: - use drm_client_setup_with_fourcc() Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Geert Uytter

[PATCH v4 31/80] drm/panel-mipi-dbi: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" Acked-by: Noralf Trønnes --- drivers/gpu/drm/tiny/panel-mipi-dbi.c |

[PATCH v4 28/80] drm/mi0283qt: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" Acked-by: Noralf Trønnes --- drivers/gpu/drm/tiny/mi0283qt.c | 4 +++

[PATCH v4 29/80] drm/mxsfb/lcdif: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The lcdif driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out enti

[PATCH v4 34/80] drm/renesas/rz-du: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The rz-du driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out enti

[PATCH v4 27/80] drm/meson: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The meson driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out enti

[PATCH v4 24/80] drm/logicvc: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The logicvc driver specifies a preferred color mode from the value in struct drm_mode_config.preferred_depth. The fbdev client

[PATCH v4 39/80] drm/stm: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup_with-fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v4: - remove duplicated S-o-b tag (Gerd) v2: - use drm_client_setup_with_fourcc() Signed-off-by: Thomas Zimmerman

[PATCH v4 25/80] drm/mcde: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The mcde driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out entir

[PATCH v4 32/80] drm/pl111: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup_with_color_mode() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas --- drivers/gpu/drm/pl111/pl111_drv.c |

[PATCH v4 22/80] drm/ingenic: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The ingenic driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out en

[PATCH v4 33/80] drm/renesas/rcar-du: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The rcar-du driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out en

[PATCH v4 37/80] drm/rockchip: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Andy Yan Acked-by: Heiko Stuebner --- drivers/g

[PATCH v4 41/80] drm/tidss: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The tidss driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out enti

[PATCH v4 36/80] drm/repaper: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" Acked-by: Noralf Trønnes --- drivers/gpu/drm/tiny/repaper.c | 4 +++-

[PATCH v4 20/80] drm/imx/ipuv3: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup_with_color_mode() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Philipp Zabel Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel T

[PATCH v4 43/80] drm/st7586: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: David Lechner Acked-by: David Lechner --- drivers/gpu/drm/tiny/st7586.c | 4 +++- 1 f

[PATCH v4 49/80] drm/fbdev-shmem: Support struct drm_driver.fbdev_probe

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and reimplement the old fb_probe callback on top of it. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. This change allows the common fbdev client to run on top of SHME

[PATCH v4 47/80] drm/xlnx: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup_with_fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v2: - use drm_client_setup_with_fourcc() Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Tomi Valkein

[PATCH v4 45/80] drm/tve200: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup_with_fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v2: - use drm_client_setup_with_fourcc() Signed-off-by: Thomas Zimmermann Cc: Linus Walleij Acked-by: Linus Wal

[PATCH v4 51/80] drm/bochs: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The bochs driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out enti

[PATCH v4 40/80] drm/sun4i: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The sun4i driver specifies as preferred color mode of 32. As this is the default if no format has been given, leave it out ent

[PATCH v4 30/80] drm/mxsfb: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The mxsfb driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out enti

[PATCH v4 56/80] drm/mgag200: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup_with_fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v2: - use drm_client_setup_with_fourcc() Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Thomas Zimmermann

[PATCH v4 54/80] drm/gud: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" Acked-by: Noralf Trønnes --- drivers/gpu/drm/gud/gud_drv.c | 4 +++-

[PATCH v4 50/80] drm/ast: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The ast driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out entire

[PATCH v4 48/80] drm/fbdev-dma: Remove obsolete setup function

2024-09-09 Thread Thomas Zimmermann
The old setup function drm_fbdev_dma_setup() is unused. Remove it and its internal callbacks. New drivers should call drm_client_setup() instead. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fbdev_dma.c | 120 +--- in

[PATCH v4 53/80] drm/gm12u320: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Hans de Goede Acked-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/gm12u320.c

[PATCH v4 38/80] drm/sti: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The sti driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out entire

[PATCH v4 52/80] drm/cirrus: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The cirrus driver requests the same client pixel format as the value stored in struct drm_mode_config.preferred_depth. The fbd

[PATCH v4 70/80] drm/vboxvideo: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The vboxvideo driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out

[PATCH v4 67/80] drm/loongson: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The loongson driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out e

[PATCH v4 58/80] drm/simpledrm: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas

[PATCH v4 55/80] drm/hyperv_drm: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Deepak Rawat Reviewed-by: Deepak Rawat --- drivers/gpu/drm/hyperv/hyperv_drm_drv.c |

[PATCH v4 65/80] drm/amdgpu: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The amdgpu driver specifies a preferred color mode depending on the available video memory, with a default of 32. Adapt this f

[PATCH v4 75/80] drm/gma500: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v4 42/80] drm/tilcdc: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup_with_color_mode() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v3: - add DRM_FBDEV_DMA_DRIVER_OPS macro Signed-off-by: Thomas Zimmermann Cc: Jyri Sarha Cc: Tomi Valkeinen

[PATCH v4 72/80] drm/fbdev-ttm: Remove obsolete setup function

2024-09-09 Thread Thomas Zimmermann
The old setup function drm_fbdev_ttm_setup() is unused. Remove it and its internal callbacks. New drivers should call drm_client_setup() instead. Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fbdev_ttm.c | 119 inclu

[PATCH v4 46/80] drm/vc4: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup_with_fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v2: - use drm_client_setup_with_fourcc() Signed-off-by: Thomas Zimmermann Cc: Maxime Ripard Cc: Dave Stevenson

[PATCH v4 63/80] drm/fbdev-shmem: Remove obsolete setup function

2024-09-09 Thread Thomas Zimmermann
The old setup function drm_fbdev_shmem_setup() is unused. Remove it and its internal callbacks. New drivers should call drm_client_setup() instead. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fbdev_shmem.c | 120 +-

[PATCH v4 61/80] drm/virtgpu: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The virtgpu driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out en

[PATCH v4 69/80] drm/qxl: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The qxl driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out entire

[PATCH v4 59/80] drm/solomon: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The solomon driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out en

[PATCH v4 57/80] drm/ofdrm: Use DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas

[PATCH v4 64/80] drm/fbdev-ttm: Support struct drm_driver.fbdev_probe

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and reimplement the old fb_probe callback on top of it. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. This change allows the common fbdev client to run on top of TTM-

[PATCH v4 71/80] drm/vmwgfx: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Zack Rusin Cc: Broadcom internal kernel review list Acked-by: Javier Martinez Canillas

[PATCH v4 44/80] drm/st7735r: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: David Lechner Acked-by: David Lechner --- drivers/gpu/drm/tiny/st7735r.c | 4 +++- 1

[PATCH v4 60/80] drm/udl: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Sean Paul Cc: Thomas Zimmermann Acked-by: Javier Martinez Canillas -

[PATCH v4 62/80] drm/vkms: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Rodrigo Siqueira Cc: Melissa Wen Cc: "Maíra Canal" Cc: Haneen Mohammed Acked-by: Jav

[PATCH v4 78/80] drm/tegra: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v4 73/80] drm/armada: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v4 74/80] drm/exynos-drm: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v4 77/80] drm/radeon: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v4 66/80] drm/hisilicon/hibmc: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The hibmc driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out enti

[PATCH v4 76/80] drm/msm: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v4 68/80] drm/nouveau: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The nouveau driver specifies a preferred color mode depending on the available video memory, with a default of 32. Adapt this

[PATCH v4 79/80] drm/omapdrm: Remove struct drm_fb_helper from struct omap_fbdev.

2024-09-09 Thread Thomas Zimmermann
Store instances of drm_fb_helper and struct omap_fbdev separately. This will allow omapdrm to use the common fbdev client, which allocates its own instance of struct drm_fb_helper. There is at most one instance of each per DRM device, so both can be referenced directly from the omap and DRM device

[PATCH v4 80/80] drm/omapdrm: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

Re: [RFC 1/4] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-09 Thread Philipp Stanner
On Mon, 2024-09-09 at 13:29 +0200, Christian König wrote: > Am 09.09.24 um 11:44 schrieb Philipp Stanner: > > On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > Without the locking amdgpu currently can race > > > amdgpu_ctx_set_entity_priority() and dr

Re: [RFC 1/4] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-09 Thread Christian König
Am 09.09.24 um 14:13 schrieb Philipp Stanner: On Mon, 2024-09-09 at 13:29 +0200, Christian König wrote: Am 09.09.24 um 11:44 schrieb Philipp Stanner: On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Without the locking amdgpu currently can race amdgpu_ctx_set_ent

RE: [PATCH] drm/amdgpu: disable RAS bad page feature for specific APU

2024-09-09 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] connected_to_gpu is legacy design - I understand UMC IP version is also used so it works. Checking is_app_apu flag is good enough at this stage. It would be better to move the code change to amdgpu_ras_fs_init. In addition, it's more accu

Re: [RFC 1/2] drm/amdgpu: Remove dynamic DRM scheduling priority override

2024-09-09 Thread Christian König
Adding Leo as well. Am 06.09.24 um 20:06 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin According to Christian the dynamic DRM priority override was only interesting before the hardware priority (dona via drm_sched_entity_modify_sched()) existed. Furthermore, both overrides also only work somewh

  1   2   >