Re: [PATCH 1/4] new helper: drm_gem_prime_handle_to_dmabuf()

2024-08-23 Thread Thomas Zimmermann
Hi Am 23.08.24 um 03:57 schrieb Al Viro: Do you have any problems with the variant below? The only changes are in commit message and added comment for new helper... commit 8c291056e3e88153ef4b6316d5247547da200757 Author: Al Viro Date: Fri Aug 2 09:56:28 2024 -0400 new helper: drm_gem_

[PATCH -next v3] drm/amd/display: Remove unused dcn35_fpga_funcs and related functions

2024-08-23 Thread Jinjie Ruan
dcn35_fpga_funcs is not used anywhere, remove it. And also remove related not used dcn35_init_clocks_fpga() and dcn35_update_clocks_fpga(). Signed-off-by: Jinjie Ruan --- v3: - Also remove related unused functions. - Update the commit message. v2: - Remove it instead of making it static. --- ..

Re: [PATCH 1/4] new helper: drm_gem_prime_handle_to_dmabuf()

2024-08-23 Thread Al Viro
Do you have any problems with the variant below? The only changes are in commit message and added comment for new helper... commit 8c291056e3e88153ef4b6316d5247547da200757 Author: Al Viro Date: Fri Aug 2 09:56:28 2024 -0400 new helper: drm_gem_prime_handle_to_dmabuf() Once someth

[PATCH -next] drm/amd/display: Remove unnecessary semicolon after switch statement

2024-08-23 Thread Yang Li
This commit removes the unnecessary semicolon (`;`) following the closing brace of the switch statement in the function 'dml2_core_utils_get_tile_block_size_bytes'. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9804 Signed-off-by: Yang Li --- .../amd/display/dc

Re: [PATCH -next v2 RESEND] drm/amd/display: Remove unused dcn35_fpga_funcs

2024-08-23 Thread Jinjie Ruan
On 2024/8/23 2:01, Alex Deucher wrote: > On Thu, Aug 22, 2024 at 5:20 AM Jinjie Ruan wrote: >> >> dcn35_fpga_funcs is not used anywhere, remove it. > > This will lead to warnings about unused functions. The fpga specific > functions should be removed as well. I'd suggest compile testing your

Re: [PATCH 1/4] new helper: drm_gem_prime_handle_to_dmabuf()

2024-08-23 Thread Al Viro
On Thu, Aug 22, 2024 at 04:41:59PM +0200, Thomas Zimmermann wrote: > Hi > > Am 12.08.24 um 08:59 schrieb Al Viro: > > Once something had been put into descriptor table, the only thing you > > can do with it is returning descriptor to userland - you can't withdraw > > it on subsequent failure exit,

[PATCH v2] drm/radeon: Switch radeon_connector to struct drm_edid

2024-08-23 Thread Thomas Weißschuh
"struct drm_edid" is the safe and recommended alternative to "struct edid". Rename the member to make sure that no usage sites are missed, as "struct drm_edid" has some restrictions, for example it can not be used with kfree(). Signed-off-by: Thomas Weißschuh --- Changes in v2: - Simplify some l

Re: [PATCH 0/2] Fix for lightup issue on Lenovo 4k60 HDMI

2024-08-23 Thread Jiri Slaby
On 22. 08. 24, 21:14, Fangzhi Zuo wrote: 338567d176 ("drm/amd/display: Fix MST BW calculation Regression") has been merged with a mistake being fixed by "drm/amd/display: Fix a mistake in revert commit" Fix dsc enablement for Synaptics Cascaded Panamera hub is included in "drm/amd/display: F

[PATCH] drm/amd/display: fix some indenting in CalculatePrefetchSchedule()

2024-08-23 Thread Dan Carpenter
These tabs were deleted accidentally in commit d07722e1fc74 ("drm/amd/display: DML2.1 Reintegration for Various Fixes"). Add them back. Signed-off-by: Dan Carpenter --- .../dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c| 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH 1/4] new helper: drm_gem_prime_handle_to_dmabuf()

2024-08-23 Thread Al Viro
On Fri, Aug 23, 2024 at 09:21:14AM +0200, Thomas Zimmermann wrote: > Acked-by: Thomas Zimmermann > > Thank you so much. OK, Acked-by added, branch force-pushed to git://git.kernel.org:/pub/scm/linux/kernel/git/viro/vfs.git #for-drm In case if anybody wants a signed pull request, see below; or

[PATCH v2] drivers:smumgr:fix up the misspellings

2024-08-23 Thread Yang Ruibin
Hightest is a typo. It should be highest.Please ensure the consistency of variable naming. Signed-off-by: Yang Ruibin <11162...@vivo.com> --- Changes V2: - Replaced the word "hightest_pcie_level_enabled" with "hightest_pcie_level_enabled". --- .../drm/amd/pm/powerplay/smumgr/fiji_smumgr.c|

Re: [PATCH 1/1] drm/amdgpu/display: SPDX copyright for spl_os_types.h

2024-08-23 Thread Hamza Mahfooz
On 8/22/24 20:14, Zaeem Mohamed wrote: Use appropriate SPDX copyright for spl_os_types.h Signed-off-by: Zaeem Mohamed Reviewed-by: Hamza Mahfooz --- .../gpu/drm/amd/display/dc/spl/spl_os_types.h | 29 +++ 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/dri

Re: [PATCH 1/1] drm/amdgpu/display: remove unecessary TODO spl_os_types.h

2024-08-23 Thread Hamza Mahfooz
On 8/23/24 00:35, Zaeem Mohamed wrote: Remove TODO from spl_os_types.h Signed-off-by: Zaeem Mohamed s/unecessary TODO/unnecessary TODO in With that addressed: Reviewed-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/dc/spl/spl_os_types.h | 1 - 1 file changed, 1 deletion(-) diff --g

Re: [PATCH] Revert "drm/ttm: increase ttm pre-fault value to PMD size"

2024-08-23 Thread Alex Deucher
Ping? On Tue, Aug 20, 2024 at 9:46 AM Alex Deucher wrote: > > This reverts commit 0ddd2ae586d28e521d37393364d989ce118802e0. > > This patch causes sluggishness and stuttering in graphical > apps. > > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3564 > Link: https://www.spinics.net/lists

Re: [PATCH v2] drivers:smumgr:fix up the misspellings

2024-08-23 Thread Alex Deucher
On Fri, Aug 23, 2024 at 5:30 AM Yang Ruibin <11162...@vivo.com> wrote: > > Hightest is a typo. It should be highest.Please ensure > the consistency of variable naming. > > Signed-off-by: Yang Ruibin <11162...@vivo.com> > --- > Changes V2: > - Replaced the word "hightest_pcie_level_enabled" with >

Re: [PATCH] Revert "drm/ttm: increase ttm pre-fault value to PMD size"

2024-08-23 Thread Christian König
Am 23.08.24 um 15:13 schrieb Alex Deucher: Ping? On Tue, Aug 20, 2024 at 9:46 AM Alex Deucher wrote: This reverts commit 0ddd2ae586d28e521d37393364d989ce118802e0. This patch causes sluggishness and stuttering in graphical apps. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3564 Lin

[PATCH] drm/amdgpu: always allocate cleared VRAM for GEM allocations

2024-08-23 Thread Alex Deucher
This adds allocation latency, but aligns better with user expectations. The latency should improve with the drm buddy clearing patches that Arun has been working on. In addition this fixes the high CPU spikes seen when doing wipe on release. Closes: https://gitlab.freedesktop.org/drm/amd/-/issue

Re: [PATCH] drm/amd: Don't wake dGPUs while reading sensors

2024-08-23 Thread Hamza Mahfooz
On 8/19/24 22:04, Mario Limonciello wrote: From: Mario Limonciello If the dGPU is off, then reading the sysfs files with a sensor monitoring application will wake it. Change the behavior to return an error when the dGPU is in D3cold. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/

Re: [PATCH] drm/amd: Don't wake dGPUs while reading sensors

2024-08-23 Thread Mario Limonciello
On 8/23/2024 08:44, Hamza Mahfooz wrote: On 8/19/24 22:04, Mario Limonciello wrote: From: Mario Limonciello If the dGPU is off, then reading the sysfs files with a sensor monitoring application will wake it. Change the behavior to return an error when the dGPU is in D3cold. Signed-off-by: Mar

Re: [PATCH] drm/amdgpu: always allocate cleared VRAM for GEM allocations

2024-08-23 Thread Christian König
Am 23.08.24 um 15:36 schrieb Alex Deucher: This adds allocation latency, but aligns better with user expectations. The latency should improve with the drm buddy clearing patches that Arun has been working on. The problem is still that we can't most likely will run into issues with some of the

[PATCH AUTOSEL 6.10 18/24] drm/amdgpu: Update kmd_fw_shared for VCN5

2024-08-23 Thread Sasha Levin
From: Yinjie Yao [ Upstream commit 507a2286c052919fe416b3daa0f0061d0fc702b9 ] kmd_fw_shared changed in VCN5 Signed-off-by: Yinjie Yao Reviewed-by: Ruijing Dong Acked-by: Alex Deucher Signed-off-by: Alex Deucher (cherry picked from commit aa02486fb18cecbaca0c4fd393d1a03f1d4c3f9a) Signed-off-

Re: [PATCH] drm/amd: Don't wake dGPUs while reading sensors

2024-08-23 Thread Alex Deucher
On Mon, Aug 19, 2024 at 10:30 PM Mario Limonciello wrote: > > From: Mario Limonciello > > If the dGPU is off, then reading the sysfs files with a sensor monitoring > application will wake it. Change the behavior to return an error when the > dGPU is in D3cold. I'm a little concerned that this wi

Re: [PATCH] drm/amd: Don't wake dGPUs while reading sensors

2024-08-23 Thread Mario Limonciello
On 8/23/2024 09:09, Alex Deucher wrote: On Mon, Aug 19, 2024 at 10:30 PM Mario Limonciello wrote: From: Mario Limonciello If the dGPU is off, then reading the sysfs files with a sensor monitoring application will wake it. Change the behavior to return an error when the dGPU is in D3cold. I

Re: [PATCH] drm/amd: Don't wake dGPUs while reading sensors

2024-08-23 Thread Alex Deucher
On Fri, Aug 23, 2024 at 10:13 AM Mario Limonciello wrote: > > On 8/23/2024 09:09, Alex Deucher wrote: > > On Mon, Aug 19, 2024 at 10:30 PM Mario Limonciello > > wrote: > >> > >> From: Mario Limonciello > >> > >> If the dGPU is off, then reading the sysfs files with a sensor monitoring > >> appl

Re: [PATCH] drm/amd: Don't wake dGPUs while reading sensors

2024-08-23 Thread Mario Limonciello
On 8/23/2024 09:31, Alex Deucher wrote: On Fri, Aug 23, 2024 at 10:13 AM Mario Limonciello wrote: On 8/23/2024 09:09, Alex Deucher wrote: On Mon, Aug 19, 2024 at 10:30 PM Mario Limonciello wrote: From: Mario Limonciello If the dGPU is off, then reading the sysfs files with a sensor monit

[PATCH v2 1/2] drm/amd: Reduce sysfs and debugfs attribute boilerplate

2024-08-23 Thread Mario Limonciello
All accesses to attributes have a check for reset/suspend/runpm. Move this code into dedicated functions. No intended functional changes. Signed-off-by: Mario Limonciello --- v1->v2: * Split out to two patches to reduce boilerplate with common functions * Different behavior for sysfs and debugf

[PATCH v2 2/2] drm/amd: Don't wake dGPUs while reading sensors

2024-08-23 Thread Mario Limonciello
If the dGPU is off, then reading the sysfs files with a sensor monitoring application will wake it. Change the behavior to return an error when the dGPU is in runtime PM. Leave the behavior the same for debugfs files. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 8 +

Re: [PATCH 3/9] drm/panel: panel-novatak-nt35510: Use backlight power constants

2024-08-23 Thread Linus Walleij
On Wed, Jul 31, 2024 at 2:23 PM Thomas Zimmermann wrote: > Replace FB_BLANK_ constants with their counterparts from the > backlight subsystem. The values are identical, so there's no > change in functionality or semantics. > > Signed-off-by: Thomas Zimmermann > Cc: Linus Walleij > Cc: Neil Arms

RE: [PATCH 00/16] DC Patches August 19, 2024

2024-08-23 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eD

Re: [PATCH v2 1/5] drm/amd: Introduce additional IPS debug flags

2024-08-23 Thread Aurabindo Pillai
On 8/19/24 3:22 PM, sunpeng...@amd.com wrote: From: Leo Li [Why] Idle power states (IPS) describe levels of power-gating within DCN. DM and DC is responsible for ensuring that we are out of IPS before any DCN programming happens. Any DCN programming while we're in IPS leads to undefined beh

[PATCH] drm/amdgpu/swsmu: always force a state reprogram on init

2024-08-23 Thread Alex Deucher
Always reprogram the hardware state on init. This ensures the PMFW state is explicitly programmed and we are not relying on the default PMFW state. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3131 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 15 +++

[PATCH] drm/amdkfd: restore_process_worker race with GPU reset

2024-08-23 Thread Philip Yang
If GPU reset kick in while KFD restore_process_worker running, this may causes different issues, for example below rcu stall warning, because restore work may move BOs and evict queues under VRAM pressure. Fix this race by taking adev reset_domain read semaphore to prevent GPU reset in restore_pro

Re: [PATCH v2 11/86] drm/atmel-hdlcd: Run DRM default client setup

2024-08-23 Thread Sam Ravnborg
On Wed, Aug 21, 2024 at 02:59:08PM +0200, Thomas Zimmermann wrote: > Call drm_client_setup_with_fourcc() to run the kernel's default client > setup for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > v2: > - use drm_client_setup_with_fou

Re: AMD drm patch workflow is broken for stable trees

2024-08-23 Thread Alex Deucher
On Thu, Aug 15, 2024 at 1:11 AM Greg KH wrote: > > On Wed, Aug 14, 2024 at 05:30:08PM -0400, Alex Deucher wrote: > > On Wed, Aug 14, 2024 at 4:55 PM Felix Kuehling > > wrote: > > > > > > On 2024-08-12 11:00, Greg KH wrote: > > > > Hi all, > > > > > > > > As some of you have noticed, there's a TO

[PATCH] drm/amdkfd: Add cache line size info

2024-08-23 Thread David Belanger
Populate cache line size info in topology based on information from IP discovery table. Signed-off-by: David Belanger --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/