Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
b/drivers/gpu/drm/amd/display/dc/bios/bios_parse
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
b/drivers/gpu/drm/amd/display/dc/bios/bios_parse
Sorry for the spam folks.
I didn't realize that the new amdgpu driver would work on that old
hardware. I'm using that driver now, hoping it will be more stable than
radeon. I'm not sure why Ubuntu is set up to use the radeon driver by
default.
kms
On Wed, Aug 21, 2024 at 1:52 PM Krister Swenson
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
b/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
index 9eccdb38
Instead of using the min() implementation of
the ternary operator, use real macros.
Signed-off-by: Yang Ruibin <11162...@vivo.com>
---
drivers/gpu/drm/amd/pm/powerplay/smumgr/fiji_smumgr.c | 5 +
drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c | 7 ++-
drivers/gpu/drm/amd
*** BLURB HERE ***
Yu Jiaoliang (6):
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drivers/gpu/drm/amd/display/dc/bios/b
On 2024-08-21 15:54:14+, Mario Limonciello wrote:
> On 8/18/2024 01:56, Thomas Weißschuh wrote:
> > Not all platforms provide correct PWM backlight capabilities through ATIF.
>
> I don't think correct is an accurate term here. How about 'optimial'?
Looks typoed to me :-)
What about this?
N
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
b/drivers/gpu/drm/amd/display/module
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
index b12651246
Fix the assignment for i2c_speed_in_khz_hdcp.
Fixex: commit b15cde19c32d ("drm/amd/display:
Add i2c speed arbitration for dc_i2c and hdcp_i2c")
Signed-off-by: Yuesong Li
---
.../gpu/drm/amd/display/dc/resource/dce100/dce100_resource.c| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
On 8/21/24 7:59 AM, Thomas Zimmermann wrote:
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> Signed-off-by: Thomas Zimmermann
> Cc: David Lechner
> ---
Acked-by:
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
b/drivers/gpu/drm/amd/display/dc/core/dc_resour
*** BLURB HERE ***
Yu Jiaoliang (6):
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drivers/gpu/drm/amd/display/dc/bios/b
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c
b/drivers/gpu/drm/amd/displ
Hello all,
I couldn't find a list to send mail to concerning the radeon driver. Is
this an OK place?
I'm desperate for help, as I have crippling issues with my AMD cards since
updating to Ubuntu 24.04. This is my work machine, and it's seriously
hampering my productivity.
I have a bit of experie
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
b/drivers/gpu/drm/amd/display/module
*** BLURB HERE ***
Yu Jiaoliang (6):
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drivers/gpu/drm/amd/display/dc/bios/b
On Wed, Aug 21, 2024 at 6:04 AM Thomas Zimmermann wrote:
>
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> The kirin driver specifies a preferred color mode of 32.
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c
b/drivers/gpu/drm/amd/displ
On Wed, Aug 14, 2024 at 06:15:46PM -0400, Felix Kuehling wrote:
>
> On 2024-08-12 02:59, Al Viro wrote:
> > Using drm_gem_prime_handle_to_fd() to set dmabuf up and insert it into
> > descriptor table, only to have it looked up by file descriptor and
> > remove it from descriptor table is not just
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
b/drivers/gpu/drm/amd/display/dc/core/dc_resour
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
b/drivers/gpu/drm/amd/display/module
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
b/drivers/gpu/drm/amd/display/module
Hi Mario,
(+ a question for Dustin inside)
On 2024-08-21 15:45:46+, Mario Limonciello wrote:
> On 8/18/2024 01:56, Thomas Weißschuh wrote:
> > The value of "min_input_signal" returned from ATIF on a Framework AMD 13
> > is "12". This leads to a fairly bright minimum display backlight.
> >
>
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
b/drivers/gpu/drm/amd/display/dc/core/dc_resour
On 2024-08-21 15:51:17+, Mario Limonciello wrote:
> On 8/18/2024 01:56, Thomas Weißschuh wrote:
> > Panels using a PWM-controlled backlight source do not have a standard
> > way to communicate their valid PWM ranges.
> > On x86 the ranges are read from ACPI through driver-specific tables.
> > T
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
b/drivers/gpu/drm/amd/display/dc/bios/bios_parse
On 8/21/24 7:59 AM, Thomas Zimmermann wrote:
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> Signed-off-by: Thomas Zimmermann
> Cc: David Lechner
> ---
Acked-by:
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
b/drivers/gpu/drm/amd/display/dc/core/dc_resour
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
index b12651246
The variable highest_pcie_level_enabled is named
hightest_pcie_level_enabled in other modules.
Please ensure the consistency of variable naming
and use min macros instead of the triadic operator.
Signed-off-by: Yang Ruibin <11162...@vivo.com>
---
.../amd/pm/powerplay/smumgr/iceland_smumgr.c
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
index b12651246
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c
b/drivers/gpu/drm/amd/displ
dcn35_fpga_funcsc is not used anywhere, remove it.
Signed-off-by: Jinjie Ruan
---
v2:
- Remove it instead of making it static.
---
.../gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
b/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
index 9eccdb38
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
index b12651246
dcn35_fpga_funcs is not used anywhere, remove it.
Signed-off-by: Jinjie Ruan
---
v2:
- Remove it instead of making it static.
---
.../gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn3
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
b/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
index 9eccdb38
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c
b/drivers/gpu/drm/amd/displ
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
b/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
index 9eccdb38
Use the macro instead of ternary operator.
Signed-off-by: Yu Jiaoliang
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
b/drivers/gpu/drm/amd/display/dc/bios/bios_parse
On 8/21/24 7:59 AM, Thomas Zimmermann wrote:
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> Signed-off-by: Thomas Zimmermann
> Cc: David Lechner
> ---
Acked-by:
*** BLURB HERE ***
Yu Jiaoliang (6):
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drm/amd/display: Use max/min macro
drivers/gpu/drm/amd/display/dc/bios/b
On 21.08.24 22:46, Felix Kuehling wrote:
On 2024-08-21 08:03, Christian König wrote:
Rework how VM operations synchronize to submissions. Provide an
amdgpu_sync container to the backends instead of an reservation
object and fill in the amdgpu_sync object in the higher layers
of the code.
No in
On 8/21/24 14:59, Thomas Zimmermann wrote:
> Call drm_client_setup_with-fourcc() to run the kernel's default client
> setup for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> v2:
> - use drm_client_setup_with_fourcc()
>
> Signed-off-by
Am 21.08.24 um 22:01 schrieb Felix Kuehling:
On 2024-08-21 08:03, Christian König wrote:
This patch tries to solve the basic problem we also need to sync to
the KFD fences of the BO because otherwise it can be that we clear
PTEs while the KFD queues are still running.
This is going to trigger
Implement the compute pipe reset and driver will
fallback to pipe reset when queue reset failed.
Signed-off-by: Prike Liang
---
v3: Use the dev log and filer out the gfx9.4.4 pipe reset support.
v2: Convert the GC logic instance to physical instance in the
register accessing process and use t
For mes11 old firmware has issue to map legacy queue,
add a flag to switch mes to map legacy queue.
Signed-off-by: Jack Xiao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 1 +
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 49 +
Artifacts appear when using dc->current_state as the minimal transition
state in a scenario where update_planes_and_stream_state() would set the
context as the new one because the update type is FULL. To prevent those
artifacts, instead of defining the minimal state according to plane
addition (cur
On Thu, Aug 22, 2024 at 6:55 AM Jack Xiao wrote:
>
> For mes11 old firmware has issue to map legacy queue,
> add a flag to switch mes to map legacy queue.
>
Reported-by: Andrew Worsley
Link: https://lists.freedesktop.org/archives/amd-gfx/2024-August/112773.html
> Signed-off-by: Jack Xiao
> ---
On 8/22/2024 01:12, Thomas Weißschuh wrote:
On 2024-08-21 15:51:17+, Mario Limonciello wrote:
On 8/18/2024 01:56, Thomas Weißschuh wrote:
Panels using a PWM-controlled backlight source do not have a standard
way to communicate their valid PWM ranges.
On x86 the ranges are read from ACPI thr
On 8/22/2024 01:14, Thomas Weißschuh wrote:
On 2024-08-21 15:54:14+, Mario Limonciello wrote:
On 8/18/2024 01:56, Thomas Weißschuh wrote:
Not all platforms provide correct PWM backlight capabilities through ATIF.
I don't think correct is an accurate term here. How about 'optimial'?
Loo
On 8/21/24 09:00, Thomas Zimmermann wrote:
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbdev_probe in struct drm_driver, so that the client
setup can start the common fbdev client.
The amdgpu driver specifies a preferred color mode depending on
the available vid
On 7/23/2024 04:42, Lu Yao wrote:
[Why]
When running kdump test on a machine with R7340 card, a hang is caused due
to the failure of 'amdgpu_device_ip_init()', error message as follows:
'[drm:amdgpu_device_ip_init [amdgpu]] *ERROR* hw_init of IP block
failed -22'
'[drm:uvd_v3_1_hw_init [
在 2024/8/22 14:57, Yu Jiaoliang 写道:
> *** BLURB HERE ***
>
> Yu Jiaoliang (6):
>drm/amd/display: Use max/min macro
>drm/amd/display: Use max/min macro
>drm/amd/display: Use max/min macro
>drm/amd/display: Use max/min macro
>drm/amd/display: Use max/min macro
>drm/amd/display
The variable highest_pcie_level_enabled is named
hightest_pcie_level_enabled in other modules.
Please ensure the consistency of variable naming
and use min macros instead of the triadic operator.
Signed-off-by: Yang Ruibin <11162...@vivo.com>
---
.../drm/amd/pm/powerplay/smumgr/tonga_smumgr.c |
Alex Deucher wrote:
> On Wed, Aug 21, 2024 at 3:45â¯AM Ma Ke wrote:
> >
> > Instead of using state->fb->obj[0] directly, get object from framebuffer
> > by calling drm_gem_fb_get_obj() and return error code when object is
> > null to avoid using null object of framebuffer.
> >
> > Cc: sta...@vger
Hi!
> From: Tim Huang
>
> [ Upstream commit 9a5f15d2a29d06ce5bd50919da7221cda92afb69 ]
>
> Clear warning that uses uninitialized value fw_size.
This is queued for 5.15 and 6.10, but not 6.1, for example. Mistake?
Best regards,
Pa
Sorry, please ignore this patch.
Because the corresponding header file is not included, there may be
compilation errors.
在 2024/8/22 14:57, Yang Ruibin 写道:
Instead of using the min() implementation of
the ternary operator, use real macros.
Signed-off-by: Yang Ruibin <11162...@vivo.com>
---
On 2024-08-21 19:22, Ramesh Errabolu
wrote:
KFD's design of unified memory (UM) does not allow users to
configure the size of buffer used in migrating buffer either
from Sysmem to VRAM or vice versa.
This is not true, app can change range granularit
On Wed, Aug 21, 2024 at 9:06 AM Thomas Zimmermann wrote:
>
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> The amdgpu driver specifies a preferred color mode depend
On 2024-07-30 16:15, Philip Yang wrote:
Document how to use SMI system management interface to enable and
receive SVM events. Document SVM event triggers.
Define SVM events message string format macro that could be used by user
mode for sscanf to parse the event. Add it to uAPI header file to ma
On 2024-07-30 16:15, Philip Yang wrote:
SMI event fifo size 1KB was enough to report GPU vm fault or reset
[JZ] There is a typo here. it should be NOT enough.
event, increase it to 8KB to store about 100 migrate events, less chance
to drop the migrate events if lots of migration happened in t
On Wed, Aug 21, 2024 at 10:12 PM Candice Li wrote:
>
> Drop unsupported features on smu v14_0_2.
>
> Signed-off-by: Candice Li
> Reviewed-by: Yang Wang
Acked-by: Alex Deucher
> ---
> .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 47 ---
> 1 file changed, 47 deletions(-)
>
>
Hi
Am 12.08.24 um 08:59 schrieb Al Viro:
Once something had been put into descriptor table, the only thing you
can do with it is returning descriptor to userland - you can't withdraw
it on subsequent failure exit, etc. You certainly can't count upon
it staying in the same slot of descriptor tab
On 2024-07-30 16:15, Philip Yang wrote:
Add new SMI event to report the dropped event count when the event kfifo
is full.
When the kfifo has space for two events, generate a dropped event record
to report how many events were dropped, together with the next event to
add to kfifo.
After readin
Alex Deucher writes:
Hello Alex,
> In aperture_remove_conflicting_pci_devices(), we currently only
> call sysfb_disable() on vga class devices. This leads to the
> following problem when the pimary device is not VGA compatible:
>
> 1. A PCI device with a non-VGA class is the boot display
> 2. T
On 2024-08-21 08:57, Yang Wang wrote:
> Add list empty check to avoid null pointer issues in some corner cases.
> - list_for_each_entry_safe()
What corner cases?
If the list is empty, list_for_each_entry_safe() should be mostly a no-op.
--
Earthling Michel Dänzer \GNOME / Xwaylan
On 2024-08-21 18:01, Xiaogang.Chen
wrote:
From: Xiaogang Chen
When app unmap vm ranges(munmap) kfd/svm starts drain pending page fault and
not handle any incoming pages fault of this process until a deferred work item
got executed by default system wq. The
Hi Harry,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on drm-exynos/exynos-drm-next drm-intel/for-linux-next
drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip
linus/master v6.11-rc4 next-20240822]
[If
On 2024-08-22 10:32, James Zhu wrote:
On 2024-07-30 16:15, Philip Yang
wrote:
Document how to use SMI system management interface to enable and
receive SVM events. Document SVM event triggers.
Define SVM events message stri
On 2024-08-22 10:34, James Zhu wrote:
On 2024-07-30 16:15, Philip Yang wrote:
SMI event fifo size 1KB was enough to
report GPU vm fault or reset
[JZ] There is a typo here. it should be NOT enough.
It
[Public]
> -Original Message-
> From: Kuehling, Felix
> Sent: Wednesday, August 21, 2024 5:51 PM
> To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org
> Cc: Kasiviswanathan, Harish ; Deucher,
> Alexander
> Subject: Re: [PATCH] drm/amdkfd: fix missed queue reset on queue destroy
>
>
> On 20
Am 21.08.24 um 21:11 schrieb Alex Deucher:
In aperture_remove_conflicting_pci_devices(), we currently only
call sysfb_disable() on vga class devices. This leads to the
following problem when the pimary device is not VGA compatible:
1. A PCI device with a non-VGA class is the boot display
2.
Am 21.08.24 um 21:11 schrieb Alex Deucher:
In aperture_remove_conflicting_pci_devices(), we currently only
call sysfb_disable() on vga class devices. This leads to the
following problem when the pimary device is not VGA compatible:
1. A PCI device with a non-VGA class is the boot display
2.
If a queue is being destroyed but causes a HWS hang on removal, the KFD
may issue an unnecessary gpu reset if the destroyed queue can be fixed
by a queue reset.
This is because the queue has been removed from the KFD's queue list
prior to the preemption action on destroy so the reset call will fai
Hook up drm_crtc_vblank_on_config() in amdgpu_dm. So, that we can enable
PSR and other static screen optimizations more quickly, while avoiding
stuttering issues that are accompanied by the following dmesg error:
[drm:dc_dmub_srv_wait_idle [amdgpu]] *ERROR* Error waiting for DMUB idle:
status=3
Ideally, we want to drop the legacy vblank enable for older ASICs. This
should be possible now, since we can now specify how many frames we need
to wait before disabling vblanking instead of being forced to either
choose between no delay (which can still be buggy) and
drm_vblank_offdelay (which is
Ideally, we want to enable immediate vblank disable, when possible and
we should be able to do so on DCN35+, if PSR isn't supported by a given
CRTC.
Suggested-by: Leo Li
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++-
1 file changed, 6 insertions(
Since, drm_crtc_vblank_on_config() was recently introduced, we want to
apply laxer vblanking policies across the board, since:
1. It will allow us to shut down interrupts faster for better power
savings.
2. As a payment towards tech debt, since drm_vblank_offdelay (which
defaults to 5s) isn
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Alex Deucher
From: amd-gfx on behalf of Lijo Lazar
Sent: Thursday, August 22, 2024 12:20 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Deucher, Alexander
; Kamal, Asad ; Kamal, Asa
On Thu, Aug 22, 2024 at 3:49 AM Yang Ruibin <11162...@vivo.com> wrote:
>
> The variable highest_pcie_level_enabled is named
> hightest_pcie_level_enabled in other modules.
hightest is a typo. It should be highest. Please fix up the
misspellings instead.
Alex
> Please ensure the consistency of
On Wed, Aug 21, 2024 at 9:06 AM Thomas Zimmermann wrote:
>
> Rework fbdev probing to support fbdev_probe in struct drm_driver
> and remove the old fb_probe callback. Provide an initializer macro
> for struct drm_driver that sets the callback according to the kernel
> configuration.
>
> Call drm_cl
Applied. Thanks!
On Wed, Aug 21, 2024 at 3:45 AM Ma Ke wrote:
>
> Instead of using state->fb->obj[0] directly, get object from framebuffer
> by calling drm_gem_fb_get_obj() and return error code when object is
> null to avoid using null object of framebuffer.
>
> Cc: sta...@vger.kernel.org
> Fix
On Thu, Aug 22, 2024 at 5:20 AM Jinjie Ruan wrote:
>
> dcn35_fpga_funcs is not used anywhere, remove it.
This will lead to warnings about unused functions. The fpga specific
functions should be removed as well. I'd suggest compile testing your
changes first to catch these types of warnings.
Al
On Wed, Aug 21, 2024 at 8:29 PM Al Viro wrote:
>
> On Wed, Aug 14, 2024 at 06:15:46PM -0400, Felix Kuehling wrote:
> >
> > On 2024-08-12 02:59, Al Viro wrote:
> > > Using drm_gem_prime_handle_to_fd() to set dmabuf up and insert it into
> > > descriptor table, only to have it looked up by file desc
On Thu, Aug 22, 2024 at 2:57 AM Yu Jiaoliang wrote:
>
> *** BLURB HERE ***
>
> Yu Jiaoliang (6):
> drm/amd/display: Use max/min macro
> drm/amd/display: Use max/min macro
> drm/amd/display: Use max/min macro
> drm/amd/display: Use max/min macro
> drm/amd/display: Use max/min macro
> dr
On 2024-08-22 11:58, Hamza Mahfooz wrote:
> Hook up drm_crtc_vblank_on_config() in amdgpu_dm. So, that we can enable
> PSR and other static screen optimizations more quickly, while avoiding
> stuttering issues that are accompanied by the following dmesg error:
>
> [drm:dc_dmub_srv_wait_idle [am
On 2024-08-22 11:58, Hamza Mahfooz wrote:
> Since, drm_crtc_vblank_on_config() was recently introduced, we want to
> apply laxer vblanking policies across the board, since:
>
> 1. It will allow us to shut down interrupts faster for better power
>savings.
>
> 2. As a payment towards tech debt,
338567d176 ("drm/amd/display: Fix MST BW calculation Regression") has been
merged
with a mistake being fixed by "drm/amd/display: Fix a mistake in revert commit"
Fix dsc enablement for Synaptics Cascaded Panamera hub is included in
"drm/amd/display: Fix Synaptics Cascaded DSC Determination"
Ple
Synaptics Cascaded Panamera topology needs to unconditionally
acquire root aux for dsc decoding.
Signed-off-by: Fangzhi Zuo
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/am
[why]
It is to fix in try_disable_dsc() due to misrevert patch of
"drm/amd/display: Fix MST BW calculation Regression"
[How]
Fix restoring minimum compression bw by 'max_kbps', instead of
native bw 'stream_kbps'
Signed-off-by: Fangzhi Zuo
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_
Print the index for the profiles.
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3543
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0
This is an additional patch to be included in this week's promotion
series:
* Uses SPDX Copyright for spl_os_types.h
Cc: Daniel Wheeler
Zaeem Mohamed (1):
drm/amdgpu/display: SPDX copyright for spl_os_types.h
.../gpu/drm/amd/display/dc/spl/spl_os_types.h | 29 +++
1 file chan
Use appropriate SPDX copyright for spl_os_types.h
Signed-off-by: Zaeem Mohamed
---
.../gpu/drm/amd/display/dc/spl/spl_os_types.h | 29 +++
1 file changed, 4 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/spl/spl_os_types.h
b/drivers/gpu/drm/amd/displ
The kernel doc says you need to select manual mode to
adjust this, but the code only allows you to adjust it when
manual mode is not selected. Remove the manual mode check.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 6 ++
1 file changed, 2 insertions(+), 4 d
No change in functionality for the current code, but we
need to set the index properly before changing it if we
ever use a non-0 index.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/am
[AMD Official Use Only - AMD Internal Distribution Only]
Series is Reviewed-by: Kenneth Feng
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Friday, August 23, 2024 10:12 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 2/2] drm/amdgpu/swsmu
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Kenneth Feng
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Friday, August 23, 2024 5:55 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu/smu13.0.7: print ind
Hi Jinjie,
kernel test robot noticed the following build warnings:
[auto build test WARNING on next-20240821]
url:
https://github.com/intel-lab-lkp/linux/commits/Jinjie-Ruan/drm-amd-display-Remove-unused-dcn35_fpga_funcs/20240822-095139
base: next-20240821
patch link:
https
1 - 100 of 103 matches
Mail list logo
