Hi Thomas,
Le vendredi 16 août 2024 à 14:22 +0200, Thomas Zimmermann a écrit :
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> The ingenic driver specifies a prefe
Reviewed-by: Deepak Rawat
On Fri, Aug 16, 2024 at 5:54 AM Thomas Zimmermann wrote:
>
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> Signed-off-by: Thomas Zimmerm
Hello,
On Sat, 2024-07-27 at 19:52 +0300, serg.parti...@gmail.com wrote:
> Hello,
>
> After updating from 6.8.9 to 6.9.1 I noticed a bug on my HP Envy x360
> with AMD Ryzen 5 4500U.
>
> #regzbot introduced: v6.8.9..v6.9.1
>
> After waking up from sleep brightness is set to max level, ignoring
On 8/16/24 14:22, Thomas Zimmermann wrote:
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> Signed-off-by: Thomas Zimmermann
> Cc: "Noralf Trønnes"
> ---
> dri
On Sat, Aug 17, 2024 at 10:30:41PM +0200, Kevin Holm wrote:
>
>
> On 17.08.24 10:42, Greg KH wrote:
> > On Tue, Jul 30, 2024 at 08:53:39PM +0200, Kevin Holm wrote:
> > > From: Wayne Lin
> > >
> > > [ Upstream commit fa57924c76d995e87ca3533ec60d1d5e55769a27 ]
> > >
> > > [Why]
> > > dm_dp_mst_i
From: "Dustin L. Howett"
I have tested these panels on the Framework Laptop 13 AMD with firmware
revision 3.05 (latest at time of submission).
Signed-off-by: Dustin L. Howett
---
drivers/gpu/drm/drm_panel_backlight_quirks.c | 16
1 file changed, 16 insertions(+)
diff --git a/
On 17.08.24 10:42, Greg KH wrote:
On Tue, Jul 30, 2024 at 08:53:39PM +0200, Kevin Holm wrote:
From: Wayne Lin
[ Upstream commit fa57924c76d995e87ca3533ec60d1d5e55769a27 ]
[Why]
dm_dp_mst_is_port_support_mode() is a bit not following the original design
rule and cause
light up issue with m
drm_edid_is_valid() does not modify its argument, so mark it as const.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/drm_edid.c | 2 +-
include/drm/drm_edid.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
The AMD DRM drivers use 'struct edid', raw pointers and even custom
structs to represent EDID data.
Uniformly switch to the safe and recommended "struct drm_edid".
Some uses of "struct edid" are left because some ad-hoc parsing is still
being done inside the drivers.
The patch "drm/amd/display: S
The argument edid is passed in as const.
Preserve this constness through the edid_buf variable and the used
helper functions.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/
Panels using a PWM-controlled backlight source do not have a standard
way to communicate their valid PWM ranges.
On x86 the ranges are read from ACPI through driver-specific tables.
The built-in ranges are not necessarily correct, or may grow stale if an
older device can be retrofitted with newer p
The value of "min_input_signal" returned from ATIF on a Framework AMD 13
is "12". This leads to a fairly bright minimum display backlight.
Add a quirk to override that the minimum backlight PWM to "0" which
leads to a much lower minimum brightness, which is still visible.
Tested on a Framework AM
Not all platforms provide correct PWM backlight capabilities through ATIF.
Use the generic drm panel minimum backlight quirk infrastructure to
override the capabilities where necessary.
Signed-off-by: Thomas Weißschuh
Tested-by: Dustin L. Howett
---
drivers/gpu/drm/amd/amdgpu/Kconfig
"struct drm_edid" is the safe and recommended alternative to "struct edid".
Rename the member to make sure that no usage sites are missed,
as "struct drm_edid" has some restrictions, for example it can not be
used with kfree().
Signed-off-by: Thomas Weißschuh
---
This is only compile-tested.
---
The value of "min_input_signal" returned from ATIF on a Framework AMD 13
is "12". This leads to a fairly bright minimum display backlight.
Introduce a quirk to override "min_input_signal" to "0" which leads to a
much lower minimum brightness, which is still readable even in daylight.
Tested on a
Reduce the number of casts needed by reusing the edid_buf variable.
Also initialize edid_buf after the !edid case has been handled to avoid
the ternary expression.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 8 +---
1 file changed, 5 insert
The parsing functions do not modify their edid argument.
Mark the const to reflect this to the caller.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +++---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +-
2 files changed, 8 insertio
"struct drm_edid" is the safe and recommended alternative to "struct edid".
Now that all callers of dc_link_add_remote_sink() have access to a
validate struct drm_edid, pass it around directly.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
The callers of dc_link_add_remote_sink() are using 'struct edid' which
they all need to cast to uint8_t *.
Allow the direct passing of 'struct edid' to avoid these cast and also
move the length calculation so it does not need to be duplicated
everywhere.
Signed-off-by: Thomas Weißschuh
---
drive
All usages of these fields have been removed.
Fixes: 7c7f5b15be65 ("drm/amd/display: Refactor edid read.")
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/dc/dc_ddc_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_ddc_types.h
b/dri
"struct drm_edid" is the safe and recommended alternative to "struct edid".
Rename the member to make sure that no usage sites are missed,
as "struct drm_edid" has some restrictions, for example it can not be
used with kfree().
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/amdgpu/amdg
"struct drm_edid" is the safe and recommended alternative to "struct edid".
Rename the member to make sure that no usage sites are missed,
as "struct drm_edid" has some restrictions, for example it can not be
used with kfree().
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/amd
As struct drm_edid is opaque, drivers can't directly memcmp() the
contained data. Add a helper to provide this functionality.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/drm_edid.c | 18 ++
include/drm/drm_edid.h | 1 +
2 files changed, 19 insertions(+)
diff --git a
The custom "struct dc_edid" can be replaced by the standard "struct
drm_edid.
Rename the member to make sure that no usage sites are missed,
as "struct drm_edid" has some restrictions, for example it can not be
used with kfree().
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/a
The prototype is the whole content of commit
575d0df6dae4 ("drm/amd/display: refine the EDID override").
Apparently the definition was never added.
Fixes: 575d0df6dae4 ("drm/amd/display: refine the EDID override")
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/dc/dm_helpers.h |
From: Tatsuyuki Ishi
In Vulkan, it is the application's responsibility to perform adequate
synchronization before a sparse unmap, replace or BO destroy operation.
Until now, the kernel applied the same rule as implicitly-synchronized
APIs like OpenGL, which with per-VM BOs made page table updates
On Tue, Jul 30, 2024 at 08:53:39PM +0200, Kevin Holm wrote:
> From: Wayne Lin
>
> [ Upstream commit fa57924c76d995e87ca3533ec60d1d5e55769a27 ]
>
> [Why]
> dm_dp_mst_is_port_support_mode() is a bit not following the original design
> rule and cause
> light up issue with multiple 4k monitors afte
From: Tatsuyuki Ishi
For detection of the new explicit sync functionality without having to try
the ioctl.
Signed-off-by: Tatsuyuki Ishi
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/
From: Tatsuyuki Ishi
These are considered map operations rather than unmap, and there is no
point of doing implicit synchronization here.
Signed-off-by: Tatsuyuki Ishi
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
In Vulkan, it is the application's responsibility to perform adequate
synchronization before a sparse unmap, replace or BO destroy operation.
This adds an option to AMDGPU_VA_OPs to disable redundant implicit sync
that happens on sparse unmap or replace operations.
This has seen a significant impr
FTR:
Delivery has failed to these recipients or groups:
Ma Jun (jun@amd.com)
The email address you entered couldn't be found
So the author of the patch CANNOT respond. Anyone else?
On 19. 08. 24, 9:49, Jiri Slaby wrote:
On 12. 08. 24, 18:01, Greg Kroah-Hartman wrote:
6.10-stable review patc
Hi
Am 16.08.24 um 22:57 schrieb Alex Deucher:
On Mon, Aug 12, 2024 at 8:10 AM Thomas Zimmermann wrote:
Hi
Am 10.08.24 um 13:44 schrieb kernel test robot:
Hi Alex,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR
On Sun, 18 Aug 2024, Thomas Weißschuh wrote:
> drm_edid_is_valid() does not modify its argument, so mark it as const.
That's not true.
BR,
Jani.
>
> Signed-off-by: Thomas Weißschuh
> ---
> drivers/gpu/drm/drm_edid.c | 2 +-
> include/drm/drm_edid.h | 2 +-
> 2 files changed, 2 insertions(
Am 05.08.24 um 09:34 schrieb Nikita Zhandarovich:
On 7/30/24 23:56, Christian König wrote:
Am 30.07.24 um 19:36 schrieb Nikita Zhandarovich:
On 7/29/24 11:12, Christian König wrote:
Am 29.07.24 um 20:04 schrieb Christian König:
Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich:
Hi,
On 7/29/
On Sun, 18 Aug 2024, Thomas Weißschuh wrote:
> "struct drm_edid" is the safe and recommended alternative to "struct edid".
>
> Rename the member to make sure that no usage sites are missed,
> as "struct drm_edid" has some restrictions, for example it can not be
> used with kfree().
>
> Signed-off-
Am 05.08.24 um 16:01 schrieb Arunpravin Paneer Selvam:
We require this flag AMDGPU_GEM_CREATE_GFX12_DCC or any other
kernel level GFX12 DCC flag to differentiate the DCC buffers and other
pinned display buffers(which has TTM_PL_FLAG_CONTIGUOUS enabled).
That's a pretty bad idea, the DCC flag is
On 16. 08. 24, 21:30, Li, Roman wrote:
[Public]
Wiil update commit message as:
-
drm/amd/display: Fix MST DSC lightup
[Why]
Secondary monitor does not come up due to MST DSC bw calculation regression.
This patch is only related to this. It does not fix that issue on its
own at a
On Sun, 18 Aug 2024, Thomas Weißschuh wrote:
> As struct drm_edid is opaque, drivers can't directly memcmp() the
> contained data. Add a helper to provide this functionality.
I'm not sure why drivers would need to compare EDIDs.
The only user was added in commit eb815442e840 ("drm/amd/display: d
On Sun, 18 Aug 2024, Thomas Weißschuh wrote:
> "struct drm_edid" is the safe and recommended alternative to "struct edid".
>
> Rename the member to make sure that no usage sites are missed,
> as "struct drm_edid" has some restrictions, for example it can not be
> used with kfree().
>
> Signed-off-
[AMD Official Use Only - AMD Internal Distribution Only]
> -Original Message-
> From: Alex Deucher
> Sent: Friday, August 16, 2024 9:43 PM
> To: Huang, Trigger
> Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil ;
> Deucher, Alexander
> Subject: Re: [PATCH 1/3] drm/amdgpu: Add gpu_coredu
[AMD Official Use Only - AMD Internal Distribution Only]
> -Original Message-
> From: Alex Deucher
> Sent: Friday, August 16, 2024 9:52 PM
> To: Huang, Trigger
> Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil ;
> Deucher, Alexander
> Subject: Re: [PATCH 3/4] drm/amdgpu: skip printing
[AMD Official Use Only - AMD Internal Distribution Only]
> -Original Message-
> From: Alex Deucher
> Sent: Friday, August 16, 2024 9:59 PM
> To: Huang, Trigger
> Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil ;
> Deucher, Alexander
> Subject: Re: [PATCH 4/4] drm/amdgpu: Do core dump i
From: Trigger Huang
The current dev coredump implementation sometimes cannot fully satisfy
customer's requirements due to:
1, dev coredump is called in GPU reset function, so if GPU reset is disabled,
the dev coredump is also disabled
2, When job timeout happened, the dump GPU status will be ha
From: Trigger Huang
Do the coredump immediately after a job timeout to get a closer
representation of GPU's error status.
V2: This will skip printing vram_lost as the GPU reset is not
happened yet (Alex)
V3: Unconditionally call the core dump as we care about all the reset
functions(soft-recove
From: Trigger Huang
The vm lost status can only be obtained after a GPU reset occurs, but
sometimes a dev core dump can be happened before GPU reset. So a new
argument is added to tell the dev core dump implementation whether to
skip printing the vram_lost status in the dump.
And this patch is al
On 8/19/2024 3:23 PM, trigger.hu...@amd.com wrote:
From: Trigger Huang
Do the coredump immediately after a job timeout to get a closer
representation of GPU's error status.
V2: This will skip printing vram_lost as the GPU reset is not
happened yet (Alex)
V3: Unconditionally call the core du
Am 06.08.24 um 18:00 schrieb David (Ming Qiang) Wu:
Add JPEG IB command parser to ensure registers
in the command are within the JPEG IP block.
You should probably re-order the patches so that the cleanup comes first
and then the new functionality.
Apart from that looks good to me.
Regards,
Am 19.08.24 um 09:21 schrieb Friedrich Vock:
In Vulkan, it is the application's responsibility to perform adequate
synchronization before a sparse unmap, replace or BO destroy operation.
This adds an option to AMDGPU_VA_OPs to disable redundant implicit sync
that happens on sparse unmap or replac
Hi Christian,
On 8/19/2024 1:59 PM, Christian König wrote:
Am 05.08.24 um 16:01 schrieb Arunpravin Paneer Selvam:
We require this flag AMDGPU_GEM_CREATE_GFX12_DCC or any other
kernel level GFX12 DCC flag to differentiate the DCC buffers and other
pinned display buffers(which has TTM_PL_FLAG_CON
Hi, Thomas
I love your patch, yet ...
On 2024/8/16 20:23, Thomas Zimmermann wrote:
i915's fbdev contains additional code for hotplugging a display that
cannot be ported to the common fbdev client. Introduce the callback
struct drm_fb_helper.fb_hotplug and implement it for i915. The fbdev
help
Hi,
On 2024/8/16 20:23, Thomas Zimmermann wrote:
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbdev_probe in struct drm_driver, so that the client
setup can start the common fbdev client.
The loongson driver specifies a preferred color mode of 32. As this
is th
Thomas Zimmermann writes:
Hello Alex and Thomas,
> Hi
>
> Am 16.08.24 um 22:57 schrieb Alex Deucher:
>> On Mon, Aug 12, 2024 at 8:10 AM Thomas Zimmermann
>> wrote:
>>> Hi
>>>
>>> Am 10.08.24 um 13:44 schrieb kernel test robot:
Hi Alex,
kernel test robot noticed the following bui
On Mon, Aug 19, 2024 at 9:55 AM Andrew Worsley wrote:
>
> The v6.11-rc4 linux hangs during amdgpu start up where as the v6.10.0
> is fine. I had to take a photo of the screen (see attachment) from
> which I generated
> the following summary:
>
> Booting linux v6.11-rc4 :
> ...
> amdgpu: Virtua
On Thu, Aug 15, 2024 at 09:37:31AM +0100, Tvrtko Ursulin wrote:
>
> On 13/08/2024 19:47, Rob Clark wrote:
> > On Tue, Aug 13, 2024 at 6:57 AM Tvrtko Ursulin wrote:
> > >
> > > From: Tvrtko Ursulin
> > >
> > > Currently it is not well defined what is drm-memory- compared to other
> > > categori
[Public]
Thank you, Jiri, for your feedback.
I've dropped this patch from DC v.3.2.297.
We will follow-up on this separately and merge it after you do confirm the
issue you reported is fixed.
Thanks,
Roman
> -Original Message-
> From: Jiri Slaby
> Sent: Monday, August 19, 2024 4:37 AM
On 08/18, Thomas Weißschuh wrote:
> The AMD DRM drivers use 'struct edid', raw pointers and even custom
> structs to represent EDID data.
> Uniformly switch to the safe and recommended "struct drm_edid".
>
> Some uses of "struct edid" are left because some ad-hoc parsing is still
> being done insi
On 2024-08-16 18:57, sunpeng...@amd.com wrote:
> From: Leo Li
>
> [Why]
>
> Idle power states (IPS) describe levels of power-gating within DCN. DM
> and DC is responsible for ensuring that we are out of IPS before any DCN
> programming happens. Any DCN programming while we're in IPS leads to
Am 07.08.24 um 22:33 schrieb Bas Nieuwenhuizen:
On Wed, Aug 7, 2024 at 10:25 PM Faith Ekstrand
wrote:
On Wed, Aug 7, 2024 at 2:23 PM Joshua Ashton wrote:
I was thinking about this more recently. I was initially
considering "maybe this should be a per-BO import," but I
On Mon, Aug 19, 2024 at 4:51 PM Christian König <
ckoenig.leichtzumer...@gmail.com> wrote:
> Am 07.08.24 um 22:33 schrieb Bas Nieuwenhuizen:
>
> On Wed, Aug 7, 2024 at 10:25 PM Faith Ekstrand
> wrote:
>
>> On Wed, Aug 7, 2024 at 2:23 PM Joshua Ashton wrote:
>>
>>> I was thinking about this more
Am 08.08.24 um 19:48 schrieb Victor Skvortsov:
Register access from userspace should be blocked until
reset is complete.
Signed-off-by: Victor Skvortsov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 44 ++---
1 file changed, 32 insertions(+), 12 deletions(-)
diff --git a
Am 19.08.24 um 10:04 schrieb Thomas Zimmermann:
Hi
Am 16.08.24 um 22:57 schrieb Alex Deucher:
On Mon, Aug 12, 2024 at 8:10 AM Thomas Zimmermann
wrote:
Hi
Am 10.08.24 um 13:44 schrieb kernel test robot:
Hi Alex,
kernel test robot noticed the following build errors:
[auto build test ERRO
Traditional utcl2 fault_status polling does not
work in SRIOV environment. The polling of fault
status register from guest side will be dropped
by hardware.
Driver should switch to check utcl2 interrupt
source id to identify utcl2 poison event. It is
set to 1 when poisoned data interrupts are
sign
Not supported.
Signed-off-by: Hawking Zhang
---
.../gpu/drm/amd/amdkfd/kfd_int_process_v10.c | 71 ---
1 file changed, 71 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c
b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c
index 8e0d0356e810..bb8cbfc39
Driver switches to interrupt source id to identify
utcl2 poison event. polling interface is not needed.
Signed-off-by: Hawking Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 16
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 --
drivers/gpu/drm/amd/amdgpu/amdgpu_gfxhub.
The driver needs to wait for the on board firmware
to finish its initialization before probing the card.
Commit 959056982a9b ("drm/amdgpu: Fix discovery initialization failure during
pci rescan")
switched from using msleep() to using usleep_range() which
seems to have caused init failures on some
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Monday, August 19, 2024 23:24
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Ma Jun
Subject: [PATCH] drm/amd
On 16/08/2024 14:22, Thomas Zimmermann wrote:
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbdev_probe in struct drm_driver, so that the client
setup can start the common fbdev client.
Signed-off-by: Thomas Zimmermann
Cc: Neil Armstrong
Cc: Jessica Zhang
---
On 16/08/2024 14:22, Thomas Zimmermann wrote:
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbdev_probe in struct drm_driver, so that the client
setup can start the common fbdev client.
Signed-off-by: Thomas Zimmermann
Cc: Neil Armstrong
Cc: Jessica Zhang
---
On Mon, Aug 19, 2024 at 10:00 AM Bas Nieuwenhuizen
wrote:
>
>
> On Mon, Aug 19, 2024 at 4:51 PM Christian König <
> ckoenig.leichtzumer...@gmail.com> wrote:
>
>> Am 07.08.24 um 22:33 schrieb Bas Nieuwenhuizen:
>>
>> On Wed, Aug 7, 2024 at 10:25 PM Faith Ekstrand
>> wrote:
>>
>>> On Wed, Aug 7, 2
Thomas Zimmermann writes:
Hello Thomas,
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Thomas Zimmermann
> Cc: Javier Ma
Thomas Zimmermann writes:
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Thomas Zimmermann
> Cc: Javier Martinez Canillas
Thomas Zimmermann writes:
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> The solomon driver specifies a preferred color mode of 32. As this
> is the default if no
In aperture_remove_conflicting_pci_devices(), we currently only
call sysfb_disable() on vga class devices. This leads to the
following problem when the pimary device is not VGA compatible:
1. A PCI device with a non-VGA class is the boot display
2. That device is probed first and it is not a VGA
I forgot to update the patch title but it should probably be something like:
video/aperture: optionally match the device in sysfb_disable()
Alex
On Mon, Aug 19, 2024 at 1:00 PM Alex Deucher wrote:
>
> In aperture_remove_conflicting_pci_devices(), we currently only
> call sysfb_disable() on vga
Alex Deucher writes:
Hello Alex,
> In aperture_remove_conflicting_pci_devices(), we currently only
> call sysfb_disable() on vga class devices. This leads to the
> following problem when the pimary device is not VGA compatible:
>
> 1. A PCI device with a non-VGA class is the boot display
> 2. T
Currently multiple partitions will incorrectly overwrite the VM lookup
table since the table is indexed by PASID and multiple partitions can
register different VM objects on the same PASID.
This results in loading the wrong VM object on PASID query.
To correct this, setup the lookup table to be p
On 2024-08-19 10:41, Harry Wentland wrote:
On 2024-08-16 18:57, sunpeng...@amd.com wrote:
From: Leo Li
[Why]
Idle power states (IPS) describe levels of power-gating within DCN. DM
and DC is responsible for ensuring that we are out of IPS before any DCN
programming happens. Any DCN progra
From: Leo Li
[Why]
Idle power states (IPS) describe levels of power-gating within DCN. DM
and DC is responsible for ensuring that we are out of IPS before any DCN
programming happens. Any DCN programming while we're in IPS leads to
undefined behavior (mostly hangs).
Because IPS intersects with
From: Leo Li
[Why]
In preparation for enabling IPS debug flags that require DM changes,
a common entry point for allowing DC idle optimisations is needed.
[How]
Create an alias in DM for dc_allow_idle_optimizations(). Change all
calls to it into dm_allow_idle_optimizations().
No functional ch
From: Leo Li
[Why]
dc_exit_ips_for_hw_access() is the same as
dc_allow_idle_optimizations(), but with a check on whether IPS is
supported by the ASIC.
[How]
Let's also pipe it through the dm function introduced by the previous
change.
No functional changes are intended.
Signed-off-by: Leo Li
From: Leo Li
[Why]
The IPS_DISABLE_DYNAMIC configuration disables IPS in all cases except
for when the driver is put into d3 for s0ix.
[How]
Now that we have a common entry point into dc_allow_idle_optimizations
from dm, implement said configuration there.
Signed-off-by: Leo Li
---
.../gpu/
From: Leo Li
[Why]
There are currently known backlight and abm issues when IPS is enabled
on DCN35.
While the issues are being ironed out, let's default to
IPS_DISABLE_DYNAMIC so users will not experience hangs. When the issues
are resolved, this patch should be reverted.
[How]
Set the defaul
[Public]
> -Original Message-
> From: Jiri Slaby
> Sent: Monday, August 19, 2024 3:54 AM
> To: Greg Kroah-Hartman ;
> sta...@vger.kernel.org
> Cc: patc...@lists.linux.dev; Deucher, Alexander
> ; Sasha Levin ; Koenig,
> Christian ; Pan, Xinhui ;
> amd-gfx@lists.freedesktop.org
> Subject: R
CTM values are defined as signed-magnitude values. Add
a helper that converts from CTM signed-magnitude fixed
point value to the twos-complement value used by
drm_fixed.
Signed-off-by: Harry Wentland
---
include/drm/drm_fixed.h | 18 ++
1 file changed, 18 insertions(+)
diff --gi
fixp2int always rounds down, fixp2int_ceil rounds up. We need
the new fixp2int_round.
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/vkms/vkms_composer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/vkms_composer.c
b/drivers/gpu/drm/vkms/vkms_compo
This is an RFC set for a color pipeline API, along with implementations
in VKMS and amdgpu. It is tested with a set of IGT tests that can be
found at [1]. The IGT tests run a pixel-by-pixel comparison with an
allowable delta variation as the goal for these transformations is
perceptual correctness,
Signed-off-by: Harry Wentland
---
Documentation/gpu/drm-kms.rst | 15 +++
drivers/gpu/drm/drm_colorop.c | 31 +++
2 files changed, 46 insertions(+)
diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst
index abfe220764e1..2292e65f044c
v5:
- Drop unused header definitions
v3:
- Read NEXT ID from drm_colorop's next pointer
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/drm_atomic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index d333433319f6..9919a6f109
v5:
- Don't require BYPASS to succeed (Sebastian)
- use DATA for 1D and 3D LUT types (Sebastian)
- update 3DLUT ops to use 3DLUT_MODES and 3DLUT_MODE_INDEX
- Add section on drm_colorop extensibility
- Add color_pipeline.rst to RFC toc tree
v4:
- Drop IOCTL docs since we dropped the IOCTLs (P
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/drm_atomic.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index b09db9835e1f..096460d38545 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b
This patches introduces a new drm_colorop mode object. This
object represents color transformations and can be used to
define color pipelines.
We also introduce the drm_colorop_state here, as well as
various helpers and state tracking bits.
v5:
- Add comment to drm_atomic_state.colorops
- Repla
v5:
- Add drm_get_colorop_curve_1d_type_name in header
- Add drm_colorop_init
- Set default curve
- Add kernel docs
v4:
- Use drm_colorop_curve_1d_type_enum_list to get name (Pekka)
- Create separate init function for 1D curve
- Pass supported TFs into 1D curve init function
Signed-off-by:
We want to be able to bypass each colorop at all times.
Introduce a new BYPASS boolean property for this.
v5:
- Drop TODO
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/drm_atomic_uapi.c | 6 +-
drivers/gpu/drm/drm_colorop.c | 15 +++
include/drm/drm_colorop.h |
Add a read-only TYPE property. The TYPE specifies the colorop
type, such as enumerated curve, 1D LUT, CTM, 3D LUT, PWL LUT,
etc.
v5:
- Add drm_get_colorop_type_name in header
- Add kernel docs
v4:
- Use enum property for TYPE (Pekka)
v3:
- Make TYPE a range property
- Move enum drm_colorop_
Debugging LUT math is much easier when we can unit test
it. Add kunit functionality to VKMS and add tests for
- get_lut_index
- lerp_u16
v5:
- Bring back static for lerp_u16 and get_lut_index (Arthur)
v4:
- Test the critical points of the lerp function (Pekka)
v3:
- Use include way of testi
We'll construct color pipelines out of drm_colorop by
chaining them via the NEXT pointer. NEXT will point to
the next drm_colorop in the pipeline, or by 0 if we're
at the end of the pipeline.
v5:
- move next comment here from Add 3x4 CTM patch (Sebastian)
- Add kernel doc
v4:
- Allow setting o
We add two 3x4 matrices into the VKMS color pipeline. The reason
we're adding matrices is so that we can test that application
of a matrix and its inverse yields an output equal to the input
image.
One complication with the matrix implementation has to do with
the fact that the matrix entries are
With the introduction of the pre-blending color pipeline we
can no longer have color operations that don't have a clear
position in the color pipeline. We deprecate all existing
plane properties. For upstream drivers those are:
- COLOR_ENCODING
- COLOR_RANGE
Drivers are expected to ignore these
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/vkms/tests/vkms_color_tests.c | 37 ++-
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/tests/vkms_color_tests.c
b/drivers/gpu/drm/vkms/tests/vkms_color_tests.c
index fc73e48aa57c..e6ac01dee830 1
From: Alex Hung
Signed-off-by: Alex Hung
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
index d260db42d407..8fc0
1 - 100 of 146 matches
Mail list logo
