Re: [PATCH 9/9] drm/tilcdc: Use backlight power constants

2024-08-02 Thread jyri . sarha
July 31, 2024 at 3:17 PM, "Thomas Zimmermann" mailto:tzimmerm...@suse.de?to=%22Thomas%20Zimmermann%22%20%3Ctzimmermann%40suse.de%3E > wrote: > > Replace FB_BLANK_ constants with their counterparts from the > backlight subsystem. The values are identical, so there's no > change in functionality o

commit 9d8c094ddab0 breaks Xorg/xfce4

2024-08-02 Thread Bert Karwatzki
Since linux-next-20240801 starting Xorg/xfce4 fails on my MSI Alpha15 Laptop. I bisected this to the following commit and reverting this in linux-next-20240801 fixes the issue for me. Gnome (with Xwayland) works as usual. 9d8c094ddab05db88d183ba82e23be807848cad8 is the first bad commit commit 9d8

[PATCH v3 0/2] drm: minimum backlight overrides and implementation for amdgpu

2024-08-02 Thread Thomas Weißschuh
The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minimum display backlight. Add a generic override helper for the user to override the settings provided by the firmware through the kernel cmdline. Also add amdgpu as a user of that help

[PATCH v3 2/2] drm/amd/display: implement minimum brightness override

2024-08-02 Thread Thomas Weißschuh
This is useful if the minimum backlight as reported by machines VBT does not match the user expectations. As an example, the minimum backlight brightness on the Framework 13 matte panel is too high. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++

[PATCH] drm/amdgpu: add dce6 drm_panic support

2024-08-02 Thread Lu Yao
Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Lu Yao --- The patch can work properly on the TTY, but after start X, drawn image is messy, it looks like the data isn't linearly arranged. However at

[PATCH -next] drm/amd/display: remove unneeded semicolon

2024-08-02 Thread Jiapeng Chong
No functional modification involved. ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c:6463:166-167: Unneeded semicolon. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9633 Signed-off-by: Jiapeng Chong --- .../display/dc/dml2/dml21/s

[PATCH v3 1/2] drm/connector: add drm_connector_get_cmdline_min_brightness_override()

2024-08-02 Thread Thomas Weißschuh
Add a helper which can read a overridden minimum backlight value from the kernel cmdline. This is useful if the minimum backlight as reported by machines VBT does not match the user expectations. As an example, the minimum backlight brightness on the Framework 13 matte panel is too high. Signed-o

Re: [PATCH v3 0/2] drm: minimum backlight overrides and implementation for amdgpu

2024-08-02 Thread Hans de Goede
Hi, On 7/31/24 10:55 PM, Daniel Vetter wrote: > On Wed, Jul 31, 2024 at 08:40:12PM +0300, Jani Nikula wrote: >> On Wed, 31 Jul 2024, Thomas Weißschuh wrote: >>> The value of "min_input_signal" returned from ATIF on a Framework AMD 13 >>> is "12". This leads to a fairly bright minimum display back

Re: [PATCH 1/3] drm/amdgpu: Forward soft recovery errors to userspace

2024-08-02 Thread Christian König
Am 01.08.24 um 17:17 schrieb Friedrich Vock: Hi, I happened to come across an issue just now again where soft recovery fails to get reported to userspace properly, causing apps to submit hanging work in a loop (which ended up hanging the entire machine) - it seems like this patch never made it i

Re: [PATCH] drm/amdgpu: add dce6 drm_panic support

2024-08-02 Thread Christian König
Am 02.08.24 um 09:17 schrieb Lu Yao: Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Lu Yao --- The patch can work properly on the TTY, but after start X, drawn image is messy, it looks like the d

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-08-02 Thread Lazar, Lijo
On 8/2/2024 12:25 AM, Marek Olšák wrote: > On Thu, Aug 1, 2024, 03:37 Christian König > wrote: > > __ > Am 01.08.24 um 08:53 schrieb Marek Olšák: >> On Thu, Aug 1, 2024, 00:28 Khatri, Sunil > > wrote: >> >> >> On

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-02 Thread Sebastian Wick
I'm very unhappy about how this has played out. We have a new sysfs property that controls a feature of the display path that has been set to a default(!) which changes the color behavior! This broke color management for everyone who is on a device which supports this feature. What should have be

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-02 Thread Harry Wentland
On 2024-08-02 09:28, Sebastian Wick wrote: > I'm very unhappy about how this has played out. > > We have a new sysfs property that controls a feature of the display > path that has been set to a default(!) which changes the color > behavior! This broke color management for everyone who is on a dev

[PATCH 1/2] Revert "drm: Introduce 'power saving policy' drm property"

2024-08-02 Thread Hamza Mahfooz
This reverts commit 76299a557f36d624ca32500173ad7856e1ad93c0. It was merged without meeting userspace requirements. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/drm_connector.c | 48 - include/drm/drm_connector.h | 2 -- include/drm/drm_mode_config.h |

[PATCH 2/2] Revert "drm/amd: Add power_saving_policy drm property to eDP connectors"

2024-08-02 Thread Hamza Mahfooz
This reverts commit 9d8c094ddab05db88d183ba82e23be807848cad8. It was merged without meeting userspace requirements. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 -- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 52 ++- .../gpu/drm/amd/dis

Re: [REGRESSION] Brightness at max level after waking up from sleep on AMD Laptop

2024-08-02 Thread Hamza Mahfooz
On 7/31/24 02:38, Linux regression tracking (Thorsten Leemhuis) wrote: [+amd-glx, +lkml, +dri-devel] On 27.07.24 18:52, serg.parti...@gmail.com wrote: After updating from 6.8.9 to 6.9.1 I noticed a bug on my HP Envy x360 with AMD Ryzen 5 4500U. [...] After waking up from sleep brightness is s

Re: [PATCH 1/2] Revert "drm: Introduce 'power saving policy' drm property"

2024-08-02 Thread Harry Wentland
On 2024-08-02 10:59, Hamza Mahfooz wrote: > This reverts commit 76299a557f36d624ca32500173ad7856e1ad93c0. > > It was merged without meeting userspace requirements. > > Signed-off-by: Hamza Mahfooz Series is: Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/drm_connector.c | 48

[PATCH] drm/amdkfd: Handle queue destroy buffer access race

2024-08-02 Thread Philip Yang
Add helper function kfd_queue_unreference_buffers to reduce queue buffer refcount, separate it from release queue buffers. Because it is circular locking to hold dqm_lock to take vm lock, kfd_ioctl_destroy_queue should take vm lock, unreference queue buffers first, but not release queue buffers, t

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-02 Thread Sebastian Wick
On Fri, Aug 2, 2024 at 4:37 PM Harry Wentland wrote: > > On 2024-08-02 09:28, Sebastian Wick wrote: > > I'm very unhappy about how this has played out. > > > > We have a new sysfs property that controls a feature of the display > > path that has been set to a default(!) which changes the color > >

[PATCH] drm/amdkfd: fallback to pipe reset on queue reset fail for gfx9

2024-08-02 Thread Jonathan Kim
If queue reset fails, tell the CP to reset the pipe. Since queues multiplex context per pipe and we've issues a device wide preemption prior to the hang, we can assume the hung pipe only has one queue to reset on pipe reset. Signed-off-by: Jonathan Kim --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gf

[PATCH 1/2] Revert "drm/amdgpu: Extend KIQ reg polling wait for VF"

2024-08-02 Thread Victor Skvortsov
KIQ timeouts no longer seen. This reverts commit b4d12cc00ad69e8a0dea2ece7202bacfd8b894fb. --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index 137a88b8de4

[PATCH 2/2] drm/amdgpu: abort KIQ waits when there is a pending reset

2024-08-02 Thread Victor Skvortsov
Stop waiting for the KIQ to return back when there is a reset pending. It's quite likely that the KIQ will never response. Signed-off-by: Victor Skvortsov Suggested-by: Lazar Lijo --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h | 5 + 2 files

Re: 6.10/bisected/regression - Since commit e356d321d024 in the kernel log appears the message "MES failed to respond to msg=MISC (WAIT_REG_MEM)" which were never seen before

2024-08-02 Thread Mikhail Gavrilov
On Wed, Jul 24, 2024 at 10:16 PM Mikhail Gavrilov wrote: > > https://patchwork.freedesktop.org/patch/605201/ > For which kernel is this patch intended? The patch is not applied on > top of d67978318827. I am able to apply this patch on top of e4fc196f5ba3 and the issue is gone. Tested-by: Mikhai

Re: [PATCH] drm/amdkfd: Handle queue destroy buffer access race

2024-08-02 Thread Felix Kuehling
On 2024-08-02 11:28, Philip Yang wrote: Add helper function kfd_queue_unreference_buffers to reduce queue buffer refcount, separate it from release queue buffers. Because it is circular locking to hold dqm_lock to take vm lock, kfd_ioctl_destroy_queue should take vm lock, unreference queue buf