XDC 2024: Registration & Call for Proposals now open!

2024-07-12 Thread Mark Filion
Hello! Registration & Call for Proposals are now open for XDC 2024, which will take place at the Concordia University Conference Centre in Montréal, Canada on October 9 to 11. New this year: XDC 2024 will feature two full days dedicated to talks followed by a day dedicated to workshops, meetings

[PATCH] drm/amd/amdgpu: Fix uninitialized variable warnings

2024-07-12 Thread Ma Ke
Return 0 to avoid returning an uninitialized variable r. Fixes: 230dd6bb6117 ("drm/amd/amdgpu: implement mode2 reset on smu_v13_0_10") Signed-off-by: Ma Ke --- drivers/gpu/drm/amd/amdgpu/smu_v13_0_10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu

Re: [PATCH v4 6/6] fbdev/viafb: Make I2C terminology more inclusive

2024-07-12 Thread Helge Deller
On 7/11/24 07:27, Easwar Hariharan wrote: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage e

Re: [PATCH v4 5/6] fbdev/smscufx: Make I2C terminology more inclusive

2024-07-12 Thread Helge Deller
On 7/11/24 07:27, Easwar Hariharan wrote: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage e

Re: amdgpu [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data

2024-07-12 Thread Thomas Glanzmann
Hello Mario, * Mario Limonciello [2024-07-11 16:57]: > Can I ask you to please file a request with Debian to update all of > amdgpu firmware to a new snapshot? done. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1076151 Cheers, Thomas

Re: [RFC] drm/amdgpu: More efficient ring padding

2024-07-12 Thread Christian König
Am 11.07.24 um 20:17 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin From the department of questionable optimisations today we have a minor improvement to how padding / filling the rings with nops is done. Having noticed that typically 200+ nops per submission are filled into the ring, using a

RE: [PATCH] drm/amdgpu: Mark amdgpu_bo as invalid after moved

2024-07-12 Thread YuanShang Mao (River)
[AMD Official Use Only - AMD Internal Distribution Only] Add more info and CC @Kuehling, Felix @cao, lin In amdgpu_amdkfd_fence.c, there is a design description: /* Eviction Fence * Fence helper functions to deal with KFD memory eviction. * Big Idea - Since KFD submissions are done by user que

Re: [PATCH] drm/amdgpu: Mark amdgpu_bo as invalid after moved

2024-07-12 Thread Christian König
Hi River, well that is complete nonsense. The BOs are not meant to be used with on demand faulting, so their VM state absolutely shouldn't matter to the KFD. Regards, Christian. Am 12.07.24 um 04:54 schrieb YuanShang Mao (River): [AMD Official Use Only - AMD Internal Distribution Only] We

Re: [PATCH] drm/amdgpu: Mark amdgpu_bo as invalid after moved

2024-07-12 Thread Christian König
Hi River, well that isn't an error at all, this is perfectly expected behavior. The VMs used by the KFD process are currently not meant to be used by classic CS at the same time. This is one of the reasons for that. Regards, Christian. Am 12.07.24 um 09:35 schrieb YuanShang Mao (River): [A

[PATCH v1 0/2] SDMA v5_2 ip dump support for devcoredump

2024-07-12 Thread Sunil Khatri
Sample output: IP: sdma_v5_2 num_instances:2 Instance:0 mmSDMA0_STATUS_REG 0x46deed57 mmSDMA0_STATUS1_REG 0x03ff mmSDMA0_STATUS2_REG 0x3f20 mmSDMA0_STATUS3_REG

RE: [PATCH v1 0/2] SDMA v5_2 ip dump support for devcoredump

2024-07-12 Thread Khatri, Sunil
[AMD Official Use Only - AMD Internal Distribution Only] Ignore Plz -Original Message- From: Sunil Khatri Sent: Friday, July 12, 2024 5:23 PM To: Deucher, Alexander ; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil Subject: [PATCH v1 0/2] SDMA v5_2 ip dump support f

[PATCH v1 1/2] drm/amdgpu: Add sdma_v5_2 ip dump for devcoredump

2024-07-12 Thread Sunil Khatri
Add ip dump for sdma_v5_2 for devcoredump for all instances of sdma. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 1 + drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 82 2 files changed, 83 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v1 0/2] SDMA v5_2 ip dump support for devcoredump

2024-07-12 Thread Sunil Khatri
Sample output: IP: sdma_v5_2 num_instances:2 Instance:0 mmSDMA0_STATUS_REG 0x46deed57 mmSDMA0_STATUS1_REG 0x03ff mmSDMA0_STATUS2_REG 0x3f20 mmSDMA0_STATUS3_REG

[PATCH v1 2/2] drm/amdgpu: add print support for sdma_v_5_2 ip_dump

2024-07-12 Thread Sunil Khatri
Add support for ip dump for sdma_v_5_2 in devcoredump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c index 05a13

[PATCH] drm/amdgpu: fix the print message in devcoredump

2024-07-12 Thread Sunil Khatri
Fix the memory type logged for gtt memory size which is wrongly logged as visible vram size. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c b/dr

Re: [RFC] drm/amdgpu: More efficient ring padding

2024-07-12 Thread Christian König
Am 12.07.24 um 11:14 schrieb Tvrtko Ursulin: On 12/07/2024 08:33, Christian König wrote: Am 11.07.24 um 20:17 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin  From the department of questionable optimisations today we have a minor improvement to how padding / filling the rings with nops is don

Re: [PATCH] drm/amdgpu: fix the print message in devcoredump

2024-07-12 Thread Alex Deucher
On Fri, Jul 12, 2024 at 8:28 AM Sunil Khatri wrote: > > Fix the memory type logged for gtt memory size > which is wrongly logged as visible vram size. > > Signed-off-by: Sunil Khatri Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 2 +- > 1 file changed, 1

Re: [PATCH v1 2/2] drm/amdgpu: add print support for sdma_v_5_2 ip_dump

2024-07-12 Thread Alex Deucher
Series is: Reviewed-by: Alex Deucher On Fri, Jul 12, 2024 at 8:23 AM Sunil Khatri wrote: > > Add support for ip dump for sdma_v_5_2 in devcoredump. > > Signed-off-by: Sunil Khatri > --- > drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 24 > 1 file changed, 24 insertions(+) >

Re: [Patch v2] drm/ttm: Allow direct reclaim to allocate local memory

2024-07-12 Thread Christian König
Am 12.07.24 um 15:40 schrieb Vlastimil Babka: On 7/8/24 6:06 PM, Rajneesh Bhardwaj wrote: Limiting the allocation of higher order pages to the closest NUMA node and enabling direct memory reclaim provides not only failsafe against situations when memory becomes too much fragmented and the alloca

Re: [PATCH] drm/amdgpu: Mark amdgpu_bo as invalid after moved

2024-07-12 Thread Felix Kuehling
KFD eviction fences are triggered by the enable_signaling callback on the eviction fence. Any move operations scheduled by amdgpu_bo_move are held up by the GPU scheduler until the eviction fence is signaled by the KFD eviction handler, which only happens after the user mode queues are stopped.

[PATCH 2/3] drm/amdgpu: More efficient ring padding

2024-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having noticed that typically 200+ nops per submission are written into the ring, using a rather verbose one-nop-at-a-time-plus-ring-buffer- arithmetic as done in amdgpu_ring_write(), the obvious idea was to improve it by filling those nops in blocks. This patch therefore ad

[PATCH 1/3] drm/amdpgu: Micro-optimise amdgpu_ring_commit

2024-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin For some value of optimisation we can replace the division with an bitwise and. And it even shrinks the code. Before: 6c9: 53 push %rbx 6ca: 4c 8b 47 08 mov0x8(%rdi),%r8 6ce: 31 d2 xor

[PATCH 3/3] drm/amdpug: More more efficient ring padding

2024-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Similarly as in the previous patch, we add a new amdgpu_ring_fill64() helper which can write out the nops more efficiently using memset64(). This should have a lesser effect than the previous patch, given how the affected rings have at most 64 dword alignment restriction, in

[PATCH 0/3] Ring commit and padding micro-optimisations

2024-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A three patches to streamline the ring nop padding process which happens on every submission. I smoke tested graphics and video decode on the Steam Deck but cannot do much more testing than that. Therefore no guarantees I did not break something. Cc: Christian König Tvrt

[PATCH v3 2/3] drm/amdgpu: More efficient ring padding

2024-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having noticed that typically 200+ nops per submission are written into the ring, using a rather verbose one-nop-at-a-time-plus-ring-buffer- arithmetic as done in amdgpu_ring_write(), the obvious idea was to improve it by filling those nops in blocks. This patch therefore ad

Re: [PATCH] drm/amd: Bump KMS_DRIVER_MINOR version

2024-07-12 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jul 11, 2024 at 11:05 AM Aurabindo Pillai wrote: > > Increase the KMS minor version to indicate GFX12 DCC support since this > contains a major change in how DCC is managed across IPs like GFX, DCN > etc. This will be used mainly by userspace like Mesa to

[pull] amdgpu drm-next-6.11

2024-07-12 Thread Alex Deucher
Hi Dave, Sima, A few updates for new IPs, but mostly bug fixes. The following changes since commit 62a05f4ae9c1fb70bc75d494c9c1c373d2c2e374: Merge tag 'drm-msm-next-2024-07-04' of https://gitlab.freedesktop.org/drm/msm into drm-next (2024-07-05 12:45:41 +0200) are available in the Git reposi

[PATCH] drm/amdgpu: Fix atomics on GFX12

2024-07-12 Thread David Belanger
If PCIe supports atomics, configure register to prevent DF from breaking atomics in separate load/store operations. Signed-off-by: David Belanger Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_df.h| 1 + drivers/g

RE: [PATCH 00/50] DC Patches July 10th, 2024

2024-07-12 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eD