Re: FW: [PATCH] drm/amdgpu/jpeg5: Add support for DPG mode

Hi, Looks good to me ! Acked-by: Saleemkhan Jamadar -Original Message- From: amd-gfx On Behalf Of Sonny Jiang Sent: Monday, June 24, 2024 11:28 PM To:amd-gfx@lists.freedesktop.org Cc: Jiang, Sonny Subject: [PATCH] drm/amdgpu/jpeg5: Add support for DPG mode From: Sonny Jiang Add DPG

[PATCH v3 4/7] drm/radeon: rdev->ddev to rdev_to_drm(rdev) 3

Please refer to patch 1. Signed-off-by: Wu Hoi Pok --- drivers/gpu/drm/radeon/r600_hdmi.c | 2 +- drivers/gpu/drm/radeon/radeon_acpi.c | 10 +- drivers/gpu/drm/radeon/radeon_agp.c | 2 +- drivers/gpu/drm/radeon/radeon_atombios.c | 2 +- drivers/gpu/drm/radeon/radeon_aud

Re: [PATCH v2 1/3] drm: Add panel backlight quirks

Hi Thomas, On 6/23/24 10:51 AM, Thomas Weißschuh wrote: > Panels using a PWM-controlled backlight source without an do not have a > standard way to communicate their valid PWM ranges. > On x86 the ranges are read from ACPI through driver-specific tables. > The built-in ranges are not necessarily c

[PATCH v3 6/7] drm/radeon: rdev->ddev to rdev_to_drm(rdev) 5

Please refer to patch 1. Signed-off-by: Wu Hoi Pok --- drivers/gpu/drm/radeon/radeon_ib.c | 2 +- drivers/gpu/drm/radeon/radeon_irq_kms.c | 12 ++-- drivers/gpu/drm/radeon/radeon_object.c | 2 +- drivers/gpu/drm/radeon/radeon_pm.c | 20 ++-- drivers/gpu/drm/r

[PATCH v3 7/7] drm/radeon: rdev->ddev to rdev_to_drm(rdev) 6

Please refer to patch 1. Signed-off-by: Wu Hoi Pok --- drivers/gpu/drm/radeon/rs400.c | 6 +++--- drivers/gpu/drm/radeon/rs600.c | 14 +++--- drivers/gpu/drm/radeon/rs690.c | 2 +- drivers/gpu/drm/radeon/rv515.c | 4 ++-- drivers/gpu/drm/radeon/rv770.c | 2 +- drivers/gpu/drm/radeon/

[PATCH v3 0/7] drm/radeon: remove load callback

Changes between v1 and v3: 1. add "ddev->dev_private = rdev;" 2. include a cover letter Wu Hoi Pok (7): drm/radeon: remove load callback drm/radeon: rdev->ddev to rdev_to_drm(rdev) 1 drm/radeon: rdev->ddev to rdev_to_drm(rdev) 2 drm/radeon: rdev->ddev to rdev_to_drm(rdev) 3 drm/radeon:

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

Hi Hans! thanks for your feedback! On 2024-06-24 11:11:40+, Hans de Goede wrote: > On 6/23/24 10:51 AM, Thomas Weißschuh wrote: > > The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > > is "12". This leads to a fairly bright minimum display backlight. > > > > Add a gen

[PATCH v3 2/7] drm/radeon: rdev->ddev to rdev_to_drm(rdev) 1

Please refer to patch 1. Signed-off-by: Wu Hoi Pok --- drivers/gpu/drm/radeon/atombios_encoders.c | 2 +- drivers/gpu/drm/radeon/cik.c | 14 ++--- drivers/gpu/drm/radeon/dce6_afmt.c | 2 +- drivers/gpu/drm/radeon/evergreen.c | 12 +-- drivers/gpu/d

Re: [PATCH] drm/amd/display: Check pipe_ctx before it is used

> resource_get_otg_master_for_stream() could return NULL, we > should check the return value of 'otg_master' before it is > used in resource_log_pipe_for_stream(). A similar fix was integrated already according to a contribution by Natanel Roizenman. >From which Linux version did you take source f

[PATCH v3 1/7] drm/radeon: remove load callback

Remove ".load" callback form "kms_driver", and move "struct drm_device" into radeon_device. Patch 2 to 7 follows up with changing the way of accessing drm_device, from "rdev->ddev" to "rdev_to_drm(rdev)" which is "&rdev->ddev". Signed-off-by: Wu Hoi Pok --- drivers/gpu/drm/radeon/radeon.h |

Re: [PATCH v2 1/7] drm/radeon: remove load callback

Thank you. I have resubmitted with a cover letter. On Mon, Jun 24, 2024 at 3:22 AM Thomas Zimmermann wrote: > > Hi > > Am 21.06.24 um 16:15 schrieb Wu Hoi Pok: > > This is "drm/radeon: remove load callback" v2, the only changes > > were made are adding "ddev->dev_private = rdev;", right after > >

[PATCH v3 3/7] drm/radeon: rdev->ddev to rdev_to_drm(rdev) 2

Please refer to patch 1. Signed-off-by: Wu Hoi Pok --- drivers/gpu/drm/radeon/r300.c | 6 +++--- drivers/gpu/drm/radeon/r420.c | 6 +++--- drivers/gpu/drm/radeon/r520.c | 2 +- drivers/gpu/drm/radeon/r600.c | 12 ++-- drivers/gpu/drm/radeon/r600_cs.c | 2 +- drivers/

Re: [PATCH] drm/amd/display: Check pipe_ctx before it is used

>> resource_get_otg_master_for_stream() could return NULL, we >> should check the return value of 'otg_master' before it is >> used in resource_log_pipe_for_stream(). > > A similar fix was integrated already according to a contribution > by Natanel Roizenman. > From which Linux version did you take

[PATCH v3 5/7] drm/radeon: rdev->ddev to rdev_to_drm(rdev) 4

Please refer to patch 1. Signed-off-by: Wu Hoi Pok --- drivers/gpu/drm/radeon/radeon_device.c | 19 +++ drivers/gpu/drm/radeon/radeon_display.c | 74 - drivers/gpu/drm/radeon/radeon_fbdev.c | 26 - drivers/gpu/drm/radeon/radeon_fence.c | 8 +-- drivers/g

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

Hi Thomas, On 6/23/24 10:51 AM, Thomas Weißschuh wrote: > The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > is "12". This leads to a fairly bright minimum display backlight. > > Add a generic quirk infrastructure for backlight configuration to > override the settings prov

Re: [PATCH 1/6] drm/amdgpu: allow ioctls to opt-out of runtime pm

Le 20/06/2024 à 15:36, Christian König a écrit : Am 20.06.24 um 15:06 schrieb Pierre-Eric Pelloux-Prayer: Le 19/06/2024 à 11:26, Christian König a écrit : Am 18.06.24 um 17:23 schrieb Pierre-Eric Pelloux-Prayer: Waking up a device can take multiple seconds, so if it's not going to be used we

[PATCH] drm/radeon: check bo_va->bo is non-NULL before using it

The call to radeon_vm_clear_freed might clear bo_va->bo, so we have to check it before dereferencing it. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/radeon/radeon_gem.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon

Re: [PATCH] drm/radeon: check bo_va->bo is non-NULL before using it

Am 25.06.24 um 14:41 schrieb Pierre-Eric Pelloux-Prayer: The call to radeon_vm_clear_freed might clear bo_va->bo, so we have to check it before dereferencing it. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/radeon/radeon_gem.c | 11 ++- 1 file changed, 10 insertions(

Re: [linux-next:master] BUILD REGRESSION f76698bd9a8ca01d3581236082d786e9a6b72bb7

On Mon, Jun 24, 2024 at 12:31:54PM -0700, Andrew Morton wrote: > On Sun, 23 Jun 2024 07:11:24 +0800 kernel test robot wrote: > > > tree/branch: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > branch HEAD: f76698bd9a8ca01d3581236082d786e9a6b72bb7 Add linux-next

[PATCH] drm/amdkfd: Use device based logging for errors

Convert some pr_* to some dev_* APIs to identify the device. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 3 +- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 21 --- drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.c | 8 ++- .../gpu/drm/amd/amdkfd/kfd_packet_

[PATCH v2] drm/radeon: check bo_va->bo is non-NULL before using it

The call to radeon_vm_clear_freed might clear bo_va->bo, so we have to check it before dereferencing it. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/radeon/radeon_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/dr

Re: [PATCH v2] drm/radeon: check bo_va->bo is non-NULL before using it

On Tue, Jun 25, 2024 at 10:32 AM Pierre-Eric Pelloux-Prayer wrote: > > The call to radeon_vm_clear_freed might clear bo_va->bo, so > we have to check it before dereferencing it. > > Signed-off-by: Pierre-Eric Pelloux-Prayer Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_gem.c |

[PATCH] drm/amd: Add some missing register definitions

Add some register offsets that are required for Display DCC on DCN401 Fixes: 000342e3a22 ("drm/amd: Add reg definitions for DCN401 DCC") Reported-by: Tom St Denis Signed-off-by: Aurabindo Pillai --- .../include/asic_reg/dcn/dcn_4_1_0_offset.h| 18 ++ 1 file changed, 18 inser

Re: [PATCH] drm/amd: Add some missing register definitions

On Tue, Jun 25, 2024 at 2:32 PM Aurabindo Pillai wrote: > > Add some register offsets that are required for Display DCC on DCN401 > > Fixes: 000342e3a22 ("drm/amd: Add reg definitions for DCN401 DCC") > Reported-by: Tom St Denis > Signed-off-by: Aurabindo Pillai Acked-by: Alex Deucher > --- >

Re: [PATCH] drm/amdkfd: Use device based logging for errors

On Tue, Jun 25, 2024 at 10:32 AM Lijo Lazar wrote: > > Convert some pr_* to some dev_* APIs to identify the device. > > Signed-off-by: Lijo Lazar Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 3 +- > drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 21 -

[PATCH] drm/amdgpu: add mutex to protect ras shared memory

Add mutex to protect ras shared memory. Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c| 124 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c | 2 + 3 files changed, 87 insertions(+), 40 deletions(-

[PATCH] drm/amdgpu: normalize registers as local xcc to read/write in gfx_v9_4_3

[WHY] sriov has the higher bit violation when flushing tlb [HOW] normalize the registers to keep lower 16-bit(dword aligned) to aviod higher bit violation RLCG will mask xcd out and always assume it's accessing its own xcd Signed-off-by: Jane Jian --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c |

RE: [PATCH] drm/amdgpu: add missing error handling for amdgpu_ring_alloc()

[AMD Official Use Only - AMD Internal Distribution Only] Hi Christian Thanks for your suggestion, I agree with you. I will submit the next version to drop the return value from amdgpu_ring_alloc(). Regards, Bob -Original Message- From: Koenig, Christian Sent: 2024年6月21日 17:28 To: Zhou

Re: [PATCH] drm/amdgpu: normalize registers as local xcc to read/write in gfx_v9_4_3

Am 26.06.24 um 05:01 schrieb Jane Jian: [WHY] sriov has the higher bit violation when flushing tlb [HOW] normalize the registers to keep lower 16-bit(dword aligned) to aviod higher bit violation RLCG will mask xcd out and always assume it's accessing its own xcd Signed-off-by: Jane Jian Lij

Re: [PATCH] drm/amdgpu: normalize registers as local xcc to read/write in gfx_v9_4_3

On 6/26/2024 8:31 AM, Jane Jian wrote: > [WHY] > sriov has the higher bit violation when flushing tlb > > [HOW] > normalize the registers to keep lower 16-bit(dword aligned) to aviod higher > bit violation > RLCG will mask xcd out and always assume it's accessing its own xcd > > Signed-off-by

[PATCH] drm/amdgpu: normalize registers as local xcc to read/write in gfx_v9_4_3

[WHY] sriov has the higher bit violation when flushing tlb [HOW] normalize the registers to keep lower 16-bit(dword aligned) to aviod higher bit violation RLCG will mask xcd out and always assume it's accessing its own xcd v2 add check in wait mem that only do the normalization on regspace Sign

Re: [PATCH] drm/amdgpu: normalize registers as local xcc to read/write in gfx_v9_4_3

On 6/26/2024 11:31 AM, Jane Jian wrote: > [WHY] > sriov has the higher bit violation when flushing tlb > > [HOW] > normalize the registers to keep lower 16-bit(dword aligned) to aviod higher > bit violation > RLCG will mask xcd out and always assume it's accessing its own xcd > > v2 > add che