RE: [PATCH] drm/amdkfd: use mode1 reset for RAS poison consumption

2024-06-13 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Thursday, June 13, 2024 14:57 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH] drm/amdkfd: use mode1 reset

Re: "firmware/sysfb: Set firmware-framebuffer parent device" breaks lightdm on Ubuntu 22.04 using amdgpu

2024-06-13 Thread Thomas Zimmermann
Hi Am 13.06.24 um 08:00 schrieb Marek Olšák: +amd-gfx On Thu, Jun 13, 2024 at 1:59 AM Marek Olšák wrote: Hi Thomas, Commit 9eac534db0013aff9b9124985dab114600df9081 as per the title breaks (crashes?) lightdm (login screen) such that all I get is the terminal. It's also reproducible with tag v

Re: [PATCH] drm/amdkfd: use mode1 reset for RAS poison consumption

2024-06-13 Thread Lazar, Lijo
On 6/13/2024 12:27 PM, Tao Zhou wrote: > Per FW requirement, replace mode2 with mode1. > > Signed-off-by: Tao Zhou > --- > drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v

Re: [PATCH 1/5] drm/amdgpu: add condition check for waking up thread

2024-06-13 Thread Lazar, Lijo
On 6/13/2024 7:55 AM, YiPeng Chai wrote: > 1. Cannot add messages to fifo in gpu reset mode. > 2. Only when the message is successfully saved to the > fifo, the thread can be awakened. > I think fifo should still cache the poison requests while in reset. Page retirement thread may try to acqui

RE: [PATCH] drm/amdkfd: use mode1 reset for RAS poison consumption

2024-06-13 Thread Zhou1, Tao
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, June 13, 2024 4:07 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdkfd: use mode1 reset for RAS poison consumption > > > > On 6/13/2024 12:

[BUG] 6.10-rc3 [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory with ring turned off

2024-06-13 Thread Mirsad Todorovac
Hi, all! Running the vanilla torvalds tree kernel 6.10-rc3, there occurred an error in boot with amdgpu. Here is the complete output: kernel: [8.704024] WARNING: CPU: 24 PID: 689 at drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:1379 amdgpu_bo_release_notify (drivers/gpu/drm/amd/amdgpu/amdgpu

Re: [bug report] drm/amdgpu: amdgpu crash on playing videos, linux 6.10-rc

2024-06-13 Thread Linux regression tracking (Thorsten Leemhuis)
On 06.06.24 05:06, Winston Ma wrote: > Hi I got the same problem on Linux Kernel 6.10-rc2. I got the problem by > following the procedure below: > > 1. Boot Linux Kernel 6.10-rc2 > 2. Open Firefox (Any browser should work) > 3. Open a Youtube Video > 4. On the playing video, toggle fullscreen

Re: [PATCH] Revert "drm/amdgpu: init iommu after amdkfd device init"

2024-06-13 Thread Greg KH
On Wed, Jun 12, 2024 at 12:10:37PM +1200, Matthew Ruffell wrote: > Hi Greg KH, Sasha, > > Please pick up this patch for 5.15 stable tree. I have built a test kernel and > can confirm that it fixes affected users. > > Downstream bug: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2068738

Patch "Revert "drm/amdgpu: init iommu after amdkfd device init"" has been added to the 5.15-stable tree

2024-06-13 Thread gregkh
This is a note to let you know that I've just added the patch titled Revert "drm/amdgpu: init iommu after amdkfd device init" to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [bug report] drm/amdgpu: amdgpu crash on playing videos, linux 6.10-rc

2024-06-13 Thread Wang Yunchen
On Wed, 2024-06-12 at 15:14 +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > On 06.06.24 05:06, Winston Ma wrote: > > Hi I got the same problem on Linux Kernel 6.10-rc2. I got the problem by > > following the procedure below: > > > >  1. Boot Linux Kernel 6.10-rc2 > >  2. Open Firefo

[PATCH] drm/amdkfd: add ASIC version check for the reset selection of RAS poison

2024-06-13 Thread Tao Zhou
GFX v9.4.3 uses mode1 reset, other ASICs choose mode2. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_int_

Re: [PATCH] drm/amdkfd: add ASIC version check for the reset selection of RAS poison

2024-06-13 Thread Lazar, Lijo
On 6/13/2024 4:43 PM, Tao Zhou wrote: > GFX v9.4.3 uses mode1 reset, other ASICs choose mode2. > > Signed-off-by: Tao Zhou Acked-by: Lijo Lazar Thanks, Lijo > --- > drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff

Re: [PATCH 4/5] drm/amdgpu: wait for gpu to complete reset

2024-06-13 Thread Christian König
Am 13.06.24 um 04:25 schrieb YiPeng Chai: Add completion to wait for gpu to complete reset. Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 12 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 1 + 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/d

Re: [PATCH 5/5] drm/amdgpu: add gpu reset check before page retirement thread runs

2024-06-13 Thread Christian König
Am 13.06.24 um 04:25 schrieb YiPeng Chai: If gpu is recovering, clear all message reset flags in fifo and wait for gpu to complete recovery. Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu

Re: "firmware/sysfb: Set firmware-framebuffer parent device" breaks lightdm on Ubuntu 22.04 using amdgpu

2024-06-13 Thread Marek Olšák
On Thu, Jun 13, 2024 at 3:23 AM Thomas Zimmermann wrote: > > Hi > > Am 13.06.24 um 08:00 schrieb Marek Olšák: > > +amd-gfx > > > > On Thu, Jun 13, 2024 at 1:59 AM Marek Olšák wrote: > >> Hi Thomas, > >> > >> Commit 9eac534db0013aff9b9124985dab114600df9081 as per the title > >> breaks (crashes?) l

Re: "firmware/sysfb: Set firmware-framebuffer parent device" breaks lightdm on Ubuntu 22.04 using amdgpu

2024-06-13 Thread Thomas Zimmermann
Hi Am 13.06.24 um 16:20 schrieb Marek Olšák: On Thu, Jun 13, 2024 at 3:23 AM Thomas Zimmermann wrote: Hi Am 13.06.24 um 08:00 schrieb Marek Olšák: +amd-gfx On Thu, Jun 13, 2024 at 1:59 AM Marek Olšák wrote: Hi Thomas, Commit 9eac534db0013aff9b9124985dab114600df9081 as per the title break

[PATCH] drm/amd/display/dc: Remove dc code repetition

2024-06-13 Thread Joao Paulo Pereira da Silva
Code is repeated in functions optc1_enable_crtc (dc/optc/dcn10/dcn10_optc.c) and optc2_enable_crtc (dc/optc/dcn20/dcn20_optc.c). So, remove it with the creation of a macro. Signed-off-by: Joao Paulo Pereira da Silva --- .../amd/display/dc/optc/dcn10/dcn10_optc.c| 29 ++- ...

Re: [PATCH v5 2/3] drm: Allow drivers to choose plane types to async flip

2024-06-13 Thread André Almeida
Hi Dmitry, Em 12/06/2024 17:45, Dmitry Baryshkov escreveu: On Wed, Jun 12, 2024 at 04:37:12PM -0300, André Almeida wrote: Different planes may have different capabilities of doing async flips, so create a field to let drivers allow async flip per plane type. Signed-off-by: André Almeida ---

[linux-next:master] BUILD REGRESSION 6906a84c482f098d31486df8dc98cead21cce2d0

2024-06-13 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 6906a84c482f098d31486df8dc98cead21cce2d0 Add linux-next specific files for 20240613 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202406131636.ccrcjztc-...@intel.com Error

Re: [PATCH] drm/amd/display: Increase frame-larger-than warning limit

2024-06-13 Thread Nathan Chancellor
Hi Palmer (and AMD folks), On Tue, Jun 04, 2024 at 09:04:23AM -0700, Palmer Dabbelt wrote: > On Mon, 03 Jun 2024 15:29:48 PDT (-0700), nat...@kernel.org wrote: > > On Thu, May 30, 2024 at 07:57:42AM -0700, Palmer Dabbelt wrote: > > > From: Palmer Dabbelt > > > > > > I get a handful of build erro