From: Tvrtko Ursulin
Align kerneldoc with the function argument name.
Signed-off-by: Tvrtko Ursulin
Reported-by: Stephen Rothwell
Fixes: 26e20235ce00 ("drm/amdgpu: Add amdgpu_bo_is_vm_bo helper")
Cc: Christian König
Cc: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
1 file
[AMD Official Use Only - AMD Internal Distribution Only]
> -Original Message-
> From: Alex Deucher
> Sent: Friday, May 17, 2024 11:52 PM
> To: Xiao, Shane
> Cc: amd-gfx@lists.freedesktop.org; Kuehling, Felix
> ; Somasekharan, Sreekant
> ; Liu, Aaron ;
> Yao, Longlong
> Subject: Re: [PAT
[AMD Official Use Only - AMD Internal Distribution Only]
> -Original Message-
> From: Xiao, Shane
> Sent: Monday, May 20, 2024 4:21 PM
> To: Alex Deucher
> Cc: amd-gfx@lists.freedesktop.org; Kuehling, Felix
> ; Somasekharan, Sreekant
> ; Liu, Aaron ;
> Yao, Longlong
> Subject: RE: [PATCH
This patch changes the implementation of AMDGPU_PTE_MTYPE_GFX12,
clear the bits before setting the new one.
This fixed the potential issue that GFX12 setting memory to NC.
v2: Clear mtype field before setting the new one (Alex)
Signed-off-by: longlyao
Signed-off-by: Shane Xiao
---
drivers/gpu/
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Alex,
I have changed the macro AMDGPU_PTE_MTYPE_GFX12 to clear mtype bit before
setting.
Add one parameter for this macro, and some related code needs to be changed.
I'm not sure whether that's the ideal way to do it, but if it is, I'l
Yes, problem is no more.
Thanks.
> On Mon, May 6, 2024 at 6:00 AM Borislav Petkov wrote:
>
>> + amd-gfx@lists.freedesktop.org
>>
>> On Sun, May 05, 2024 at 09:59:22PM +0300, Tranton Baddy wrote:
>>> I have this in my dmesg since version 6.8.6, not sure when it appeared. Is
>>> amdgpu driver has
On Fri, May 17, 2024 at 02:54:57PM +0530, Vignesh Raman wrote:
> zlib.net is not allowing tarball download anymore and results
> in below error in kernel+rootfs_arm32 container build,
> urllib.error.HTTPError: HTTP Error 403: Forbidden
> urllib.error.HTTPError: HTTP Error 415: Unsupported Media Typ
[Why]
The vram width value is 0.
Because the integratedsysteminfo table in VBIOS has updated to 2.3.
[Solution]
Driver needs a new intergrated info v2.3 table too.
Then the vram width value will be correct.
Signed-off-by: Li Ma
---
.../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 15 ++
driv
On Fri, May 17, 2024 at 02:54:58PM +0530, Vignesh Raman wrote:
> Stop vendoring the testlist into the kernel. Instead, use the
> testlist from the IGT build to ensure we do not miss renamed
> or newly added tests.
>
> Signed-off-by: Vignesh Raman
> ---
>
> v2:
> - Fix testlist generation for a
On Fri, May 17, 2024 at 02:54:59PM +0530, Vignesh Raman wrote:
> With latest IGT, the tests tries to load the module and it
> fails. So build the virtual GPU driver for virtio as module.
Why? If the test fails on module loading (if the driver is built-in)
then it's the test that needs to be fixed,
On Fri, May 17, 2024 at 02:55:00PM +0530, Vignesh Raman wrote:
> test-list.txt and test-list-full.txt are not generated for
> cross-builds and they are required by drm-ci for testing
> arm32 targets.
>
> This is fixed in igt-gpu-tools. So uprev IGT to include the
> commit which fixes this issue. D
On Fri, May 17, 2024 at 02:55:01PM +0530, Vignesh Raman wrote:
> Skip driver specific tests and skip kms tests for
> panfrost driver since it is not a kms driver.
>
> Signed-off-by: Vignesh Raman
> ---
I didn't perform a through check, but generally looks good.
Reviewed-by: Dmitry Baryshkov
-
On Fri, May 17, 2024 at 02:55:02PM +0530, Vignesh Raman wrote:
> Now the testlist is used from IGT build, so update
> xfails with the new testlist.
>
> Set the timeout of all i915 jobs to 1h30m since some jobs
> takes more than 1 hour to complete.
>
> Signed-off-by: Vignesh Raman
> ---
>
> v2:
From: Tvrtko Ursulin
Convert fdinfo memory stats to use the common drm_print_memory_stats
helper.
This achieves alignment with the common keys as documented in
drm-usage-stats.rst, adding specifically drm-total- key the driver was
missing until now.
Additionally I made the code stop skipping to
From: Tvrtko Ursulin
Currently it is not well defined what is drm-memory- compared to other
categories.
In practice the only driver which emits these keys is amdgpu and in them
exposes the current resident buffer object memory (including shared).
To prevent any confusion, document that drm-memo
the inst passed to reg read/write should be physical instance.
Fix the miss matched code.
Signed-off-by: Victor Zhao
---
.../drm/amd/amdgpu/amdgpu_amdkfd_gc_9_4_3.c | 6 ++---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 2 +-
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 8 +++---
dri
On 5/20/2024 4:44 PM, Victor Zhao wrote:
> the inst passed to reg read/write should be physical instance.
> Fix the miss matched code.
>
> Signed-off-by: Victor Zhao
> ---
> .../drm/amd/amdgpu/amdgpu_amdkfd_gc_9_4_3.c | 6 ++---
> .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 2 +-
> dr
Acked-by: Alex Deucher
On Mon, May 20, 2024 at 7:07 AM Li Ma wrote:
>
> [Why]
> The vram width value is 0.
> Because the integratedsysteminfo table in VBIOS has updated to 2.3.
>
> [Solution]
> Driver needs a new intergrated info v2.3 table too.
> Then the vram width value will be correct.
>
> S
On Fri, May 17, 2024 at 4:42 AM Yang Li wrote:
>
> This patch updates the function documentation comment for
> optc35_set_odm_combine to conform to the kernel-doc specification.
>
> Signed-off-by: Yang Li
Thanks for the patch. Srini already fixed this last week.
Alex
> ---
> drivers/gpu/drm/
Applied. Thanks!
Alex
On Mon, May 20, 2024 at 4:18 AM Tvrtko Ursulin wrote:
>
> From: Tvrtko Ursulin
>
> Align kerneldoc with the function argument name.
>
> Signed-off-by: Tvrtko Ursulin
> Reported-by: Stephen Rothwell
> Fixes: 26e20235ce00 ("drm/amdgpu: Add amdgpu_bo_is_vm_bo helper")
> Cc
the inst passed to amdgpu_virt_rlcg_reg_rw should be physical instance.
Fix the miss matched code.
Signed-off-by: Victor Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 18 +-
2 files changed, 11 insertions(+), 11 deleti
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks for pointing that out. You are right, kiq is taking logical xcc id and
should not be affected.
I'm sending out a new patch, please help review again.
Thanks,
Victor
-Original Message-
From: Lazar, Lijo
Sent: Monday, May 20
On Sat, May 18, 2024 at 8:17 PM Armin Wolf wrote:
>
> Am 17.05.24 um 03:30 schrieb Barry Kauler:
>
> > Armin, Yifan, Prike,
> > I will top-post, so you don't have to scroll down.
> > After identifying the commit that causes black screen with my gpu, I
> > posted the result to you guys, on May 9.
>
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 632483ea8004edfadd035de36e1ab2c7c4f53158 Add linux-next specific
files for 20240520
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202405202243.shvs2otq-...@intel.com
https
This reverts commit 28ebbb4981cb1fad12e0b1227dbecc88810b1ee8.
Revert this commit as apparently the LLVM code to take advantage of
this never landed.
Signed-off-by: Alex Deucher
Cc: Feifei Xu
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 11 ++-
1 file changed, 2 insertions(+), 9 deleti
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Yifan Zhang
-Original Message-
From: Ma, Li
Sent: Monday, May 20, 2024 6:59 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zhang, Yifan
; Huang, Tim ; Zhang, Jesse(Jie)
; Yu, Lang ; Zhu, Jiadong
; Ma
On 5/20/2024 16:07, Rino Andre Johnsen wrote:
[Why]
For debugging and testing purposes.
[How]
Create amdgpu_current_pixelencoding debugfs entry.
Usage: cat /sys/kernel/debug/dri/1/crtc-0/amdgpu_current_pixelencoding
Signed-off-by: Rino Andre Johnsen
---
.../amd/display/amdgpu_dm/amdgpu_dm_de
And also make sure the the value of msg[1].len should be in the range of u16.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_eeprom.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_eeprom.c
b/drivers/gpu/drm/amd/am
adev->umsch_mm.data_size - 1 >> 16 >> 16 is 0 regardless of the values of its
operands
Signed-off-by: Jesse Zhang
---
drivers/gpu/drm/amd/amdgpu/umsch_mm_v4_0.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/umsch_mm_v4_0.c
b/drivers/gpu/drm/am
Enum asic_type always greater than or equal CHIP_TAHITI.
Signed-off-by: Jesse Zhang
---
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c
b/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c
index f245fc0bc6d3..
adev->pg_flags >> 16 >> 16 is 0 regardless of the values of its operands.
Signed-off-by: Jesse Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
b/drivers/gpu/drm/amd/amdgpu/amdgp
When user space sets an invalid ta type, the pointer context will be empty.
So it need to check the pointer context before using it
Signed-off-by: Jesse Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/am
This commit fixes a format truncation issue arosed by the snprintf
function potentially writing more characters into the ring->name buffer
than it can hold, in the amdgpu_gfx_kiq_init_ring function
The issue occurred because the '%d' format specifier could write between
1 and 10 bytes into a regio
[AMD Official Use Only - AMD Internal Distribution Only]
From: Frank Min
device_cntl2 is accessible from pci config space, so program it through pci cfg
space instead of mmio.
Signed-off-by: Frank Min
---
drivers/gpu/drm/amd/amdgpu/nbif_v6_3_1.c | 13 -
1 file changed, 8 insertio
On 5/21/2024 10:13 AM, Srinivasan Shanmugam wrote:
> This commit fixes a format truncation issue arosed by the snprintf
> function potentially writing more characters into the ring->name buffer
> than it can hold, in the amdgpu_gfx_kiq_init_ring function
>
> The issue occurred because the '%d'
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Kenneth Feng
-Original Message-
From: Min, Frank
Sent: Tuesday, May 21, 2024 1:24 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Gao, Likun ;
Feng, Kenneth
Subject: FW: [PATCH] drm/amdgpu: program device
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Yang Wang
Best Regards,
Kevin
-Original Message-
From: amd-gfx On Behalf Of Tao Zhou
Sent: Tuesday, May 21, 2024 11:17 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: [PATCH] drm/amdgpu: use u32 for buf
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Jesse,
> -Original Message-
> From: amd-gfx On Behalf Of Jesse
> Zhang
> Sent: Tuesday, May 21, 2024 11:26 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Koenig, Christian
> ; Huang, Tim ; Zhang,
> Jesse(Jie)
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Tim,
-Original Message-
From: Huang, Tim
Sent: Tuesday, May 21, 2024 2:12 PM
To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Koenig, Christian
; Zhang, Jesse(Jie) ; Zhang,
Jesse(Jie)
Subject: RE
Hi Dmitry,
On 20/05/24 16:30, Dmitry Baryshkov wrote:
On Fri, May 17, 2024 at 02:54:58PM +0530, Vignesh Raman wrote:
Stop vendoring the testlist into the kernel. Instead, use the
testlist from the IGT build to ensure we do not miss renamed
or newly added tests.
Signed-off-by: Vignesh Raman
--
40 matches
Mail list logo
