Re: [PATCH v4 00/10] Add PM policy interfaces

2024-05-15 Thread Lazar, Lijo
On 5/14/2024 4:35 PM, Lijo Lazar wrote: > This series adds APIs to get the supported PM policies and also set them. A PM > policy type is a predefined policy type supported by an SOC and each policy > may > define two or more levels to choose from. A user can select the appropriate > level throu

Re: [RFC 1/5] drm/amdgpu: Fix migration rate limiting accounting

2024-05-15 Thread Christian König
Am 08.05.24 um 20:09 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin The logic assumed any migration attempt worked and therefore would over- account the amount of data migrated during buffer re-validation. As a consequence client can be unfairly penalised by incorrectly considering its migration

Re: [RFC 2/5] drm/amdgpu: Actually respect buffer migration budget

2024-05-15 Thread Christian König
Am 08.05.24 um 20:09 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Current code appears to live in a misconception that playing with buffer allowed and preferred placements can control the decision on whether backing store migration will be attempted or not. Both from code inspection and from e

RE: [PATCH v4 01/10] drm/amd/pm: Add support for DPM policies

2024-05-15 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Tuesday, May 14, 2024 7:06 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Ma, Le Subject: [PATCH v4 01/10] drm/amd/pm: A

RE: [PATCH v4 01/10] drm/amd/pm: Add support for DPM policies

2024-05-15 Thread Kamal, Asad
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Wang, Yang(Kevin) Sent: Wednesday, May 15, 2024 1:10 PM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; K

[PATCH] drm/amd/pm: disable gpo temporarily

2024-05-15 Thread Gao, Likun
[AMD Official Use Only - AMD Internal Distribution Only] From: Kenneth Feng disable gpo temprarily since it is not ready in fw Signed-off-by: Kenneth Feng Reviewed-by: Jack Gui --- drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/driv

[PATCH v3 1/4] drm/amdgpu: update the ip_dump to ipdump_core

2024-05-15 Thread Sunil Khatri
Update the memory pointer from ip_dump to ipdump_core to make it specific to core registers and rest other registers to be dumped in their respective memories. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 14 +++---

[PATCH v3 3/4] drm/amdgpu: add support to dump gfx10 queue registers

2024-05-15 Thread Sunil Khatri
Add gfx queue register for all instances in ip dump for gfx10. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 1 + drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 86 + 2 files changed, 87 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH v3 4/4] drm/amdgpu: add prints while ip registr dump

2024-05-15 Thread Sunil Khatri
add prints before and after during ip registers dump. It avoids user to think of system being stuck/hung as register dump takes time after a gpu hang. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/

[PATCH v3 2/4] drm/amdgpu: Add support to dump gfx10 cp registers

2024-05-15 Thread Sunil Khatri
add support to dump registers of all instances of cp registers in gfx10 Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 1 + drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 117 +++- 2 files changed, 114 insertions(+), 4 deletions(-) diff --git a/driver

RE: [PATCH v3] drm/amdkfd: Remove bo NULL check in gmc_v12_0_get_vm_pte() function

2024-05-15 Thread Russell, Kent
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Sreekant > Somasekharan > Sent: Tuesday, May 14, 2024 8:31 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix ; Somasekharan, Sreekant > ; Dan

Re: [RFC 1/5] drm/amdgpu: Fix migration rate limiting accounting

2024-05-15 Thread Tvrtko Ursulin
On 15/05/2024 08:14, Christian König wrote: Am 08.05.24 um 20:09 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin The logic assumed any migration attempt worked and therefore would over- account the amount of data migrated during buffer re-validation. As a consequence client can be unfairly pen

Re: [PATCH v3] drm/amdkfd: Remove bo NULL check in gmc_v12_0_get_vm_pte() function

2024-05-15 Thread Dan Carpenter
On Tue, May 14, 2024 at 08:31:03PM -0400, Sreekant Somasekharan wrote: > Remove bo NULL check in amdgpu/gmc_v12_0.c:gmc_v12_0_get_vm_pte() function > to fix smatch warning: > > 'drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c:518 gmc_v12_0_get_vm_pte() > warn: variable dereferenced before check 'bo' (see l

Re: [RFC 2/5] drm/amdgpu: Actually respect buffer migration budget

2024-05-15 Thread Tvrtko Ursulin
On 15/05/2024 08:20, Christian König wrote: Am 08.05.24 um 20:09 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Current code appears to live in a misconception that playing with buffer allowed and preferred placements can control the decision on whether backing store migration will be attempte

Re: [PATCH] drm/amd/pm: disable gpo temporarily

2024-05-15 Thread Alex Deucher
On Wed, May 15, 2024 at 7:12 AM Gao, Likun wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > From: Kenneth Feng > > disable gpo temprarily since it is not ready in fw > > Signed-off-by: Kenneth Feng > Reviewed-by: Jack Gui Acked-by: Alex Deucher > --- > drivers/gpu/drm

Re: [RFC 2/5] drm/amdgpu: Actually respect buffer migration budget

2024-05-15 Thread Christian König
Am 15.05.24 um 12:59 schrieb Tvrtko Ursulin: On 15/05/2024 08:20, Christian König wrote: Am 08.05.24 um 20:09 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Current code appears to live in a misconception that playing with buffer allowed and preferred placements can control the decision on w

[PATCH] drm/amdgpu/display: Update kdoc for 'optc35_set_odm_combine'

2024-05-15 Thread Srinivasan Shanmugam
The parameters segment_width and last_segment_width are used to control the configuration of the Output Plane Processor (OPP), specifically the width of each segment that the display is divided into and the width of the last segment Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/../displ

[PATCH] drm/amdgpu/vcn: update vcn5 enc/dec capabilities

2024-05-15 Thread Ruijing Dong
Update the capabilities for supporting 8k encoding/decoding. Signed-off-by: Ruijing Dong --- drivers/gpu/drm/amd/amdgpu/soc24.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc24.c b/drivers/gpu/drm/amd/amdgpu/soc24.c index b2b9e0f83b

RE: [PATCH v4 10/10] Documentation/amdgpu: Add PM policy documentation

2024-05-15 Thread Deucher, Alexander
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, May 14, 2024 7:06 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Deucher, Alexander > ; Kamal, Asad ; Ma, > Le > Subject: [PATCH v4 10/10] Documentation/amdgp

RE: [PATCH v3 1/4] drm/amdgpu: update the ip_dump to ipdump_core

2024-05-15 Thread Deucher, Alexander
[Public] > -Original Message- > From: Sunil Khatri > Sent: Wednesday, May 15, 2024 8:18 AM > To: Deucher, Alexander ; Koenig, Christian > > Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil > Subject: [PATCH v3 1/4] drm/amdgpu: update the ip_dump to ipdump_core > > Update the memory poin

RE: [PATCH v3 2/4] drm/amdgpu: Add support to dump gfx10 cp registers

2024-05-15 Thread Deucher, Alexander
[Public] > -Original Message- > From: Sunil Khatri > Sent: Wednesday, May 15, 2024 8:18 AM > To: Deucher, Alexander ; Koenig, Christian > > Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil > Subject: [PATCH v3 2/4] drm/amdgpu: Add support to dump gfx10 cp > registers > > add support to

RE: [PATCH v3 3/4] drm/amdgpu: add support to dump gfx10 queue registers

2024-05-15 Thread Deucher, Alexander
[Public] > -Original Message- > From: Sunil Khatri > Sent: Wednesday, May 15, 2024 8:18 AM > To: Deucher, Alexander ; Koenig, Christian > > Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil > Subject: [PATCH v3 3/4] drm/amdgpu: add support to dump gfx10 queue > registers > > Add gfx queu

[PATCH] drm/radeon: initialize atom DIG backlight for iMac12, 1 and iMac12, 2 with Radeon 6750M

2024-05-15 Thread Kendall Smith
If a Radeon 6750M GPU from an iMac12,1 is installed into an iMac 12,2, there is no backlight device initialized during boot. Everything else is functional, but the display brightness cannot be controlled. There are no directories present in /sys/class/backlight after booting. A simple one line m

[PATCH] drm/radeon: initialize atom DIG backlight for iMac12, 1 and iMac12, 2 with Radeon 6750M

2024-05-15 Thread Kendall Smith
If a Radeon 6750M GPU from an iMac12,1 is installed into an iMac 12,2, there is no backlight device initialized during boot. Everything else is functional, but the display brightness cannot be controlled. There are no directories present in /sys/class/backlight after booting. A simple one line m

Re: [RFC 2/5] drm/amdgpu: Actually respect buffer migration budget

2024-05-15 Thread Tvrtko Ursulin
On 15/05/2024 15:31, Christian König wrote: Am 15.05.24 um 12:59 schrieb Tvrtko Ursulin: On 15/05/2024 08:20, Christian König wrote: Am 08.05.24 um 20:09 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Current code appears to live in a misconception that playing with buffer allowed and pre

[PATCH 1/2] drm/amd/amdgpu: add thm 14.0.2 header file

2024-05-15 Thread Kenneth Feng
add thm 14.0.2 header file v2: add license, update to latest changes (Alex) Signed-off-by: Kenneth Feng Signed-off-by: Alex Deucher --- .../include/asic_reg/thm/thm_14_0_2_offset.h | 228 + .../include/asic_reg/thm/thm_14_0_2_sh_mask.h | 940 ++ 2 files changed, 1168 inser

[PATCH 2/2] drm/amd/pm: enable thermal alert on smu 14.0.2/3

2024-05-15 Thread Kenneth Feng
enable thermal alert on smu 14.0.2/3 Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v14_0.h | 8 +++ .../gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c| 68 ++- .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 35 +- 3 files changed, 108 insertions(+),

Re: [PATCH v3 1/4] drm/amdgpu: update the ip_dump to ipdump_core

2024-05-15 Thread Khatri, Sunil
On 5/16/2024 1:37 AM, Deucher, Alexander wrote: [Public] -Original Message- From: Sunil Khatri Sent: Wednesday, May 15, 2024 8:18 AM To: Deucher, Alexander ; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil Subject: [PATCH v3 1/4] drm/amdgpu: update the ip_dump to

Re: [PATCH v3 3/4] drm/amdgpu: add support to dump gfx10 queue registers

2024-05-15 Thread Khatri, Sunil
On 5/16/2024 1:42 AM, Deucher, Alexander wrote: [Public] -Original Message- From: Sunil Khatri Sent: Wednesday, May 15, 2024 8:18 AM To: Deucher, Alexander ; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil Subject: [PATCH v3 3/4] drm/amdgpu: add support to dump g

Re: [PATCH v3 2/4] drm/amdgpu: Add support to dump gfx10 cp registers

2024-05-15 Thread Khatri, Sunil
On 5/16/2024 1:40 AM, Deucher, Alexander wrote: [Public] -Original Message- From: Sunil Khatri Sent: Wednesday, May 15, 2024 8:18 AM To: Deucher, Alexander ; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil Subject: [PATCH v3 2/4] drm/amdgpu: Add support to dump g