Re: [PATCH 1/2] drm/amd/amdgpu: customized the reset to skip soft recovery

[AMD Official Use Only - General] Hi @Deucher, Alexander and @Koenig, Christian Could you help review this patch? Customer needs this toggle to turn off software recovery and use mode2 reset directly. This toggle is also needed

Re: [PATCH 2/2] drm/amd/amdgpu: use the default reset for ras recovery

[AMD Official Use Only - General] Hi @Deucher, Alexander and @Koenig, Christian Could you help review this patch? Without this patch, when customer set `reset_method=3` modprobe param to use mode2 reset, ras recovery will also u

Re: [PATCH v2 03/12] drm/i915: Make I2C terminology more inclusive

On Fri, 03 May 2024, Rodrigo Vivi wrote: > On Fri, May 03, 2024 at 02:04:15PM -0700, Easwar Hariharan wrote: >> On 5/3/2024 12:34 PM, Rodrigo Vivi wrote: >> > On Fri, May 03, 2024 at 06:13:24PM +, Easwar Hariharan wrote: >> >> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced >> >

Re: [PATCH v2 03/12] drm/i915: Make I2C terminology more inclusive

Hi, On Fri, May 03, 2024 at 03:34:12PM -0400, Rodrigo Vivi wrote: > On Fri, May 03, 2024 at 06:13:24PM +, Easwar Hariharan wrote: > > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > > with more appropriate terms. Inspired by and following on to Wolfram's > > seri

RE: [PATCH v2] drm/amdgpu: Fix out-of-bounds write warning

[Public] Reviewed-by: Tim Huang Best Regards, Tim Huang > -Original Message- > From: amd-gfx On Behalf Of Ma Jun > Sent: Monday, May 6, 2024 1:59 PM > To: amd-gfx@lists.freedesktop.org; Koenig, Christian > ; Deucher, Alexander > > Cc: Ma, Jun > Subject: [PATCH v2] drm/amdgpu: Fix o

Re: [PATCH v2 11/12] fbdev/smscufx: Make I2C terminology more inclusive

Am 03.05.24 um 20:13 schrieb Easwar Hariharan: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, n

Re: [PATCH v2 12/12] fbdev/viafb: Make I2C terminology more inclusive

Am 03.05.24 um 20:13 schrieb Easwar Hariharan: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, n

[PATCH 1/2] drm/amdgpu: fix ucode out-of-bounds read warning

Clear warning that read ucode[] may out-of-bounds. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c index b8280be6225d..c3d89088123d 10064

[PATCH 2/2] drm/amdgpu: fix mc_data out-of-bounds read warning

Clear warning that read mc_data[i-1] may out-of-bounds. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c index 52b12c1718eb.

[PATCH 1/2] drm/amdgpu: Fix uninitialized variable warning in amdgpu_info_ioctl

Check the return value of amdgpu_xcp_get_inst_details, otherwise we may use an uninitialized variable inst_mask Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.

[PATCH 2/2] drm/amdgpu/pm: Fix the param type of set_power_profile_mode

Function .set_power_profile_mode need an array as input parameter. So define variable workload as an array to fix the below coverity warning. "Passing &workload to function hwmgr->hwmgr_func->set_power_profile_mode which uses it as an array. This might corrupt or misinterpret adjacent memory locat

[PATCH v2 00/12] Make I2C terminology more inclusive for I2C Algobit and consumers

I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of the I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the spec

[PATCH v2 12/12] fbdev/viafb: Make I2C terminology more inclusive

I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specific

[PATCH v2 05/12] media: cobalt: Make I2C terminology more inclusive

I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specific

Re: [PATCH v2 03/12] drm/i915: Make I2C terminology more inclusive

On 5/3/2024 12:34 PM, Rodrigo Vivi wrote: > On Fri, May 03, 2024 at 06:13:24PM +, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix drivers/i2c/[1], f

[PATCH] drm/amd/pm: Fix error code in vega10_hwmgr_backend_init()

Return -EINVAL on error instead of success. Also on the success path, return a literal zero instead of "return result;" Fixes: e098bc9612c2 ("drm/amd/pm: optimize the power related source code layout") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 4 +

[bug report] drm/amd/display: Separate setting and programming of cursor

Hello Harry Wentland, Commit f63f86b5affc ("drm/amd/display: Separate setting and programming of cursor") from Mar 15, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c:398 dc_stream_program_cursor_position(

[bug report] drm/amdgpu: Add sdma v7_0 ip block support (v7)

Hello Likun Gao, Commit b412351e91bd ("drm/amdgpu: Add sdma v7_0 ip block support (v7)") from Jul 4, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:171 sdma_v7_0_ring_set_wptr() warn: duplicate check '*is_queue_unmap

[PATCH v2 10/12] sfc: falcon: Make I2C terminology more inclusive

I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specific

[bug report] drm/amd/display: Do cursor programming with rest of pipe

Hello Harry Wentland, Commit 66eba12a5482 ("drm/amd/display: Do cursor programming with rest of pipe") from Mar 15, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8433 amdgpu_dm_update_cursor()

[PATCH v2 11/12] fbdev/smscufx: Make I2C terminology more inclusive

I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specific

Re: [PATCH v1 12/12] fbdev/viafb: Make I2C terminology more inclusive

On 5/3/2024 12:39 AM, Thomas Zimmermann wrote: > Hi > > Am 03.05.24 um 00:26 schrieb Easwar Hariharan: >> On 5/2/2024 3:46 AM, Thomas Zimmermann wrote: >>> >>> Am 30.04.24 um 19:38 schrieb Easwar Hariharan: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" >>>

[PATCH v2 04/12] media: au0828: Make I2C terminology more inclusive

I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specific

[bug report] drm/amdkfd: mark GFX12 system and peer GPU memory mappings as MTYPE_NC

Hello Sreekant Somasekharan, This is a semi-automatic email about new static checker warnings. Commit 628e1ace2379 ("drm/amdkfd: mark GFX12 system and peer GPU memory mappings as MTYPE_NC") from Mar 26, 2024, leads to the following Smatch complaint: drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c:518

[PATCH v2 08/12] media: ivtv: Make I2C terminology more inclusive

I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specific

[PATCH v2 06/12] media: cx18: Make I2C terminology more inclusive

I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specific

[PATCH v2 07/12] media: cx25821: Make I2C terminology more inclusive

I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specific

[PATCH] drm/amdgpu: delete unnecessary check

The "ret" variable is zero. No need to check. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index a037e8fba29f..

[PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specific

[PATCH v2 02/12] drm/gma500: Make I2C terminology more inclusive

I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specific

[PATCH v2 09/12] media: cx23885: Make I2C terminology more inclusive

I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specific

[PATCH v2 03/12] drm/i915: Make I2C terminology more inclusive

I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specific

Re: [PATCH] drm/amd/pm: Fix error code in vega10_hwmgr_backend_init()

> Return -EINVAL on error instead of success. Also on the success path, > return a literal zero instead of "return result;" How do you think about to omit the initialisation for the variable “result” in another update step? Regards, Markus

Re: Error in amd driver?

+ amd-gfx@lists.freedesktop.org On Sun, May 05, 2024 at 09:59:22PM +0300, Tranton Baddy wrote: > I have this in my dmesg since version 6.8.6, not sure when it appeared. Is > amdgpu driver has bug? > [ 64.253144] > == > [ 64.2531

Re: [PATCH] Documentation/gpu: Document the situation with unqualified drm-memory-

On 03/05/2024 16:58, Alex Deucher wrote: On Fri, May 3, 2024 at 11:33 AM Daniel Vetter wrote: On Fri, May 03, 2024 at 01:58:38PM +0100, Tvrtko Ursulin wrote: [And I forgot dri-devel.. doing well!] On 03/05/2024 13:40, Tvrtko Ursulin wrote: [Correcting Christian's email] On 03/05/2024 1

Re: [RFC 5/5] drm/amdgpu: Only show VRAM in fdinfo if it exists

On 03/05/2024 14:47, Alex Deucher wrote: On Fri, May 3, 2024 at 3:50 AM Tvrtko Ursulin wrote: On 02/05/2024 14:16, Christian König wrote: Am 30.04.24 um 19:27 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Do not emit the key-value pairs if the VRAM does not exist ie. VRAM placement is no

Re: [PATCH] Documentation/gpu: Document the situation with unqualified drm-memory-

On 03/05/2024 14:39, Alex Deucher wrote: On Fri, May 3, 2024 at 8:58 AM Tvrtko Ursulin wrote: [And I forgot dri-devel.. doing well!] On 03/05/2024 13:40, Tvrtko Ursulin wrote: [Correcting Christian's email] On 03/05/2024 13:36, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Currently it

[PATCH] drm/amdkfd: Check debug trap enable before write dbg_ev_file

In interrupt context, write dbg_ev_file will be run by work queue. It will cause write dbg_ev_file execution after debug_trap_disable, which will cause NULL pointer access. v2: cancel work "debug_event_workarea" before set dbg_ev_file as NULL. Signed-off-by: Lin.Cao --- drivers/gpu/drm/amd/amdkf

Re: [PATCH] Documentation/gpu: Document the situation with unqualified drm-memory-

On Fri, May 03, 2024 at 06:06:03PM +0100, Tvrtko Ursulin wrote: > > On 03/05/2024 16:58, Alex Deucher wrote: > > On Fri, May 3, 2024 at 11:33 AM Daniel Vetter wrote: > > > > > > On Fri, May 03, 2024 at 01:58:38PM +0100, Tvrtko Ursulin wrote: > > > > > > > > [And I forgot dri-devel.. doing well!

[PATCH] drm/buddy: Fix the range bias clear memory allocation issue

Problem statement: During the system boot time, an application request for the bulk volume of cleared range bias memory when the clear_avail is zero, we dont fallback into normal allocation method as we had an unnecessary clear_avail check which prevents the fallback method leads to fb allocation f

[PATCH] drm/amdgpu: Fix the BO release clear memory warning

This happens when the amdgpu_bo_release_notify running before amdgpu_ttm_set_buffer_funcs_status set the buffer funcs to enabled. check the buffer funcs enablement before calling the fill buffer memory. Log snip: [6.036477] [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory wit

Re: [PATCH 2/2] drm/amdgpu: fix mc_data out-of-bounds read warning

On Mon, May 6, 2024 at 5:37 AM Tim Huang wrote: > > Clear warning that read mc_data[i-1] may out-of-bounds. > > Signed-off-by: Tim Huang Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/am

Re: Error in amd driver?

On Mon, May 6, 2024 at 6:00 AM Borislav Petkov wrote: > > + amd-gfx@lists.freedesktop.org > > On Sun, May 05, 2024 at 09:59:22PM +0300, Tranton Baddy wrote: > > I have this in my dmesg since version 6.8.6, not sure when it appeared. Is > > amdgpu driver has bug? Should be fixed in: https://git.k

Re: [PATCH 1/2] drm/amdgpu: fix ucode out-of-bounds read warning

On Mon, May 6, 2024 at 5:26 AM Tim Huang wrote: > > Clear warning that read ucode[] may out-of-bounds. > > Signed-off-by: Tim Huang Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/

Re: [PATCH 3/3] drm/amdgpu: fix uninitialized variable warning for jpeg_v4

On Mon, May 6, 2024 at 2:32 AM Tim Huang wrote: > > Clear warning that using uninitialized variable r. > > Signed-off-by: Tim Huang Series is: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dr

Re: [PATCH 1/2] drm/amdgpu: Fix uninitialized variable warning in amdgpu_info_ioctl

On Mon, May 6, 2024 at 6:22 AM Ma Jun wrote: > > Check the return value of amdgpu_xcp_get_inst_details, otherwise we > may use an uninitialized variable inst_mask > > Signed-off-by: Ma Jun Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 11 +-- > 1 file change

[PATCH 0/5] Fdinfo memory stats clarification and amdgpu refactor

From: Tvrtko Ursulin Following on from the recent discussion from: https://lore.kernel.org/dri-devel/ZjjTaeZYNqVSj2y-@phenom.ffwll.local/T/#mb8105d8d7de055d3068975d27c428525e55cff84 I included some old three patches to start with, since the last in the series depends on first, plus first had

[PATCH 2/5] drm/amdgpu: Reduce mem_type to domain double indirection

From: Tvrtko Ursulin All apart from AMDGPU_GEM_DOMAIN_GTT memory domains map 1:1 to TTM placements. And the former be either AMDGPU_PL_PREEMPT or TTM_PL_TT, depending on AMDGPU_GEM_CREATE_PREEMPTIBLE. Simplify a few places in the code which convert the TTM placement into a domain by checking aga

[PATCH 4/5] Documentation/gpu: Document the situation with unqualified drm-memory-

From: Tvrtko Ursulin Currently it is not well defined what is drm-memory- compared to other categories. In practice the only driver which emits these keys is amdgpu and in them exposes the total memory use (including shared). To prevent any confusion, document that drm-memory- is deprecated and

[PATCH 3/5] drm/amdgpu: Describe all object placements in debugfs

From: Tvrtko Ursulin Accurately show all placements when describing objects in debugfs, instead of bunching them up under the 'CPU' placement. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Felix Kuehling Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 1

[PATCH 5/5] drm/amdgpu: Use drm_print_memory_stats helper from fdinfo

From: Tvrtko Ursulin Convert fdinfo memory stats to use the common drm_print_memory_stats helper. This achieves alignment with the common keys as documented in drm-usage-stats.rst, adding specifically drm-total- key the driver was missing until now. Additionally I made the code stop skipping to

[PATCH 1/5] drm/amdgpu: Add amdgpu_bo_is_vm_bo helper

From: Tvrtko Ursulin Help code readability by replacing a bunch of: bo->tbo.base.resv == vm->root.bo->tbo.base.resv With: amdgpu_vm_is_bo_always_valid(vm, bo) No functional changes. v2: * Rename helper and move to amdgpu_vm. (Christian) v3: * Use Christian's kerneldoc. v4: * Fixed logic

[PATCH] drm/amdkfd: Reconcile the definition and use of oem_id in struct kfd_topology_device

Currently oem_id is defined as uint8_t[6] and casted to uint64_t* in some use case. This would lead code scanner to complain about access beyond. Re-define it in union to enforce 8-byte size and alignment to avoid potential issue. Signed-off-by: Michael Chen Reviewed-by: Felix Kuehling --- driv

[PATCH] drm/amdkfd: don't allow mapping the MMIO HDP page with large pages

We don't get the right offset in that case. The GPU has an unused 4K area of the register BAR space into which you can remap registers. We remap the HDP flush registers into this space to allow userspace (CPU or GPU) to flush the HDP when it updates VRAM. However, on systems with >4K pages, we e

[PATCH 01/14] drm/amdgpu: add nbio set_reg_remap helper

Will be used to consolidate reg remap settings and fix HDP flushes on systems with non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h b/d

[PATCH 02/14] drm/amdgpu: add set_reg_remap callback for NBIO 6.1

This will be used to consolidate the register remap offset configuration and fix HDP flushes on systems non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) dif

[PATCH 04/14] drm/amdgpu: add set_reg_remap callback for NBIO 7.4

This will be used to consolidate the register remap offset configuration and fix HDP flushes on systems non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers

[PATCH 05/14] drm/amdgpu: add set_reg_remap callback for NBIO 7.9

This will be used to consolidate the register remap offset configuration and fix HDP flushes on systems non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drive

[PATCH 07/14] drm/amdgpu: add set_reg_remap callback for NBIO 7.2

This will be used to consolidate the register remap offset configuration and fix HDP flushes on systems non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v7_2.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers

[PATCH 03/14] drm/amdgpu: add set_reg_remap callback for NBIO 7.0

This will be used to consolidate the register remap offset configuration and fix HDP flushes on systems non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v7_0.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/

[PATCH 10/14] drm/amdgpu: add set_reg_remap callback for NBIO 7.7

This will be used to consolidate the register remap offset configuration and fix HDP flushes on systems non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers

[PATCH 08/14] drm/amdgpu: add set_reg_remap callback for NBIO 2.3

This will be used to consolidate the register remap offset configuration and fix HDP flushes on systems non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/

[PATCH 09/14] drm/amdgpu: add set_reg_remap callback for NBIO 4.3

This will be used to consolidate the register remap offset configuration and fix HDP flushes on systems non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v4_3.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers

[PATCH 11/14] drm/amdgpu: add set_reg_remap callback for NBIF 6.3.1

This will be used to consolidate the register remap offset configuration and fix HDP flushes on systems non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbif_v6_3_1.c | 16 1 file changed, 16 insertions(+) diff --git a/drive

[PATCH 13/14] drm/amdgpu/nv: use common nbio callback to set remap offset

This fixes HDP flushes on systems with non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 4 drivers/gpu/drm/amd/amdgpu/nbio_v7_2.c | 4 drivers/gpu/drm/amd/amdgpu/nv.c| 6 +- 3 files changed, 1 insertion(+),

[PATCH 14/14] drm/amdgpu/soc21: use common nbio callback to set remap offset

This fixes HDP flushes on systems with non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v4_3.c | 3 --- drivers/gpu/drm/amd/amdgpu/soc21.c | 4 +--- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amd

[PATCH 12/14] drm/amdgpu/soc15: use common nbio callback to set remap offset

This fixes HDP flushes on systems with non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c | 4 drivers/gpu/drm/amd/amdgpu/nbio_v7_0.c | 3 --- drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 4 drivers/gpu/drm/amd/amdgpu/nbio_v

[PATCH 06/14] drm/amdgpu: add set_reg_remap callback for NBIO 7.11

This will be used to consolidate the register remap offset configuration and fix HDP flushes on systems non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers

[PATCH] drm/amdkfd: Refactor kfd CRIU into its own file

The kfd CRIU code takes up about a thousand lines in the kfd_chardev file; move it to its own file. No functional change intended. Signed-off-by: David Francis --- drivers/gpu/drm/amd/amdkfd/Makefile | 1 + drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 972 +- drivers/gp

Re: [PATCH 2/2] drm/amd/amdgpu: use the default reset for ras recovery

On Mon, Apr 29, 2024 at 4:07 AM Kenneth Feng wrote: > > use the default reset for ras recovery > > Signed-off-by: Kenneth Feng > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > b/drivers/gpu/

Re: [PATCH] drm/amdkfd: Remove arbitrary timeout for hmm_range_fault

On 2024-05-01 18:56, Philip Yang wrote: On system with khugepaged enabled and user cases with THP buffer, the hmm_range_fault may takes > 15 seconds to return -EBUSY, the arbitrary timeout value is not accurate, cause memory allocation failure. Remove the arbitrary timeout value, return EAGAIN

Re: [PATCH] drm/amdkfd: Refactor kfd CRIU into its own file

On 2024-05-06 15:20, David Francis wrote: The kfd CRIU code takes up about a thousand lines in the kfd_chardev file; move it to its own file. No functional change intended. Signed-off-by: David Francis --- drivers/gpu/drm/amd/amdkfd/Makefile | 1 + drivers/gpu/drm/amd/amdkfd/kfd_ch

Re: [PATCH] drm/amdkfd: Ensure gpu_id is unique

On 2024-05-03 18:06, Harish Kasiviswanathan wrote: gpu_id needs to be unique for user space to identify GPUs via KFD interface. In the current implementation there is a very small probability of having non unique gpu_ids. v2: Add check to confirm if gpu_id is unique. If not unique, find one

Re: [PATCH] drm/amdkfd: Ensure gpu_id is unique

On 2024-05-06 16:30, Felix Kuehling wrote: > > On 2024-05-03 18:06, Harish Kasiviswanathan wrote: >> gpu_id needs to be unique for user space to identify GPUs via KFD >> interface. In the current implementation there is a very small >> probability of having non unique gpu_ids. >> >> v2: Add che

Re: [PATCH] drm/amdkfd: Ensure gpu_id is unique

On 2024-05-06 17:10, Harish Kasiviswanathan wrote: On 2024-05-06 16:30, Felix Kuehling wrote: On 2024-05-03 18:06, Harish Kasiviswanathan wrote: gpu_id needs to be unique for user space to identify GPUs via KFD interface. In the current implementation there is a very small probability of having

Re: [PATCH] drm/amdgpu: Assign correct bits for SDMA HDP flush

This patch is causing crashes of Manor Lords on my Navi 21 on the 6.8.9 stable kernel. It leads to an assertion failure in wine: File: ../src-wine/dlls/winevulkan/loader_thunks.c Line: 3621 Expression "!status && vkEndCommandBuffer"" This happens both with radv and amdvlk. It starts happening

RE: [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches

Ping... Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: 2024年5月6日 14:47 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Li, Candice Subject: [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches This patch i

RE: [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches

[AMD Official Use Only - General] Reviewed-by: Candice Li Thanks, Candice -Original Message- From: Wang, Yang(Kevin) Sent: Tuesday, May 7, 2024 9:36 AM To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Li, Candice ; Zhou, Hao (Claire) Subject:

RE: [PATCH] drm/amd/pm: fix the uninitialized scalar variable warning

[AMD Official Use Only - General] Hi Jesse, > -Original Message- > From: Zhang, Jesse(Jie) > Sent: Monday, May 6, 2024 2:21 PM > To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Huang, Tim > Subject: RE: [PATCH] drm/amd/pm: fix the u

[PATCH] drm/amdgpu: fix RAS unload driver issue in SRIOV

Fix null pointer issue when unload driver in SRIOV mode. Adjust the function position to ensure that the amdgpu_mca/aca_xxx_init() related functions can be initialized properly. Signed-off-by: Yang Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 14 -- 1 file changed, 8 insertion

Re: [PATCH] drm/amdgpu: Assign correct bits for SDMA HDP flush

On 5/7/2024 6:00 AM, Harry Wentland wrote: > This patch is causing crashes of Manor Lords on my Navi 21 on the 6.8.9 > stable kernel. It leads to an assertion failure in wine: > > File: ../src-wine/dlls/winevulkan/loader_thunks.c > Line: 3621 > > Expression "!status && vkEndCommandBuffer"" >

[PATCH] drm/amdgpu: Fix out-of-bounds read of df_v1_7_channel_number

Check the fb_channel_number range to avoid the array out-of-bounds read error Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/amdgpu/df_v1_7.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/df_v1_7.c b/drivers/gpu/drm/amd/amdgpu/df_v1_7.c index 5dfab802..cd29

RE: [PATCH] drm/amdgpu: fix RAS unload driver issue in SRIOV

[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Wang, Yang(Kevin) Sent: Tuesday, May 7, 2024 10:50 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Li, Candice Subject: [PATCH] drm/amdgpu: fix RAS unload driver

RE: [PATCH] drm/amdgpu: Fix out-of-bounds read of df_v1_7_channel_number

[Public] Reviewed-by: Tim Huang Best Regards, Tim Huang > -Original Message- > From: amd-gfx On Behalf Of Ma Jun > Sent: Tuesday, May 7, 2024 11:19 AM > To: amd-gfx@lists.freedesktop.org; Koenig, Christian > ; Deucher, Alexander > > Cc: Ma, Jun > Subject: [PATCH] drm/amdgpu: Fix ou

[PATCH 1/2] drm/amd/pm: revert the commit 576bffd10d01

This patch doesn't need and will update new patch. Signed-off-by: Jesse Zhang --- .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 32 +++ 1 file changed, 5 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c b/drivers/gpu/drm/amd/pm/swsmu

[PATCH 1/2] drm/amd/pm: revert the commit 576bffd10d01

Revert this commit: 576bffd10d01 and will update new patch. Signed-off-by: Jesse Zhang --- .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 32 +++ 1 file changed, 5 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c b/drivers/gpu/drm/amd

[PATCH 2/2] drm/amd/pm: enable UMD Pstate profile level for renoir

This patch enable UMD Pstates profile level for the renoir_set_performance_level interface. -profile_min_sclk -profile_min_fclk Signed-off-by: Jesse Zhang Suggested-by: Tim Huang --- .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 58 +++ 1 file changed, 48 insertions(+), 10

RE: [PATCH 2/2] drm/amd/pm: enable UMD Pstate profile level for renoir

[AMD Official Use Only - General] > -Original Message- > From: Jesse Zhang > Sent: Tuesday, May 7, 2024 11:43 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Huang, Tim ; Zhang, > Jesse(Jie) ; Zhang, Jesse(Jie) > Subject: [PATCH 2/2] drm/amd/pm: en

Re: [PATCH v1 2/5] drm/ci: generate testlist from build

Hi Dmitry, On 30/04/24 15:47, Dmitry Baryshkov wrote: On Tue, Apr 30, 2024 at 02:41:18PM +0530, Vignesh Raman wrote: Stop vendoring the testlist into the kernel. Instead, use the testlist from the IGT build to ensure we do not miss renamed or newly added tests. Signed-off-by: Vignesh Raman --

Re: [PATCH] drm/amdkfd: Ensure gpu_id is unique

On 5/4/2024 3:36 AM, Harish Kasiviswanathan wrote: > gpu_id needs to be unique for user space to identify GPUs via KFD > interface. In the current implementation there is a very small > probability of having non unique gpu_ids. > > v2: Add check to confirm if gpu_id is unique. If not unique, fi

Re: [PATCH v1 4/5] drm/ci: skip driver specific tests

Hi Helen, On 30/04/24 20:01, Helen Koike wrote: On 30/04/2024 06:11, Vignesh Raman wrote: Skip driver specific tests and skip kms tests for panfrost driver since it is not a kms driver. Signed-off-by: Vignesh Raman ---   .../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt   | 14 +-  

Re: [PATCH v1 5/5] drm/ci: update xfails for the new testlist

Hi Dmitry, On 30/04/24 15:45, Dmitry Baryshkov wrote: On Tue, Apr 30, 2024 at 02:41:21PM +0530, Vignesh Raman wrote: Now the testlist is used from IGT build, so update xfails with the new testlist. Signed-off-by: Vignesh Raman --- .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 47 +++--

[PATCH] drm/amdgpu: change log level

Change log level. Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c i

RE: [PATCH] drm/amdgpu: change log level

Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Chai, Thomas Sent: 2024年5月7日 14:27 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Li, Candice ; Wang, Yang(Kevin) ; Yang, Stanley ; Chai, Thomas Subject: [PATCH] drm/amdgpu: change log level Ch