Re: [PATCH v2 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-19 Thread Jani Nikula
On Thu, 18 Apr 2024, Robert Foss wrote: > I'm seeing build errors for drivers/gpu/drm/bridge/ite-it6505.c, is > this expected? No, but it's possible my configs didn't catch all configs. :( BR, Jani. -- Jani Nikula, Intel

[PATCH] drm/amd/display: Remove duplicate dcn32/dcn32_clk_mgr.h header

2024-04-19 Thread Jiapeng Chong
./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c: dcn32/dcn32_clk_mgr.h is included more than once. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8789 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c |

[PATCH] drm/amdgpu/umsch: don't execute umsch test when GPU is in reset/suspend

2024-04-19 Thread Lang Yu
umsch test needs full GPU functionality(e.g., VM update, TLB flush, possibly buffer moving under memory pressure) which may be not ready under these states. Just skip it to avoid potential issues. Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c | 3 +++ 1 file changed, 3

RE: [PATCH] drm/amdgpu/umsch: don't execute umsch test when GPU is in reset/suspend

2024-04-19 Thread Gopalakrishnan, Veerabadhran (Veera)
[AMD Official Use Only - General] Looks good to me. Reviewed-by: Veerabadhran Gopalakrishnan Regards, Veera -Original Message- From: Yu, Lang Sent: Friday, April 19, 2024 1:22 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Gopalakrishnan, Veerabadhran (Veera) ; Yu, Lan

Re: [PATCH] drm/amdgpu: Update BO eviction priorities

2024-04-19 Thread Christian König
Am 18.04.24 um 20:06 schrieb Felix Kuehling: Make SVM BOs more likely to get evicted than other BOs. These BOs opportunistically use available VRAM, but can fall back relatively seamlessly to system memory. It also avoids SVM migrations evicting other, more important BOs as they will evict other

[PATCH] drm/amdgpu: Fix snprintf buffer size in smu_v14_0_init_microcode

2024-04-19 Thread Srinivasan Shanmugam
This commit addresses buffer overflow in the smu_v14_0_init_microcode function. The issue was about the snprintf function writing more bytes into the fw_name buffer than it can hold. The line of code is: snprintf(fw_name, sizeof(fw_name), "amdgpu/%s.bin", ucode_prefix); Here, snprintf is used to

[PATCH v2] drm/amdgpu: Fix snprintf buffer size in smu_v14_0_init_microcode

2024-04-19 Thread Srinivasan Shanmugam
This commit addresses buffer overflow in the smu_v14_0_init_microcode function. The issue was about the snprintf function writing more bytes into the fw_name buffer than it can hold. The line of code is: snprintf(fw_name, sizeof(fw_name), "amdgpu/%s.bin", ucode_prefix); Here, snprintf is used to

Re: [PATCH] drm/amdgpu/umsch: don't execute umsch test when GPU is in reset/suspend

2024-04-19 Thread Christian König
Am 19.04.24 um 09:52 schrieb Lang Yu: umsch test needs full GPU functionality(e.g., VM update, TLB flush, possibly buffer moving under memory pressure) which may be not ready under these states. Just skip it to avoid potential issues. Signed-off-by: Lang Yu Reviewed-by: Christian König ---

Re: [PATCH] drm/amdgpu/vcn: fix unitialized variable warnings

2024-04-19 Thread Christian König
Am 18.04.24 um 20:07 schrieb Pierre-Eric Pelloux-Prayer: Init r to 0 to avoid returning an uninitialized value if we never enter the loop. This case should never be hit in practive, but returning 0 doesn't hurt. The same fix is applied to the 4 places using the same pattern. Signed-off-by: Pier

[PATCH v2] drm/amdgpu/vcn: fix unitialized variable warnings

2024-04-19 Thread Pierre-Eric Pelloux-Prayer
Avoid returning an uninitialized value if we never enter the loop. This case should never be hit in practice, but returning 0 doesn't hurt. The same fix is applied to the 4 places using the same pattern. v2: - fixed typos in commit message (Alex) - use "return 0;" before the done label instea

[PATCH] drm/amdkfd: demote unsupported device messages to dev_info

2024-04-19 Thread Alex Deucher
It's not really an error since the devices don't support the necessary hardware functionality. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3331 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

RE: [PATCH] drm/amdkfd: demote unsupported device messages to dev_info

2024-04-19 Thread Russell, Kent
[AMD Official Use Only - General] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Friday, April 19, 2024 10:01 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] drm/amdkfd: demote unsupported device m

Re: [PATCH] drm/amd/display: Remove duplicate dcn32/dcn32_clk_mgr.h header

2024-04-19 Thread Alex Deucher
Reviewed-by: Alex Deucher And applied. Thanks! Alex On Thu, Apr 18, 2024 at 10:37 PM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c: > dcn32/dcn32_clk_mgr.h is included more than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanoli

[PATCH v3] drm/amdgpu: Fix snprintf buffer size in smu_v14_0_init_microcode

2024-04-19 Thread Srinivasan Shanmugam
This commit addresses buffer overflow in the smu_v14_0_init_microcode function. The issue was about the snprintf function writing more bytes into the fw_name buffer than it can hold. The line of code is: snprintf(fw_name, sizeof(fw_name), "amdgpu/%s.bin", ucode_prefix); Here, snprintf is used to

[PATCH v4] drm/amdgpu: Fix snprintf buffer size in smu_v14_0_init_microcode

2024-04-19 Thread Srinivasan Shanmugam
This commit addresses buffer overflow in the smu_v14_0_init_microcode function. The issue was about the snprintf function writing more bytes into the fw_name buffer than it can hold. The line of code is: snprintf(fw_name, sizeof(fw_name), "amdgpu/%s.bin", ucode_prefix); Here, snprintf is used to

[PATCH] drm/amdkfd: Add VRAM accounting for SVM migration

2024-04-19 Thread Mukul Joshi
Do VRAM accounting when doing migrations to vram to make sure there is enough available VRAM and migrating to VRAM doesn't evict other possible non-unified memory BOs. If migrating to VRAM fails, driver can fall back to using system memory seamlessly. Signed-off-by: Mukul Joshi --- drivers/gpu/d

[PATCH] drm/amdkfd: Fix rescheduling of restore worker

2024-04-19 Thread Felix Kuehling
Handle the case that the restore worker was already scheduled by another eviction while the restore was in progress. Fixes: 9a1c1339abf9 ("drm/amdkfd: Run restore_workers on freezable WQs") Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 6 +++--- 1 file changed, 3 i

[linux-next:master] BUILD REGRESSION a35e92ef04c07bd473404b9b73d489aea19a60a8

2024-04-19 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: a35e92ef04c07bd473404b9b73d489aea19a60a8 Add linux-next specific files for 20240419 Error/Warning: (recently discovered and may have been fixed) WARNING: modpost: vmlinux: section mismatch in

Re: [PATCH] drm/amdkfd: Add VRAM accounting for SVM migration

2024-04-19 Thread Felix Kuehling
On 2024-04-19 12:23, Mukul Joshi wrote: Do VRAM accounting when doing migrations to vram to make sure there is enough available VRAM and migrating to VRAM doesn't evict other possible non-unified memory BOs. If migrating to VRAM fails, driver can fall back to using system memory seamlessly. Sign

Re: [PATCH] drm/amdkfd: Fix rescheduling of restore worker

2024-04-19 Thread Philip Yang
On 2024-04-19 15:00, Felix Kuehling wrote: Handle the case that the restore worker was already scheduled by another eviction while the restore was in progress. Fixes: 9a1c1339abf9 ("drm/amdkfd: Run restore_workers on freezable WQs") Signed-off-by: Felix Kueh

[pull] amdgpu, amdkfd, radeon drm-next-6.10

2024-04-19 Thread Alex Deucher
Hi Dave, Sima, More new stuff for 6.10. The following changes since commit ab956ed95b8bc4a65c913d7057075866d5fc3724: drm/amd/display: Add a function for checking tmds mode (2024-04-12 00:36:47 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git t