[PATCH] drm/amdgpu: Fix truncation in smu_v11_0_init_microcode

2024-03-22 Thread Srinivasan Shanmugam
Reducing the size of ucode_prefix to 25 in the smu_v11_0_init_microcode function. we ensure that fw_name can accommodate the maximum possible string size Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/smu_v11_0.c: In function ‘smu_v11_0_init_microcode’: drivers/gpu/drm

[PATCH] drm/ttm: Implement strict NUMA pool allocations

2024-03-22 Thread Rajneesh Bhardwaj
This change allows TTM to be flexible to honor NUMA localized allocations which can result in significant performance improvement on a multi socket NUMA system. On GFXIP 9.4.3 based AMD APUs, we see manyfold benefits of this change resulting not only in ~10% performance improvement in certain bench

Re: [PATCH] drm/amdgpu: Fix truncation issues in gfx_v9_0.c

2024-03-22 Thread Lazar, Lijo
On 3/22/2024 11:54 AM, Srinivasan Shanmugam wrote: > The size of fw_name is increased to ensure that it can accommodate > the maximum possible size of the string being written into it. > > Fixes the below with gcc W=1: > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c: In function ‘gfx_v9_0_early_init’:

Re: [PATCH] drm/amdgpu: Fix truncations in gfx_v11_0_init_microcode()

2024-03-22 Thread Lazar, Lijo
On 3/22/2024 12:02 PM, Srinivasan Shanmugam wrote: > Reducing the size of ucode_prefix to 25 in the gfx_v11_0_init_microcode > function. This would ensure that the total number of characters being > written into fw_name does not exceed its size of 40. > > Fixes the below with gcc W=1: > drivers

Re: [PATCH] drm/amdgpu: Fix truncation in gfx_v10_0_init_microcode

2024-03-22 Thread Lazar, Lijo
On 3/22/2024 12:24 PM, Srinivasan Shanmugam wrote: > The total size of the fw_name buffer is 8 (for "amdgpu/") + 30 (for > ucode_prefix) + 5 (for "_pfp") + 5 (for "_wks") + 5 (for ".bin") = 53 > characters. > > Fixes the below with gcc W=1: > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c: In function

Re: [PATCH] drm/amdgpu: Fix truncation in smu_v11_0_init_microcode

2024-03-22 Thread Lazar, Lijo
On 3/22/2024 12:33 PM, Srinivasan Shanmugam wrote: > Reducing the size of ucode_prefix to 25 in the smu_v11_0_init_microcode > function. we ensure that fw_name can accommodate the maximum possible > string size > > Fixes the below with gcc W=1: > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/smu

[PATCH] drm/amd/display: clean up some inconsistent indenting

2024-03-22 Thread Jiapeng Chong
No functional modification involved. drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn351/dcn351_fpu.c:569 dcn351_decide_zstate_support() warn: inconsistent indenting. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8608 Signed-off-by: Jiapeng Chong --- drivers/

[PATCH] drm/amdgpu: fix the list movement

2024-03-22 Thread Shashank Sharma
This patch adds a fix for list object movement, which was introduced in the TLB flush series. Fixes: 0a29a49f3ed4 ("drm/amdgpu: sync page table freeing with tlb flush") Cc: Christian König Suggested-by: Christian König Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.

Re: [PATCH] drm/amdgpu: fix the list movement

2024-03-22 Thread Christian König
Am 22.03.24 um 12:14 schrieb Shashank Sharma: This patch adds a fix for list object movement, which was introduced in the TLB flush series. Fixes: 0a29a49f3ed4 ("drm/amdgpu: sync page table freeing with tlb flush") Cc: Christian König Suggested-by: Christian König Signed-off-by: Shashank Sharm

Re: [PATCH] drm/ttm: Implement strict NUMA pool allocations

2024-03-22 Thread Christian König
Am 22.03.24 um 08:07 schrieb Rajneesh Bhardwaj: This change allows TTM to be flexible to honor NUMA localized allocations which can result in significant performance improvement on a multi socket NUMA system. On GFXIP 9.4.3 based AMD APUs, we see manyfold benefits of this change resulting not onl

RE: [PATCH] drm/ttm: Implement strict NUMA pool allocations

2024-03-22 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Rajneesh Bhardwaj >Sent: Friday, March 22, 2024 3:08 AM >To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org >Cc: felix.kuehl...@amd.com; alexander.deuc...@amd.com; >christian.koe...@amd.com; Rajneesh Bhardwaj >; Joe Great

[PATCH IP-REVIEW] drm/amd/display: Update dcn351 to latest dcn35 config

2024-03-22 Thread Roman.Li
From: Sung Joon Kim [why & how] There were some fixes in dcn35 that need to be ported over to dcn351 to prevent any regression. Signed-off-by: Sung Joon Kim Reviewed-by: Liu, Xi (Alex) --- drivers/gpu/drm/amd/display/dc/dml/dcn351/dcn351_fpu.c| 9 ++--- drivers/gpu/drm/amd/displa

Re: [PATCH 2/2] drm/amdgpu: enable UMSCH 4.0.6

2024-03-22 Thread Deucher, Alexander
[AMD Official Use Only - General] Series is: Acked-by: Alex Deucher From: amd-gfx on behalf of Lang Yu Sent: Thursday, March 21, 2024 10:53 PM To: amd-gfx@lists.freedesktop.org Cc: Yu, Lang ; Gopalakrishnan, Veerabadhran (Veera) Subject: [PATCH 2/2] drm/amdg

[PATCH] drm/amdgpu : Add mes_log_enable to control mes log feature

2024-03-22 Thread shaoyunl
The MES log might slow down the performance for extra step of log the data, disable it by default and introduce a parameter can enable it when necessary Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 10 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 5 - driver

[PATCH] drm/amdgpu : Increase the mes log buffer size as per new MES FW version

2024-03-22 Thread shaoyunl
>From MES version 0x54, the log entry increased and require the log buffer size to be increased. The 16k is maximum size agreed Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 5 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 1 + 2 files changed, 3 insertions(+), 3 deleti

[PATCH] drm/amdgpu : Add mes_log_enable to control mes log feature

2024-03-22 Thread shaoyunl
The MES log might slow down the performance for extra step of log the data, disable it by default and introduce a parameter can enable it when necessary Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 10 ++ drivers/gp

[linux-next:master] BUILD REGRESSION 13ee4a7161b6fd938aef6688ff43b163f6d83e37

2024-03-22 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 13ee4a7161b6fd938aef6688ff43b163f6d83e37 Add linux-next specific files for 20240322 Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | |-- drivers-gpu-drm-amd

[PATCH] drm/amd/display: fix IPX enablement

2024-03-22 Thread Hamza Mahfooz
We need to re-enable idle power optimizations after entering PSR. Since, we get kicked out of idle power optimizations before entering PSR (entering PSR requires us to write to DCN registers, which isn't allowed while we are in IPS). Fixes: bfe4f0b0e717 ("drm/amd/display: Add more checks for exiti

Re: [PATCH] drm/amd/display: fix IPX enablement

2024-03-22 Thread Kazlauskas, Nicholas
[Public] Reviewed-by: Nicholas Kazlauskas Regards, Nicholas Kazlauskas From: Mahfooz, Hamza Sent: Friday, March 22, 2024 2:56 PM To: amd-gfx@lists.freedesktop.org Cc: Kazlauskas, Nicholas ; Li, Roman ; Li, Sun peng (Leo) ; Wentland, Harry ; Deucher, Alexande

[PATCH 1/3] amd/amdkfd: add a function to wait no process running in kfd

2024-03-22 Thread Zhigang Luo
Signed-off-by: Zhigang Luo Change-Id: I2a98d513c26107ac76ecf20e951c188afbc7ede6 --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 20 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 5 - drivers/gpu/drm/amd/amdkfd/kfd_device.c| 11 +++ 3 files changed, 35 inserti

[PATCH 2/3] amd/amdgpu: wait no process running in kfd before resuming device

2024-03-22 Thread Zhigang Luo
it will cause page fault after device recovered if there is a process running. Signed-off-by: Zhigang Luo Change-Id: Ib1eddb56b69ecd41fe703abd169944154f48b0cd --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_de

[PATCH 3/3] amd/amdgpu: improve VF recover time

2024-03-22 Thread Zhigang Luo
1. change AMDGPU_VF2PF_UPDATE_MAX_RETRY_LIMIT from 30 to 5. 2. set fatel error detected flag. Change-Id: If1e0357deffa4549d4e83e925c8d764f7f8c9f42 Signed-off-by: Zhigang Luo --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 1 + drivers/gpu/drm/am

Re: [PATCH] drm/ttm: Implement strict NUMA pool allocations

2024-03-22 Thread Bhardwaj, Rajneesh
On 3/22/2024 9:15 AM, Christian König wrote: Am 22.03.24 um 08:07 schrieb Rajneesh Bhardwaj: This change allows TTM to be flexible to honor NUMA localized allocations which can result in significant performance improvement on a multi socket NUMA system. On GFXIP 9.4.3 based AMD APUs, we see

Re: [PATCH] drm/ttm: Implement strict NUMA pool allocations

2024-03-22 Thread Bhardwaj, Rajneesh
On 3/22/2024 11:29 AM, Ruhl, Michael J wrote: -Original Message- From: dri-devel On Behalf Of Rajneesh Bhardwaj Sent: Friday, March 22, 2024 3:08 AM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: felix.kuehl...@amd.com; alexander.deuc...@amd.com; christian.koe..