Acked-by: Jingwen Chen
On 2024/3/15 14:31, Lin.Cao wrote:
> pp_dpm_*clk should be set as read only for SRIOV one VF mode, remove
> S_IWUGO flag and _store function of these debugfs in one VF mode.
>
> Signed-off-by: Lin.Cao
> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 10 +-
> 1 file ch
This patch causes the following iounmap erorr and calltrace
iounmap: bad address d0b3631f
So just revert it and amdgpu_device_fini_sw() will cleanup the
rmmio mapping.
This reverts commit 923f7a82d2e12a99744a940954f3829ab18a9dc7.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 16 ++
Am 19.03.24 um 09:07 schrieb Ma Jun:
This patch causes the following iounmap erorr and calltrace
iounmap: bad address d0b3631f
So just revert it and amdgpu_device_fini_sw() will cleanup the
rmmio mapping.
I think we can improve the wording here. Something like this:
The original pat
Thanks, I will fix it when push to the next branch
Regards,
Ma Jun
On 3/19/2024 4:22 PM, Christian König wrote:
> Am 19.03.24 um 09:07 schrieb Ma Jun:
>> This patch causes the following iounmap erorr and calltrace
>> iounmap: bad address d0b3631f
>
>> So just revert it and amdgpu_device_
On Mon, Mar 18, 2024 at 6:37 AM Alex Deucher wrote:
>
> On Mon, Mar 18, 2024 at 4:47 AM Kurt Kartaltepe wrote:
> >
> > These checks prevent using amdgpu with the pcie=assign-busses parameter
> > which will re-address devices from their acpi values.
> >
> > Signed-off-by: Kurt Kartaltepe
>
> This
On Mon, Mar 18, 2024 at 12:57 PM Alex Deucher wrote:
>
> On Mon, Mar 18, 2024 at 3:52 PM Alex Deucher wrote:
> >
...
> > Depends on the platform, but recent ones use VFCT. That said, there
> > should only ever be one IGPU in the system so I think we could just
> > rely on the VID and DID for APU
On Mon, Mar 18, 2024 at 8:42 AM Alex Deucher wrote:
>
> On Mon, Mar 18, 2024 at 10:19 AM Kurt Kartaltepe
> wrote:
> >
> > On Mon, Mar 18, 2024 at 6:37 AM Alex Deucher wrote:
> > >
> > > On Mon, Mar 18, 2024 at 4:47 AM Kurt Kartaltepe
> > > wrote:
> > > >
> > > > These checks prevent using amd
在 2024/3/18 22:33, kernel test robot 写道:
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 2e93f143ca010a5013528e1cfdc895f024fe8c21 Add linux-next specific
files for 20240318
Error/Warning ids grouped by kconfigs:
gcc_recent_errors
|-- arc-a
Am 19.03.24 um 02:55 schrieb Kurt Kartaltepe:
On Mon, Mar 18, 2024 at 12:57 PM Alex Deucher wrote:
On Mon, Mar 18, 2024 at 3:52 PM Alex Deucher wrote:
...
Depends on the platform, but recent ones use VFCT. That said, there
should only ever be one IGPU in the system so I think we could just
OD is not supported on Arcturus, so the OD table
should not be used.
Signed-off-by: Ma Jun
---
.../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 33 +++
1 file changed, 5 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
b/drivers/gpu/d
Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam:
Add clear page support in vram memory region.
v1(Christian):
- Dont handle clear page as TTM flag since when moving the BO back
in from GTT again we don't need that.
- Make a specialized version of amdgpu_fill_buffer() which on
Am 18.03.24 um 17:11 schrieb Shashank Sharma:
The idea behind this patch is to delay the freeing of PT entry objects
until the TLB flush is done.
This patch:
- Adds a tlb_flush_waitlist in amdgpu_vm_update_params which will keep the
objects that need to be freed after tlb_flush.
- Adds PT ent
Hi Christian,
On 3/19/2024 3:58 PM, Christian König wrote:
Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam:
Add clear page support in vram memory region.
v1(Christian):
- Dont handle clear page as TTM flag since when moving the BO back
in from GTT again we don't need that.
-
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a new file which would be the right place to
hold functions which will be used between sysfs, debugfs
and devcoredump.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Suni
Validated the code by using the function in same way as ioctl would use
in devcoredump and getting the valid values.
Also this would be the container of the information that we need to
share between ioctl, debugfs and devcoredump and keep updating this
based on information needed.
On 3/19/2
On Tue, Mar 19, 2024 at 6:22 AM Ma Jun wrote:
>
> OD is not supported on Arcturus, so the OD table
> should not be used.
>
> Signed-off-by: Ma Jun
Acked-by: Alex Deucher
> ---
> .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 33 +++
> 1 file changed, 5 insertions(+), 28 delet
Am 19.03.24 um 12:41 schrieb Paneer Selvam, Arunpravin:
Hi Christian,
On 3/19/2024 3:58 PM, Christian König wrote:
Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam:
Add clear page support in vram memory region.
v1(Christian):
- Dont handle clear page as TTM flag since when moving th
On 3/19/2024 6:02 PM, Sunil Khatri wrote:
> Refactor the code so debugfs and devcoredump can reuse
> the common information and avoid unnecessary copy of it.
>
> created a new file which would be the right place to
> hold functions which will be used between sysfs, debugfs
> and devcoredump.
>
Hi Christian,
On 3/19/2024 7:17 PM, Christian König wrote:
Am 19.03.24 um 12:41 schrieb Paneer Selvam, Arunpravin:
Hi Christian,
On 3/19/2024 3:58 PM, Christian König wrote:
Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam:
Add clear page support in vram memory region.
v1(Christian):
On 3/19/2024 7:19 PM, Lazar, Lijo wrote:
On 3/19/2024 6:02 PM, Sunil Khatri wrote:
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a new file which would be the right place to
hold functions which will be used between sy
On 3/19/2024 7:27 PM, Khatri, Sunil wrote:
>
> On 3/19/2024 7:19 PM, Lazar, Lijo wrote:
>>
>> On 3/19/2024 6:02 PM, Sunil Khatri wrote:
>>> Refactor the code so debugfs and devcoredump can reuse
>>> the common information and avoid unnecessary copy of it.
>>>
>>> created a new file which would
On 3/19/2024 7:43 PM, Lazar, Lijo wrote:
On 3/19/2024 7:27 PM, Khatri, Sunil wrote:
On 3/19/2024 7:19 PM, Lazar, Lijo wrote:
On 3/19/2024 6:02 PM, Sunil Khatri wrote:
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a ne
On Tue, Mar 19, 2024 at 10:22 AM Lazar, Lijo wrote:
>
>
>
> On 3/19/2024 7:27 PM, Khatri, Sunil wrote:
> >
> > On 3/19/2024 7:19 PM, Lazar, Lijo wrote:
> >>
> >> On 3/19/2024 6:02 PM, Sunil Khatri wrote:
> >>> Refactor the code so debugfs and devcoredump can reuse
> >>> the common information and
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a new file which would be the right place to
hold functions which will be used between ioctl, debugfs
and devcoredump.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Suni
On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote:
>
> Refactor the code so debugfs and devcoredump can reuse
> the common information and avoid unnecessary copy of it.
>
> created a new file which would be the right place to
> hold functions which will be used between sysfs, debugfs
> and devcor
Am 19.03.24 um 15:25 schrieb Sunil Khatri:
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a new file which would be the right place to
hold functions which will be used between ioctl, debugfs
and devcoredump.
Ok, taking a
On 3/19/2024 8:07 PM, Christian König wrote:
Am 19.03.24 um 15:25 schrieb Sunil Khatri:
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a new file which would be the right place to
hold functions which will be used betwee
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 226d3c72fcde130a99d760895ebdd20e78e02cb5 Add linux-next specific
files for 20240319
Error/Warning ids grouped by kconfigs:
gcc_recent_errors
|-- alpha-allyesconfig
| |--
drivers-gpu-drm-amd
Am 19.03.24 um 15:44 schrieb Khatri, Sunil:
On 3/19/2024 8:07 PM, Christian König wrote:
Am 19.03.24 um 15:25 schrieb Sunil Khatri:
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a new file which would be the right place
Am 19.03.24 um 15:26 schrieb Alex Deucher:
On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote:
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a new file which would be the right place to
hold functions which will be used
On Tue, Mar 19, 2024 at 10:56 AM Christian König
wrote:
>
> Am 19.03.24 um 15:26 schrieb Alex Deucher:
> > On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote:
> >> Refactor the code so debugfs and devcoredump can reuse
> >> the common information and avoid unnecessary copy of it.
> >>
> >> create
Am 19.03.24 um 15:59 schrieb Alex Deucher:
On Tue, Mar 19, 2024 at 10:56 AM Christian König
wrote:
Am 19.03.24 um 15:26 schrieb Alex Deucher:
On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote:
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessar
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a new file which would be the right place to
hold functions which will be used between ioctl, debugfs
and devcoredump.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Suni
Sent a new patch based on discussion with Alex.
On 3/19/2024 8:34 PM, Christian König wrote:
Am 19.03.24 um 15:59 schrieb Alex Deucher:
On Tue, Mar 19, 2024 at 10:56 AM Christian König
wrote:
Am 19.03.24 um 15:26 schrieb Alex Deucher:
On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri
wrote:
Ref
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a new file which would be the right place to
hold functions which will be used between ioctl, debugfs
and devcoredump.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Suni
[AMD Official Use Only - General]
Ignore this as I have send v3.
-Original Message-
From: Sunil Khatri
Sent: Tuesday, March 19, 2024 8:41 PM
To: Deucher, Alexander ; Koenig, Christian
; Sharma, Shashank
Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;
linux-ker...@v
This DC patchset brings improvements in multiple areas. In summary, we have:
- Fix some bound and NULL check
- Fix nonseamless transition from ODM + MPO to ODM + subvp
- Allow Z8 when stutter threshold is not met
- Remove plane and stream pointers from dc scratch
- Remove read/write to external re
From: Alvin Lee
[Why & How]
There is a corner case where a single PSR panel
fails to enter idle optimizations if the panel
is not flipping (no planes or DPMS_OFF == true).
This is because the panel will not enter PSR if it's
not flipping, but this will prevent the FW idle opt
path from being exec
From: Taimur Hassan
[Why]
Previous patch to allow DTBCLK disable didn't address boot case. Driver
thinks DTBCLK is disabled by default, so we don't send disable message to
PMFW. DTBCLK is then enabled at idle desktop on boot, burning power.
[How]
Set dtbclk_en to true on boot so that disable mes
From: Natanel Roizenman
[WHY]
Previously, we'd disabled HPO whenever an HPO display was disconnected. This
caused other HPO displays to blank whenever one was unplugged.
[HOW]
This change restricts HPO enable/disable to dce110_apply_ctx_to_hw and adds a
helper function (dce110_is_hpo_enabled) th
From: Sung Joon Kim
[why&how]
We need to remove the reference to these registers to
prevent any usage in the future.
Reviewed-by: Nicholas Kazlauskas
Acked-by: Tom Chung
Signed-off-by: Sung Joon Kim
---
.../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 38 ---
.../amd/display/d
From: Dillon Varone
[Why&How]
These additional callbacks to DC will be required for the DML2 wrapper. Also
consolidate common callbacks for projects to a single location for maintenance.
Reviewed-by: Chaitanya Dhere
Acked-by: Tom Chung
Signed-off-by: Dillon Varone
---
.../gpu/drm/amd/display
From: Dillon Varone
[Why&How}
Some interfaces needed changes to support future architectures.
Reviewed-by: Chaitanya Dhere
Acked-by: Tom Chung
Signed-off-by: Dillon Varone
---
.../gpu/drm/amd/display/dc/core/dc_state.c| 14 +--
.../gpu/drm/amd/display/dc/core/dc_surface.c | 2 +
From: Wenjing Liu
[why&how]
In some platform out_transfer_func may not be popualted. We need to check
for null before dereferencing it.
Fixes: 4b939f625e9b ("drm/amd/display: Generalize new minimal transition path")
Reviewed-by: Alvin Lee
Acked-by: Tom Chung
Signed-off-by: Wenjing Liu
---
dr
From: Sohaib Nadeem
[why&how]
Add the missing null check before dereference for dc_stream_status*
Fixes: 06653fc22752 ("drm/amd/display: Implement update_planes_and_stream_v3
sequence")
Reviewed-by: Josip Pavic
Acked-by: Tom Chung
Signed-off-by: Sohaib Nadeem
---
drivers/gpu/drm/amd/display
From: Wenjing Liu
[why]
when ODM + MPO is used for all 4 available pipes. Pipe transition will
be nonseamless. Phantom OTG master pipe reuses the secondary OPP head
pipe. There is no possible seamless path to transit to the new
state. The correct logic would be to reuse a secondary DPP pipe a
From: George Shen
[Why]
MPC flow rate control is not needed for DCN30 and above. Current logic
that uses it can result in underflow for certain edge cases (such as
DSC N422 + ODM combine + 422 left edge pixel).
[How]
Remove MPC flow rate control logic and programming for DCN30 and above.
Cc: Ma
From: Wenjing Liu
[why & how]
We are boundling changes in plane state and build scaling params
together. This is to simplify DML code so DML doesn't need to build
scaling params. We are also avoiding rebuilding scaling params for
planes without scaling changes.
Reviewed-by: Dillon Varone
Acked-
From: Roman Li
[Why]
NumFclkLevelsEnabled is used for DcfClocks bounds check
instead of designated NumDcfClkLevelsEnabled.
That can cause array index out-of-bounds access.
[How]
Use designated variable for dcn35 DcfClocks bounds check.
Fixes: 6b8d9862159f ("drm/amd/display: Fix array-index-out-
From: Nicholas Kazlauskas
[Why]
We don't have a way to specify IPS2 for display off but RCG only for
static screen and local video playback.
[How]
Add a new setting that allows RCG only when displays are active but
IPS2 when all displays are off.
Reviewed-by: Ovidiu Bunea
Acked-by: Tom Chung
From: Bhawanpreet Lakha
[Why&How]
Some panels don't meet the stutter threshold (4k etc), this leads to
power regressions. Allow z8 for panels that don't meet the threshold
but support PSR/replay
Reviewed-by: Nicholas Kazlauskas
Acked-by: Tom Chung
Signed-off-by: Bhawanpreet Lakha
---
drivers
From: Bhawanpreet Lakha
[Why&How]
Some panels don't meet the stutter threshold (4k etc), this leads to
power regressions. Allow z8 for panels that don't meet the threshold
but support PSR/replay
Reviewed-by: Nicholas Kazlauskas
Acked-by: Tom Chung
Signed-off-by: Bhawanpreet Lakha
---
drivers
From: Sung Joon Kim
[why&how]
To prevent out of bounds error, we need
to increase the clock table size.
Reviewed-by: Xi Liu
Acked-by: Tom Chung
Signed-off-by: Sung Joon Kim
---
.../amd/display/dc/dml2/dml2_translation_helper.c | 14 +-
1 file changed, 5 insertions(+), 9 deletion
From: Sridevi Arvindekar
[Why]
Number of hpo dp2 link encoders is increased.
Instances are changed.
[How]
Increased size in resource pool, init for each instance
Reviewed-by: Alvin Lee
Acked-by: Tom Chung
Signed-off-by: Sridevi Arvindekar
---
drivers/gpu/drm/amd/display/dc/inc/hw/hw_shared.
From: Alvin Lee
[Why&How]
Remove several plane and stream pointers from dc for code
refactoring.
Reviewed-by: Wenjing Liu
Acked-by: Tom Chung
Signed-off-by: Alvin Lee
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 18 ++---
.../amd/display/amdgpu_dm/amdgpu_dm_color.c | 42 +-
From: Dillon Varone
[WHY&HOW]
Converting the watermark set structure to a union and modifying some interfaces
to accommodate future usage.
Reviewed-by: Chaitanya Dhere
Acked-by: Tom Chung
Signed-off-by: Dillon Varone
---
.../gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c | 8
.../gpu
From: Anthony Koo
- Add Display PHY FSM command interface for automated testing
Acked-by: Tom Chung
Signed-off-by: Anthony Koo
---
.../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 39 ++-
1 file changed, 38 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display
From: Muhammad Ahmed
[why]
Driver crashes when pipe idx not set properly
[how]
Add code to skip the pipe that idx not set properly
Reviewed-by: Charlene Liu
Acked-by: Tom Chung
Signed-off-by: Muhammad Ahmed
---
drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c | 5 +
1 file changed, 5 in
From: Aric Cyr
This version brings along following fixes:
- Fix some bound and NULL check
- Fix nonseamless transition from ODM + MPO to ODM + subvp
- Allow Z8 when stutter threshold is not met
- Remove plane and stream pointers from dc scratch
- Remove read/write to external register
- Increase
59 matches
Mail list logo
