Re: [PATCH] drm/amdgpu: Handle duplicate BOs during process restore

2024-03-11 Thread Lazar, Lijo
On 3/8/2024 10:17 PM, Felix Kuehling wrote: > On 2024-03-08 11:22, Mukul Joshi wrote: >> In certain situations, some apps can import a BO multiple times >> (through IPC for example). To restore such processes successfully, >> we need to tell drm to ignore duplicate BOs. >> While at it, also add

[PATCH] drm/amdgpu: add all ringbuffer information in devcoredump

2024-03-11 Thread Sunil Khatri
Add ringbuffer information such as: rptr, wptr, ring name, ring size and also the ring contents for each ring on a gpu reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/amd/a

RE: [PATCH] drm/amdgpu: add all ringbuffer information in devcoredump

2024-03-11 Thread Khatri, Sunil
Ignore this as I updated commit message and subject so sending new mail. -Original Message- From: Sunil Khatri Sent: Monday, March 11, 2024 5:04 PM To: Deucher, Alexander ; Koenig, Christian ; Sharma, Shashank Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux-

[PATCH] drm/amdgpu: add ring buffer information in devcoredump

2024-03-11 Thread Sunil Khatri
Add relevant ringbuffer information such as rptr, wptr, ring name, ring size and also the ring contents for each ring on a gpu reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/d

Re: Reminder: 2024 X.Org Board of Directors Elections timeline extended, request for nominations

2024-03-11 Thread Christopher Michael
This is a reminder that we are still looking for candidates for the upcoming X.Org Board of Directors elections, and that today is the last day to submit personal statements for nomination. X.org membership renewals are still open and will be needed to vote on those elections. Please read bel

Re: [PATCH] drm/amdgpu: add ring buffer information in devcoredump

2024-03-11 Thread Christian König
Am 11.03.24 um 13:22 schrieb Sunil Khatri: Add relevant ringbuffer information such as rptr, wptr, ring name, ring size and also the ring contents for each ring on a gpu reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 21 + 1 file cha

Re: [PATCH v5 1/2] drm/amdgpu: implement TLB flush fence

2024-03-11 Thread Sharma, Shashank
On 07/03/2024 20:22, Philip Yang wrote: On 2024-03-06 09:41, Shashank Sharma wrote: From: Christian König The problem is that when (for example) 4k pages are replaced with a single 2M page we need to wait for change to be flushed out by invalidating the TLB before the PT can be freed. Solv

Re: Proposal to add CRIU support to DRM render nodes

2024-03-11 Thread Tvrtko Ursulin
Hi Felix, On 06/12/2023 21:23, Felix Kuehling wrote: Executive Summary: We need to add CRIU support to DRM render nodes in order to maintain CRIU support for ROCm application once they start relying on render nodes for more GPU memory management. In this email I'm providing some background w

Re: [PATCH] drm/amdgpu: add ring buffer information in devcoredump

2024-03-11 Thread Khatri, Sunil
On 3/11/2024 7:29 PM, Christian König wrote: Am 11.03.24 um 13:22 schrieb Sunil Khatri: Add relevant ringbuffer information such as rptr, wptr, ring name, ring size and also the ring contents for each ring on a gpu reset. Signed-off-by: Sunil Khatri ---   drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH v2] drm/amdgpu: add ring buffer information in devcoredump

2024-03-11 Thread Sunil Khatri
Add relevant ringbuffer information such as rptr, wptr,rb mask, ring name, ring size and also the rings content for each ring on a gpu reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drive

[PATCH AUTOSEL 6.7 16/23] drm/amdgpu: Enable gpu reset for S3 abort cases on Raven series

2024-03-11 Thread Sasha Levin
From: Prike Liang [ Upstream commit c671ec01311b4744b377f98b0b4c6d033fe569b3 ] Currently, GPU resets can now be performed successfully on the Raven series. While GPU reset is required for the S3 suspend abort case. So now can enable gpu reset for S3 abort cases on the Raven series. Signed-off-b

[PATCH AUTOSEL 6.6 11/17] drm/amdgpu: Enable gpu reset for S3 abort cases on Raven series

2024-03-11 Thread Sasha Levin
From: Prike Liang [ Upstream commit c671ec01311b4744b377f98b0b4c6d033fe569b3 ] Currently, GPU resets can now be performed successfully on the Raven series. While GPU reset is required for the S3 suspend abort case. So now can enable gpu reset for S3 abort cases on the Raven series. Signed-off-b

[PATCH AUTOSEL 6.1 08/13] drm/amdgpu: Enable gpu reset for S3 abort cases on Raven series

2024-03-11 Thread Sasha Levin
From: Prike Liang [ Upstream commit c671ec01311b4744b377f98b0b4c6d033fe569b3 ] Currently, GPU resets can now be performed successfully on the Raven series. While GPU reset is required for the S3 suspend abort case. So now can enable gpu reset for S3 abort cases on the Raven series. Signed-off-b

[PATCH AUTOSEL 5.15 3/5] drm/amdgpu: Enable gpu reset for S3 abort cases on Raven series

2024-03-11 Thread Sasha Levin
From: Prike Liang [ Upstream commit c671ec01311b4744b377f98b0b4c6d033fe569b3 ] Currently, GPU resets can now be performed successfully on the Raven series. While GPU reset is required for the S3 suspend abort case. So now can enable gpu reset for S3 abort cases on the Raven series. Signed-off-b

RE: [PATCH] drm/amdgpu: Handle duplicate BOs during process restore

2024-03-11 Thread Joshi, Mukul
[AMD Official Use Only - General] > -Original Message- > From: Christian König > Sent: Monday, March 11, 2024 2:50 AM > To: Joshi, Mukul ; amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix > Subject: Re: [PATCH] drm/amdgpu: Handle duplicate BOs during process > restore > > Caution: Thi

RE: [PATCH] drm/amdgpu: Handle duplicate BOs during process restore

2024-03-11 Thread Joshi, Mukul
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Monday, March 11, 2024 4:13 AM > To: Kuehling, Felix ; Joshi, Mukul > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: Handle duplicate BOs during process > restore > > > > On 3/8/2024 10:

RE: Re:Re: Re:RE: Why has to offer "/dev/drv/render128" fd when running ROCm demo?

2024-03-11 Thread Russell, Kent
[AMD Official Use Only - General] That flow was removed back in 5.13 timeframe, with this patch: commit f45e6b9d03ff767ff946b6fce7ed3b004ab43ba4 Author: Felix Kuehling felix.kuehl...@amd.com Date: Wed Apr 7 17:30:05 2021 -0400 drm/amdkfd: Remove legacy code n

Re: [PATCH] drm/amdgpu: Handle duplicate BOs during process restore

2024-03-11 Thread Felix Kuehling
On 2024-03-11 11:25, Joshi, Mukul wrote: [AMD Official Use Only - General] -Original Message- From: Christian König Sent: Monday, March 11, 2024 2:50 AM To: Joshi, Mukul ; amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix Subject: Re: [PATCH] drm/amdgpu: Handle duplicate BOs during pr

Re: [PATCH] drm/amdgpu: add ring buffer information in devcoredump

2024-03-11 Thread Christian König
Am 11.03.24 um 15:48 schrieb Khatri, Sunil: On 3/11/2024 7:29 PM, Christian König wrote: Am 11.03.24 um 13:22 schrieb Sunil Khatri: Add relevant ringbuffer information such as rptr, wptr, ring name, ring size and also the ring contents for each ring on a gpu reset. Signed-off-by: Sunil Khat

Re: [PATCH] drm/amdgpu: Handle duplicate BOs during process restore

2024-03-11 Thread Christian König
Am 11.03.24 um 16:33 schrieb Felix Kuehling: On 2024-03-11 11:25, Joshi, Mukul wrote: [AMD Official Use Only - General] -Original Message- From: Christian König Sent: Monday, March 11, 2024 2:50 AM To: Joshi, Mukul ; amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix Subject: Re: [PAT

Re: [PATCH] drm/amdgpu: Handle duplicate BOs during process restore

2024-03-11 Thread Felix Kuehling
On 2024-03-11 12:33, Christian König wrote: Am 11.03.24 um 16:33 schrieb Felix Kuehling: On 2024-03-11 11:25, Joshi, Mukul wrote: [AMD Official Use Only - General] -Original Message- From: Christian König Sent: Monday, March 11, 2024 2:50 AM To: Joshi, Mukul ; amd-gfx@lists.freedeskt

Re: [PATCH v2] drm/amdgpu: add ring buffer information in devcoredump

2024-03-11 Thread Christian König
Am 11.03.24 um 16:11 schrieb Sunil Khatri: Add relevant ringbuffer information such as rptr, wptr,rb mask, ring name, ring size and also the rings content for each ring on a gpu reset. Signed-off-by: Sunil Khatri I think printing the mask still might be useful, but that's just a nit pick. Wi

Re: [PATCH v5 1/2] drm/amdgpu: implement TLB flush fence

2024-03-11 Thread Bhardwaj, Rajneesh
Acked-and-tested-by: Rajneesh Bhardwaj On 3/11/2024 10:37 AM, Sharma, Shashank wrote: On 07/03/2024 20:22, Philip Yang wrote: On 2024-03-06 09:41, Shashank Sharma wrote: From: Christian König The problem is that when (for example) 4k pages are replaced with a single 2M page we need to wai

[PATCH] drm/amdgpu: Do not skip gfx9.4.3 and sdma4.4.2 fini under SRIOV

2024-03-11 Thread Victor Lu
GFX and SDMA is not properly deinitialized under SRIOV. Remove amdgpu_sriov_vf() guards to allow VF to deinitialize correctly. Signed-off-by: Victor Lu --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 7 +-- drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 9 - 2 files changed, 9 insertions

[PATCH] drm/amdgpu: amdgpu_ttm_gart_bind set gtt bound flag

2024-03-11 Thread Philip Yang
Otherwise amdgpu_ttm_backend_unbind will not clear the gart page table and leave valid mapping entry to the stale system page. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/dri

Re: [PATCH] drm/amdgpu: amdgpu_ttm_gart_bind set gtt bound flag

2024-03-11 Thread Christian König
Am 11.03.24 um 23:21 schrieb Philip Yang: Otherwise amdgpu_ttm_backend_unbind will not clear the gart page table and leave valid mapping entry to the stale system page. Signed-off-by: Philip Yang Good catch, that bug is probably in there for quite a while. Reviewed-by: Christian König ---