[PATCH 1/5] drm/amdgpu: add new bit definitions for GC 9.0 PROTECTION_FAULT_STATUS

2024-02-19 Thread Tao Zhou
Add UCE and FED bit definitions. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/include/asic_reg/gc/gc_9_0_sh_mask.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/include/asic_reg/gc/gc_9_0_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/gc/gc_9_0_sh_mask.h index

[PATCH 2/5] drm/amdgpu: add utcl2 poison query for gfxhub

2024-02-19 Thread Tao Zhou
Implement it for gfxhub 1.0 and 1.2. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfxhub.h | 2 ++ drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 17 + drivers/gpu/drm/amd/amdgpu/gfxhub_v1_2.c | 15 +++ 3 files changed, 34 insertions(+) diff --git a

[PATCH 3/5] drm/amdgpu: retire gfx ras query_utcl2_poison_status

2024-02-19 Thread Tao Zhou
Replace it with related interface in gfxhub functions. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h| 1 - drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c| 12

[PATCH 5/5] drm/amdgpu: skip GFX FED error in page fault handling

2024-02-19 Thread Tao Zhou
Let kfd interrupt handler process it. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index 773725a92cf1..70defc394b7b 10

[PATCH 4/5] amd/amdkfd: get node id for query_utcl2_poison_status

2024-02-19 Thread Tao Zhou
Obtain it from ring entry. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c | 3 ++- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c b/drivers/gp

Re: [PATCH v3 9/9] drm/ci: uprev IGT and update testlist

2024-02-19 Thread Vignesh Raman
Hi Maíra, On 10/02/24 23:50, Maíra Canal wrote: On 2/10/24 15:17, Maíra Canal wrote: On 1/30/24 12:03, Vignesh Raman wrote: Uprev IGT and add amd, v3d, vc4 and vgem specific tests to testlist. Have testlist.txt per driver and include a base testlist so that the driver specific tests will run o

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-19 Thread Pekka Paalanen
On Fri, 16 Feb 2024 10:32:10 -0600 Mario Limonciello wrote: > On 2/16/2024 10:13, Harry Wentland wrote: > > > > > > On 2024-02-16 11:11, Harry Wentland wrote: > >> > >> > >> On 2024-02-16 10:42, Pekka Paalanen wrote: > >>> On Fri, 16 Feb 2024 09:33:47 -0500 > >>> Harry Wentland wrote: > >>

Re: [PATCH v3 3/9] drm/ci: mediatek: Add job to test panfrost and powervr GPU driver

2024-02-19 Thread Vignesh Raman
Hi Helen, On 09/02/24 23:51, Helen Koike wrote: On 30/01/2024 12:03, Vignesh Raman wrote: For mediatek mt8173, the GPU driver is powervr and for mediatek mt8183, the GPU driver is panfrost. So add support in drm-ci to test panfrost and powervr GPU driver for mediatek SOCs and update xfails. P

[PATCH] drm/amd/display: Fix potential null pointer dereference in dc_dmub_srv

2024-02-19 Thread Srinivasan Shanmugam
Fixes potential null pointer dereference warnings in the dc_dmub_srv_cmd_list_queue_execute() and dc_dmub_srv_is_hw_pwr_up() functions. In both functions, the 'dc_dmub_srv' variable was being dereferenced before it was checked for null. This could lead to a null pointer dereference if 'dc_dmub_srv

Re: [PATCH] drm/amd: Drop abm_level property

2024-02-19 Thread Christian König
Am 16.02.24 um 16:33 schrieb Mario Limonciello: This vendor specific property has never been used by userspace software and conflicts with the panel_power_savings sysfs file. That is a compositor and user could fight over the same data. Fixes: f97e4303da16 ("drm/amd/display: add panel_power_savi

Re: [PATCH 5/5] drm/amdgpu: skip GFX FED error in page fault handling

2024-02-19 Thread Lazar, Lijo
On 2/19/2024 1:45 PM, Tao Zhou wrote: > Let kfd interrupt handler process it. > > Signed-off-by: Tao Zhou > --- > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > b/drivers/gpu/dr

Re: [PATCH v3 3/9] drm/ci: mediatek: Add job to test panfrost and powervr GPU driver

2024-02-19 Thread Helen Koike
On 19/02/2024 06:39, Vignesh Raman wrote: Hi Helen, On 09/02/24 23:51, Helen Koike wrote: On 30/01/2024 12:03, Vignesh Raman wrote: For mediatek mt8173, the GPU driver is powervr and for mediatek mt8183, the GPU driver is panfrost. So add support in drm-ci to test panfrost and powervr GPU

Re: Kernel 6.7+ broke under-powering of my RX 6700XT. (Archlinux, mesa/amdgpu)

2024-02-19 Thread Linux regression tracking (Thorsten Leemhuis)
On 17.02.24 14:30, Greg KH wrote: > On Sat, Feb 17, 2024 at 02:01:54PM +0100, Roman Benes wrote: >> Minimum power limit on latest(6.7+) kernels is 190W for my GPU (RX 6700XT, >> mesa, archlinux) and I cannot get power cap as low as before(to 115W), >> neither with Corectrl, LACT or TuxClocker and /

Re: Kernel 6.7+ broke under-powering of my RX 6700XT. (Archlinux, mesa/amdgpu)

2024-02-19 Thread Romano
Hello everyone, patch by user @fililip was posted there, but not submitted: "I think I'd have to submit it to the linux kernel mailing list, which I am kinda scared of 😅. It could be better to submit that patch to Arch Linux maintainers; they could include it in their kernel builds." Impleme

Re: Kernel 6.7+ broke under-powering of my RX 6700XT. (Archlinux, mesa/amdgpu)

2024-02-19 Thread Roman Benes
Hello everyone, patch by user @fililip was posted there, but not submitted: /"I think I'd have to submit it to the linux kernel mailing list, which I am kinda scared of 😅. It could be better to submit that patch to Arch Linux maintainers; they could include it in their kernel builds."/ Imple

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-19 Thread Christian König
Am 16.02.24 um 19:37 schrieb Alex Deucher: On Fri, Feb 16, 2024 at 10:42 AM Christian König wrote: Am 16.02.24 um 16:12 schrieb Mario Limonciello: On 2/16/2024 09:05, Harry Wentland wrote: On 2024-02-16 09:47, Christian König wrote: Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-19 Thread Alex Deucher
On Mon, Feb 19, 2024 at 10:19 AM Christian König wrote: > > Am 16.02.24 um 19:37 schrieb Alex Deucher: > > On Fri, Feb 16, 2024 at 10:42 AM Christian König > > wrote: > >> Am 16.02.24 um 16:12 schrieb Mario Limonciello: > >>> On 2/16/2024 09:05, Harry Wentland wrote: > > On 2024-02-16 0

Re: [PATCH 1/2] drm/amdgpu: add new accessors for GPU reset-affected critcal sections

2024-02-19 Thread Christian König
Am 16.02.24 um 16:13 schrieb Alex Deucher: Provide helper functions for code which needs to be mutually exclusive with GPU resets. While we are here, move amdgpu_in_reset in amdgpu_reset.c since that is the more logical location for it and add documentation. Signed-off-by: Alex Deucher --- d

Re: [PATCH 2/2] drm/amdgpu: use new reset-affected accessors for userspace interfaces

2024-02-19 Thread Christian König
Am 16.02.24 um 16:13 schrieb Alex Deucher: Use the new reset critical section accessors for debugfs, sysfs, and the INFO IOCTL to provide proper mutual exclusivity to hardware with respect the GPU resets. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 20 +- d

Re: [PATCH] drm/amdgpu: Drop redundant parameter in amdgpu_gfx_kiq_init_ring

2024-02-19 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: Ma, Jun Sent: Monday, February 19, 2024 1:40 AM To: amd-gfx@lists.freedesktop.org ; Koenig, Christian ; Deucher, Alexander Cc: Ma, Jun Subject: [PATCH] drm/amdgpu: Drop redundant parameter in amdgpu_gfx_kiq_init_ring

[pull] amdgpu, amdkfd, radeon drm-next-6.9

2024-02-19 Thread Alex Deucher
Hi Dave, Sima, More new stuff for 6.9. The following changes since commit d5597444032b2f5c8624918fb5b29be5bba78a3c: drm/amdgpu: Fix HDP flush for VFs on nbio v7.9 (2024-02-07 12:26:24 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-dr

RE: [PATCH 5/5] drm/amdgpu: skip GFX FED error in page fault handling

2024-02-19 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Monday, February 19, 2024 8:40 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 5/5] drm/amdgpu: skip GFX FED error in page fault handling > > > > On 2/19/2024 1:45 PM, Tao Zhou wro

Re: [PATCH 2/2] drm/amdgpu: use new reset-affected accessors for userspace interfaces

2024-02-19 Thread Lazar, Lijo
On 2/16/2024 8:43 PM, Alex Deucher wrote: > Use the new reset critical section accessors for debugfs, sysfs, > and the INFO IOCTL to provide proper mutual exclusivity > to hardware with respect the GPU resets. > This looks more like a priority inversion. When the device needs reset, it doesn't

RE: [PATCH 3/3] drm/amdgpu: Remove pcie bw sys entry

2024-02-19 Thread Zhang, Hawking
[AMD Official Use Only - General] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Kamal, Asad Sent: Friday, February 16, 2024 20:59 To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Zhang, Hawking ; Ma, Le ; Zhang, Morris ; Kamal, Asad Subject: [PATC