[AMD Official Use Only - General]
> Sent: Friday, January 26, 2024 9:43 AM
> To: Alex Deucher
> Cc: Deucher, Alexander ; Sharma, Deepak
> ; amd-gfx@lists.freedesktop.org
> Subject: RE: [PATCH 1/2] drm/amdgpu: skip to program GFXDEC registers for
> PM abort case
>
> [AMD Official Use Only - Genera
[AMD Official Use Only - General]
>-Original Message-
>From: amd-gfx On Behalf Of Felix
>Kuehling
>Sent: Friday, January 26, 2024 6:28 AM
>To: amd-gfx@lists.freedesktop.org
>Cc: Cornwall, Jay ; Koenig, Christian
>; Paneer Selvam, Arunpravin
>
>Subject: [PATCH] drm/amdkfd: Relocate TBA/TMA
No need to set golden settings in driver from gfx 11.5.0 onwards
Signed-off-by: Yifan Zhang
---
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 32 ++
1 file changed, 2 insertions(+), 30 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
b/drivers/gpu/drm/amd/amd
I've applied the patch to 6.7.2. The device then shows up under:
/sys/devices/pci:00/:00:08.1/:c1:00.0/drm/card1/card1-eDP-1/amdgpu/panel_power_savings
(on Framework Laptop 13 amd 7840U with 780M).
After a few tests i can say that at least in my system it’s not working.
Setting a va
I've applied the patch to 6.7.2. The device then shows up under:
/sys/devices/pci:00/:00:08.1/:c1:00.0/drm/card1/card1-eDP-1/amdgpu/panel_power_savings
(on Framework Laptop 13 amd 7840U with 780M).
After a few tests i can say that at least in my system it’s not
working. Setting a v
I've applied the patch to 6.7.2. The device then shows up under:
/sys/devices/pci:00/:00:08.1/:c1:00.0/drm/card1/card1-eDP-1/amdgpu/panel_power_savings
(on Framework Laptop 13 amd 7840U with 780M).
After a few tests i can say that at least in my system it’s not working.
Setting a va
Hello Felix,
This patch seems working on my system, also it seems fixes the ROCM/OpenGL
interop problem.
Is this intended to happen or not? Maybe we need more users to test it.
Besides,
Tested-by: Shengyu Qu
Best Regards,
Shengyu
在 2024/1/26 06:27, Felix Kuehling 写道:
The TBA and TMA, alon
Hi
In Debian (https://bugs.debian.org/1061449) we got the following
quotred report:
On Wed, Jan 24, 2024 at 07:38:16PM +0100, Patrice Duroux wrote:
> Package: src:linux
> Version: 6.7.1-1~exp1
> Severity: normal
>
> Dear Maintainer,
>
> Giving a try to 6.7, here is a message extracted from dmes
I've applied the patch to 6.7.2. The device then shows up under:
/sys/devices/pci:00/:00:08.1/:c1:00.0/drm/card1/card1-eDP-1/amdgpu/panel_power_savings
(on Framework Laptop 13 amd 7840U with 780M).
After a few tests i can say that at least in my system it’s not working.
Setting a va
I only noticed this because my distro broke the mec2.bin symbolic link, so the
firmware failed to load. This resulted in:
amdgpu :0b:00.0: Direct firmware load for amdgpu/navi10_mec2.bin failed
with error -2
BUG: kernel NULL pointer dereference, address: 0008
[...]
Call Trace:
I've applied the patch to 6.7.2. The device then shows up under:
|/sys/devices/pci:00/:00:08.1/:c1:00.0/drm/card1/card1-eDP-1/amdgpu/panel_power_savings|
|||(on Framework Laptop 13 amd 7840U with 780M).|
||
After a few tests i can say that at least in my system it’s not working.
Sett
The same calls are made directly above, but conditional on the firmware
loading and validating successfully.
Fixes: 9931b67690cf ("drm/amd: Load GFX10 microcode during early_init")
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/
We are trying to get rid of all multiplications from allocation
functions to prevent integer overflows. Here the multiplication is
obviously safe, but using kcalloc() is more appropriate and improves
readability. This patch has no effect on runtime behavior.
Link:
https://www.kernel.org/doc/html/
use helper macro HW_ERR to instead of Hardwareare error string.
Signed-off-by: Yang Wang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c | 12 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amd
On 27.01.24 14:14, Salvatore Bonaccorso wrote:
>
> In Debian (https://bugs.debian.org/1061449) we got the following
> quotred report:
>
> On Wed, Jan 24, 2024 at 07:38:16PM +0100, Patrice Duroux wrote:
>>
>> Giving a try to 6.7, here is a message extracted from dmesg:
>> [4.177226] ---
On Sun, 28 Jan 2024 18:25:13 -0300
André Almeida wrote:
> Some hardware are more flexible on what they can flip asynchronously, so
> rework the plane check so drivers can implement their own check, lifting
> up some of the restrictions.
>
> Signed-off-by: André Almeida
> ---
> v3: no changes
>
[AMD Official Use Only - General]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Wang, Yang(Kevin)
Sent: Monday, January 29, 2024 17:10
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Zhou1, Tao ;
Wang, Yang(Kevin)
Subject: [PATCH] drm/amdgpu: use helper m
On Fri, 26 Jan 2024, Mario Limonciello wrote:
> Some manufacturers have intentionally put an EDID that differs from
> the EDID on the internal panel on laptops.
>
> Attempt to fetch this EDID if it exists and prefer it over the EDID
> that is provided by the panel.
>
> Signed-off-by: Mario Limonci
Am 26.01.24 um 20:47 schrieb Philip Yang:
This is to work around a bug in function drm_prime_pages_to_sg if length
of nr_pages >= 4GB, by doing the same check for max_segment and then
calling sg_alloc_table_from_pages_segment directly instead.
This issue shows up on APU because VRAM is allocated
To realize dGPU prime feature for virtio gpu, we are trying to let dGPU
import vram object of virtio gpu. As vram objects don't have backing pages
and thus can't implement the drm_gem_object_funcs.get_sg_table callback,
this removes calling drm_gem_map_dma_buf in virtgpu_gem_map_dma_buf and
impleme
As vram objects don't have backing pages and thus can't implement
drm_gem_object_funcs.get_sg_table callback. This removes drm dma-buf
callbacks in virtgpu_gem_map_dma_buf()/virtgpu_gem_unmap_dma_buf()
and implement virtgpu specific map/unmap/attach callbacks to support
both of shmem objects and vr
Am 29.01.24 um 11:31 schrieb Julia Zhang:
As vram objects don't have backing pages and thus can't implement
drm_gem_object_funcs.get_sg_table callback. This removes drm dma-buf
callbacks in virtgpu_gem_map_dma_buf()/virtgpu_gem_unmap_dma_buf()
and implement virtgpu specific map/unmap/attach callb
On Fri, Jan 26, 2024 at 7:55 PM Mario Limonciello
wrote:
>
> The ACPI specification allows for an EDID to be up to 512 bytes but
> the _DDC EDID fetching code will only try up to 256 bytes.
>
> Modify the code to instead start at 512 bytes and work it's way
> down instead.
>
> Link:
> https://uef
Update boot time errors polling seqeunce to align with
the latest firmware change.
Signed-off-by: Hawking Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 14 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 5 +
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/driv
[Public]
Hi all,
This week this patchset was tested on the following systems:
* Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U
* MSI Gaming X Trio RX 6800
* Gigabyte Gaming OC RX 7900 XTX
These systems were tested on the following display/connection types:
* eD
[AMD Official Use Only - General]
This Patch looks good to me.
Reviewed-By: Frank.Min
-Original Message-
From: amd-gfx On Behalf Of Hawking Zhang
Sent: Monday, January 29, 2024 10:35 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking
Subject: [PATCH] drm/amdgpu: Update boot time
On 2024-01-29 8:58, Shengyu Qu wrote:
Hi,
Seems rocm-opengl interop hang problem still exists[1]. Btw have you
discovered into this problem?
Best regards,
Shengyu
[1]
https://projects.blender.org/blender/blender/issues/100353#issuecomment-599
Maybe you're having a different problem. D
On 2024-01-29 3:45, Yu, Lang wrote:
[AMD Official Use Only - General]
-Original Message-
From: amd-gfx On Behalf Of Felix
Kuehling
Sent: Friday, January 26, 2024 6:28 AM
To: amd-gfx@lists.freedesktop.org
Cc: Cornwall, Jay ; Koenig, Christian
; Paneer Selvam, Arunpravin
Subject: [PATCH
On 2024-01-28 21:30, Yu, Lang wrote:
[AMD Official Use Only - General]
-Original Message-
From: Kuehling, Felix
Sent: Saturday, January 27, 2024 3:22 AM
To: Yu, Lang ; amd-gfx@lists.freedesktop.org
Cc: Francis, David
Subject: Re: [PATCH v2] drm/amdkfd: reserve the BO before validating
That we include so many C files with relative paths seems to be odd.
Apart from that looks good to me.
Christian.
Am 26.01.24 um 16:48 schrieb Rodrigo Siqueira:
In 2022, we got a great patchset from a GSoC project introducing unit
tests to the amdgpu display. Since version 3, this effort was p
On Mon, Jan 29, 2024 at 3:35 AM Liang, Prike wrote:
>
> [AMD Official Use Only - General]
>
> > Sent: Friday, January 26, 2024 9:43 AM
> > To: Alex Deucher
> > Cc: Deucher, Alexander ; Sharma, Deepak
> > ; amd-gfx@lists.freedesktop.org
> > Subject: RE: [PATCH 1/2] drm/amdgpu: skip to program GFXD
[AMD Official Use Only - General]
Ping?
From: Deucher, Alexander
Sent: Thursday, January 25, 2024 11:15 AM
To: amd-gfx@lists.freedesktop.org
Cc: Ma, Jun ; Deucher, Alexander ;
Prosyak, Vitaly
Subject: [PATCH] drm/amdgpu: Fix the warning info in mode1 reset
Fr
The error message buffer overflow 'dc->links' 12 <= 12 suggests that the
code is trying to access an element of the dc->links array that is
beyond its bounds. In C, arrays are zero-indexed, so an array with 12
elements has valid indices from 0 to 11. Trying to access dc->links[12]
would be an attem
This avoids queries to read registers or query the SMU
for telemetry data while the GPU is in reset. This mirrors
what we already do for sysfs.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgp
On 1/29/2024 03:39, Jani Nikula wrote:
On Fri, 26 Jan 2024, Mario Limonciello wrote:
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops.
Attempt to fetch this EDID if it exists and prefer it over the EDID
that is provided by the panel.
On 1/29/2024 07:54, Rafael J. Wysocki wrote:
On Fri, Jan 26, 2024 at 7:55 PM Mario Limonciello
wrote:
The ACPI specification allows for an EDID to be up to 512 bytes but
the _DDC EDID fetching code will only try up to 256 bytes.
Modify the code to instead start at 512 bytes and work it's way
On 2024-01-29 05:06, Christian König
wrote:
Am
26.01.24 um 20:47 schrieb Philip Yang:
This is to work around a bug in function
drm_prime_pages_to_sg if length
of nr_pages >= 4GB, by doing the same check for max_segment
Am 29.01.24 um 17:25 schrieb Philip Yang:
On 2024-01-29 05:06, Christian König wrote:
Am 26.01.24 um 20:47 schrieb Philip Yang:
This is to work around a bug in function drm_prime_pages_to_sg if
length
of nr_pages >= 4GB, by doing the same check for max_segment and then
calling sg_alloc_table_f
On Mon, 29 Jan 2024, Mario Limonciello wrote:
> On 1/29/2024 03:39, Jani Nikula wrote:
>> On Fri, 26 Jan 2024, Mario Limonciello wrote:
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>>> index 9caba10315a8..c7e1563a46d3 100644
Hi Felix,
On 1/29/2024 8:24 PM, Felix Kuehling wrote:
On 2024-01-29 3:45, Yu, Lang wrote:
[AMD Official Use Only - General]
-Original Message-
From: amd-gfx On Behalf Of
Felix
Kuehling
Sent: Friday, January 26, 2024 6:28 AM
To: amd-gfx@lists.freedesktop.org
Cc: Cornwall, Jay ; Koen
On 1/29/2024 10:46, Jani Nikula wrote:
On Mon, 29 Jan 2024, Mario Limonciello wrote:
On 1/29/2024 03:39, Jani Nikula wrote:
On Fri, 26 Jan 2024, Mario Limonciello wrote:
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index 9caba1
On 2024-01-29 11:30, Christian König
wrote:
Am
29.01.24 um 17:25 schrieb Philip Yang:
On 2024-01-29 05:06, Christian König
wrote:
Am 26.01.24 um 20:47 schrieb Philip
Yang:
This is to work aro
On 2024-01-29 10:24, Shengyu Qu wrote:
Hello Felix,
I think you are right. This problem has existed for years(just look at
the
issue creation time in my link), and is thought caused by OpenGL-ROCM
interop(that's why I think this patch might help). It is very easy to
trigger this problem in blen
On 2024-01-29 11:50, Arunpravin Paneer Selvam wrote:
@@ -339,18 +346,19 @@ static void kfd_init_apertures_v9(struct
kfd_process_device *pdd, uint8_t id)
pdd->lds_base = MAKE_LDS_APP_BASE_V9();
pdd->lds_limit = MAKE_LDS_APP_LIMIT(pdd->lds_base);
- /* Raven needs SVM to supp
[Public]
> -Original Message-
> From: William Bulley
> Sent: Sunday, January 28, 2024 2:38 PM
> To: Deucher, Alexander
> Cc: amd-gfx@lists.freedesktop.org
> Subject: Re: Have WX 3200 Radeon graphics card -- cannot get X11 session to
> work
>
> According to "Deucher, Alexander" on Fri,
>
Am 29.01.24 um 18:48 schrieb Felix Kuehling:
On 2024-01-29 11:50, Arunpravin Paneer Selvam wrote:
@@ -339,18 +346,19 @@ static void kfd_init_apertures_v9(struct
kfd_process_device *pdd, uint8_t id)
pdd->lds_base = MAKE_LDS_APP_BASE_V9();
pdd->lds_limit = MAKE_LDS_APP_LIMIT(pdd->lds
According to "Deucher, Alexander" on Mon, 01/29/24
at 13:53:
>
> [Public]
>
> Glad to year you got it working!
Thanks! Two additional things you might be able to point me to...
1) how do I unsubscribe to amd-gfx@lists.freedesktop.org
(the control page doesn't think I'm a member so I can't
The change looks good to me.
Validated now on kernel 5.7 ( branch origin/adeucher/amd-staging-drm-next)
Thanks, Vitaly
On 2024-01-29 10:33, Deucher, Alexander wrote:
>
> [AMD Official Use Only - General]
>
>
> Ping?
>
> --
On 1/28/2024 10:18, David McFarland wrote:
The same calls are made directly above, but conditional on the firmware
loading and validating successfully.
Fixes: 9931b67690cf ("drm/amd: Load GFX10 microcode during early_init")
This is a great find, thank you for the fix. I'll apply it to our tre
On 1/29/2024 14:46, Mario Limonciello wrote:
On 1/28/2024 10:18, David McFarland wrote:
The same calls are made directly above, but conditional on the firmware
loading and validating successfully.
Fixes: 9931b67690cf ("drm/amd: Load GFX10 microcode during early_init")
This is a great find, th
On 1/29/2024 16:18, David McFarland wrote:
The same calls are made directly above, but conditional on the firmware
loading and validating successfully.
Fixes: 9931b67690cf ("drm/amd: Load GFX10 microcode during early_init")
Signed-off-by: David McFarland
---
v2: signed off
Thanks.
Reviewed-by
[Public]
>-Original Message-
>From: Zhang, Yifan
>Sent: Monday, January 29, 2024 5:06 PM
>To: amd-gfx@lists.freedesktop.org
>Cc: Deucher, Alexander ; Koenig, Christian
>; Huang, Tim ; Yu, Lang
>; Zhang, Yifan
>Subject: [PATCH] drm/amdgpu: remove golden setting for gfx 11.5.0
>
>No need t
[Public]
>-Original Message-
>From: Kuehling, Felix
>Sent: Monday, January 29, 2024 10:58 PM
>To: Yu, Lang ; amd-gfx@lists.freedesktop.org
>Cc: Francis, David
>Subject: Re: [PATCH v2] drm/amdkfd: reserve the BO before validating it
>
>On 2024-01-28 21:30, Yu, Lang wrote:
>> [AMD Official
Reviewed-by: Ma Jun
Regards,
Ma Jun
On 1/29/2024 11:33 PM, Deucher, Alexander wrote:
> [AMD Official Use Only - General]
>
>
> Ping?
>
>
[Public]
Thanks for catching this. Will update in V2.
Best Regards,
Yifan
-Original Message-
From: Yu, Lang
Sent: Tuesday, January 30, 2024 9:51 AM
To: Zhang, Yifan ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Koenig, Christian
; Huang, Tim
Subject: RE: [PATCH] drm/amdgpu:
No need to set GC golden settings in driver from gfx 11.5.0 onwards.
Signed-off-by: Yifan Zhang
---
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
i
56 matches
Mail list logo
