Re: [PATCH 1/1] drm/virtio: Implement device_attach

2024-01-11 Thread Zhang, Julia
On 2024/1/10 18:21, Daniel Vetter wrote: > On Wed, Jan 10, 2024 at 05:56:28PM +0800, Julia Zhang wrote: >> drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be >> implemented, or else return ENOSYS. Virtio has no get_sg_table >> implemented for vram object. To fix this, add a new

[PATCH] drm/amdgpu: Clean up errors in discovery.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: "foo* bar" should be "foo *bar" Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/discovery.h | 32 + 1 file changed, 11 insertions(+), 21 deletion

[PATCH] drm/radeon: Clean up errors in smu7_discrete.h

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/smu7_discrete.h | 51 +- 1 file changed, 17 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/rade

[PATCH] drm/amdgpu: Clean up errors in kgd_pp_interface.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following enum go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/kgd_pp_interface.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/kgd_pp_in

[PATCH] drm/amdgpu: Clean up errors in v10_structs.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/v10_structs.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/include/v10_structs.h b

[PATCH] drm/amd/amdgpu: Clean up errors in amdgpu_umr.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: spaces required around that '=' (ctx:VxV) Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/amdgpu_umr.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_umr.h b/drivers/gpu/drm/am

[PATCH] drm/amdgpu: Clean up errors in dimgrey_cavefish_ip_offset.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/dimgrey_cavefish_ip_offset.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/inclu

[PATCH] drm/amdgpu: Clean up errors in clearstate_gfx9.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/clearstate_gfx9.h | 27 +++- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/amd/amdg

[PATCH] drm/amd/display: Clean up errors in renoir_ip_offset.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/renoir_ip_offset.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/renoir_

[PATCH] drm/radeon: Clean up errors in si_dpm.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/si_dpm.c | 132 +++- 1 file changed, 44 insertions(+), 88 deletions(-) diff --git a/drivers/gpu/drm/radeon/

[PATCH] drm/radeon/dpm: Clean up errors in trinity_dpm.h

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/trinity_dpm.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/trinity_dpm.h b/drivers/g

[PATCH] drm/amdgpu: Clean up errors in amdgpu_drv.c

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: do not initialise globals to 0 Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/am

[PATCH] drm/amdgpu: Clean up errors in atomfirmwareid.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following enum go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/atomfirmwareid.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/atomfirmwar

[PATCH] drm/amdgpu: Clean up errors in cgs_common.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space required after that ',' (ctx:VxV) Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/cgs_common.h | 23 +++ 1 file changed, 11 insertions(+), 12 d

[PATCH] drm/amdgpu: Clean up errors in displayobject.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: spaces required around that '=' (ctx:WxV) ERROR: space prohibited after that open parenthesis '(' Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/displayobject.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/radeon: Clean up errors in rs400.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: space required before the open parenthesis '(' Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/rs400.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/rs400.c b/drivers/gpu/drm/radeon/rs

[PATCH] drm/amdgpu: Clean up errors in atombios.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space required after that close brace '}' Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/atombios.h | 74 +++--- 1 file changed, 30 insertions(+), 4

Re: [PATCH 1/3] selftests/bpf: Update LLVM Phabricator links

2024-01-11 Thread Yonghong Song
On 1/9/24 2:16 PM, Nathan Chancellor wrote: reviews.llvm.org was LLVM's Phabricator instances for code review. It has been abandoned in favor of GitHub pull requests. While the majority of links in the kernel sources still work because of the work Fangrui has done turning the dynamic Phabricato

[PATCH] drm/radeon: Clean up errors in radeon_atpx_handler.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following function definitions go on the next line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/radeon_atpx_handler.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH] drm/amdgpu: Clean up errors in clearstate_si.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/clearstate_si.h | 24 -- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/amdg

[PATCH] drm/amd: Clean up errors in sdma_v2_4.c

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: trailing statements should be on next line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-)

[PATCH] drm/amdgpu: Clean up errors in amdgpu_atomfirmware.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: "foo* bar" should be "foo *bar" Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.h b/drivers

[PATCH 3/6] drm/amdgpu: prefer snprintf over sprintf

2024-01-11 Thread Jani Nikula
This will trade the W=1 warning -Wformat-overflow to -Wformat-truncation. This lets us enable -Wformat-overflow subsystem wide. Cc: Alex Deucher Cc: Christian König Cc: Pan, Xinhui Cc: amd-gfx@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 ++-

[PATCH] drm/amdgpu: Clean up errors in gfx_v9_4.c

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c b/drivers

[PATCH] drm/amdgpu: Clean up errors in amdgpu_ib.c

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: do not use assignment in if condition Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/a

[PATCH] drm/radeon/dpm: Clean up errors in sumo_dpm.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space prohibited before that close parenthesis ')' ERROR: spaces required around that '?' (ctx:VxW) Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/sumo_dpm.c | 18 -

[PATCH] drm/amdgpu: Clean up errors in amdgpu_gmc.c

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: need consistent spacing around '-' (ctx:WxV) Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/

[PATCH] drm/amd/include/vangogh_ip_offset: Clean up errors in vangogh_ip_offset.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/vangogh_ip_offset.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/vangog

[PATCH] drm/radeon: Clean up errors in ni.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: trailing statements should be on next line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/ni.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) dif

[PATCH] drm/radeon: Clean up errors in radeon_audio.h

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/radeon_audio.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_audio.h b/dri

[PATCH] drm/radeon: Clean up errors in trinity_dpm.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space prohibited before that ',' (ctx:WxW) ERROR: need consistent spacing around '-' (ctx:WxV) Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/kv_dpm.c | 9 - 1 file cha

[PATCH] drm/amd: Clean up errors in amdgpu_vkms.c

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c b/driv

[PATCH] drm/amdgpu: Clean up errors in amdgpu_rlc.c

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: space prohibited before that '++' (ctx:WxB) Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c b/drivers/gpu/d

[PATCH] drm/amd/pp: Clean up errors in dm_pp_interface.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before that ',' (ctx:WxE) Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/dm_pp_interface.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(

[PATCH] drm/radeon: Clean up errors in rs600.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/rs600.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/rs600.c b/drivers/gpu/drm/radeon/rs

[PATCH] drm/amd/include/vega10_ip_offset:Clean up errors in vega10_ip_offset.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following enum go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/vega10_ip_offset.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/vega10_ip

Re: [PATCH 0/3] Update LLVM Phabricator and Bugzilla links

2024-01-11 Thread Kees Cook
On Tue, Jan 09, 2024 at 03:16:28PM -0700, Nathan Chancellor wrote: > This series updates all instances of LLVM Phabricator and Bugzilla links > to point to GitHub commits directly and LLVM's Bugzilla to GitHub issue > shortlinks respectively. > > I split up the Phabricator patch into BPF selftests

[PATCH] drm/radeon/kms: Clean up errors in rv6xx_dpm.h

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/rv6xx_dpm.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/rv6xx_dpm.h b/drivers/gpu/d

[PATCH] drm/radeon: Clean up errors in si_dpm.h

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: open brace '{' following enum go on the same line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/si_dpm.h | 21 +++-- 1 file changed, 7 insertions(+), 14 del

[PATCH] drm/amd/amdgpu: Clean up errors in beige_goby_ip_offset.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/beige_goby_ip_offset.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/bei

[PATCH] drm/radeon: Clean up errors in radeon_asic.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: spaces required around that '||' (ctx:VxE) Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/radeon_asic.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_asic.c b/drivers/gpu/

[PATCH] drm/amdgpu: Clean up errors in jpeg_v2_5.c

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: space required before the open parenthesis '(' ERROR: that open brace { should be on the previous line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-)

[PATCH] drm/amdgpu: Clean up errors in amdgpu.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/driv

[PATCH] drm/amd/include/navi14_ip_offset: Clean up errors in navi14_ip_offset.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/navi14_ip_offset.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/navi14_

[PATCH] drm/amdgpu: Clean up errors in navi12_ip_offset.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/navi12_ip_offset.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/navi12_

[PATCH] drm/amd: Clean up errors in vega10_ip_offset.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/cyan_skillfish_ip_offset.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include

[PATCH] drm/radeon: Clean up errors in radeon_audio.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: "foo* bar" should be "foo *bar" ERROR: that open brace { should be on the previous line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/radeon_audio.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/dr

[PATCH] drm/radeon: Clean up errors in r600_dpm.h

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following enum go on the same line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/r600_dpm.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_dpm.h b/drivers/gpu/drm/r

[PATCH] drm/amd/include: Clean up errors in arct_ip_offset.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/arct_ip_offset.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/arct_ip_o

[PATCH] drm/radeon/btc_dpm: Clean up errors in btc_dpm.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space required before the open parenthesis '(' ERROR: spaces required around that '+=' (ctx:VxV) ERROR: spaces required around that '=' (ctx:VxW) Signed-off-by: GuoHua Chen --- driver

[PATCH] drm/amdgpu: Clean up errors in navi10_ih.c

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c b/drivers/

[PATCH] drm/amdgpu: Clean up errors in atom-bits.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: space prohibited before that ',' (ctx:WxV) Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/atom-bits.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/include/atom-bits.h b/drivers/gpu/dr

[PATCH] drm/radeon/trinity_dpm: Clean up errors in trinity_dpm.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: space required before the open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' ERROR: that open brace { should be on the previous line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/trinity_dpm.c | 22 +

[PATCH] drm/radeon: Clean up errors in radeon_display.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/radeon_display.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) d

[PATCH] drm/amdgpu: Clean up errors in umc_v6_0.c

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/amdgpu/umc_v6_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v6_0.c b/drivers/gpu/drm/amd/a

[PATCH] drm/radeon/ni_dpm: Clean up errors in ni_dpm.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/ni_dpm.h | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/radeon/ni_dpm.h b/drivers/g

[PATCH] drm/amd/include/vega20_ip_offset: Clean up errors in vega20_ip_offset.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: spaces required around that '=' (ctx:WxV) Signed-off-by: chenxuebing --- .../gpu/drm/amd/include/vega20_ip_offset.h| 78 +-- 1 file changed, 38 insertions(+), 4

[PATCH] drm/radeon/rv770: Clean up errors in rv770_dpm.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/rv770_dpm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/rv770_dpm.c b/drivers/gpu/

[PATCH] drm/radeon: Clean up errors in r600.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/r600.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600

[PATCH] drm/radeon: Clean up errors in ni_dpm.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: space prohibited before that ',' (ctx:WxV) ERROR: space required after that ',' (ctx:WxV) Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/atom-bits.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH] drm/radeon: Clean up errors in uvd_v1_0.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: "(foo*)" should be "(foo *)" Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/uvd_v1_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/uvd_v1_0.c b/drivers/gpu/drm/radeon/uvd_v1_0.c index

[PATCH] drm/radeon/ci_dpm: Clean up errors in ci_dpm.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: need consistent spacing around '-' (ctx:WxV) ERROR: space required before the open parenthesis '(' ERROR: "foo* bar" should be "foo *bar" Signed-off-by: GuoHua Chen --- drivers/gpu/dr

[PATCH] drm/amdgpu: Clean up errors in displayobject.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: spaces required around that '=' (ctx:WxV) ERROR: space prohibited after that open parenthesis '(' Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/displayobject.h | 72 ++--- 1 file changed, 36 insertions(+), 36 d

[PATCH] drm/radeon: Clean up errors in rv770_smc.h

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: open brace '{' following union go on the same line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/rv770_smc.h | 27 +-- 1 file changed, 9 insertions(

[PATCH] drm/radeon: Clean up errors in rv6xx_dpm.h

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/atombios_crtc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/

[PATCH] drm/amd/include/sienna_cichlid_ip_offset: Clean up errors in sienna_cichlid_ip_offset.h

2024-01-11 Thread chenxuebing
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: chenxuebing --- drivers/gpu/drm/amd/include/sienna_cichlid_ip_offset.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include

[PATCH] drm/radeon/r100: Clean up errors in r100.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: spaces required around that '+=' (ctx:VxV)o Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/r100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c inde

Re: [PATCH 1/1] drm/virtio: Implement device_attach

2024-01-11 Thread Christian König
Am 11.01.24 um 09:52 schrieb Zhang, Julia: On 2024/1/10 18:21, Daniel Vetter wrote: On Wed, Jan 10, 2024 at 05:56:28PM +0800, Julia Zhang wrote: drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be implemented, or else return ENOSYS. Virtio has no get_sg_table implemented for

[PATCH v2] drm/amdkfd: Fix the shift-out-of-bounds warning

2024-01-11 Thread Ma Jun
There is shift-out-of-bounds warning following if ecode=0. "shift exponent 4294967295 is too large for 64-bit type 'long long unsigned int'" Signed-off-by: Ma Jun Suggested-by: Felix Kuehling --- include/uapi/linux/kfd_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH] drm/amd/pm: Fix smuv13.0.6 current clock reporting

2024-01-11 Thread Lijo Lazar
When current clock is equal to max dpm level clock, the level is not indicated correctly with *. Fix by comparing current clock against dpm level value. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

RE: [PATCH] drm/amd/pm: Fix smuv13.0.6 current clock reporting

2024-01-11 Thread Kamal, Asad
[AMD Official Use Only - General] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Thursday, January 11, 2024 4:02 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Ma, Le ; Wang, Yang(Kevin) Subject:

[PATCH] drm/radeon/kms: Clean up errors in smu7_fusion.h

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before open square bracket '[' Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/smu7_fusion.h | 42 +++- 1 file changed, 16 insertions

[PATCH] drm/radeon/kms: Clean up errors in smu7.h

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/smu7.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/smu7.h b/drivers/gpu/drm/rade

[PATCH] drm/radeon: Clean up errors in si.c

2024-01-11 Thread XueBing Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: trailing statements should be on next lineo Signed-off-by: XueBing Chen --- drivers/gpu/drm/radeon/si.c | 63 + 1 file changed, 22 insertions(+), 4

[PATCH] drm/radeon: Clean up errors in evergreen.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: spaces required around that '&=' (ctx:WxO) ERROR: space required before that '~' (ctx:OxV) ERROR: space prohibited before that close parenthesis ')' ERROR: space required after that ','

[PATCH] drm/radeon: Clean up errors in radeon_mode.h

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/radeon_mode.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_mode.h b/dr

[PATCH] drm/radeon: Clean up errors in kv_smc.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: spaces required around that '=' (ctx:VxW) Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/kv_smc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/kv_smc.c b/drivers/gpu/drm/radeon/kv_smc.c

[PATCH] gpu/drm/radeon: Clean up errors in evergreen.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/r300_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH] drm/radeon: Clean up errors in atombios.h

2024-01-11 Thread XueBing Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space required after that close brace '}' Signed-off-by: XueBing Chen --- drivers/gpu/drm/radeon/atombios.h | 135 -- 1 file changed, 54 insertions(+),

[PATCH] drm/radeon: Clean up errors in radeon.h

2024-01-11 Thread XueBing Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: XueBing Chen --- drivers/gpu/drm/radeon/radeon.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm

[PATCH] drm/radeon: Clean up errors in clearstate_ci.h

2024-01-11 Thread XueBing Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: XueBing Chen --- drivers/gpu/drm/radeon/clearstate_ci.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/clearstate_ci.h b/drivers

[PATCH] drm/radeon/kms: Clean up errors in radeon_pm.c

2024-01-11 Thread XueBing Chen
Fix the following errors reported by checkpatch: ERROR: space required before the open parenthesis '(' Signed-off-by: XueBing Chen --- drivers/gpu/drm/radeon/radeon_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm

[PATCH] drm/radeon/dpm: Clean up errors in evergreen_smc.h

2024-01-11 Thread XueBing Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: XueBing Chen --- drivers/gpu/drm/radeon/evergreen_smc.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/evergreen_smc.h

[PATCH] drm/radeon: Clean up errors in clearstate_cayman.h

2024-01-11 Thread XueBing Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: XueBing Chen --- drivers/gpu/drm/radeon/clearstate_cayman.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/clearstate_c

[PATCH] drm/radeon: Clean up errors in evergreen_reg.h

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: space prohibited before that close parenthesis ')' ERROR: need consistent spacing around '<<' (ctx:WxV) ERROR: need consistent spacing around '-' (ctx:WxV) Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/evergreen_reg.h | 10 +---

[PATCH] drm/radeon: Clean up errors in ci_dpm.h

2024-01-11 Thread XueBing Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: XueBing Chen --- drivers/gpu/drm/radeon/ci_dpm.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/ci_dpm.h b/drivers/gpu/drm

[PATCH] drm/radeon/evergreen_cs: Clean up errors in evergreen_cs.c

2024-01-11 Thread XueBing Chen
Fix the following errors reported by checkpatch: ERROR: space required after that ',' (ctx:VxV) ERROR: spaces required around that '>' (ctx:VxV) ERROR: spaces required around that '<' (ctx:VxV) Signed-off-by: XueBing Chen --- drivers/gpu/drm/radeon/evergreen_cs.c | 4 ++-- 1 file changed, 2 ins

[PATCH] drm/radeon: Clean up errors in r600_dpm.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/r600_dpm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_dpm.c b/drivers/gpu/dr

[PATCH] drm/radeon: Clean up errors in rv515.c

2024-01-11 Thread GuoHua Chen
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: GuoHua Chen --- drivers/gpu/drm/radeon/rv515.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/rv515.c b/drivers/gpu/drm/radeon/rv

[PATCH] drm/radeon/ni_dpm: Clean up errors in nislands_smc.h

2024-01-11 Thread XueBing Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: XueBing Chen --- drivers/gpu/drm/radeon/nislands_smc.h | 51 +-- 1 file changed, 17 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/rad

[PATCH] drm/radeon: Clean up errors in pptable.h

2024-01-11 Thread XueBing Chen
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space required after that close brace '}' Signed-off-by: XueBing Chen --- drivers/gpu/drm/radeon/pptable.h | 204 +-- 1 file changed, 82 insertions(+),

[PATCH] SWDEV-439292 - Update RLC_SPM_MC_CNT by ring wreg

2024-01-11 Thread YuanShang
Why: RLC_SPM_MC_CNTL can not updated by MMIO since MMIO protection is enabled during runtime. How: submit command of wreg in amdgpu ring to update RLC_SPM_MC_CNT. Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- drive

[PATCH v2] drm/amd/amdgpu: Update RLC_SPM_MC_CNT by ring wreg

2024-01-11 Thread YuanShang
[Why] RLC_SPM_MC_CNTL can not updated by MMIO since MMIO protection is enabled during runtime in guest machine. [How] Submit command of wreg in amdgpu ring to update RLC_SPM_MC_CNT. Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_v

[PATCH] drm/{amdgpu, radeon}: check PS, WS index

2024-01-11 Thread Alexander
These patches add index checking to parameter / work space reads and writes to ATOMBIOS bytecode. Theoretically, it would be possible to perform stack-aligned out-of-bounds read and writes, and since the bytecode is in the BIOS, any exploits which could be made with this would persist across r

[PATCH 1/2] drm/amdgpu: check PS, WS index

2024-01-11 Thread Alexander
From: Alexander Richards Theoretically, it would be possible for a buggy or malicious VBIOS to overwrite past the bounds of the passed parameters (or its own workspace); add bounds checking to prevent this from happening. Signed-off-by: Alexander Richards --- drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH 2/2] drm/radeon: check PS, WS index

2024-01-11 Thread Alexander
From: Alexander Richards Theoretically, it would be possible for a buggy or malicious VBIOS to overwrite past the bounds of the passed parameters (or its own workspace); add bounds checking to prevent this from happening. Signed-off-by: Alexander Richards --- drivers/gpu/drm/radeon/atom.c

[PATCH] drm/amdgpu: fix typo in parameter description

2024-01-11 Thread Alex Deucher
Missing space. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 5c9caf5fa075..0712d5867849 100644 --- a/drivers/gpu/

Re: [PATCH] drm/amdkfd: Fix the shift-out-of-bounds warning

2024-01-11 Thread Felix Kuehling
[+Jon] On 2024-01-11 01:05, Ma, Jun wrote: Hi Felix, On 1/10/2024 11:57 PM, Felix Kuehling wrote: On 2024-01-10 04:39, Ma Jun wrote: There is following shift-out-of-bounds warning if ecode=0. "shift exponent 4294967295 is too large for 64-bit type 'long long unsigned int'" Signed-off-by: M

Re: [PATCH] drm/amdkfd: reserve the BO before validating it

2024-01-11 Thread Felix Kuehling
On 2024-01-11 02:22, Lang Yu wrote: Fixes: 410f08516e0f ("drm/amdkfd: Move dma unmapping after TLB flush") [ 41.708711] WARNING: CPU: 0 PID: 1463 at drivers/gpu/drm/ttm/ttm_bo.c:846 ttm_bo_validate+0x146/0x1b0 [ttm] [ 41.708989] Call Trace: [ 41.708992] [ 41.708996] ? show_regs+0x6c/

Re: [PATCH v3] amd/amdkfd: Set correct svm range actual loc after spliting

2024-01-11 Thread Felix Kuehling
On 2024-01-10 17:01, Philip Yang wrote: While svm range partial migrating to system memory, clear dma_addr vram domain flag, otherwise the future split will get incorrect vram_pages and actual loc. After range spliting, set new range and old range actual_loc: new range actual_loc is 0 if new->

  1   2   >