[PATCH v3] drm/amdgpu: Release 'adev->pm.fw' before return in 'amdgpu_device_need_post()'

2023-12-26 Thread Srinivasan Shanmugam
In function 'amdgpu_device_need_post(struct amdgpu_device *adev)' - 'adev->pm.fw' may not be released before return. Using the function release_firmware() to release adev->pm.fw. Thus fixing the below: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1571 amdgpu_device_need_post() warn: 'adev->pm.fw'

[PATCH] drm/amdgpu: Fix possible NULL dereference in amdgpu_ras_query_error_status_helper()

2023-12-26 Thread Srinivasan Shanmugam
Return 0, if blk is >= AMDGPU_RAS_BLOCK_COUNT Fixes the below: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1183 amdgpu_ras_query_error_status_helper() error: we previously assumed 'info' could be null (see line 1176) Cc: Tao Zhou Cc: Hawking Zhang Cc: Christian König Cc: Alex Deucher Signed-of

[PATCH] Removing duplicate copyright text

2023-12-26 Thread Marcelo Mendes Spessoto Junior
Signed-off-by: Marcelo Mendes Spessoto Junior The file display/modules/inc/mod_freesync.h has two identical AMD Copyright texts. This simple patch aims to remove the duplicate one. --- .../amd/display/modules/inc/mod_freesync.h| 28 --- 1 file changed, 28 deletions(-) diff

RE: [PATCH] drm/amdgpu: Fix possible NULL dereference in amdgpu_ras_query_error_status_helper()

2023-12-26 Thread Zhang, Hawking
[AMD Official Use Only - General] Invalid block id should return invalid error code. Regards, Hawking -Original Message- From: SHANMUGAM, SRINIVASAN Sent: Tuesday, December 26, 2023 18:04 To: Deucher, Alexander ; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVAS

Re: [PATCH v2 0/1] Implementation of resource_query_layout

2023-12-26 Thread Gurchetan Singh
On Thu, Dec 21, 2023 at 2:01 AM Julia Zhang wrote: > Hi all, > > Sorry to late reply. This is v2 of the implementation of > resource_query_layout. This adds a new ioctl to let guest query information > of host resource, which is originally from Daniel Stone. We add some > changes to support query

Re: [PATCH] Removing duplicate copyright text

2023-12-26 Thread Marcelo Mendes
Hello Bagas, I'm sorry for that. I will send another mail of this patch with your recommendations. Em ter., 26 de dez. de 2023 23:30, Bagas Sanjaya escreveu: > On Tue, Dec 26, 2023 at 08:57:41PM -0300, Marcelo Mendes Spessoto Junior > wrote: > > Signed-off-by: Marcelo Mendes Spessoto Junior <

[PATCH v2] drm/amdgpu: Fix possible NULL dereference in amdgpu_ras_query_error_status_helper()

2023-12-26 Thread Srinivasan Shanmugam
Return invalid error code -EINVAL for invalid block id. Fixes the below: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1183 amdgpu_ras_query_error_status_helper() error: we previously assumed 'info' could be null (see line 1176) Suggested-by: Hawking Zhang Cc: Tao Zhou Cc: Hawking Zhang Cc: Chris

RE: [PATCH v2] drm/amdgpu: Fix possible NULL dereference in amdgpu_ras_query_error_status_helper()

2023-12-26 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: SHANMUGAM, SRINIVASAN Sent: Wednesday, December 27, 2023 12:37 To: Deucher, Alexander ; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN ; Zhang, Hawking ;