Re: [PATCH] drm/amdgpu: clean up some inconsistent indenting

2023-09-01 Thread Christian König
Am 01.09.23 um 09:02 schrieb Jiapeng Chong: No functional modification involved. drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c:34 nbio_v7_11_get_rev_id() warn: inconsistent indenting. We should probably not have a printk here in the first place. Christian. Reported-by: Abaci Robot Closes: htt

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-09-01 Thread Alex Deucher
On Thu, Aug 31, 2023 at 6:01 PM Alex Hung wrote: > > > > On 2023-08-30 01:29, Jani Nikula wrote: > > On Tue, 29 Aug 2023, Alex Hung wrote: > >> On 2023-08-29 11:03, Jani Nikula wrote: > >>> On Tue, 29 Aug 2023, Jani Nikula wrote: > On Tue, 29 Aug 2023, Alex Deucher wrote: > > On Tue, A

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-09-01 Thread Jani Nikula
On Thu, 31 Aug 2023, Alex Hung wrote: > On 2023-08-30 01:29, Jani Nikula wrote: >> On Tue, 29 Aug 2023, Alex Hung wrote: >>> There is a patch under internal reviews. It removes calls edid_override >>> and drm_edid_override_connector_update as intended in this patchset but >>> does not remove the

[PATCH -next 3/5] drm/amd/display: clean up some inconsistent indentings

2023-09-01 Thread Yang Li
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn35/dcn35_hwseq.c:159 dcn35_init_hw() warn: inconsistent indentig Signed-off-by: Yang Li --- .../drm/amd/display/dc/dcn35/dcn35_hwseq.c| 32 +-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/dis

[PATCH -next 1/4] drm/amd/display: Remove duplicated include in dcn35_resource.c

2023-09-01 Thread Yang Li
./drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c: dcn31/dcn31_dio_link_encoder.h is included more than once. Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_reso

[PATCH -next 5/5] drm/amd/display: clean up one inconsistent indenting

2023-09-01 Thread Yang Li
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn35/dcn35_fpu.c:260 dcn35_update_bw_bounding_box_fpu() warn: inconsistent indenting Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/

[PATCH -next 1/5] drm/amd/display: clean up one inconsistent indenting

2023-09-01 Thread Yang Li
drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv.c:355 dmub_srv_hw_setup() warn: inconsistent indenting Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dmub/src/dmub

[PATCH -next 3/4] drm/amd/display: Remove duplicated include in dcn35_hwseq.c

2023-09-01 Thread Yang Li
./drivers/gpu/drm/amd/display/dc/dcn35/dcn35_hwseq.c: clk_mgr.h is included more than once. Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn35/dcn35_hwseq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_hwseq.c b/drivers/gpu/drm/amd/

[PATCH] drm/amd: Make fence wait in suballocator uninterruptible

2023-09-01 Thread Simon Pilkington
c103a23f2f297c6ab2e5e74e39b655439f3524a6 made the fence wait in amdgpu_sa_bo_new() interruptible but there is no code to handle an interrupt. This caused the kernel to randomly explode in high-VRAM-pressure situations so make it uninterruptible again. Signed-off-by: Simon Pilkington --- drivers/

Re: [V11 3/8] wifi: mac80211: Add support for WBRF features

2023-09-01 Thread Jeff Johnson
On 8/30/2023 11:20 PM, Evan Quan wrote: To support the WBRF mechanism, Wifi adapters utilized in the system must Since this is the first mention of WBRF in the core wireless code IMO you should indicate what this is an acronym for and briefly describe it (or add a lore link). I'm wondering i

[PATCH -next 2/5] drm/amd/display: clean up one inconsistent indenting

2023-09-01 Thread Yang Li
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn35/dcn35_resource.c:1877 dcn35_resource_construct() warn: inconsistent indenting Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/d

[PATCH] drm/amdgpu: clean up some inconsistent indenting

2023-09-01 Thread Jiapeng Chong
No functional modification involved. drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c:34 nbio_v7_11_get_rev_id() warn: inconsistent indenting. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6316 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c |

[PATCH -next 4/5] drm/amd/display: clean up some inconsistent indentings

2023-09-01 Thread Yang Li
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:288 dcn35_update_clocks() warn: inconsistent indenting Signed-off-by: Yang Li --- .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 28 +-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/driver

[PATCH -next 4/4] drm/amd/display: Remove duplicated include in dcn35_clk_mgr.c

2023-09-01 Thread Yang Li
./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c: dcn35_clk_mgr.h is included more than once. Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn

[PATCH] drm/amd: Make fence wait in suballocator uninterruptible

2023-09-01 Thread Simon Pilkington
Commit c103a23f2f29 ("drm/amd: Convert amdgpu to use suballocation helper.") made the fence wait in amdgpu_sa_bo_new() interruptible but there is no code to handle an interrupt. This caused the kernel to randomly explode in high-VRAM-pressure situations so make it uninterruptible again. Fixes: c10

[PATCH -next 2/4] drm/amd/display: Remove duplicated include in dcn35_optc.c

2023-09-01 Thread Yang Li
./drivers/gpu/drm/amd/display/dc/dcn35/dcn35_optc.c: dcn35_optc.h is included more than once. Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn35/dcn35_optc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_optc.c b/drivers/gpu/drm/amd/

Re: [Patch v2 2/3] drm/mst: Refactor the flow for payload allocation/removement

2023-09-01 Thread Alex Deucher
On Thu, Aug 31, 2023 at 6:45 PM Lyude Paul wrote: > > On Thu, 2023-08-24 at 04:12 +, Lin, Wayne wrote: > > [Public] > > > > Hi Lyude, > > > > I'm afraid that I don't have the permissions to push and would like to have > > your help. Thanks! > > Whoops, sorry I only just noticed this message. I

[RFT PATCH 00/15] drm: non-drm-misc drivers call drm_atomic_helper_shutdown() at the right times

2023-09-01 Thread Douglas Anderson
NOTE: in order to avoid email sending limits on the cover letter, I've split this patch series in two. Patches that target drm-misc and ones that don't. The cover letter of the two is identical other than this note. This patch series came about after a _long_ discussion between me and Maxime Rip

[RFT PATCH 09/15] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-01 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call drm_atomic

[RFT PATCH 14/15] drm/radeon: Call drm_helper_force_disable_all() at shutdown/remove time

2023-09-01 Thread Douglas Anderson
Based on grepping through the source code, this driver appears to be missing a call to drm_atomic_helper_shutdown(), or in this case the non-atomic equivalent drm_helper_force_disable_all(), at system shutdown time and at driver remove time. This is important because drm_helper_force_disable_all()