[PATCH] drm/amdgpu: Fix identation issues in 'kgd_gfx_v9_program_trap_handler_settings'

2023-08-07 Thread Srinivasan Shanmugam
Fixes the following: ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Cc: "Pan, Xinhui" Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 4 ++--

Re: [PATCH] drm/amdgpu: Fix identation issues in 'kgd_gfx_v9_program_trap_handler_settings'

2023-08-07 Thread Christian König
Am 07.08.23 um 09:23 schrieb Srinivasan Shanmugam: Fixes the following: ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Cc: "Pan, Xinhui" Signed-off-by: Srinivasan Shanmugam Reviewed-

[PATCH] drm/amdgpu: Fix identifier names to function definition arguments in atom.h

2023-08-07 Thread Srinivasan Shanmugam
Fixes the following: WARNING: function definition argument 'struct card_info *' should also have an identifier name WARNING: function definition argument 'uint32_t' should also have an identifier name WARNING: function definition argument 'void *' should also have an identifier name WARNING: fu

[PATCH v2] drm/amdgpu: Add FRU sysfs nodes only if needed

2023-08-07 Thread Lijo Lazar
Create sysfs nodes for FRU data only if FRU data is available. Move the logic to FRU specific file. Signed-off-by: Lijo Lazar --- v2: Add fru sysfs fini to take care of removing files (Hawking) drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 71 +-- .../gpu/drm/amd/amdgpu/amdgpu_fr

RE: [PATCH] drm/amdgpu: Fix identifier names to function definition arguments in atom.h

2023-08-07 Thread Chen, Guchun
[Public] > -Original Message- > From: SHANMUGAM, SRINIVASAN > Sent: Monday, August 7, 2023 4:27 PM > To: Koenig, Christian ; Deucher, Alexander > ; Chen, Guchun ; > Pan, Xinhui > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN > > Subject: [PATCH] drm/amdgpu: Fix identifier nam

[PATCH] drm/amdgpu: add RAS fatal error handler for NBIO v7.9

2023-08-07 Thread Tao Zhou
Register RAS fatal error interrupt and add handler. v2: only register NBIO RAS for dGPU platform. change nbio_v7_9_set_ras_controller_irq_state and nbio_v7_9_set_ras_err_event_athub_irq_state to dummy functions. Signed-off-by: Tao Zhou Reviewed-by: Hawking Zhang --- drivers/gpu/drm/am

RE: [PATCH v2] drm/amdgpu: Add FRU sysfs nodes only if needed

2023-08-07 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Monday, August 7, 2023 16:32 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander Subject: [PATCH v2] drm/amdgpu: Add FRU sysfs nodes only if n

Re: [PATCH] drm/buddy: Fix drm buddy info output format

2023-08-07 Thread Arunpravin Paneer Selvam
looks good to me as well. Reviewed-by: Arunpravin Paneer Selvam On 8/7/2023 12:17 PM, Christian König wrote: Am 04.08.23 um 08:56 schrieb Ma Jun: [1] Change pages to blocks to avoid confusion. [2] Fix output format to align the output info. Signed-off-by: Ma Jun Of hand looks good to me,

[PATCH] drm/amd: Use pci_dev_id() to simplify the code

2023-08-07 Thread Xiongfeng Wang
PCI core API pci_dev_id() can be used to get the BDF number for a pci device. We don't need to compose it mannually. Use pci_dev_id() to simplify the code a little bit. Signed-off-by: Xiongfeng Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 8 1 file changed, 4 insertions(+), 4 del

Re: [PATCH] drm/amd: fix debugfs access for discovery blob

2023-08-07 Thread Alex Deucher
On Tue, Aug 1, 2023 at 4:15 PM Mario Limonciello wrote: > > Accessing the blob for amdgpu discovery from debugfs triggers: > > [ 1924.487667] kernel BUG at mm/usercopy.c:102! > > usercopy_abort() explains that it needs to be solved by creating > a cache to store the data. > > Link: https://gitlab.

Re: [PATCH] drm/radeon: Remove the references of radeon_gem_ pread & pwrite ioctls

2023-08-07 Thread Alex Deucher
On Thu, Jul 27, 2023 at 9:48 AM Srinivasan Shanmugam wrote: > > Removing the functions of pread & pwrite & IOCTL defines, as their > existence allows an authorized client to spam the system logs. > > 'Fixes: 6f9e0e87b71f ("drm/radeon: Fix ENOSYS with better fitting error codes > in radeon_gem.c")

Re: [PATCH 3/3] drm/mst: adjust the function drm_dp_remove_payload_part2()

2023-08-07 Thread Imre Deak
On Mon, Aug 07, 2023 at 02:43:02AM +, Lin, Wayne wrote: > [AMD Official Use Only - General] > > > -Original Message- > > From: Imre Deak > > Sent: Friday, August 4, 2023 11:32 PM > > To: Lin, Wayne > > Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; > > ly...@redh

Re: [PATCH 28/29] drm/amdkfd: Refactor migrate init to support partition switch

2023-08-07 Thread Michel Dänzer
On 7/28/23 19:20, Alex Deucher wrote: > On Fri, Jul 28, 2023 at 1:19 PM Michel Dänzer wrote: >> On 7/28/23 18:43, Alex Deucher wrote: >>> On Fri, Jul 28, 2023 at 10:25 AM Michel Dänzer wrote: On 7/28/23 11:30, Michel Dänzer wrote: > On 7/28/23 03:38, Zhang, Jesse(Jie) wrote: >> >

Re: [PATCH] drm/amd/display: Return value of function

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Thu, Aug 3, 2023 at 10:18 AM Denis Arefev wrote: > > Added return value check hpd_enable > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Denis Arefev > --- > drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c | 2 +- > 1 file chan

Re: [PATCH -next v2] drm/amdgpu: Remove a lot of unnecessary ternary operators

2023-08-07 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 3, 2023 at 10:47 PM Ruan Jinjie wrote: > > There are many ternary operators, the true or false judgement > of which is unnecessary in C language semantics. > > Signed-off-by: Ruan Jinjie > --- > v2: > - add the wrong removed true or false judgement hunk code >

Re: [PATCH 2/2] drm/amd/pm: correct the logics for retreiving SMU13 OD setting limits

2023-08-07 Thread Alex Deucher
Series is: Acked-by: Alex Deucher On Wed, Aug 2, 2023 at 9:36 PM Evan Quan wrote: > > To better meet the growing demainds for more OD features. > > Signed-off-by: Evan Quan > --- > .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 70 +-- > .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v11_0.h

2023-08-07 Thread Alex Deucher
Applied with the garbage hunks dropped. Alex On Mon, Jul 31, 2023 at 9:12 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran Sun > --- > d

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0_7_ppt.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 9:26 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: spaces required around that '=' (ctx:VxW) > ERROR: that open brace { should be on the previous line > > Sig

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 9:43 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required before the open parenthesis '(' > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/sws

Re: [PATCH] drm/amd/pm: Clean up errors in aldebaran_ppt.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:01 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: space required after that ',' (ctx:VxV) > ERROR: spaces required around that '=' (ctx:VxW) > ERROR: else shou

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0_6_ppt.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:06 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: code indent should use tabs where possible > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0_5_ppt.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:08 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space prohibited before that ',' (ctx:WxW) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 2 +- > 1 file changed, 1 insert

Re: [PATCH] drm/amd: Clean up errors in smu_v13_0_5_ppt.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:11 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space prohibited before that ',' (ctx:WxW) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/smu_internal.h | 4 ++-- > 1 file changed, 2 insertions(+)

Re: [PATCH] drm/amd/pm: Clean up errors in amdgpu_smu.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:28 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '=' (ctx:WxV) > ERROR: spaces required around that '&&' (ctx:VxW) > ERROR: that open brace { should be on the previous line > ERROR: space

Re: [PATCH] drm/amd/pm: Clean up errors in amd_powerplay.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:37 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: spaces required around that '||' (ctx:WxO) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerp

Re: [PATCH] drm/amd/pm: Clean up errors in vega10_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:45 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: space required after that ',' (ctx:VxV) > ERROR: space prohibited before that ',' (ctx:WxV) > > Signed-off-by

Re: [PATCH] drm/amd/pm: Clean up errors in vega12_hwmgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:57 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: need consistent spacing around '/' (ctx:WxV) > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/

Re: [PATCH] drm/amd/pm/powerplay/hwmgr/ppevvmath: Clean up errors in ppevvmath.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 11:03 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: return is not a function, parentheses are not required > ERROR: space required after that ',' (ctx:VxV) > ERROR: space required before the open parenthesis '(' > ERROR

Re: [PATCH] drm/amd/pm: Clean up errors in smu10_hwmgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 11:09 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '=' (ctx:VxW) > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/pm/powerplay/hwmgr/smu1

Re: [PATCH] drm/amd/pm: Clean up errors in fiji_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 11:16 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > .../drm/amd/pm/powerplay/hwmgr/fiji_baco.c| 24 +++ > 1 file

Re: [PATCH] drm/amd/pm: Clean up errors in vega10_powertune.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 11:38 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: space prohibited after that open parenthesis '(' > > Signed-off-by: Ran Sun > --- > .../amd/pm/powerplay/hw

Re: [PATCH] drm/amd/pm: Clean up errors in vega10_hwmgr.c

2023-08-07 Thread Alex Deucher
This one doesn't apply due to whitespace differences. Alex On Tue, Aug 1, 2023 at 1:58 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing statements should be on next line > ERROR: space required before the open brace '{' > ERROR: space required before the

Re: [PATCH] drm/amd/pm: Clean up errors in vega12_pptable.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 2:04 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: space prohibited before open square bracket '[' > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/pm/powe

Re: [PATCH] drm/amd/pm: Clean up errors in vega12_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 2:09 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_baco.c | 12 > 1 file ch

Re: [PATCH] drm/amdgpu: Clean up errors in smu7_powertune.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 2:15 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/pm/powerplay/hwmgr

Re: [PATCH] drm/amdgpu: Clean up errors in common_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 3:55 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/common_baco.c | 2 +- > 1 file changed, 1 insertio

Re: [PATCH] drm/amdgpu: Clean up errors in smu_helper.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 4:00 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '=' (ctx:VxV) > ERROR: spaces required around that '<' (ctx:VxV) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/

Re: [PATCH] drm/amdgpu: Clean up errors in ppatomctrl.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 4:37 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h | 6 ++ > 1 file changed

Re: [PATCH] drm/amd/pm: Clean up errors in vega10_pptable.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 4:40 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > .../amd/pm/powerplay/hwmgr/vega10_pptable.h| 18 ++ > 1 file

Re: [PATCH] drm/amd: Clean up errors in smu7_hwmgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:00 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: spaces required around that '=' (ctx:VxV) > ERROR: spaces required around that '<' (ctx:VxV) > > Signed-off-by:

Re: [PATCH] drm/amd: Clean up errors in pptable_v1_0.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:02 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/pptable_v1_0.h | 3 +-- > 1 file changed,

Re: [PATCH] drm/amd: Clean up errors in vega10_processpptables.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:19 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: "foo* bar" should be "foo *bar" > ERROR: space required before the open brace '{' > ERROR: space required before the open parenthesis '(' > > Signed-off-by: Ran Sun > -

Re: [PATCH] drm/amdgpu/powerplay: Clean up errors in smu_helper.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:22 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space prohibited before that close parenthesis ')' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.h | 2 +- > 1 file changed, 1 i

Re: [PATCH] drm/amd/pm: Clean up errors in vega20_hwmgr.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:25 AM Quan, Evan wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Evan Quan > > > -Original Message- > > From: amd-gfx On Behalf Of Ran > > Sun > > Sent: Tuesday, August 1, 2023 10:39 AM > > To: Deucher, Alexander ; airl...@gmail.c

Re: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:25 AM Quan, Evan wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Evan Quan > > > -Original Message- > > From: amd-gfx On Behalf Of Ran > > Sun > > Sent: Tuesday, August 1, 2023 4:03 PM > > To: Deucher, Alexander ; airl...@gmail.co

Re: [PATCH] drm/amdgpu/powerplay: Clean up errors in vega20_hwmgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:28 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: code indent should use tabs where possible > ERROR: space required before the open parenthesis '(' > ERROR: space prohibited before that close parenthesis ')' > > Signed

Re: [PATCH] gpu: amd: Clean up errors in ppatomfwctrl.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:30 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.h | 3 +-- > 1 file changed,

Re: [PATCH] drm/amd/pm: Clean up errors in tonga_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:34 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > .../drm/amd/pm/powerplay/hwmgr/tonga_baco.c | 30 +++ > 1 file ch

Re: [PATCH] drm/amd/pm/powerplay/hwmgr/hwmgr: Clean up errors in hwmgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:37 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space prohibited after that '~' (ctx:WxW) > ERROR: spaces required around that '||' (ctx:VxW) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr

Re: [PATCH] drm/amd/pm: Clean up errors in vega12_hwmgr.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:38 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following enum go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.h | 3 +-- > 1 file changed, 1

Re: [PATCH] drm/amd/pm: Clean up errors in vega20_pptable.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:44 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: space prohibited before open square bracket '[' > > Signed-off-by: Ran Sun > --- > .../amd/pm/powerplay/hw

Re: [PATCH] drm/amd/pm: Clean up errors in polaris_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:47 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > .../drm/amd/pm/powerplay/hwmgr/polaris_baco.c | 30 +++ > 1 file ch

Re: [PATCH] drm/amd/pm: Clean up errors in smu9_driver_if.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:51 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space prohibited before open square bracket '[' > > Signed-off-by: Ran Sun > --- > .../drm/amd/pm/powerplay/inc/smu9_driver_if.h | 20 +-- > 1 file cha

Re: [PATCH] drm/amd/pm: Clean up errors in smu71.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:23 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: space prohibited before open square bracket '[' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/

Re: [PATCH] drm/amd/pm: Clean up errors in smu7_fusion.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:29 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: space prohibited before open square bracket '[' > > Signed-off-by: Ran Sun > --- > .../drm/amd/pm/powerpla

Re: [PATCH] drm/amd/pm: Clean up errors in smu7.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:31 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h | 6 ++ > 1 file changed, 2 inse

Re: [PATCH] drm/amd/pm: Clean up errors in pp_thermal.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:38 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/inc/pp_thermal.h | 6 ++ > 1 file changed,

Re: [PATCH] drm/amd/pm: Clean up errors in hardwaremanager.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:39 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/inc/hardwaremanager.h | 3 +-- > 1 file changed

Re: [PATCH] drm/amd/pm: Clean up errors in hwmgr.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:48 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: Use C99 flexible arrays > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h |

Re: [PATCH] drm/amd/pm: Clean up errors in smu73.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:56 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: space prohibited before open square bracket '[' > ERROR: "foo * bar" should be "foo *bar" > > Signed-off-by:

Re: [PATCH] drm/amd/pm: Clean up errors in smu75.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:59 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space prohibited before open square bracket '[' > ERROR: "foo * bar" should be "foo *bar" > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/inc/smu75

Re: [PATCH] drm/amd/pm: Clean up errors in smu8_smumgr.h

2023-08-07 Thread Alex Deucher
Need to be careful with these changes to make sure we aren't changing the size calculations somewhere. Alex On Tue, Aug 1, 2023 at 10:03 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: Use C99 flexible arrays > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/

Re: [PATCH] drivers/amd/pm: Clean up errors in smu8_smumgr.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:10 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: space prohibited before that ',' (ctx:WxW) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/legacy-

Re: [PATCH] drm/amd/pm: Clean up errors in r600_dpm.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:15 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/legacy-dpm/r600_dpm.h | 3 +-- > 1 file changed, 1 insertio

Re: [PATCH] drm/amd/pm: Clean up errors in sislands_smc.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:25 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/pm/legacy-dpm/sislands_smc.h | 63 +++ > 1 file c

Re: [PATCH] drm/amd/pm: Clean up errors in amdgpu_pm.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:31 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: space required before the open parenthesis '(' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/amd

Re: [PATCH] drm/amd/display: Clean up errors in color_gamma.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:40 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing whitespace > ERROR: else should follow close brace '}' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 5 ++--- >

Re: [PATCH] drm/amd/display: Clean up errors in ddc_regs.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:44 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/display/dc/gpio/ddc_regs.h| 40 +-- > 1 file changed, 2

Re: [PATCH] drm/amd/dc: Clean up errors in hpd_regs.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:47 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/dc/gpio/hpd_regs.h | 10 +- > 1 file changed, 5 inserti

Re: [PATCH] drm/amd/display: Clean up errors in dce110_timing_generator.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:52 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '=' (ctx:WxV) > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/display/dc/dce110/dce110_timing_generator.c | 4 ++-- > 1 file changed,

Re: [PATCH] drm/amd/display: Clean up errors in dce110_hw_sequencer.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:53 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required before the open brace '{' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 +- > 1 file changed, 1 in

Re: [PATCH] drm/amd/display: Clean up errors in dce112_hw_sequencer.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:54 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required before the open brace '{' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/dc/dce112/dce112_hw_sequencer.c | 2 +- > 1 file changed, 1 in

Re: [PATCH] drm/amd/display: Clean up errors in dcn315_smu.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:58 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran Sun > --- > .../display/dc/clk_mgr/dcn3

Re: [PATCH] drm/amd/display: Clean up errors in dcn316_clk_mgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 11:01 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c | 6 ++ > 1 fil

Re: [PATCH] drm/amd/display: Clean up errors in dcn316_smu.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 11:03 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran Sun > --- > .../amd/display/dc/clk_mgr/

Re: [PATCH] drm/amd/display: Clean up errors in bios_parser2.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! As a follow up patch, care to drop the break statements after a return? On Tue, Aug 1, 2023 at 11:23 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: switch and case should be at the same indent > ERROR: code indent should use tabs where possibl

Re: [PATCH] drm/amd/display: Clean up errors in dc_stream.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:14 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 3 +-- > 1 file changed, 1 insert

Re: [PATCH] drm/amd/display: Clean up errors in dcn10_dpp_dscl.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:16 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: else should follow close brace '}' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c | 3 +-- > 1 file changed, 1 insertion(+),

Re: [PATCH] drm/amd/display: Clean up errors in display_mode_vba_30.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:20 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: else should follow close brace '}' > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 6 ++ > 1 file changed, 2 inser

Re: [PATCH] drm/amd/display: Clean up errors in dce_clk_mgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:26 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '?' (ctx:VxE) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/dc/dce/dce_clk_mgr.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH] drm/amdgpu: Clean up errors in cik_ih.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:35 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/cik_ih.c | 3 +-- > 1 file changed, 1 insertion(+), 2 de

Re: [PATCH] drm/amdgpu: Clean up errors in vce_v3_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:38 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 9 +++-- > 1 file changed, 3 insertions

Re: [PATCH] drm/amdgpu: Clean up errors in amdgpu_psp.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:40 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: open brace '{' following enum go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/a

Re: [PATCH] drm/amdgpu: Clean up errors in ih_v6_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:43 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing statements should be on next line > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/ih_v

Re: [PATCH] drm/amdgpu: Clean up errors in vega20_ih.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:46 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing statements should be on next line > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/vega

Re: [PATCH] drm/amdgpu: Clean up errors in mmhub_v9_4.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:48 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: code indent should use tabs where possible > ERROR: space required before the open parenthesis '(' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/mmhub_

Re: [PATCH] drm/amdgpu/atomfirmware: Clean up errors in amdgpu_atomfirmware.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:51 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '>=' (ctx:WxV) > ERROR: spaces required around that '!=' (ctx:WxV) > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran

Re: [PATCH] drm/amd: Clean up errors in amdgpu_cgs.c

2023-08-07 Thread Alex Deucher
Already fixed. On Wed, Aug 2, 2023 at 2:55 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: switch and case should be at the same indent > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 64 - > 1 file changed,

Re: [PATCH] drm/amdgpu: Clean up errors in uvd_v7_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:58 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that ':' (ctx:VxE) > that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c |

Re: [PATCH] drm/jpeg: Clean up errors in jpeg_v2_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:00 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH] drm/amdgpu: Clean up errors in dce_v10_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:04 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 30 +- > 1 file ch

Re: [PATCH] drm/amdgpu: Clean up errors in mxgpu_nv.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:06 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: else should follow close brace '}' > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c |

Re: [PATCH] drm/amdgpu/jpeg: Clean up errors in vcn_v1_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:12 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required before the open parenthesis '(' > ERROR: space prohibited after that '~' (ctx:WxW) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/vcn_v1_

Re: [PATCH] drm/amdgpu: Clean up errors in dce_v8_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:18 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: code indent should use tabs where possible > ERROR: space required before the open brace '{' > > Signed-off-by:

Re: [PATCH] drm/amdgpu: Clean up errors in soc21.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:21 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/soc21.c | 30 ++ > 1 file ch

Re: [PATCH] drm/amdgpu: Clean up errors in amdgpu_atombios.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:23 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h | 9 +++-- > 1 file changed, 3

Re: [PATCH] drm/amdgpu: Clean up errors in mes_v11_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:24 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: else should follow close brace '}' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH] drm/amdgpu: Clean up errors in amdgpu_trace.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:26 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required after that ',' (ctx:VxV) > ERROR: "foo* bar" should be "foo *bar" > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 4 ++--

Re: [PATCH] drm/amdgpu: Clean up errors in amdgpu_ring.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:28 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that ':' (ctx:VxW) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH] drm/amdgpu: Clean up errors in amdgpu_virt.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:31 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required before the open parenthesis '(' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +- > 1 file changed, 1 insertion(+), 1

  1   2   >