[PATCH 6.1 066/228] drm/amd/display: fix dc/core/dc.c kernel-doc

2023-08-02 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit db4107e92a817502ad19fdd30250f87dcb6f6331 ] Fix all kernel-doc warnings in dc/core/dc.c: dc.c:385: warning: missing initial short description on line: * dc_stream_adjust_vmin_vmax: dc.c:392: warning: contents before sections dc.c:399: warning: No descriptio

[PATCH] drm/amd: Clean up errors in vega10_processpptables.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: "foo* bar" should be "foo *bar" ERROR: space required before the open brace '{' ERROR: space required before the open parenthesis '(' Signed-off-by: Ran Sun --- .../gpu/drm/amd/pm/powerplay/hwmgr/vega10_processpptables.c | 6 +++--- 1 file

[PATCH] drm/amd/pm: Clean up errors in pp_thermal.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/pp_thermal.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc

[PATCH] drm/amd/pm: Clean up errors in vega20_pptable.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before open square bracket '[' Signed-off-by: Ran Sun --- .../amd/pm/powerplay/hwmgr/vega20_pptable.h | 19 --- 1 file changed, 8 insertions(+),

[PATCH] drm/amd/pm: Clean up errors in vega10_pptable.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- .../amd/pm/powerplay/hwmgr/vega10_pptable.h| 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/po

[PATCH] drm/amd/pm: Clean up errors in smu73.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before open square bracket '[' ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/smu73.h | 45 ---

[PATCH] drm/amd/display: Clean up errors in dcn315_smu.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- .../display/dc/clk_mgr/dcn315/dcn315_smu.c| 26 +-- 1 file changed, 12 insertions(+), 14 d

[PATCH] drm/amd/display: Clean up errors in dce112_hw_sequencer.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: space required before the open brace '{' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/dce112/dce112_hw_sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce11

[PATCH] drm/amd/display: Clean up errors in dce110_timing_generator.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: spaces required around that '=' (ctx:WxV) Signed-off-by: Ran Sun --- .../gpu/drm/amd/display/dc/dce110/dce110_timing_generator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce11

[PATCH] drm/amd/pm: Clean up errors in smu9_driver_if.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: space prohibited before open square bracket '[' Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/inc/smu9_driver_if.h | 20 +-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/power

[PATCH] drm/amd/display: Clean up errors in color_gamma.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: trailing whitespace ERROR: else should follow close brace '}' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/d

[PATCH] drm/amd/display: Clean up errors in dmub_cmd.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: Use C99 flexible arrays Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/a

[PATCH] drm/amd/pm: Clean up errors in sislands_smc.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- .../gpu/drm/amd/pm/legacy-dpm/sislands_smc.h | 63 +++ 1 file changed, 21 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/lega

Re: [PATCH] drm/amd/pm: Clean up errors in smu73_discrete.h

2023-08-02 Thread Bagas Sanjaya
On 01/08/2023 18:34, Jani Nikula wrote: > On Tue, 01 Aug 2023, Bagas Sanjaya wrote: >> And it is unfortunate that you and @208suo.com people doesn't reply to >> review comments (try searching lore.kernel.org) > > Essentially a one-way firehose of patches pointed at our general > direction is not

[PATCH] drm/amd/display: Clean up errors in bios_parser2.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: switch and case should be at the same indent ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- .../drm/amd/display/dc/bios/bios_parser2.c| 32 +-- 1 file changed, 16 insertions(+), 16 deletion

[PATCH] drm/amd/pm/powerplay/hwmgr/hwmgr: Clean up errors in hwmgr.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: space prohibited after that '~' (ctx:WxW) ERROR: spaces required around that '||' (ctx:VxW) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH] drm/amd/display: Clean up errors in ddc_regs.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Ran Sun --- .../gpu/drm/amd/display/dc/gpio/ddc_regs.h| 40 +-- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/gpio/

[PATCH] drm/amd/pm: Clean up errors in smu7.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/smu7.

[PATCH] drm/amdgpu/powerplay: Clean up errors in vega20_hwmgr.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: code indent should use tabs where possible ERROR: space required before the open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Ran Sun --- .../gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c| 12

[PATCH] drm/amd: Clean up errors in amdgpu_cgs.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: switch and case should be at the same indent Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 64 - 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdg

[PATCH] drm/amd/pm: Clean up errors in kv_dpm.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space prohibited before that ',' (ctx:WxW) ERROR: need consistent spacing around '-' (ctx:WxV) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 48 -

[PATCH -next] drm/amd/pm: Remove many unnecessary NULL values

2023-08-02 Thread Ruan Jinjie
Ther are many pointers assigned first, which need not to be initialized, so remove the NULL assignment. Signed-off-by: Ruan Jinjie --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c | 2 +- drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 2 +- drivers/gpu/drm/amd/pm/powerpla

[PATCH] drm/amdgpu/atomfirmware: Clean up errors in amdgpu_atomfirmware.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: spaces required around that '>=' (ctx:WxV) ERROR: spaces required around that '!=' (ctx:WxV) ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 8 1 file

[PATCH] drm/amd/display: Clean up errors in dcn316_smu.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- .../amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 18 -- 1 file changed, 8 insertions(+), 10 de

[PATCH] drm/amd: Clean up errors in processpptables.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following function definitions go on the next line ERROR: code indent should use tabs where possible ERROR: space required before the open parenthesis '(' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/pro

[PATCH] drm/amd: Clean up errors in pptable_v1_0.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/pptable_v1_0.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwm

[PATCH] drm/amdgpu: Clean up errors in ppatomctrl.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/h

[PATCH] drm/amd/pm: Clean up errors in amdgpu_pm.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space required before the open parenthesis '(' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/d

[PATCH] drm/amdgpu: Clean up errors in amdgpu_psp.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: open brace '{' following enum go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 12 1 file changed, 4 insertions(+), 8 deletions

[PATCH] drm/amd/display: Clean up errors in dce110_hw_sequencer.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: space required before the open brace '{' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce11

[PATCH] drm/amd/dc: Clean up errors in hpd_regs.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/gpio/hpd_regs.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hpd_regs.h

[PATCH] drm/amdgpu: Clean up errors in vce_v3_0.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers

[PATCH] drm/amd/display: Clean up errors in dce_clk_mgr.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: spaces required around that '?' (ctx:VxE) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/dce/dce_clk_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clk_mgr.c b/d

[PATCH] drm/amdgpu: Clean up errors in ih_v6_0.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: trailing statements should be on next line ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dr

[PATCH] drm/amdgpu: Clean up errors in mmhub_v9_4.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: code indent should use tabs where possible ERROR: space required before the open parenthesis '(' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH] drm/amd/pm: Clean up errors in smu8_smumgr.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: Use C99 flexible arrays Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/smumgr/smu8_smumgr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/smu8_smumgr.h b/drivers/g

[PATCH] gpu: amd: Clean up errors in ppatomfwctrl.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwm

[PATCH] drm/amd/pm: Clean up errors in smu75.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: space prohibited before open square bracket '[' ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/smu75.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in vega12_hwmgr.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following enum go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr

[PATCH] drm/amd/pm: Clean up errors in polaris_baco.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/hwmgr/polaris_baco.c | 30 +++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powe

[PATCH] drm/amd/pm: Clean up errors in tonga_baco.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/hwmgr/tonga_baco.c | 30 +++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powe

[PATCH] drm/amd/pm: Clean up errors in smu73_discrete.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: trailing whitespace ERROR: space prohibited before open square bracket '[' Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/inc/smu73_discrete.h | 73 --- 1 file

[PATCH] drm/amd/pm: Clean up errors in hwmgr.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: Use C99 flexible arrays Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/

[PATCH] drm/amd/pm: Clean up errors in smu71.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before open square bracket '[' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/smu71.h | 22 +++- 1 file changed, 8 insertions(+),

[PATCH] drm/amdgpu: Clean up errors in dce_v10_0.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 30 +- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/

[PATCH] drm/amd/pm: Clean up errors in hardwaremanager.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/hardwaremanager.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/in

[PATCH] drm/amdgpu: Clean up errors in vega20_ih.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: trailing statements should be on next line ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

[PATCH] drm/amdgpu: Clean up errors in mxgpu_nv.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: else should follow close brace '}' ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/g

Re: [PATCH] drm/amd/pm: Clean up errors in smu73_discrete.h

2023-08-02 Thread Bagas Sanjaya
On Tue, Aug 01, 2023 at 10:00:24AM +, Ran Sun wrote: > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: trailing whitespace > ERROR: space prohibited before open square bracket '[' > Thanks for fixing up your tooling to

[PATCH] drm/amdgpu: Clean up errors in uvd_v7_0.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: spaces required around that ':' (ctx:VxE) that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH] drm/amd: Clean up errors in smu7_hwmgr.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that '<' (ctx:VxV) Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 26 +-

[PATCH] drivers/amd/pm: Clean up errors in smu8_smumgr.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 48 -- 1 file changed, 17 insertions(+), 31 dele

[PATCH] drm/amd/pm: Clean up errors in r600_dpm.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/legacy-dpm/r600_dpm.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/r600_dpm.h b/

[PATCH] drm/amd/display: Clean up errors in display_mode_vba_30.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: else should follow close brace '}' Signed-off-by: Ran Sun --- .../gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/di

[PATCH] drm/amd/pm: Clean up errors in smu7_fusion.h

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before open square bracket '[' Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/inc/smu7_fusion.h| 42 +++ 1 file changed, 16 insertions(+),

[PATCH] drm/amdgpu/jpeg: Clean up errors in vcn_v1_0.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: space required before the open parenthesis '(' ERROR: space prohibited after that '~' (ctx:WxW) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/d

[PATCH] drm/amd/display: Clean up errors in dc_stream.c

2023-08-02 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-08-02 Thread Marek Olšák
A screen that doesn't update isn't usable. Killing the window system and returning to the login screen is one option. Killing the window system manually from a terminal or over ssh and then returning to the login screen is another option, but 99% of users either hard-reset the machine or do sysrq+R

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-08-02 Thread Michel Dänzer
On 8/2/23 09:38, Marek Olšák wrote: > > The precedent from the CPU land is pretty strong here. There is > SIGSEGV for invalid CPU memory access and SIGILL for invalid CPU > instructions, yet we do nothing for invalid GPU memory access and > invalid GPU instructions. Sending a terminating signal fr

Re: [PATCH 2/4] drm/bridge-connector: handle subconnector types

2023-08-02 Thread Neil Armstrong
On 29/07/2023 02:49, Dmitry Baryshkov wrote: If the created connector type supports subconnector type property, create and attach corresponding it. The default subtype value is 0, which maps to the DRM_MODE_SUBCONNECTOR_Unknown type. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_bri

Re: [PATCH] drm/amd/pm: Clean up errors in smu73_discrete.h

2023-08-02 Thread Jani Nikula
On Wed, 02 Aug 2023, Bagas Sanjaya wrote: > On 01/08/2023 18:34, Jani Nikula wrote: >> On Tue, 01 Aug 2023, Bagas Sanjaya wrote: >>> And it is unfortunate that you and @208suo.com people doesn't reply to >>> review comments (try searching lore.kernel.org) >> >> Essentially a one-way firehose of

Re: [PATCH] drm/amdgpu: Always emit GDS switch when GDS/GWS/OA is used

2023-08-02 Thread Friedrich Vock
Gentle ping. Any updates on this yet? Thanks, Friedrich On 20.07.23 23:25, Friedrich Vock wrote: Hi, On 07.07.23 10:21, Christian König wrote: Am 07.07.23 um 09:28 schrieb Friedrich Vock: Hi Christian, On 07.07.23 08:56, Christian König wrote: Am 07.07.23 um 08:28 schrieb Friedrich Vock:

Re: [PATCH v5 6/6] drm/doc: Define KMS atomic state set

2023-08-02 Thread Daniel Vetter
On Mon, 31 Jul 2023 at 04:01, André Almeida wrote: > > Em 13/07/2023 04:51, Pekka Paalanen escreveu: > > On Tue, 11 Jul 2023 10:57:57 +0200 > > Daniel Vetter wrote: > > > >> On Fri, Jul 07, 2023 at 07:40:59PM -0300, André Almeida wrote: > >>> From: Pekka Paalanen > >>> > >>> Specify how the atom

Re: [PATCH] drm/amd/display: check attr flag before set cursor degamma on DCN3+

2023-08-02 Thread Harry Wentland
Thanks. Change is merged to amd-staging-drm-next. Harry On 2023-08-01 00:07, Alex Hung wrote: > Tested-by: Alex Hung > > On 2023-07-31 02:35, Melissa Wen wrote: >> Don't set predefined degamma curve to cursor plane if the cursor >> attribute flag is not set. Applying a degamma curve to the curs

Re: [PATCH] drm/amd/display: Clean up errors in dmub_cmd.h

2023-08-02 Thread kernel test robot
Hi Ran, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.5-rc4 next-20230802] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH 2/4] drm/bridge-connector: handle subconnector types

2023-08-02 Thread Laurent Pinchart
On Wed, Aug 02, 2023 at 12:05:50PM +0300, Dmitry Baryshkov wrote: > On Wed, 2 Aug 2023 at 11:35, Neil Armstrong wrote: > > On 29/07/2023 02:49, Dmitry Baryshkov wrote: > > > If the created connector type supports subconnector type property, > > > create and attach corresponding it. The default subt

Re: [PATCH 1/4] drm: allow specifying default subtype for the DP subconnector property

2023-08-02 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Sat, Jul 29, 2023 at 03:49:10AM +0300, Dmitry Baryshkov wrote: > In the embedded usecases the default subtype depends on the bridge > chain, so it is easier to specify the subtype at the proprety attachment s/proprety/property/ > type rather than specifyin

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-02 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshkov wrote: > To properly define the USB-C DP altmode connectors, add the USB > subconnector type. > > Suggested-by: Simon Ser > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/drm_connector.c |

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-02 Thread Laurent Pinchart
On Wed, Aug 02, 2023 at 10:01:19PM +0300, Dmitry Baryshkov wrote: > On 02/08/2023 21:55, Laurent Pinchart wrote: > > Hi Dmitry, > > > > Thank you for the patch. > > > > On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshkov wrote: > >> To properly define the USB-C DP altmode connectors, add t

Re: [PATCH 1/3] drm/amdkfd: Sync trap handler binaries with source

2023-08-02 Thread Felix Kuehling
On 2023-07-31 16:40, Jay Cornwall wrote: Some changes have been lost during rebases. Rebuild sources. Signed-off-by: Jay Cornwall The series is Reviewed-by: Felix Kuehling --- .../gpu/drm/amd/amdkfd/cwsr_trap_handler.h| 741 +- 1 file changed, 371 insertions(+), 37

[PATCH 1/2] drm/amd/pm: correct the way for checking custom OD settings

2023-08-02 Thread Evan Quan
`FeatureCtrlMask` should not be included in those settings interested. Signed-off-by: Evan Quan --- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 16 .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 16 2 files changed, 16 insertions(+), 16 deletions(-)

[PATCH 2/2] drm/amd/pm: correct the logics for retreiving SMU13 OD setting limits

2023-08-02 Thread Evan Quan
To better meet the growing demainds for more OD features. Signed-off-by: Evan Quan --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 70 +-- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 70 +-- 2 files changed, 64 insertions(+), 76 deletions(-) diff --git a/

Re: [PATCH] drm/amdgpu: Remove volatile from 'wb' & from 'ptr' in amdgpu.h

2023-08-02 Thread SHANMUGAM, SRINIVASAN
On 7/24/2023 10:43 PM, Alex Deucher wrote: On Mon, Jul 24, 2023 at 11:54 AM Srinivasan Shanmugam wrote: Fixes the following from checkpatch.pl: WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst + volatile uint32_t *wb; WARNING:

RE: [PATCH] drm/amd/pm: Fix SMU v13.0.6 energy reporting

2023-08-02 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Wednesday, August 2, 2023 12:56 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kasiviswanathan, Harish Subject: [PATCH] drm/amd/pm: F

RE: [PATCH] drm/amdgpu: Report vbios version instead of PN

2023-08-02 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Wednesday, August 2, 2023 13:14 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander Subject: [PATCH] drm/amdgpu: Report vbios version instead