Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Christian König
Well first of all don't expose the VMID to userspace. The UMD doesn't know (and shouldn't know) which VMID is used for a submission since this is dynamically assigned and can change at any time. For debugging there is an interface to use an reserved VMID for your debugged process which allows

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Christian König
Am 02.05.23 um 03:26 schrieb André Almeida: Em 01/05/2023 16:24, Alex Deucher escreveu: On Mon, May 1, 2023 at 2:58 PM André Almeida wrote: I know that devcoredump is also used for this kind of information, but I believe that using an IOCTL is better for interfacing Mesa + Linux rather than

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Bas Nieuwenhuizen
On Tue, May 2, 2023 at 11:12 AM Timur Kristóf wrote: > > Hi Christian, > > Christian König ezt írta (időpont: 2023. máj. 2., > Ke 9:59): >> >> Am 02.05.23 um 03:26 schrieb André Almeida: >> > Em 01/05/2023 16:24, Alex Deucher escreveu: >> >> On Mon, May 1, 2023 at 2:58 PM André Almeida >> >> wr

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Christian König
Hi Timur, Am 02.05.23 um 11:12 schrieb Timur Kristóf: Hi Christian, Christian König ezt írta (időpont: 2023. máj. 2., Ke 9:59): Am 02.05.23 um 03:26 schrieb André Almeida: > Em 01/05/2023 16:24, Alex Deucher escreveu: >> On Mon, May 1, 2023 at 2:58 PM André Almeida >> w

Re: [PATCH] drm/amd/display: mark amdgpu_dm_connector_funcs_force static

2023-05-02 Thread Hamza Mahfooz
On 5/1/23 10:31, Arnd Bergmann wrote: From: Arnd Bergmann A global function without a header prototype has made it into linux-next during the merge window: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6339:6: error: no previous prototype for 'amdgpu_dm_connector_funcs_force' [

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Linux regression tracking (Thorsten Leemhuis)
[CCing the regression list, as it should be in the loop for regressions: https://docs.kernel.org/admin-guide/reporting-regressions.html] [TLDR: I'm adding this report to the list of tracked Linux kernel regressions; the text you find below is based on a few templates paragraphs you might have enco

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Timur Kristóf
Hi Christian, Christian König ezt írta (időpont: 2023. máj. 2., Ke 9:59): > Am 02.05.23 um 03:26 schrieb André Almeida: > > Em 01/05/2023 16:24, Alex Deucher escreveu: > >> On Mon, May 1, 2023 at 2:58 PM André Almeida > >> wrote: > >>> > >>> I know that devcoredump is also used for this kind of

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Alex Deucher
On Tue, May 2, 2023 at 7:45 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > [CCing the regression list, as it should be in the loop for regressions: > https://docs.kernel.org/admin-guide/reporting-regressions.html] > > [TLDR: I'm adding this report to the list of tracked Linux kernel >

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Alex Deucher
On Tue, May 2, 2023 at 9:34 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > On 02.05.23 15:13, Alex Deucher wrote: > > On Tue, May 2, 2023 at 7:45 AM Linux regression tracking (Thorsten > > Leemhuis) wrote: > > > >> On 30.04.23 13:44, Felix Richter wrote: > >>> Hi, > >>> > >>> I am ru

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Linux regression tracking (Thorsten Leemhuis)
On 02.05.23 15:13, Alex Deucher wrote: > On Tue, May 2, 2023 at 7:45 AM Linux regression tracking (Thorsten > Leemhuis) wrote: > >> On 30.04.23 13:44, Felix Richter wrote: >>> Hi, >>> >>> I am running into an issue with the integrated GPU of the Ryzen 9 7950X. It >>> seems to be a regression from

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Timur Kristóf
Hi, On Tue, 2023-05-02 at 13:14 +0200, Christian König wrote: > > > > Christian König ezt írta (időpont: 2023. > > máj. 2., Ke 9:59): > >   > > > Am 02.05.23 um 03:26 schrieb André Almeida: > > >  > Em 01/05/2023 16:24, Alex Deucher escreveu: > > >  >> On Mon, May 1, 2023 at 2:58 PM André Almeid

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Alex Deucher
On Tue, May 2, 2023 at 9:35 AM Timur Kristóf wrote: > > Hi, > > On Tue, 2023-05-02 at 13:14 +0200, Christian König wrote: > > > > > > Christian König ezt írta (időpont: 2023. > > > máj. 2., Ke 9:59): > > > > > > > Am 02.05.23 um 03:26 schrieb André Almeida: > > > > > Em 01/05/2023 16:24, Alex De

Re: [PATCH] drm/amdgpu: set gfx9 onwards APU atomics support to be true

2023-05-02 Thread Lang Yu
On 04/30/ , Yifan Zhang wrote: > APUs w/ gfx9 onwards doesn't reply on PCIe atomics, rather > it is internal path w/ native atomic support. Set have_atomics_support > to true. > > Signed-off-by: Yifan Zhang Reviewed-by: Lang Yu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++ >

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Felix Richter
On 5/2/23 15:34, Linux regression tracking (Thorsten Leemhuis) wrote: On 02.05.23 15:13, Alex Deucher wrote: On Tue, May 2, 2023 at 7:45 AM Linux regression tracking (Thorsten Leemhuis) wrote: On 30.04.23 13:44, Felix Richter wrote: Hi, I am running into an issue with the integrated GPU of

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Linux regression tracking (Thorsten Leemhuis)
On 02.05.23 15:48, Felix Richter wrote: > On 5/2/23 15:34, Linux regression tracking (Thorsten Leemhuis) wrote: >> On 02.05.23 15:13, Alex Deucher wrote: >>> On Tue, May 2, 2023 at 7:45 AM Linux regression tracking (Thorsten >>> Leemhuis) wrote: >>> On 30.04.23 13:44, Felix Richter wrote: >>>

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Timur Kristóf
On Tue, 2023-05-02 at 09:45 -0400, Alex Deucher wrote: > On Tue, May 2, 2023 at 9:35 AM Timur Kristóf > wrote: > > > > Hi, > > > > On Tue, 2023-05-02 at 13:14 +0200, Christian König wrote: > > > > > > > > Christian König ezt írta (időpont: > > > > 2023. > > > > máj. 2., Ke 9:59): > > > > > >

[PATCH] drm/amdgpu: fix an amdgpu_irq_put() issue in gmc_v9_0_hw_fini()

2023-05-02 Thread Hamza Mahfooz
As made mention of, in commit 9128e6babf10 ("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v10_0_hw_fini") and commit c094b8923bdd ("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v11_0_hw_fini"). It is meaningless to call amdgpu_irq_put() for gmc.ecc_irq. So, remove it from gmc_v9_0_hw_fini()

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Alex Deucher
On Tue, May 2, 2023 at 11:22 AM Timur Kristóf wrote: > > On Tue, 2023-05-02 at 09:45 -0400, Alex Deucher wrote: > > On Tue, May 2, 2023 at 9:35 AM Timur Kristóf > > wrote: > > > > > > Hi, > > > > > > On Tue, 2023-05-02 at 13:14 +0200, Christian König wrote: > > > > > > > > > > Christian König ez

[PATCH 0/8] DC Patches May 02, 2023

2023-05-02 Thread Alex Hung
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Block SubVP on displays that have pixclk > 1800Mhz * Block SubVP high refresh when VRR active fixed * Enforce 60us prefetch for 200Mhz DCFCLK modes * Check Vactive for VRR active for FPO + Vactive * Add symclk wor

[PATCH 1/8] drm/amd/display: Add additional pstate registers to HW state query

2023-05-02 Thread Alex Hung
From: Sung Lee [WHY] These registers would be useful to know when debugging pstate issues. [HOW] Add additional registers to hw state query. Reviewed-by: Aric Cyr Reviewed-by: Jun Lei Acked-by: Alex Hung Signed-off-by: Sung Lee --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.h | 2 ++

[PATCH 2/8] drm/amd/display: Show the DCN/DCE version in the log

2023-05-02 Thread Alex Hung
From: Rodrigo Siqueira Some times people send their dmesg log for debugging, and one common task is to check the modesetting line to catch which DCN/DCE we need to debug. This commit introduces a simple conversion from the DCN/DCE version to a string shown in the dmesg log. Reviewed-by: Hamza Ma

[PATCH 3/8] drm/amd/display: Add symclk workaround during disable link output

2023-05-02 Thread Alex Hung
From: Leo Chen [Why & How] This is originally a change (9c75891f) in DCN32 because of the lack of interface to set TX while keeping symclk on. Adding this workaround to DCN314 will resolve the current issue. Fixes: 9c75891feef0 ("drm/amd/display: rework recent update PHY state commit") Reviewed-

[PATCH 4/8] drm/amd/display: Check Vactive for VRR active for FPO + Vactive

2023-05-02 Thread Alex Hung
From: Alvin Lee [Description] - For FPO + Vactive cases, we rely on the Vactive display to be at it's nominal refresh rate because the Vactive pipe may not necessarily assert P-State allow while it's in VBLANK - For cases where the Vactive display has a stretched VBLANK due to VRR, we could

[PATCH 5/8] drm/amd/display: Enforce 60us prefetch for 200Mhz DCFCLK modes

2023-05-02 Thread Alex Hung
From: Alvin Lee [Description] - Due to bandwidth / arbitration issues at 200Mhz DCFCLK, we want to enforce minimum 60us of prefetch to avoid intermittent underflow issues - Since 60us prefetch is already enforced for UCLK DPM0, and many DCFCLK's > 200Mhz are mapped to UCLK DPM1, in theory

[PATCH 6/8] drm/amd/display: Block SubVP high refresh when VRR active fixed

2023-05-02 Thread Alex Hung
From: Alvin Lee [Description] - SubVP high refresh is blocked when VRR is active variable, but we should also block it for when VRR is active fixed (video use case) Reviewed-by: Nevenko Stupar Reviewed-by: Jun Lei Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Acked-by

[PATCH 7/8] drm/amd/display: Block SubVP on displays that have pixclk > 1800Mhz

2023-05-02 Thread Alex Hung
From: Alvin Lee [Description] - Enabling SubVP on high refresh rate displays had a side effect of also enabling on high bandwidth displays such as 8K60 - However, these are not validated and should be blocked for the time being - Block SubVP on displays that have pix rate > 1800Mhz (includes

[PATCH 8/8] drm/amd/display: Promote DAL to 3.2.235

2023-05-02 Thread Alex Hung
From: Aric Cyr This version brings along following fixes: - Block SubVP on displays that have pixclk > 1800Mhz - Block SubVP high refresh when VRR active fixed - Enforce 60us prefetch for 200Mhz DCFCLK modes - Check Vactive for VRR active for FPO + Vactive - Add symclk workaround during disable l