On Wed, Mar 29, 2023 at 9:23 PM Mario Limonciello
wrote:
>
>
> On 3/29/23 04:59, Kai-Heng Feng wrote:
> > When the power is lost due to ACPI power resources being turned off, the
> > driver should reset the GPU so it can work anew.
> >
> > First, _PR3 support of the hierarchy needs to be found cor
Hello Pierre-Eric,
Thanks for your review, my comments inline.
On 30/03/2023 10:02, Pierre-Eric Pelloux-Prayer wrote:
Hi Shashank,
On 29/03/2023 18:04, Shashank Sharma wrote:
From: Alex Deucher
This patch intorduces new UAPI/IOCTL for usermode graphics
queue. The userspace app will fill th
This DC patchset brings improvements in multiple areas. In summary, we
highlight:
- FW Release 0.0.161.0
- Improvements on FPO/FAMS
- Correction to DML calculation
- Fix to multiple clock related issues
Cc: Daniel Wheeler
---
Alvin Lee (3):
drm/amd/display: Clear FAMS flag if FAMS doesn't re
From: Alvin Lee
[Description]
- If we find that applying FAMS doesn't reduce the voltage level,
we will not use it
- Ensure to clear the stream flags indicating FAMS if we hit this
case
Reviewed-by: Jun Lei
Acked-by: Qingqing Zhuo
Signed-off-by: Alvin Lee
---
drivers/gpu/drm/amd/display/
From: Zhikai Zhai
[WHY]
It will introduce the extra warnning log on some asic
that doesn't register
[HOW]
Add the register on dcn32
Reviewed-by: Dmytro Laktyushkin
Acked-by: Qingqing Zhuo
Signed-off-by: Zhikai Zhai
---
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.h | 1 +
1 file chan
From: Hamza Mahfooz
To enable root clock optimizations, we need a number of
register writes and need to account for the difference
in DPSTREAMCLK between DCN31 and DCN314. To prevent
issues, add a number of register writes to
DCCG_MASK_SH_LIST_DCN314_COMMON(), and define dccg314_init()
which is m
[AMD Official Use Only - General]
Hi, Luben
Thanks for the review. Please see inline.
Best Regards,
Alan
-Original Message-
From: Tuikov, Luben
Sent: Tuesday, March 28, 2023 3:00 AM
To: Liu, HaoPing (Alan) ; amd-gfx@lists.freedesktop.org
Cc: Lakha, Bhawanpreet
Subject: Re: [PA
From: Alvin Lee
[Description]
- When determining FPO support, include FPO + VActive support
- Support FPO + VActive if one display meets regular requirements
for FPO and the second display is able to switch in VACTIVE with
a given amount of margin
Reviewed-by: Jun Lei
Acked-by: Qingqing Zhu
From: Paul Hsieh
[Why]
In 2560x1600@240p eDP panel, driver use lowest voltage level
to play 1080p video cause underflow. According to HW SPEC,
the senario should use high voltage level.
[How]
ChromaPre value is zero when bandwidth validation.
Correct ChromaPre calculation.
Reviewed-by: Nicholas
From: Alvin Lee
[Description]
- On init if a display is connected, we need to maintain the DISPCLK
frequency
- Even though DPG_EN=1, the display still requires the correct
timing or it could cause audio corruption (if DISPCLK freq
is reduced)
- Read the current DISPCLK freq and request the
From: Charlene Liu
[why]
based on dscclk instance offset check conditiona program dscclk
Reviewed-by: Nicholas Kazlauskas
Acked-by: Qingqing Zhuo
Signed-off-by: Charlene Liu
---
.../gpu/drm/amd/display/dc/dcn20/dcn20_dccg.h | 8
.../gpu/drm/amd/display/dc/dcn31/dcn31_dccg.c | 18
From: Michael Strauss
[WHY]
New sequence for transparent mode DP1.x link training was provided by LTTPR
vendor
[HOW]
Implement new FIXED_VS sequence, increase LT retry count to minimize
any potential intermittent lightup failures
Reviewed-by: Jun Lei
Acked-by: Qingqing Zhuo
Signed-off-by: Mic
From: Anthony Koo
- Add command to idle opt.
- Rename d3 entry event and add idle trigger param on
notify event.
- Add bit to fw boot status to notify status when hardware
is powered up.
Reviewed-by: Aric Cyr
Acked-by: Qingqing Zhuo
Signed-off-by: Anthony Koo
---
.../gpu/drm/amd/dis
From: Aric Cyr
This DC version brings along:
- FW Release 0.0.161.0
- Improvements on FPO/FAMS
- Correction to DML calculation
- Fix to multiple clock related issues
Acked-by: Qingqing Zhuo
Signed-off-by: Aric Cyr
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+),
[AMD Official Use Only - General]
Hi Christian,
Thanks for the review. Please see inline.
Best Regards,
Alan
-Original Message-
From: Christian König
Sent: Tuesday, March 28, 2023 7:16 PM
To: Liu, HaoPing (Alan) ; amd-gfx@lists.freedesktop.org
Cc: Lakha, Bhawanpreet
Subject: R
Am 30.03.23 um 10:15 schrieb Shashank Sharma:
Hello Pierre-Eric,
[SNIP]
I'm also wondering why the doorbell needs a handle+offset but
other buffers are passed in as virtual addresses?
As you know, doorbell offset here will be an relative offset in this
doorbell page, but the MQD needs the abso
Am 30.03.23 um 11:15 schrieb Liu, HaoPing (Alan):
[AMD Official Use Only - General]
Hi Christian,
Thanks for the review. Please see inline.
Best Regards,
Alan
-Original Message-
From: Christian König
Sent: Tuesday, March 28, 2023 7:16 PM
To: Liu, HaoPing (Alan) ;
amd-gfx@lists.fre
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shashank Sharma
Rename doorbell.num_doorbells to doorbell.num_kernel_doorbells to
make it more readable.
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: Shashank Sharma
Acked-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/a
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shashank Sharma
This patch adds double include protection for doorbell.h
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: Shashank Sharma
Reviewed-by: Christian König
I suggest to get this pushed to amd-staging-drm-next ASAP togeth
Hey Christian,
On 30/03/2023 13:05, Christian König wrote:
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shashank Sharma
This patch adds double include protection for doorbell.h
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: Shashank Sharma
Reviewed-by: Christian König
I s
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shashank Sharma
This patch:
- creates a new file for doorbell management.
- moves doorbell code from amdgpu_device.c to this file.
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: Shashank Sharma
---
drivers/gpu/drm/amd/amdgpu/Makefi
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shashank Sharma
This patch removes the check and change in num_kernel_doorbells
for MES, which is not being used anywhere by MES code.
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: Shashank Sharma
Reviewed-by: Christian König
-
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Alex Deucher
This patch adds flags for a new gem domain AMDGPU_GEM_DOMAIN_DOORBELL
in the UAPI layer.
V2: Drop 'memory' from description (Christian)
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: Alex Deucher
Reviewed-by: Christia
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Alex Deucher
This patch adds changes:
- to accommodate the new GEM domain DOORBELL
- to accommodate the new TTM PL DOORBELL
in order to manage doorbell pages as GEM object.
V2: Addressed reviwe comments from Christian
- drop the doorbel
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shashank Sharma
This patch initialzes the ttm resource manager for doorbells.
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: Shashank Sharma
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shashank Sharma
This patch adds helper functions to create and free doorbell
pages for kernel objects.
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: Shashank Sharma
---
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h | 41 ++
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shashank Sharma
This patch:
- creates a doorbell page for graphics driver usages.
- removes the adev->doorbell.ptr variable, replaces it with
kernel-doorbell-bo's cpu address.
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: Shash
On 30/03/2023 13:29, Christian König wrote:
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shashank Sharma
This patch adds helper functions to create and free doorbell
pages for kernel objects.
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: Shashank Sharma
---
drivers/gpu/dr
On 30/03/2023 13:30, Christian König wrote:
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shashank Sharma
This patch:
- creates a doorbell page for graphics driver usages.
- removes the adev->doorbell.ptr variable, replaces it with
kernel-doorbell-bo's cpu address.
Cc: Alex Deuch
Hi Alan,
I'll comment in the other thread, as it seems Christian commented directly to
your
patch the day after my comment, rather than following up with my email sent the
previous
day and we now have two divergent threads where you post two identical
comments, and it shouldn't
be like that--we
[AMD Official Use Only - General]
Please add a Fixes tag:
Fixes: 2bedd3f21b30 drm/amdgpu: skip ASIC reset for APUs when go to S4
in your patch.
-Original Message-
From: Huang, Tim
Sent: Thursday, March 30, 2023 10:33 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Limon
[AMD Official Use Only - General]
Also in commit message move the issue into Link tag.
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2483
> -Original Message-
> From: Zhang, Yifan
> Sent: Thursday, March 30, 2023 07:29
> To: Huang, Tim ; amd-gfx@lists.freedesktop.org
> Cc: Deuch
Hi Alan,
Inline:
On 2023-03-30 06:48, Christian König wrote:
> Am 30.03.23 um 11:15 schrieb Liu, HaoPing (Alan):
>>
>> [AMD Official Use Only - General]
>>
>>
>>
>> Hi Christian,
>>
>>
>>
>> Thanks for the review. Please see inline.
>>
>>
>>
>> Best Regards,
>>
>> Alan
>>
>>
>>
>> -Or
On Thu, Mar 30, 2023 at 6:48 AM Christian König
wrote:
>
> Am 30.03.23 um 11:15 schrieb Liu, HaoPing (Alan):
>
> [AMD Official Use Only - General]
>
>
>
> Hi Christian,
>
>
>
> Thanks for the review. Please see inline.
>
>
>
> Best Regards,
>
> Alan
>
>
>
> -Original Message-
> From: Chris
Hi Shashank,
Inline:
On 2023-03-29 11:47, Shashank Sharma wrote:
> From: Shashank Sharma
>
> Rename doorbell.num_doorbells to doorbell.num_kernel_doorbells to
> make it more readable.
>
> Cc: Alex Deucher
> Cc: Christian Koenig
> Signed-off-by: Shashank Sharma
> ---
> drivers/gpu/drm/amd/a
Hello Luben,
Thanks for the review, comments inline.
On 30/03/2023 15:11, Luben Tuikov wrote:
Hi Shashank,
Inline:
On 2023-03-29 11:47, Shashank Sharma wrote:
From: Shashank Sharma
Rename doorbell.num_doorbells to doorbell.num_kernel_doorbells to
make it more readable.
Cc: Alex Deucher
On Wed, Mar 29, 2023 at 11:36 PM Kai-Heng Feng
wrote:
>
> On Wed, Mar 29, 2023 at 9:23 PM Mario Limonciello
> wrote:
> >
> >
> > On 3/29/23 04:59, Kai-Heng Feng wrote:
> > > When the power is lost due to ACPI power resources being turned off, the
> > > driver should reset the GPU so it can work a
Hi Shashank,
Inline:
On 2023-03-30 07:09, Christian König wrote:
> Am 29.03.23 um 17:47 schrieb Shashank Sharma:
>> From: Shashank Sharma
>>
>> This patch:
>> - creates a new file for doorbell management.
>> - moves doorbell code from amdgpu_device.c to this file.
>>
>> Cc: Alex Deucher
>> Cc:
On 2023-03-30 07:14, Christian König wrote:
> Am 29.03.23 um 17:47 schrieb Shashank Sharma:
>> From: Alex Deucher
>>
>> This patch adds changes:
>> - to accommodate the new GEM domain DOORBELL
>> - to accommodate the new TTM PL DOORBELL
>>
>> in order to manage doorbell pages as GEM object.
>>
>>
On 30/03/2023 15:29, Luben Tuikov wrote:
Hi Shashank,
Inline:
On 2023-03-30 07:09, Christian König wrote:
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shashank Sharma
This patch:
- creates a new file for doorbell management.
- moves doorbell code from amdgpu_device.c to this file.
On 2023-03-29 11:47, Shashank Sharma wrote:
> From: Shashank Sharma
>
> This patch adds helper functions to create and free doorbell
> pages for kernel objects.
>
> Cc: Alex Deucher
> Cc: Christian Koenig
> Signed-off-by: Shashank Sharma
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h
On 30/03/2023 15:33, Luben Tuikov wrote:
On 2023-03-30 07:14, Christian König wrote:
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Alex Deucher
This patch adds changes:
- to accommodate the new GEM domain DOORBELL
- to accommodate the new TTM PL DOORBELL
in order to manage doorbell p
On 2023-03-30 09:42, Luben Tuikov wrote:
> On 2023-03-29 11:47, Shashank Sharma wrote:
>> From: Shashank Sharma
>>
>> This patch adds helper functions to create and free doorbell
>> pages for kernel objects.
>>
>> Cc: Alex Deucher
>> Cc: Christian Koenig
>> Signed-off-by: Shashank Sharma
>> ---
On 2023-03-30 09:43, Shashank Sharma wrote:
>
> On 30/03/2023 15:33, Luben Tuikov wrote:
>> On 2023-03-30 07:14, Christian König wrote:
>>> Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Alex Deucher
This patch adds changes:
- to accommodate the new GEM domain DOORBELL
>>
On 30/03/2023 15:45, Luben Tuikov wrote:
On 2023-03-30 09:43, Shashank Sharma wrote:
On 30/03/2023 15:33, Luben Tuikov wrote:
On 2023-03-30 07:14, Christian König wrote:
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Alex Deucher
This patch adds changes:
- to accommodate the new GEM
As I'm reviewing this, it is obvious that this patchset hasn't gone
though scripts/checkpatch.pl.
It's good practice to run one's patches through scripts/checkpatch.pl,
to see deviations on common Linux practices, and correct them.
Regards,
Luben
On 2023-03-29 11:47, Shashank Sharma wrote:
> The
[AMD Official Use Only - General]
Hey Luben,
Agree and noted.
I have configured my editor to write the code according to the alignment
conventions, but probably something missed the mark.
- Shashank
-Original Message-
From: Tuikov, Luben
Sent: 30 March 2023 15:50
To: Sharma, Shasha
On 30/03/2023 15:42, Luben Tuikov wrote:
On 2023-03-29 11:47, Shashank Sharma wrote:
From: Shashank Sharma
This patch adds helper functions to create and free doorbell
pages for kernel objects.
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: Shashank Sharma
---
drivers/gpu/drm/amd
On 2023-03-30 09:48, Shashank Sharma wrote:
>
> On 30/03/2023 15:45, Luben Tuikov wrote:
>> On 2023-03-30 09:43, Shashank Sharma wrote:
>>> On 30/03/2023 15:33, Luben Tuikov wrote:
On 2023-03-30 07:14, Christian König wrote:
> Am 29.03.23 um 17:47 schrieb Shashank Sharma:
>> From: Ale
On 2023-03-30 10:04, Shashank Sharma wrote:
>
> On 30/03/2023 15:42, Luben Tuikov wrote:
>> On 2023-03-29 11:47, Shashank Sharma wrote:
>>> From: Shashank Sharma
>>>
>>> This patch adds helper functions to create and free doorbell
>>> pages for kernel objects.
>>>
>>> Cc: Alex Deucher
>>> Cc: Ch
On Wed, Mar 29, 2023 at 11:48 AM Shashank Sharma
wrote:
>
> From: Shashank Sharma
>
> Rename doorbell.num_doorbells to doorbell.num_kernel_doorbells to
> make it more readable.
>
> Cc: Alex Deucher
> Cc: Christian Koenig
> Signed-off-by: Shashank Sharma
Reviewed-by: Alex Deucher
> ---
> dr
On Wed, Mar 29, 2023 at 11:48 AM Shashank Sharma
wrote:
>
> From: Shashank Sharma
>
> This patch adds double include protection for doorbell.h
>
> Cc: Alex Deucher
> Cc: Christian Koenig
> Signed-off-by: Shashank Sharma
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_do
On Wed, Mar 29, 2023 at 11:48 AM Shashank Sharma
wrote:
>
> From: Shashank Sharma
>
> This patch:
> - creates a new file for doorbell management.
> - moves doorbell code from amdgpu_device.c to this file.
>
> Cc: Alex Deucher
> Cc: Christian Koenig
> Signed-off-by: Shashank Sharma
> ---
> dri
On Wed, Mar 29, 2023 at 11:48 AM Shashank Sharma
wrote:
>
> From: Shashank Sharma
>
> This patch removes the check and change in num_kernel_doorbells
> for MES, which is not being used anywhere by MES code.
>
> Cc: Alex Deucher
> Cc: Christian Koenig
> Signed-off-by: Shashank Sharma
Acked-by:
On 2023-03-29 11:47, Shashank Sharma wrote:
> From: Shashank Sharma
>
> This patch:
> - creates a doorbell page for graphics driver usages.
> - removes the adev->doorbell.ptr variable, replaces it with
> kernel-doorbell-bo's cpu address.
>
> Cc: Alex Deucher
> Cc: Christian Koenig
> Signed-o
On Wed, Mar 29, 2023 at 11:48 AM Shashank Sharma
wrote:
>
> From: Shashank Sharma
>
> This patch adds helper functions to create and free doorbell
> pages for kernel objects.
I think we can probably drop this patch. I think it would be simpler
to just use standard amdgpu_bos to represent them a
On Wed, Mar 29, 2023 at 11:48 AM Shashank Sharma
wrote:
>
> From: Shashank Sharma
>
> This patch initialzes the ttm resource manager for doorbells.
>
> Cc: Alex Deucher
> Cc: Christian Koenig
> Signed-off-by: Shashank Sharma
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8
> 1 fi
On 30/03/2023 16:15, Luben Tuikov wrote:
On 2023-03-30 10:04, Shashank Sharma wrote:
On 30/03/2023 15:42, Luben Tuikov wrote:
On 2023-03-29 11:47, Shashank Sharma wrote:
From: Shashank Sharma
This patch adds helper functions to create and free doorbell
pages for kernel objects.
Cc: Alex D
On 2023-03-29 11:47, Shashank Sharma wrote:
> This patch:
> - updates start/end values for each of the doorbell object
> created.
> - adds a function which validates that the kernel doorbell read/write
> is within this range.
> - uses this function during doorbell writes from kernel.
>
> Cc: A
On 2023-03-30 10:34, Shashank Sharma wrote:
>
> On 30/03/2023 16:15, Luben Tuikov wrote:
>> On 2023-03-30 10:04, Shashank Sharma wrote:
>>> On 30/03/2023 15:42, Luben Tuikov wrote:
On 2023-03-29 11:47, Shashank Sharma wrote:
> From: Shashank Sharma
>
> This patch adds helper func
On 30/03/2023 16:34, Luben Tuikov wrote:
On 2023-03-29 11:47, Shashank Sharma wrote:
This patch:
- updates start/end values for each of the doorbell object
created.
- adds a function which validates that the kernel doorbell read/write
is within this range.
- uses this function during doo
On 2023-03-30 10:28, Alex Deucher wrote:
> On Wed, Mar 29, 2023 at 11:48 AM Shashank Sharma
> wrote:
>>
>> From: Shashank Sharma
>>
>> This patch adds helper functions to create and free doorbell
>> pages for kernel objects.
>
> I think we can probably drop this patch. I think it would be simpl
On Thu, Mar 30, 2023 at 7:49 AM Shashank Sharma wrote:
>
>
> On 30/03/2023 13:30, Christian König wrote:
> >
> >
> > Am 29.03.23 um 17:47 schrieb Shashank Sharma:
> >> From: Shashank Sharma
> >>
> >> This patch:
> >> - creates a doorbell page for graphics driver usages.
> >> - removes the adev->d
On 30/03/2023 16:24, Luben Tuikov wrote:
On 2023-03-29 11:47, Shashank Sharma wrote:
From: Shashank Sharma
This patch:
- creates a doorbell page for graphics driver usages.
- removes the adev->doorbell.ptr variable, replaces it with
kernel-doorbell-bo's cpu address.
Cc: Alex Deucher
Cc:
Am 30.03.23 um 16:39 schrieb Alex Deucher:
On Thu, Mar 30, 2023 at 7:49 AM Shashank Sharma wrote:
On 30/03/2023 13:30, Christian König wrote:
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shashank Sharma
This patch:
- creates a doorbell page for graphics driver usages.
- removes the
On 30/03/2023 16:42, Christian König wrote:
Am 30.03.23 um 16:39 schrieb Alex Deucher:
On Thu, Mar 30, 2023 at 7:49 AM Shashank Sharma
wrote:
On 30/03/2023 13:30, Christian König wrote:
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shashank Sharma
This patch:
- creates a doorbell
On 2023-03-30 10:37, Shashank Sharma wrote:
>
> On 30/03/2023 16:34, Luben Tuikov wrote:
>> On 2023-03-29 11:47, Shashank Sharma wrote:
>>> This patch:
>>> - updates start/end values for each of the doorbell object
>>>created.
>>> - adds a function which validates that the kernel doorbell read
Am 30.03.23 um 16:40 schrieb Shashank Sharma:
On 30/03/2023 16:24, Luben Tuikov wrote:
On 2023-03-29 11:47, Shashank Sharma wrote:
From: Shashank Sharma
This patch:
- creates a doorbell page for graphics driver usages.
- removes the adev->doorbell.ptr variable, replaces it with
kernel-doo
On 30/03/2023 16:23, Alex Deucher wrote:
On Wed, Mar 29, 2023 at 11:48 AM Shashank Sharma
wrote:
From: Shashank Sharma
This patch:
- creates a new file for doorbell management.
- moves doorbell code from amdgpu_device.c to this file.
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: S
On 2023-03-30 10:49, Christian König wrote:
> Am 30.03.23 um 16:40 schrieb Shashank Sharma:
>>
>> On 30/03/2023 16:24, Luben Tuikov wrote:
>>> On 2023-03-29 11:47, Shashank Sharma wrote:
From: Shashank Sharma
This patch:
- creates a doorbell page for graphics driver usages.
>>>
Am 30.03.23 um 16:48 schrieb Shashank Sharma:
On 30/03/2023 16:42, Christian König wrote:
Am 30.03.23 um 16:39 schrieb Alex Deucher:
On Thu, Mar 30, 2023 at 7:49 AM Shashank Sharma
wrote:
On 30/03/2023 13:30, Christian König wrote:
Am 29.03.23 um 17:47 schrieb Shashank Sharma:
From: Shas
On 30/03/2023 16:49, Christian König wrote:
Am 30.03.23 um 16:40 schrieb Shashank Sharma:
On 30/03/2023 16:24, Luben Tuikov wrote:
On 2023-03-29 11:47, Shashank Sharma wrote:
From: Shashank Sharma
This patch:
- creates a doorbell page for graphics driver usages.
- removes the adev->doorbe
On 30/03/2023 16:33, Alex Deucher wrote:
On Wed, Mar 29, 2023 at 11:48 AM Shashank Sharma
wrote:
From: Shashank Sharma
This patch initialzes the ttm resource manager for doorbells.
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: Shashank Sharma
---
drivers/gpu/drm/amd/amdgpu/amdg
On Thu, Mar 30, 2023 at 10:34 AM Shashank Sharma
wrote:
>
>
> On 30/03/2023 16:15, Luben Tuikov wrote:
> > On 2023-03-30 10:04, Shashank Sharma wrote:
> >> On 30/03/2023 15:42, Luben Tuikov wrote:
> >>> On 2023-03-29 11:47, Shashank Sharma wrote:
> From: Shashank Sharma
>
> This pa
On 2023-03-30 10:53, Shashank Sharma wrote:
>
> On 30/03/2023 16:49, Christian König wrote:
>> Am 30.03.23 um 16:40 schrieb Shashank Sharma:
>>>
>>> On 30/03/2023 16:24, Luben Tuikov wrote:
On 2023-03-29 11:47, Shashank Sharma wrote:
> From: Shashank Sharma
>
> This patch:
>
On 30/03/2023 16:49, Luben Tuikov wrote:
On 2023-03-30 10:37, Shashank Sharma wrote:
On 30/03/2023 16:34, Luben Tuikov wrote:
On 2023-03-29 11:47, Shashank Sharma wrote:
This patch:
- updates start/end values for each of the doorbell object
created.
- adds a function which validates that
On Thu, Mar 30, 2023 at 10:48 AM Shashank Sharma
wrote:
>
>
> On 30/03/2023 16:42, Christian König wrote:
> > Am 30.03.23 um 16:39 schrieb Alex Deucher:
> >> On Thu, Mar 30, 2023 at 7:49 AM Shashank Sharma
> >> wrote:
> >>>
> >>> On 30/03/2023 13:30, Christian König wrote:
>
> Am 29.03.
On Thu, Mar 30, 2023 at 6:40 AM Christian König
wrote:
>
> Am 30.03.23 um 10:15 schrieb Shashank Sharma:
> > Hello Pierre-Eric,
> > [SNIP]
> >> I'm also wondering why the doorbell needs a handle+offset but
> >> other buffers are passed in as virtual addresses?
> >>
> > As you know, doorbell offset
On 30/03/2023 16:59, Luben Tuikov wrote:
On 2023-03-30 10:53, Shashank Sharma wrote:
On 30/03/2023 16:49, Christian König wrote:
Am 30.03.23 um 16:40 schrieb Shashank Sharma:
On 30/03/2023 16:24, Luben Tuikov wrote:
On 2023-03-29 11:47, Shashank Sharma wrote:
From: Shashank Sharma
This p
On 3/30/23 09:01, Luben Tuikov wrote:
> Hi Alan,
>
> Inline:
>
> On 2023-03-30 06:48, Christian König wrote:
>> Am 30.03.23 um 11:15 schrieb Liu, HaoPing (Alan):
>>>
>>> [AMD Official Use Only - General]
>>>
>>>
>>>
>>> Hi Christian,
>>>
>>>
>>>
>>> Thanks for the review. Please see inline
On 30/03/2023 16:55, Alex Deucher wrote:
On Thu, Mar 30, 2023 at 10:34 AM Shashank Sharma
wrote:
On 30/03/2023 16:15, Luben Tuikov wrote:
On 2023-03-30 10:04, Shashank Sharma wrote:
On 30/03/2023 15:42, Luben Tuikov wrote:
On 2023-03-29 11:47, Shashank Sharma wrote:
From: Shashank Sharma
The comment mentions that power1 cap attributes are not supported on
Vangogh, but the opposite is indeed valid: for APUs, only Vangogh is
supported. While at it, also fixed the Renoir comment below (thanks
Melissa for noticing that!).
Cc: Lijo Lazar
Cc: Melissa Wen
Signed-off-by: Guilherme G. Pi
clang with W=1 reports
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_int_process_v11.c:282:38: error:
variable
'sq_int_priv' set but not used [-Werror,-Wunused-but-set-variable]
uint8_t sq_int_enc, sq_int_errtype, sq_int_priv;
^
This variable is not
On 30/03/2023 16:12, Luben Tuikov wrote:
On 2023-03-30 09:48, Shashank Sharma wrote:
On 30/03/2023 15:45, Luben Tuikov wrote:
On 2023-03-30 09:43, Shashank Sharma wrote:
On 30/03/2023 15:33, Luben Tuikov wrote:
On 2023-03-30 07:14, Christian König wrote:
Am 29.03.23 um 17:47 schrieb Shasha
Am 2023-03-30 um 11:20 schrieb Tom Rix:
clang with W=1 reports
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_int_process_v11.c:282:38: error:
variable
'sq_int_priv' set but not used [-Werror,-Wunused-but-set-variable]
uint8_t sq_int_enc, sq_int_errtype, sq_int_priv;
Hi Dave, Daniel,
A regression fix for 6.3.
The following changes since commit 68dc1846c3a44d5e633be145c169ce2fd5420695:
drm/amd/display: Take FEC Overhead into Timeslot Calculation (2023-03-29
17:21:06 -0400)
are available in the Git repository at:
https://gitlab.freedesktop.org/agd5f/lin
amdgpu_connector_edid() copies the EDID from edid_blob_ptr as a side
effect if amdgpu_connector->edid isn't initialized. However, everywhere
that the returned EDID is used, the EDID should have been set
beforehands.
Only the EDID code and sysfs should look at the EDID property, anyway,
so stop usi
radeon_connector_edid() copies the EDID from edid_blob_ptr as a side
effect if radeon_connector->edid isn't initialized. However, everywhere
that the returned EDID is used, the EDID should have been set
beforehands.
Only the EDID code and sysfs should look at the EDID property, anyway,
so stop usi
Prefer the parsed results for is_hdmi and has_audio in display info over
calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(),
respectively.
Cc: Alex Deucher
Cc: Christian König
Cc: Pan, Xinhui
Cc: amd-gfx@lists.freedesktop.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/radeon
THIS IS UNTESTED for anything other than i915.
Use previously parsed EDID where possible for display audio/hdmi
detection. This in turn reduces edid_blob_ptr usage in a number of
places. Further reduce edid_blob_ptr usage, and document that it should
not be used by drivers directly.
BR,
Jani.
C
[Public]
Hi Felix,
That is correct. The debugger will need sq_int_priv to work.
Thanks,
Jon
> -Original Message-
> From: Kuehling, Felix
> Sent: Thursday, March 30, 2023 11:39 AM
> To: Tom Rix ; Deucher, Alexander
> ; Koenig, Christian
> ; Pan, Xinhui ;
> airl...@gmail.com; dan...@ff
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: a6d9e3034536ba4b68ac34490c02267e6eec9c05 Add linux-next specific
files for 20230330
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202303161521.jbgbafjj-...@intel.com
https
On Wed, Mar 29, 2023 at 06:00:59PM -0400, Alex Deucher wrote:
> Hi Dave, Daniel,
>
> Fixes for 6.3.
>
> The following changes since commit 197b6b60ae7bc51dd0814953c562833143b292aa:
>
> Linux 6.3-rc4 (2023-03-26 14:40:20 -0700)
>
> are available in the Git repository at:
>
> https://gitlab.
On 2023-03-29 11:47, Shashank Sharma wrote:
> This patch adds a helper function which converts a doorbell's
> relative index in a BO to an absolute doorbell offset in the
> doorbell BAR.
>
> Cc: Alex Deucher
> Cc: Christian Koenig
> Signed-off-by: Shashank Sharma
> ---
> drivers/gpu/drm/amd/am
On 30/03/2023 19:18, Luben Tuikov wrote:
On 2023-03-29 11:47, Shashank Sharma wrote:
This patch adds a helper function which converts a doorbell's
relative index in a BO to an absolute doorbell offset in the
doorbell BAR.
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by: Shashank Sharma
On Thu, Mar 30, 2023 at 11:38:59AM -0400, Alex Deucher wrote:
> Hi Dave, Daniel,
>
> A regression fix for 6.3.
>
> The following changes since commit 68dc1846c3a44d5e633be145c169ce2fd5420695:
>
> drm/amd/display: Take FEC Overhead into Timeslot Calculation (2023-03-29
> 17:21:06 -0400)
>
> a
Applied. Thanks!
On Thu, Mar 30, 2023 at 11:32 AM Guilherme G. Piccoli
wrote:
>
> The comment mentions that power1 cap attributes are not supported on
> Vangogh, but the opposite is indeed valid: for APUs, only Vangogh is
> supported. While at it, also fixed the Renoir comment below (thanks
> Me
On Thu, Mar 30, 2023 at 2:12 AM Christian König
wrote:
>
> Am 29.03.23 um 17:25 schrieb Alex Deucher:
> > From: Christian König
> >
> > Add support for submitting the shadow update packet
> > when submitting an IB. Needed for MCBP on GFX11.
> >
> > v2: update API for CSA (Alex)
> > v3: fix order
On Thu, Mar 30, 2023 at 2:16 AM Christian König
wrote:
>
> Am 29.03.23 um 17:25 schrieb Alex Deucher:
> > Used to get the size and alignment requirements for
> > the gfx shadow buffer for preemption.
> >
> > v2: use FW version check to determine whether to
> > return a valid size here
> >
On Thu, Mar 30, 2023 at 2:17 AM Christian König
wrote:
>
>
>
> Am 29.03.23 um 17:25 schrieb Alex Deucher:
> > Use the new callback to fetch the data. Return an error if
> > not supported. UMDs should use this query to check whether
> > shadow buffers are supported and if so what size they
> > sh
1 - 100 of 200 matches
Mail list logo
