RE: [Resend PATCH v1 3/3] drm/amd/pm: vangogh: support to send SMT enable message

2023-03-24 Thread Yang, WenYou
[AMD Official Use Only - General] > -Original Message- > From: Yuan, Perry > Sent: Thursday, March 23, 2023 10:21 AM > To: Yang, WenYou ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui > Cc: Liang, Richard qi ; Li, Ying > ; Liu, Kun ; amd- > g...@lists.freedesktop.org; Yang,

[PATCH] drm/amd/pm: re-enable the gfx imu when smu resume

2023-03-24 Thread Tim Huang
If the gfx imu is poweroff when suspend, then it need to be re-enabled when resume. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 40 --- 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/dr

RE: [PATCH] drm/amd/pm: re-enable the gfx imu when smu resume

2023-03-24 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of Tim > Huang > Sent: Friday, March 24, 2023 3:08 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Zhang, Yifan > ; Ma, Li ; Du, Xiaojian > ; Huang, Tim > Subject: [PATCH] drm/amd/pm: re-

RE: [PATCH] drm/amd/pm: re-enable the gfx imu when smu resume

2023-03-24 Thread Chen, Guchun
> -Original Message- > From: amd-gfx On Behalf Of Tim > Huang > Sent: Friday, March 24, 2023 3:08 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Zhang, Yifan > ; Ma, Li ; Du, Xiaojian > ; Huang, Tim > Subject: [PATCH] drm/amd/pm: re-enable the gfx imu when smu resume

Re: [pull] amdgpu drm-fixes-6.3

2023-03-24 Thread Daniel Vetter
On Thu, Mar 23, 2023 at 12:19:39PM -0400, Alex Deucher wrote: > Hi Dave, Daniel, > > Fixes for 6.3. > > The following changes since commit e8d018dd0257f744ca50a729e3d042cf2ec9da65: > > Linux 6.3-rc3 (2023-03-19 13:27:55 -0700) > > are available in the Git repository at: > > https://gitlab.

Re: BUG: KASAN: slab-use-after-free in drm_sched_get_cleanup_job+0x47b/0x5c0 [gpu_sched]

2023-03-24 Thread Christian König
Am 23.03.23 um 20:05 schrieb Mikhail Gavrilov: On Tue, Mar 21, 2023 at 11:47 PM Christian König wrote: Hi Mikhail, That looks like a reference counting issue to me. I'm going to take a look, but we have already fixed one of those recently. Probably best that you try this on drm-fixes, just t

[PATCH resent] drm/amd/display: Fix exception handling in dm_validate_stream_and_context()

2023-03-24 Thread Markus Elfring
Date: Sat, 18 Mar 2023 16:21:32 +0100 The label “cleanup” was used to jump to another pointer check despite of the detail in the implementation of the function “dm_validate_stream_and_context” that it was determined already that corresponding variables contained still null pointers. 1. Thus retu

Re: [linux-next:master] BUILD REGRESSION 7c4a254d78f89546d0e74a40617ef24c6151c8d1

2023-03-24 Thread Péter Ujfalusi
Hi, On 23/03/2023 23:34, kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: 7c4a254d78f89546d0e74a40617ef24c6151c8d1 Add linux-next > specific files for 20230323 > > Error/Warning reports: > > https://lore.kernel

[linux-next:master] BUILD SUCCESS WITH WARNING e5dbf24e8b9e6aa0a185d86ce46a7a9c79ebb40f

2023-03-24 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: e5dbf24e8b9e6aa0a185d86ce46a7a9c79ebb40f Add linux-next specific files for 20230324 Warning reports: https://lore.kernel.org/oe-kbuild-all/202303011456.wepem0zn-...@intel.com https

Re: [PATCH resent] drm/amd/display: Fix exception handling in dm_validate_stream_and_context()

2023-03-24 Thread Hamza Mahfooz
Hi Markus, On 3/24/23 11:42, Markus Elfring wrote: Date: Sat, 18 Mar 2023 16:21:32 +0100 The label “cleanup” was used to jump to another pointer check despite of the detail in the implementation of the function “dm_validate_stream_and_context” that it was determined already that corresponding

RE: [v1,2/3] drm/amd/pm: send the SMT-enable message to pmfw

2023-03-24 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, March 23, 2023 21:29 > To: Limonciello, Mario ; Yang, WenYou > ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui > Cc: Li, Ying ; Liu, Kun ; Liang, > Richard qi ; amd-gfx@lists.freedes

Re: [PATCH resent] drm/amd/display: Fix exception handling in dm_validate_stream_and_context()

2023-03-24 Thread Markus Elfring
>> The label “cleanup” was used to jump to another pointer check despite of >> the detail in the implementation of the function >> “dm_validate_stream_and_context” >> that it was determined already that corresponding variables contained >> still null pointers. >> >> 1. Thus return directly if >>  

Re: [PATCH resent] drm/amd/display: Fix exception handling in dm_validate_stream_and_context()

2023-03-24 Thread Hamza Mahfooz
On 3/24/23 14:19, Markus Elfring wrote: May longer identifiers (or even the complete SHA-1 ID) occasionally also be tolerated for the tag “Fixes”? How do you think about the proposed change possibilities? Well, the hash length is restricted by convention (see ./scripts/checkpatch.pl in the k

RE: [PATCH] drm/display: Add missing OLED Vesa brightnesses definitions

2023-03-24 Thread Clark, Felipe
[AMD Official Use Only - General] Hi Rodrigo and Harry, There was a typo in the third line of the pseudo-patch I wrote in the previous email. Here is the fixed version: #define DP_EDP_GENERAL_CAP_20x703 # define DP_EDP_OVERDRIVE_ENGINE_ENABLED (1 << 0) +# define DP_EDP_PANEL_LUMINANCE

Re: [PATCH 00/10] drm/radeon: Convert fbdev to DRM client

2023-03-24 Thread Alex Deucher
On Tue, Mar 21, 2023 at 5:33 AM Thomas Zimmermann wrote: > > Hi > > Am 20.03.23 um 16:23 schrieb Alex Deucher: > > On Mon, Mar 20, 2023 at 11:19 AM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 20.03.23 um 16:11 schrieb Christian König: > >>> Am 17.03.23 um 10:20 schrieb Thomas Zimmerma

[PATCH 3/3] drm/amdgpu: init nbio v7_9 callbacks

2023-03-24 Thread Alex Deucher
From: Hawking Zhang switch to the new nbio generation for NBIO 7.9.0. Signed-off-by: Hawking Zhang Reviewed-by: Le Ma Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_disco

[PATCH 0/3] NBIO 7.9 support

2023-03-24 Thread Alex Deucher
Add support for NBIO 7.9. The first patch is just register headers and is too big for the mailing list. Hawking Zhang (3): drm/amdgpu: add nbio v7_9_0 ip headers drm/amdgpu: add nbio v7_9 support drm/amdgpu: init nbio v7_9 callbacks drivers/gpu/drm/amd/amdgpu/Makefile | 3 +-

[PATCH 2/3] drm/amdgpu: add nbio v7_9 support

2023-03-24 Thread Alex Deucher
From: Hawking Zhang v7_9 is a new nbio generation ip. Signed-off-by: Hawking Zhang Reviewed-by: Le Ma Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile| 3 +- drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c | 369 + drivers/gpu/drm/amd/amdgpu/nbio_v7_9.

[PATCH] drm/amdgpu: Set family for GC 9.4.3

2023-03-24 Thread Alex Deucher
From: Hawking Zhang Set family for GC 9.4.3 Signed-off-by: Hawking Zhang Reviewed-by: Le Ma Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/a

[PATCH 4/9] drm/amdgpu: add gmc ip block support for GC 9.4.3

2023-03-24 Thread Alex Deucher
From: Hawking Zhang Initialize various gmc sw/hw settings/configurations for GC 9.4.3. Signed-off-by: Hawking Zhang Reviewed-by: Le Ma Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/dri

[PATCH 7/9] drm/amdgpu: add mmhub v1_8 support

2023-03-24 Thread Alex Deucher
From: Le Ma Hack the mmhub 1.7 reg offset for initial support v2: squash in header switch, CG funcs (Alex) Signed-off-by: Le Ma Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c | 477

[PATCH 0/9] GMC 9.4.3 Support

2023-03-24 Thread Alex Deucher
Add GMC (Graphics Memory Controller) support for GMC 9.4.3 which contains mmhub 1.8 and gfxhub 1.2. Patches 1-3, 6 are register headers which are too big for the mailing list. Hawking Zhang (6): drm/amdgpu: add athub v1_8_0 ip headers drm/amdgpu: add osssys v4_4_2 ip headers drm/amdgpu: add

[PATCH 9/9] drm/amdgpu: add GMC ip block for GC 9.4.3

2023-03-24 Thread Alex Deucher
From: Hawking Zhang Add GMC IP handling for GC 9.4.3 Signed-off-by: Hawking Zhang Reviewed-by: Le Ma Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/

[PATCH 8/9] drm/amdgpu: initialize gfxhub v1_2 and mmhub v1_8 funcs

2023-03-24 Thread Alex Deucher
From: Le Ma Initialize gfxhub1.2 and mmhub1.8 function calls Signed-off-by: Le Ma Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0

[PATCH 5/9] drm/amdgpu: add gfxhub v1_2 support

2023-03-24 Thread Alex Deucher
From: Le Ma Hack the gc 9.0 reg offset for initial support v2: squash in header switch (Alex) Signed-off-by: Le Ma Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_2.c | 471 +++

Re: [v1,2/3] drm/amd/pm: send the SMT-enable message to pmfw

2023-03-24 Thread Lazar, Lijo
[AMD Official Use Only - General] The notifier block is embedded in smu context of a device. If there are 4 devices and 3 of them are interested, they register using the notifier block within their smu context. Notifier is called in a chain and when received they use the container_of to get t

RE: [PATCH] drm/amd/pm: re-enable the gfx imu when smu resume

2023-03-24 Thread Huang, Tim
[Public] -Original Message- From: Quan, Evan Sent: Friday, March 24, 2023 3:17 PM To: Huang, Tim ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Ma, Li ; Du, Xiaojian ; Huang, Tim Subject: RE: [PATCH] drm/amd/pm: re-enable the gfx imu when smu resume [AMD Offic

RE: [PATCH] drm/amd/pm: re-enable the gfx imu when smu resume

2023-03-24 Thread Huang, Tim
[Public] -Original Message- From: Chen, Guchun Sent: Friday, March 24, 2023 3:26 PM To: Huang, Tim ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Ma, Li ; Du, Xiaojian ; Huang, Tim Subject: RE: [PATCH] drm/amd/pm: re-enable the gfx imu when smu resume >