Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-12-28 Thread Rob Clark
On Thu, Nov 17, 2022 at 7:12 AM Dmitry Osipenko wrote: > > On 11/17/22 18:09, Christian König wrote: > > Am 17.11.22 um 15:41 schrieb Dmitry Osipenko: > >> [SNIP] > >>> drm_sched_entity_flush() should be called from the flush callback from > >>> the file_operations structure of panfrost. See amdgp

[PATCH v2 01/11] drm/amd: Delay removal of the firmware framebuffer

2022-12-28 Thread Mario Limonciello
Removing the firmware framebuffer from the driver means that even if the driver doesn't support the IP blocks in a GPU it will no longer be functional after the driver fails to initialize. This change will ensure that unsupported IP blocks at least cause the driver to work with the EFI framebuffer

[PATCH v2 03/11] drm/amd: Convert SMUv11 microcode init to use `amdgpu_ucode_ip_version_decode`

2022-12-28 Thread Mario Limonciello
Remove the special casing from SMU v11 code. No intended functional changes. Signed-off-by: Mario Limonciello --- .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c| 35 ++- 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c

[PATCH v2 00/11] Recover from failure to probe GPU

2022-12-28 Thread Mario Limonciello
One of the first thing that KMS drivers do during initialization is destroy the system firmware framebuffer by means of `drm_aperture_remove_conflicting_pci_framebuffers` This means that if for any reason the GPU failed to probe the user will be stuck with at best a screen frozen at the last thing

[PATCH v2 02/11] drm/amd: Add a legacy mapping to "amdgpu_ucode_ip_version_decode"

2022-12-28 Thread Mario Limonciello
This will allow other parts of the driver that currently special case firmware file names to before IP version style naming to just have a single call to `amdgpu_ucode_ip_version_decode`. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 208 ++

[PATCH v2 05/11] drm/amd: Request SDMA microcode during IP discovery

2022-12-28 Thread Mario Limonciello
If SDMA microcode is not available during early init, the microcode framebuffer will have already been released and the screen will freeze. Move the request from SDMA microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Signed-off-by: Mario Limonciello ---

[PATCH v2 04/11] drm/amd: Convert SMU v13 to use `amdgpu_ucode_ip_version_decode`

2022-12-28 Thread Mario Limonciello
The special case for the one dGPU has been moved into `amdgpu_ucode_ip_version_decode`, so simplify this code. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH v2 07/11] drm/amd: Request MES microcode during IP discovery

2022-12-28 Thread Mario Limonciello
If MES microcode is required but not available during early init, the microcode framebuffer will have already been released and the screen will freeze. Move the request for MES microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Signed-off-by: Mario Limonc

[PATCH v2 09/11] drm/amd: Request GFX10 microcode during IP discovery

2022-12-28 Thread Mario Limonciello
If GFX10 microcode is required but not available during early init, the microcode framebuffer will have already been released and the screen will freeze. Move the request for GFX10 microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Signed-off-by: Mario Li

[PATCH v2 08/11] drm/amd: Request GFX9 microcode during IP discovery

2022-12-28 Thread Mario Limonciello
If GFX9 microcode is required but not available during early init, the microcode framebuffer will have already been released and the screen will freeze. Move the request for GFX9 microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Signed-off-by: Mario Limo

[PATCH v2 11/11] drm/amd: Request PSP microcode during IP discovery

2022-12-28 Thread Mario Limonciello
If PSP microcode is required but not available during early init, the firmware framebuffer will have already been released and the screen will freeze. Move the request for PSP microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Signed-off-by: Mario Limonci

[PATCH v2 06/11] drm/amd: Request VCN microcode during IP discovery

2022-12-28 Thread Mario Limonciello
If VCN microcode is not available during early init, the microcode framebuffer will have already been released and the screen will freeze. Move the request for VCN microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Signed-off-by: Mario Limonciello --- d

[PATCH v2 10/11] drm/amd: Request GFX11 microcode during IP discovery

2022-12-28 Thread Mario Limonciello
If GFX11 microcode is required but not available during early init, the microcode framebuffer will have already been released and the screen will freeze. Move the request for GFX11 microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Signed-off-by: Mario Li

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-12-28 Thread Rob Clark
On Wed, Dec 28, 2022 at 8:27 AM Rob Clark wrote: > > On Thu, Nov 17, 2022 at 7:12 AM Dmitry Osipenko > wrote: > > > > On 11/17/22 18:09, Christian König wrote: > > > Am 17.11.22 um 15:41 schrieb Dmitry Osipenko: > > >> [SNIP] > > >>> drm_sched_entity_flush() should be called from the flush callba

Re: [BUG] AMD Radeon Pro 5600M with 8GB of HBM2 memory shows blank screen on Linux

2022-12-28 Thread Orlando Chamberlain
On Mon, 26 Dec 2022 21:44:06 +1100 "Aditya Garg" wrote: > The AMD Radeon Pro 5600M with 8GB of HBM2 memory GPU is found in > MacBook Pro 16 inch, 2019 (MacBookPro16,4). > > The GPU fails to work on Linux, thus a blank black screen gets > displayed on boot. > > If nomodeset is added as a kernel