[PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state

2022-12-07 Thread Ma Jun
Add the missing declaration of struct drm_atomic_state Signed-off-by: Ma Jun --- include/drm/drm_plane_helper.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h index b00ad36cf5b6..530f88176db4 100644 --- a/include/drm/drm_plane_

[PATCH] drm/amdgpu: Retry DDC probing on DVI on failure if we got an HPD interrupt

2022-12-07 Thread xurui
HPD signals on DVI ports can be fired off before the pins required for DDC probing actually make contact, due to the pins for HPD making contact first. This results in a HPD signal being asserted but DDC probing failing, resulting in hotplugging occasionally failing. Rescheduling the hotplug work

[PATCH 2/6] drm/amdgpu: add RAS poison consumption handler for NV SRIOV

2022-12-07 Thread Tao Zhou
Send handling request to host. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c | 6 ++ drivers/gpu/drm/amd/amdgpu/mxgpu_nv.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c b/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c index e07757eea7

[PATCH 1/6] drm/amdgpu: inform PF if VF receives RAS poison interrupt

2022-12-07 Thread Tao Zhou
PF will do page retirement, reset VF and inform VF to reserve RAS bad pages. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c | 44 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 1 + drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c| 6 drivers/gpu/drm/am

[PATCH 3/6] drm/amdgpu: add VCN poison consumption handler for SRIOV

2022-12-07 Thread Tao Zhou
Inform host and let host handle consumption interrupt. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c index 72

[PATCH 4/6] drm/amdgpu: skip RAS error injection in SRIOV

2022-12-07 Thread Tao Zhou
And return successful status. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index ad490c1e2f57..

[PATCH 5/6] drm/amdgpu: update VCN/JPEG RAS setting

2022-12-07 Thread Tao Zhou
The enablement of VCN/JPEG RAS is unrelated to SRIOV. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.

[PATCH 6/6] drm/amdgpu: define RAS poison mode query function

2022-12-07 Thread Tao Zhou
1. no need to query poison mode on SRIOV guest side, host can handle it. 2. define the function to simplify code. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 54 +++-- 1 file changed, 33 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/am

Re: [bug][vaapi][h264] The commit 7cbe08a930a132d84b4cf79953b00b074ec7a2a7 on certain video files leads to problems with VAAPI hardware decoding.

2022-12-07 Thread Alex Deucher
On Wed, Dec 7, 2022 at 9:44 AM Mikhail Gavrilov wrote: > > Hi, > > I found a commit that on certain video files leads to problems with > VAAPI hardware decoding. > Reproducing the issue requires mesa to be built with the h264 hardware > encoder enabled and the attached file to be playable in the v

RE: [PATCH 4/6] drm/amdgpu: skip RAS error injection in SRIOV

2022-12-07 Thread Zhang, Hawking
[AMD Official Use Only - General] It might be better check amdgpu_sriov_vf from the beginning of the function. Return 0 directly if it is invoked from guest side. Don't need to print out something, error injection from guest is invalid. Regards, Hawking -Original Message- From: Zhou1,

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Alex Deucher
Does this patch fix the problem? Alex On Wed, Dec 7, 2022 at 2:27 AM Zhang, Jesse(Jie) wrote: > > [AMD Official Use Only - General] > > > drm/amdgpu: try allowed domain when pin framebuffer failed. > > > > [WHY&HOW] > > > > in some scenarios, the allocate memory often failed. such as

RE: [PATCH 5/6] drm/amdgpu: update VCN/JPEG RAS setting

2022-12-07 Thread Zhang, Hawking
[AMD Official Use Only - General] the commit description and the inline comments are confusing. I would say we support VCN RAS in both bare-metal and SRIOV environment now. -Original Message- From: Zhou1, Tao Sent: Wednesday, December 7, 2022 18:04 To: amd-gfx@lists.freedesktop.org; Zha

Re: [PATCH] drm/amdgpu: fixx NULL pointer deref in gmc_v9_0_get_vm_pte

2022-12-07 Thread Alex Deucher
On Wed, Dec 7, 2022 at 2:49 AM Christian König wrote: > > We not only need to make sure that we have a BO, but also that the BO > has some backing store. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 4 +++- > 1 file changed, 3 in

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Christian König
I would go a step further and just allow GTT domain on ASICs != CARRIZO | STONEY. I can't see a good reason we should still have any limitation here, VRAM doesn't have any advantage any more as far as I know. Christian. Am 07.12.22 um 16:10 schrieb Alex Deucher: Does this patch fix the prob

RE: [PATCH 1/6] drm/amdgpu: inform PF if VF receives RAS poison interrupt

2022-12-07 Thread Zhang, Hawking
[AMD Official Use Only - General] I suggest split the patch into two One is adding ras poison handler for mxgpu ai products, similar as patch #2, including drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 1 + drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c| 6 drivers/gpu/drm/amd/amdgpu/mxgpu_ai.h

RE: [PATCH 6/6] drm/amdgpu: define RAS poison mode query function

2022-12-07 Thread Zhang, Hawking
[AMD Official Use Only - General] Might be better rename to amdgdpu_ras_query_poison_mode to align with naming style of ip callbacks. +static void amdgpu_ras_poison_mode_query Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Wednesday, December 7, 2022 18:04 To: amd-gfx@list

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Paneer Selvam, Arunpravin
[AMD Official Use Only - General] Jesse informed me that this patch solves the issue, he tested all the cases. Thanks, Arun Get Outlook for Android From: Christian König Sent: Wednesday, December 7, 2022 8:53:25 PM To: Alex Deucher ; Zhan

Re: [PATCH] drm/amdgpu: Retry DDC probing on DVI on failure if we got an HPD interrupt

2022-12-07 Thread kernel test robot
Hi xurui, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.1-rc8 next-20221207] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Alex Deucher
On Wed, Dec 7, 2022 at 10:23 AM Christian König wrote: > > I would go a step further and just allow GTT domain on ASICs != CARRIZO > | STONEY. > > I can't see a good reason we should still have any limitation here, VRAM > doesn't have any advantage any more as far as I know. Well, if VRAM is avai

[PATCH] drm/amd/display: Add check for kzalloc

2022-12-07 Thread Jiasheng Jiang
As kzalloc may fail and return NULL pointer, it should be better to check the return value in order to avoid the NULL pointer dereference. Moreover, dcn3_clk_mgr_construct should return the error and should be checked cascadingly. Fixes: 4d55b0dd1cdd ("drm/amd/display: Add DCN3 CLK_MGR") Signed-of

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Paneer Selvam, Arunpravin
[AMD Official Use Only - General] Hi Christian, If this change is possible, I think it would improve the performance by eliminating the frequent BO eviction when there is a memory pressure. Thanks, Arun. Get Outlook for Android

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Christian König
Am 07.12.22 um 16:38 schrieb Alex Deucher: On Wed, Dec 7, 2022 at 10:23 AM Christian König wrote: I would go a step further and just allow GTT domain on ASICs != CARRIZO | STONEY. I can't see a good reason we should still have any limitation here, VRAM doesn't have any advantage any more as fa

Re: [PATCH] drm/amdgpu: fixx NULL pointer deref in gmc_v9_0_get_vm_pte

2022-12-07 Thread Luben Tuikov
Right--I just double checked with the koops and it is exactly the "resource" pointer in the tbo which is NULL. Reviewed-by:Luben Tuikov Regards, Luben On 2022-12-07 02:49, Christian König wrote: > We not only need to make sure that we have a BO, but also that the BO > has some backing store. >

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Alex Deucher
On Wed, Dec 7, 2022 at 10:52 AM Christian König wrote: > > Am 07.12.22 um 16:38 schrieb Alex Deucher: > > On Wed, Dec 7, 2022 at 10:23 AM Christian König > > wrote: > >> I would go a step further and just allow GTT domain on ASICs != CARRIZO > >> | STONEY. > >> > >> I can't see a good reason we s

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Christian König
Am 07.12.22 um 17:08 schrieb Alex Deucher: On Wed, Dec 7, 2022 at 10:52 AM Christian König wrote: Am 07.12.22 um 16:38 schrieb Alex Deucher: On Wed, Dec 7, 2022 at 10:23 AM Christian König wrote: I would go a step further and just allow GTT domain on ASICs != CARRIZO | STONEY. I can't se

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Alex Deucher
On Wed, Dec 7, 2022 at 11:10 AM Christian König wrote: > > > > Am 07.12.22 um 17:08 schrieb Alex Deucher: > > On Wed, Dec 7, 2022 at 10:52 AM Christian König > > wrote: > >> Am 07.12.22 um 16:38 schrieb Alex Deucher: > >>> On Wed, Dec 7, 2022 at 10:23 AM Christian König > >>> wrote: > I wou

[PATCH] drm/amdgpu: make display pinning more flexible (v2)

2022-12-07 Thread Alex Deucher
Only apply the static threshold for Stoney and Carrizo. This hardware has certain requirements that don't allow mixing of GTT and VRAM. Newer asics do not have these requirements so we should be able to be more flexible with where buffers end up. Signed-off-by: Alex Deucher --- drivers/gpu/drm/

[linux-next:master] BUILD REGRESSION 591cd61541b9b95401e17dca24be486e32104cb8

2022-12-07 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 591cd61541b9b95401e17dca24be486e32104cb8 Add linux-next specific files for 20221207 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211090634.ryfkk0ws-...@intel.com https

Re: [PATCH] drm/amdgpu: fixx NULL pointer deref in gmc_v9_0_get_vm_pte

2022-12-07 Thread Felix Kuehling
Am 2022-12-07 um 02:49 schrieb Christian König: We not only need to make sure that we have a BO, but also that the BO has some backing store. Signed-off-by: Christian König Mea culpa. Fixes: d1a372af1c3d ("drm/amdgpu: Set MTYPE in PTE based on BO flags") (using the commit hash from drm-next

[PATCH] drm/amdgpu: handle polaris10/11 overlap asics (v2)

2022-12-07 Thread Alex Deucher
Some special polaris 10 chips overlap with the polaris11 DID range. Handle this properly in the driver. v2: use local flags for other function calls. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) di

Re: [PATCH] drm/amdgpu: handle polaris10/11 overlap asics (v2)

2022-12-07 Thread Luben Tuikov
Acked-by: Luben Tuikov Regards, Luben On 2022-12-07 12:06, Alex Deucher wrote: > Some special polaris 10 chips overlap with the polaris11 > DID range. Handle this properly in the driver. > > v2: use local flags for other function calls. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/dr

Re: [PATCH] drm/amdgpu: make display pinning more flexible (v2)

2022-12-07 Thread Luben Tuikov
Acked-by: Luben Tuikov Regards, Luben On 2022-12-07 11:21, Alex Deucher wrote: > Only apply the static threshold for Stoney and Carrizo. > This hardware has certain requirements that don't allow > mixing of GTT and VRAM. Newer asics do not have these > requirements so we should be able to be mo

[PATCH 0/2] Avoid creating acpi_video0 on desktop APUs

2022-12-07 Thread Mario Limonciello
In kernel 6.1 the backlight registration code was overhauled so that at most one backlight device got registered. As part of this change there was code added to cover the "nomodeset" case to still allow making an acpi_video0 device if the BIOS contained backlight control methods. This fallback log

[PATCH 1/2] ACPI: video: Allow GPU drivers to report no panels

2022-12-07 Thread Mario Limonciello
The current logic for the ACPI backlight detection will create a backlight device if no native or vendor drivers have created 8 seconds after the system has booted if the ACPI tables included backlight control methods. If the GPU drivers have loaded, they may be able to report whether any LCD pane

[PATCH 2/2] drm/amd/display: Report to ACPI video if no panels were found

2022-12-07 Thread Mario Limonciello
On desktop APUs amdgpu doesn't create a native backlight device as no eDP panels are found. However if the BIOS has reported backlight control methods in the ACPI tables then an acpi_video0 backlight device will be made 8 seconds after boot. This has manifested in a power slider on a number of de

Re: [bug][vaapi][h264] The commit 7cbe08a930a132d84b4cf79953b00b074ec7a2a7 on certain video files leads to problems with VAAPI hardware decoding.

2022-12-07 Thread Mikhail Gavrilov
On Wed, Dec 7, 2022 at 7:58 PM Alex Deucher wrote: > > > What GPU do you have and what entries do you have in > sys/class/drm/card0/device/ip_discovery/die/0/UVD for the device? I bisected the issue on the Radeon 6800M. Parent commit for 7cbe08a930a132d84b4cf79953b00b074ec7a2a7 is 46dd2965bdd1c5

Re: [bug][vaapi][h264] The commit 7cbe08a930a132d84b4cf79953b00b074ec7a2a7 on certain video files leads to problems with VAAPI hardware decoding.

2022-12-07 Thread Alex Deucher
+ Leo, Thong On Wed, Dec 7, 2022 at 3:43 PM Mikhail Gavrilov wrote: > > On Wed, Dec 7, 2022 at 7:58 PM Alex Deucher wrote: > > > > > > What GPU do you have and what entries do you have in > > sys/class/drm/card0/device/ip_discovery/die/0/UVD for the device? > > I bisected the issue on the Radeon

Re: [PATCH 0/2] Avoid creating acpi_video0 on desktop APUs

2022-12-07 Thread Hans de Goede
Hi All, Mario, thank you for working on this. On 12/7/22 20:31, Mario Limonciello wrote: > In kernel 6.1 the backlight registration code was overhauled so that > at most one backlight device got registered. As part of this change > there was code added to cover the "nomodeset" case to still allow

Re: [PATCH 0/2] Avoid creating acpi_video0 on desktop APUs

2022-12-07 Thread Limonciello, Mario
On 12/7/2022 15:04, Hans de Goede wrote: Hi All, Mario, thank you for working on this. Sure Note that the problem of the creating a non functional acpi_video0 device happened before the overhaul too. The difference is that now we have the in kernel GPU drivers all call acpi_video_register

Re: [PATCH 0/2] Avoid creating acpi_video0 on desktop APUs

2022-12-07 Thread Hans de Goede
Hi, On 12/7/22 22:21, Limonciello, Mario wrote: > On 12/7/2022 15:04, Hans de Goede wrote: >> Hi All, >> >> Mario, thank you for working on this. > > Sure > > >> >> Note that the problem of the creating a non functional acpi_video0 >> device happened before the overhaul too. >> >> The differenc

[pull] amdgpu drm-fixes-6.1

2022-12-07 Thread Alex Deucher
Hi Dave, Daniel, A couple of small fixes for 6.1. The following changes since commit 76dcd734eca23168cb008912c0f69ff408905235: Linux 6.1-rc8 (2022-12-04 14:48:12 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.1-2022-12-07

[pull] amdgpu drm-next-6.2

2022-12-07 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.2. The following changes since commit 4670ac706ff9b3d0adb766ef9e93cc36d9dda474: drm/amdgpu: expand on GPUVM documentation (2022-12-02 10:06:00 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-next-6.2-2

[PATCH v2 0/3] Adjust ACPI video detection fallback path

2022-12-07 Thread Mario Limonciello
In kernel 6.1 the backlight registration code was overhauled so that at most one backlight device got registered. As part of this change there was code added to still allow making an acpi_video0 device if the BIOS contained backlight control methods but no native or vendor drivers registered. Even

[PATCH v2 1/3] ACPI: video: Allow GPU drivers to report no panels

2022-12-07 Thread Mario Limonciello
The current logic for the ACPI backlight detection will create a backlight device if no native or vendor drivers have created 8 seconds after the system has booted if the ACPI tables included backlight control methods. If the GPU drivers have loaded, they may be able to report whether any LCD pane

[PATCH v2 3/3] ACPI: video: Don't enable fallback path for creating ACPI backlight by default

2022-12-07 Thread Mario Limonciello
The ACPI video detection code has a module parameter `register_backlight_delay` which is currently configured to 8 seconds. This means that if after 8 seconds of booting no native driver has created a backlight device then the code will attempt to make an ACPI video backlight device. This was inte

[PATCH v2 2/3] drm/amd/display: Report to ACPI video if no panels were found

2022-12-07 Thread Mario Limonciello
On desktop APUs amdgpu doesn't create a native backlight device as no eDP panels are found. However if the BIOS has reported backlight control methods in the ACPI tables then an acpi_video0 backlight device will be made 8 seconds after boot. This has manifested in a power slider on a number of de

Re: [PATCH 0/2] Avoid creating acpi_video0 on desktop APUs

2022-12-07 Thread Daniel Dadap
On Wed, Dec 07, 2022 at 10:32:05PM +0100, Hans de Goede wrote: > Hi, > > On 12/7/22 22:21, Limonciello, Mario wrote: > > On 12/7/2022 15:04, Hans de Goede wrote: > >> Hi All, > >> > >> Mario, thank you for working on this. > > > > Sure > > > > > >> > >> Note that the problem of the creating a n

RE: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Zhang, Yifan
[AMD Official Use Only - General] Hi Alex, We need to adjust the AMDGPU_SG_THRESHOLD as well since recent APUs are configured w/ 512MB VRAM. Pls check attached patch. Best Regards, Yifan -Original Message- From: Alex Deucher Sent: Thursday, December 8, 2022 12:21 AM To: Christian Kön

[PATCH] drm/amd/display: Add DCN314 display SG Support

2022-12-07 Thread Yifan Zhang
Add display SG support for DCN 3.1.4. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 0f391a147354..6f

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Alex Deucher
On Wed, Dec 7, 2022 at 11:10 PM Zhang, Yifan wrote: > > [AMD Official Use Only - General] > > Hi Alex, > > We need to adjust the AMDGPU_SG_THRESHOLD as well since recent APUs are > configured w/ 512MB VRAM. Pls check attached patch. Why do we need to increase this threshold? The condition only

Re: [PATCH] drm/amd/display: Add DCN314 display SG Support

2022-12-07 Thread Alex Deucher
On Wed, Dec 7, 2022 at 11:14 PM Yifan Zhang wrote: > > Add display SG support for DCN 3.1.4. > > Signed-off-by: Yifan Zhang Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/display/

RE: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Zhang, Yifan
[AMD Official Use Only - General] We encountered some issues in recent APUs when tried to pin a large framebuffer (e.g. 64MB w/ dual 4K display), switch to display SG could resolve such issue. Actually we received various kinds of VRAM shortage issues recently, there is more and more pressure

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Alex Deucher
On Wed, Dec 7, 2022 at 11:35 PM Zhang, Yifan wrote: > > [AMD Official Use Only - General] > > We encountered some issues in recent APUs when tried to pin a large > framebuffer (e.g. 64MB w/ dual 4K display), switch to display SG could > resolve such issue. Actually we received various kinds of

Re: [PATCH v3 0/2] drm: Add GPU reset sysfs

2022-12-07 Thread Alex Deucher
On Wed, Nov 30, 2022 at 6:11 AM Daniel Vetter wrote: > > On Fri, Nov 25, 2022 at 02:52:01PM -0300, André Almeida wrote: > > This patchset adds a udev event for DRM device's resets. > > > > Userspace apps can trigger GPU resets by misuse of graphical APIs or driver > > bugs. Either way, the GPU res

RE: [PATCH] drm/amdgpu: handle polaris10/11 overlap asics (v2)

2022-12-07 Thread Quan, Evan
[AMD Official Use Only - General] I wonder how this is observed. Any bug report related with this? Evan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, December 8, 2022 1:06 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PA

Re: [PATCH] drm/amdgpu: make display pinning more flexible (v2)

2022-12-07 Thread Christian König
Am 07.12.22 um 17:21 schrieb Alex Deucher: Only apply the static threshold for Stoney and Carrizo. This hardware has certain requirements that don't allow mixing of GTT and VRAM. Newer asics do not have these requirements so we should be able to be more flexible with where buffers end up. Signe

[PATCH 2/7] drm/amdgpu: add RAS poison consumption handler for NV SRIOV

2022-12-07 Thread Tao Zhou
Send handling request to host. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c | 6 ++ drivers/gpu/drm/amd/amdgpu/mxgpu_nv.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c b/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c index e07757eea7

[PATCH 1/7] drm/amdgpu: add RAS poison consumption handler for AI SRIOV

2022-12-07 Thread Tao Zhou
Send message to host and host will handle it. v2: split it into two parts, one for mxgpu ai and another one for common poison consumption handler. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 1 + drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c| 6 ++ drivers/gpu/drm/amd

[PATCH 3/7] drm/amdgpu: add RAS poison consumption handler for SRIOV

2022-12-07 Thread Tao Zhou
Send message to PF if VF receives RAS poison consumption interrupt. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c | 44 +++-- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c b/drivers/gpu/drm/amd/a

[PATCH 5/7] drm/amdgpu: skip RAS error injection in SRIOV

2022-12-07 Thread Tao Zhou
Injection on guest is not allowed. v2: return directly in SRIOV environment. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index ad490

[PATCH 4/7] drm/amdgpu: add VCN poison consumption handler for SRIOV

2022-12-07 Thread Tao Zhou
Inform host and let host handle consumption interrupt. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c index 72

[PATCH 6/7] drm/amdgpu: update VCN/JPEG RAS setting

2022-12-07 Thread Tao Zhou
Support VCN/JPEG RAS in both bare metal and SRIOV environment. v2: update commit description. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.

[PATCH 7/7] drm/amdgpu: define RAS poison mode query function

2022-12-07 Thread Tao Zhou
1. no need to query poison mode on SRIOV guest side, host can handle it. 2. define the function to simplify code. v2: rename amdgpu_ras_poison_mode_query to amdgpu_ras_query_poison_mode. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 54 +++-- 1 file c