From: Yushan Zhou
release_firmware() checks whether firmware pointer is NULL.
Remove the redundant NULL check in psp_sw_fini().
Signed-off-by: Yushan Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 36 +++--
1 file changed, 16 insertions(+), 20 deletions(-)
diff --git a
[AMD Official Use Only - General]
vram_usagebyfirmware v2_2 is only used in SRIOV case, skip the related settings
in bare-metal case currently.
Signed-off-by: Likun Gao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
[AMD Official Use Only - General]
Reviewed-by: Feifei Xu
-Original Message-
From: Gao, Likun
Sent: Wednesday, November 23, 2022 6:01 PM
To: amd-gfx list
Cc: Zhang, Hawking ; Xu, Feifei
Subject: [PATCH] drm/amdgpu: skip vram reserve on firmware_v2_2 for bare-metal
[AMD Official Use
From: Dillon Varone
[ Upstream commit c149947b188c651b943c1d8ca1494d1a98a3e27f ]
[WHY?]
DCN32 uses fclk pstate watermarks for dummy pstate, and must always be
supported.
[HOW?]
Validation needs to be run with fclk pstate latency set
as the dummy pstate latency to get correct prefetch and bandwi
From: Eric Huang
[ Upstream commit 6f9eea4392a178af19360694b1db64f985d0b459 ]
It is to resolve a regression, which fails to allocate
VRAM due to no free memory in application, the reason
is we add check of vram_pin_size for memory limit, and
application is pinning the memory for Peerdirect, KFD
From: Guchun Chen
[ Upstream commit 192039f12233c9063d040266e7c98188c7c89dec ]
Otherwise, some unexpected PCIE AER errors will be observed
in runtime suspend/resume cycle.
Signed-off-by: Guchun Chen
Acked-by: Alex Deucher
Signed-off-by: Alex Deucher
Signed-off-by: Sasha Levin
---
drivers/g
From: Guchun Chen
[ Upstream commit 192039f12233c9063d040266e7c98188c7c89dec ]
Otherwise, some unexpected PCIE AER errors will be observed
in runtime suspend/resume cycle.
Signed-off-by: Guchun Chen
Acked-by: Alex Deucher
Signed-off-by: Alex Deucher
Signed-off-by: Sasha Levin
---
drivers/g
On 11/23/22 07:09, Chen, Guchun wrote:
> Hi Lijo,
>
> Thanks for your review. The cause for this change is, so far, except one line
> printing like "amdgpu: free PSP TMR buffer", there are no other printings
> once system completes rpm suspend. And moreover, "free PSP TMR buffer"
> sometimes co
We need to always call psp_load_toc() regardless of
whether we re-allocate the TMR buffer or not. Fixes
S4.
Fixes: 36238df85ade ("drm/amdgpu/psp: don't free PSP buffers on suspend")
Reported-by: Skikai Guo
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 42
Return value of a function 'dc_create_state' is
dereferenced at amdgpu_dm.c:2027 without checking for null
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Denis Arefev
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++-
1 file changed, 3 insertions(+
Hi Dave, Daniel,
Fixes for 6.1. Fairly big, but most of these have been baking for a while;
just wrapping them up now so they should be pretty well tested.
The following changes since commit eb7081409f94a9a8608593d0fb63a1aa3d6f95d8:
Linux 6.1-rc6 (2022-11-20 16:02:16 -0800)
are available in
From: Veerabadhran Gopalakrishnan
Corrected the typo in the 4K resolution parameters.
Signed-off-by: Veerabadhran Gopalakrishnan
---
drivers/gpu/drm/amd/amdgpu/nv.c| 28 ++--
drivers/gpu/drm/amd/amdgpu/soc15.c | 24
drivers/gpu/drm/amd/amdgp
Am 23.11.22 um 15:51 schrieb veerabadhran.gopalakrish...@amd.com:
From: Veerabadhran Gopalakrishnan
Corrected the typo in the 4K resolution parameters.
Signed-off-by: Veerabadhran Gopalakrishnan
Good catch, Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/nv.c| 28 ++
On Wed, Nov 23, 2022 at 8:58 AM Michel Dänzer
wrote:
>
> On 11/23/22 07:09, Chen, Guchun wrote:
> > Hi Lijo,
> >
> > Thanks for your review. The cause for this change is, so far, except one
> > line printing like "amdgpu: free PSP TMR buffer", there are no other
> > printings once system complet
On 2022-11-23 09:51, veerabadhran.gopalakrish...@amd.com wrote:
> From: Veerabadhran Gopalakrishnan
>
> Corrected the typo in the 4K resolution parameters.
>
> Signed-off-by: Veerabadhran Gopalakrishnan
>
Please add the following Fixes tags. The first is where the 4906 first
appeared, and la
On Wed, Nov 23, 2022 at 2:50 AM Khatri, Sunil wrote:
>
> [AMD Official Use Only - General]
>
> Hello Alex, Robert
>
> I too have similar issues which I am facing on chrome. Are there any tools in
> linux environment which can help debug such issues like page faults, kernel
> panic caused by inva
Fix the output of the version revision and version branch, so that they're no
longer empty after the listed change below.
Cc: Dmitrii Galantsev
Cc: Tom StDenis
Fixes: 7facf591681772 ("CI: Release RPM and DEB packages")
Signed-off-by: Luben Tuikov
---
cmake_modules/GitVersion.cmake | 4 ++--
1
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 736b6d81d93cf61a0601af90bd552103ef997b3f Add linux-next specific
files for 20221123
Error/Warning reports:
https://lore.kernel.org/linux-mm/202210261404.b6ulzg7h-...@intel.com
https
[Public]
> -Original Message-
> From: Kuehling, Felix
> Sent: November 22, 2022 6:05 PM
> To: Kim, Jonathan ; amd-
> g...@lists.freedesktop.org
> Subject: Re: [PATCH 01/29] drm/amdkfd: add debug and runtime enable
> interface
>
>
> On 2022-10-31 12:23, Jonathan Kim wrote:
> > Introduce th
[Public]
> -Original Message-
> From: Kuehling, Felix
> Sent: November 22, 2022 6:39 PM
> To: Kim, Jonathan ; amd-
> g...@lists.freedesktop.org
> Subject: Re: [PATCH 05/29] drm/amdgpu: setup hw debug registers on driver
> initialization
>
>
> On 2022-10-31 12:23, Jonathan Kim wrote:
> > A
Thanks for your comments, Alex and Michel.
So like Lijo suggested, Does dev_dbg instead of dev_info for those message
printings make sense to you as well?
Regards,
Guchun
-Original Message-
From: Alex Deucher
Sent: Wednesday, November 23, 2022 11:41 PM
To: Michel Dänzer
Cc: Chen, Guc
On 11/23/2022 7:30 PM, Alex Deucher wrote:
We need to always call psp_load_toc() regardless of
whether we re-allocate the TMR buffer or not. Fixes
S4.
I guess this fixes all cases where psp_suspend is called (regression
introduced by the fixes-tag patch) and not just S4. Suggest to refine
[AMD Official Use Only - General]
Reviewed-by: shikaguo
-Original Message-
From: Deucher, Alexander
Sent: Wednesday, November 23, 2022 10:00 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Guo, Shikai
Subject: [PATCH] drm/amdgpu/psp: always call psp_load_toc()
We need
Runtime PM can happen pretty frequently, as these printings
may be annoyed, switch to dev_dbg.
Suggested-by: Lijo Lazar
Signed-off-by: Guchun Chen
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
add vram usage information into dri debugfs amdgpu_vram_mm node.
Background:
when amdgpu driver introduces drm buddy allocator, the kernel driver
(and developer) is difficult to track the vram usage information.
Field:
0x-0x: vram usaged range.
type: kernel, device, sg
usage: norm
Am 24.11.22 um 06:49 schrieb Yang Wang:
add vram usage information into dri debugfs amdgpu_vram_mm node.
Background:
when amdgpu driver introduces drm buddy allocator, the kernel driver
(and developer) is difficult to track the vram usage information.
Field:
0x-0x: vram usaged r
[AMD Official Use Only - General]
-Original Message-
From: Koenig, Christian
Sent: Thursday, November 24, 2022 3:25 PM
To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org;
Paneer Selvam, Arunpravin
Cc: Zhang, Hawking ; Deucher, Alexander
Subject: Re: [PATCH] drm/amdgpu: add amdgpu v
Am 24.11.22 um 08:45 schrieb Wang, Yang(Kevin):
[AMD Official Use Only - General]
-Original Message-
From: Koenig, Christian
Sent: Thursday, November 24, 2022 3:25 PM
To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org; Paneer
Selvam, Arunpravin
Cc: Zhang, Hawking ; Deucher, Alexand
28 matches
Mail list logo