[PATCH] drm/amdgpu: remove redundant NULL check

2022-11-23 Thread zys . zljxml
From: Yushan Zhou release_firmware() checks whether firmware pointer is NULL. Remove the redundant NULL check in psp_sw_fini(). Signed-off-by: Yushan Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 36 +++-- 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a

[PATCH] drm/amdgpu: skip vram reserve on firmware_v2_2 for bare-metal

2022-11-23 Thread Gao, Likun
[AMD Official Use Only - General] vram_usagebyfirmware v2_2 is only used in SRIOV case, skip the related settings in bare-metal case currently. Signed-off-by: Likun Gao --- drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

RE: [PATCH] drm/amdgpu: skip vram reserve on firmware_v2_2 for bare-metal

2022-11-23 Thread Xu, Feifei
[AMD Official Use Only - General] Reviewed-by: Feifei Xu -Original Message- From: Gao, Likun Sent: Wednesday, November 23, 2022 6:01 PM To: amd-gfx list Cc: Zhang, Hawking ; Xu, Feifei Subject: [PATCH] drm/amdgpu: skip vram reserve on firmware_v2_2 for bare-metal [AMD Official Use

[PATCH AUTOSEL 6.0 26/44] drm/amd/display: use uclk pstate latency for fw assisted mclk validation dcn32

2022-11-23 Thread Sasha Levin
From: Dillon Varone [ Upstream commit c149947b188c651b943c1d8ca1494d1a98a3e27f ] [WHY?] DCN32 uses fclk pstate watermarks for dummy pstate, and must always be supported. [HOW?] Validation needs to be run with fclk pstate latency set as the dummy pstate latency to get correct prefetch and bandwi

[PATCH AUTOSEL 6.0 28/44] drm/amdkfd: Fix a memory limit issue

2022-11-23 Thread Sasha Levin
From: Eric Huang [ Upstream commit 6f9eea4392a178af19360694b1db64f985d0b459 ] It is to resolve a regression, which fails to allocate VRAM due to no free memory in application, the reason is we add check of vram_pin_size for memory limit, and application is pinning the memory for Peerdirect, KFD

[PATCH AUTOSEL 6.0 27/44] drm/amdgpu: disable BACO support on more cards

2022-11-23 Thread Sasha Levin
From: Guchun Chen [ Upstream commit 192039f12233c9063d040266e7c98188c7c89dec ] Otherwise, some unexpected PCIE AER errors will be observed in runtime suspend/resume cycle. Signed-off-by: Guchun Chen Acked-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/g

[PATCH AUTOSEL 5.15 17/31] drm/amdgpu: disable BACO support on more cards

2022-11-23 Thread Sasha Levin
From: Guchun Chen [ Upstream commit 192039f12233c9063d040266e7c98188c7c89dec ] Otherwise, some unexpected PCIE AER errors will be observed in runtime suspend/resume cycle. Signed-off-by: Guchun Chen Acked-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/g

Re: [PATCH 3/3] drm/amdgpu: add printing to indicate rpm completeness

2022-11-23 Thread Michel Dänzer
On 11/23/22 07:09, Chen, Guchun wrote: > Hi Lijo, > > Thanks for your review. The cause for this change is, so far, except one line > printing like "amdgpu: free PSP TMR buffer", there are no other printings > once system completes rpm suspend. And moreover, "free PSP TMR buffer" > sometimes co

[PATCH] drm/amdgpu/psp: always call psp_load_toc()

2022-11-23 Thread Alex Deucher
We need to always call psp_load_toc() regardless of whether we re-allocate the TMR buffer or not. Fixes S4. Fixes: 36238df85ade ("drm/amdgpu/psp: don't free PSP buffers on suspend") Reported-by: Skikai Guo Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 42

[PATCH] drm/amdgpu/display: Add pointer check

2022-11-23 Thread Denis Arefev
Return value of a function 'dc_create_state' is dereferenced at amdgpu_dm.c:2027 without checking for null Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Denis Arefev --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++- 1 file changed, 3 insertions(+

[pull] amdgpu drm-fixes-6.1

2022-11-23 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.1. Fairly big, but most of these have been baking for a while; just wrapping them up now so they should be pretty well tested. The following changes since commit eb7081409f94a9a8608593d0fb63a1aa3d6f95d8: Linux 6.1-rc6 (2022-11-20 16:02:16 -0800) are available in

[PATCH] amdgpu/nv.c: Corrected typo in the video capabilities resolution

2022-11-23 Thread veerabadhran.gopalakrishnan
From: Veerabadhran Gopalakrishnan Corrected the typo in the 4K resolution parameters. Signed-off-by: Veerabadhran Gopalakrishnan --- drivers/gpu/drm/amd/amdgpu/nv.c| 28 ++-- drivers/gpu/drm/amd/amdgpu/soc15.c | 24 drivers/gpu/drm/amd/amdgp

Re: [PATCH] amdgpu/nv.c: Corrected typo in the video capabilities resolution

2022-11-23 Thread Christian König
Am 23.11.22 um 15:51 schrieb veerabadhran.gopalakrish...@amd.com: From: Veerabadhran Gopalakrishnan Corrected the typo in the 4K resolution parameters. Signed-off-by: Veerabadhran Gopalakrishnan Good catch, Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/nv.c| 28 ++

Re: [PATCH 3/3] drm/amdgpu: add printing to indicate rpm completeness

2022-11-23 Thread Alex Deucher
On Wed, Nov 23, 2022 at 8:58 AM Michel Dänzer wrote: > > On 11/23/22 07:09, Chen, Guchun wrote: > > Hi Lijo, > > > > Thanks for your review. The cause for this change is, so far, except one > > line printing like "amdgpu: free PSP TMR buffer", there are no other > > printings once system complet

Re: [PATCH] amdgpu/nv.c: Corrected typo in the video capabilities resolution

2022-11-23 Thread Luben Tuikov
On 2022-11-23 09:51, veerabadhran.gopalakrish...@amd.com wrote: > From: Veerabadhran Gopalakrishnan > > Corrected the typo in the 4K resolution parameters. > > Signed-off-by: Veerabadhran Gopalakrishnan > Please add the following Fixes tags. The first is where the 4906 first appeared, and la

Re: Help debug amdgpu faults

2022-11-23 Thread Alex Deucher
On Wed, Nov 23, 2022 at 2:50 AM Khatri, Sunil wrote: > > [AMD Official Use Only - General] > > Hello Alex, Robert > > I too have similar issues which I am facing on chrome. Are there any tools in > linux environment which can help debug such issues like page faults, kernel > panic caused by inva

[PATCH] CI: Fix VERSION_REV and VERSION_BRANCH

2022-11-23 Thread Luben Tuikov
Fix the output of the version revision and version branch, so that they're no longer empty after the listed change below. Cc: Dmitrii Galantsev Cc: Tom StDenis Fixes: 7facf591681772 ("CI: Release RPM and DEB packages") Signed-off-by: Luben Tuikov --- cmake_modules/GitVersion.cmake | 4 ++-- 1

[linux-next:master] BUILD REGRESSION 736b6d81d93cf61a0601af90bd552103ef997b3f

2022-11-23 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 736b6d81d93cf61a0601af90bd552103ef997b3f Add linux-next specific files for 20221123 Error/Warning reports: https://lore.kernel.org/linux-mm/202210261404.b6ulzg7h-...@intel.com https

RE: [PATCH 01/29] drm/amdkfd: add debug and runtime enable interface

2022-11-23 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kuehling, Felix > Sent: November 22, 2022 6:05 PM > To: Kim, Jonathan ; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH 01/29] drm/amdkfd: add debug and runtime enable > interface > > > On 2022-10-31 12:23, Jonathan Kim wrote: > > Introduce th

RE: [PATCH 05/29] drm/amdgpu: setup hw debug registers on driver initialization

2022-11-23 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kuehling, Felix > Sent: November 22, 2022 6:39 PM > To: Kim, Jonathan ; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH 05/29] drm/amdgpu: setup hw debug registers on driver > initialization > > > On 2022-10-31 12:23, Jonathan Kim wrote: > > A

RE: [PATCH 3/3] drm/amdgpu: add printing to indicate rpm completeness

2022-11-23 Thread Chen, Guchun
Thanks for your comments, Alex and Michel. So like Lijo suggested, Does dev_dbg instead of dev_info for those message printings make sense to you as well? Regards, Guchun -Original Message- From: Alex Deucher Sent: Wednesday, November 23, 2022 11:41 PM To: Michel Dänzer Cc: Chen, Guc

Re: [PATCH] drm/amdgpu/psp: always call psp_load_toc()

2022-11-23 Thread Lazar, Lijo
On 11/23/2022 7:30 PM, Alex Deucher wrote: We need to always call psp_load_toc() regardless of whether we re-allocate the TMR buffer or not. Fixes S4. I guess this fixes all cases where psp_suspend is called (regression introduced by the fixes-tag patch) and not just S4. Suggest to refine

RE: [PATCH] drm/amdgpu/psp: always call psp_load_toc()

2022-11-23 Thread Guo, Shikai
[AMD Official Use Only - General] Reviewed-by: shikaguo -Original Message- From: Deucher, Alexander Sent: Wednesday, November 23, 2022 10:00 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Guo, Shikai Subject: [PATCH] drm/amdgpu/psp: always call psp_load_toc() We need

[PATCH] drm/amdgpu: use dev_dbg to print messages in runtime cycle

2022-11-23 Thread Guchun Chen
Runtime PM can happen pretty frequently, as these printings may be annoyed, switch to dev_dbg. Suggested-by: Lijo Lazar Signed-off-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH] drm/amdgpu: add amdgpu vram usage information into amdgpu_vram_mm

2022-11-23 Thread Yang Wang
add vram usage information into dri debugfs amdgpu_vram_mm node. Background: when amdgpu driver introduces drm buddy allocator, the kernel driver (and developer) is difficult to track the vram usage information. Field: 0x-0x: vram usaged range. type: kernel, device, sg usage: norm

Re: [PATCH] drm/amdgpu: add amdgpu vram usage information into amdgpu_vram_mm

2022-11-23 Thread Christian König
Am 24.11.22 um 06:49 schrieb Yang Wang: add vram usage information into dri debugfs amdgpu_vram_mm node. Background: when amdgpu driver introduces drm buddy allocator, the kernel driver (and developer) is difficult to track the vram usage information. Field: 0x-0x: vram usaged r

RE: [PATCH] drm/amdgpu: add amdgpu vram usage information into amdgpu_vram_mm

2022-11-23 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] -Original Message- From: Koenig, Christian Sent: Thursday, November 24, 2022 3:25 PM To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org; Paneer Selvam, Arunpravin Cc: Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: add amdgpu v

Re: [PATCH] drm/amdgpu: add amdgpu vram usage information into amdgpu_vram_mm

2022-11-23 Thread Christian König
Am 24.11.22 um 08:45 schrieb Wang, Yang(Kevin): [AMD Official Use Only - General] -Original Message- From: Koenig, Christian Sent: Thursday, November 24, 2022 3:25 PM To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org; Paneer Selvam, Arunpravin Cc: Zhang, Hawking ; Deucher, Alexand